From: "Chang, Abner" <abner.chang@amd.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"nicklew@nvidia.com" <nicklew@nvidia.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure
Date: Thu, 22 Sep 2022 04:44:39 +0000 [thread overview]
Message-ID: <MN2PR12MB396624D1EEB29809E0EE586AEA4E9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220921124233.1474-1-nicklew@nvidia.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle
> Wang via groups.io
> Sent: Wednesday, September 21, 2022 8:43 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nick Ramirez
> <nramirez@nvidia.com>
> Subject: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> VS2019 reports build failure: "warning C4701: potentially uninitialized local
> variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning of function.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> ---
> RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> b/RedfishPkg/Library/JsonLib/JsonLib.c
> index 33d5eaef79..88b89bf6f8 100644
> --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> @@ -6,6 +6,7 @@
>
> Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -566,6 +567,7 @@
> JsonValueGetUnicodeString (
> CONST CHAR8 *Utf8Str;
> CHAR16 *Ucs2Str;
>
> + Ucs2Str = NULL;
> Utf8Str = json_string_value ((json_t *) Json);
> if (Utf8Str == NULL) {
> return NULL;
> --
> 2.37.3.windows.1
>
>
>
>
>
prev parent reply other threads:[~2022-09-22 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:42 [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure Nickle Wang
2022-09-22 4:44 ` Chang, Abner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396624D1EEB29809E0EE586AEA4E9@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox