* [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure
@ 2022-09-21 12:42 Nickle Wang
2022-09-22 4:44 ` [edk2-devel] " Chang, Abner
0 siblings, 1 reply; 2+ messages in thread
From: Nickle Wang @ 2022-09-21 12:42 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Nick Ramirez
VS2019 reports build failure: "warning C4701: potentially uninitialized
local variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning
of function.
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
---
RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c b/RedfishPkg/Library/JsonLib/JsonLib.c
index 33d5eaef79..88b89bf6f8 100644
--- a/RedfishPkg/Library/JsonLib/JsonLib.c
+++ b/RedfishPkg/Library/JsonLib/JsonLib.c
@@ -6,6 +6,7 @@
Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
+ Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -566,6 +567,7 @@ JsonValueGetUnicodeString (
CONST CHAR8 *Utf8Str;
CHAR16 *Ucs2Str;
+ Ucs2Str = NULL;
Utf8Str = json_string_value ((json_t *) Json);
if (Utf8Str == NULL) {
return NULL;
--
2.37.3.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure
2022-09-21 12:42 [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure Nickle Wang
@ 2022-09-22 4:44 ` Chang, Abner
0 siblings, 0 replies; 2+ messages in thread
From: Chang, Abner @ 2022-09-22 4:44 UTC (permalink / raw)
To: devel@edk2.groups.io, nicklew@nvidia.com; +Cc: Nick Ramirez
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle
> Wang via groups.io
> Sent: Wednesday, September 21, 2022 8:43 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nick Ramirez
> <nramirez@nvidia.com>
> Subject: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> VS2019 reports build failure: "warning C4701: potentially uninitialized local
> variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning of function.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> ---
> RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> b/RedfishPkg/Library/JsonLib/JsonLib.c
> index 33d5eaef79..88b89bf6f8 100644
> --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> @@ -6,6 +6,7 @@
>
> Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -566,6 +567,7 @@
> JsonValueGetUnicodeString (
> CONST CHAR8 *Utf8Str;
> CHAR16 *Ucs2Str;
>
> + Ucs2Str = NULL;
> Utf8Str = json_string_value ((json_t *) Json);
> if (Utf8Str == NULL) {
> return NULL;
> --
> 2.37.3.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-22 4:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-21 12:42 [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure Nickle Wang
2022-09-22 4:44 ` [edk2-devel] " Chang, Abner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox