From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.41]) by mx.groups.io with SMTP id smtpd.web09.3576.1663821882194413394 for ; Wed, 21 Sep 2022 21:44:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=lObrHml1; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UWUZexvWfkoq9Gbyk/jpLeL5nyPnA75L3s/O0yzleBaZQIi/hdhJCTSjINDZuiyCmsuN5c50dp9R6izPA51cWZOYtu8aembH5h8a+Y1owVmL8AuFwVux3GzMPmCdCJGQ+7+kXwVucSS3esWlMfddYqeoARZIgcSZ13C6y25/UaQGfbCcx9nf3jhD653VbpAPn+RrM8ykW5l1iM45dr1U0GN+ARR5eAEzpwNmRDqhGlOp/3Qxst+2gg1se6iLLZg5QCInxJpC2u/P4cKFHFIaExXGRM3CRTjA0m5DmZT8cW8yP6cwZg+69WBUhWK9PoTZwO5HOosQ1V3Yb4kyrJZm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJPK1/jCuVnLlyrP+ZnxmpQyhnAZkZDy2/oNIC68f1U=; b=EkC2hfHy09fQ0X+9qkUdl9/Hoof9/crXHlHakL1W+nHaVxoZiZP/L8vaux3859pypqg5Vx7EjTPRiN0x686CSmDBxSS3E9l7FtZvP1Hx6XuWYJMN4CPV9olvegSe9bIa2+AQ6ho8WK8KBvtchgMlh/YQwOi30BpyMofsK6OxCKViaMViK8H13vscvz/h8Aya/HoBtwQ/Zg01iphUvZfHJFZqb/4xWLxSNynKVmc0ch3cy/D9b+KgHU19G3nNA7dstwnnFsehPryhEIp4w8Mh2KzoSMC1n6EDilFGraXQVtMmiHwRExrkd4yLZB3Fa+EuoBHbkgzI0EG3WaatF82Rwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJPK1/jCuVnLlyrP+ZnxmpQyhnAZkZDy2/oNIC68f1U=; b=lObrHml1xMUS1T75TpGCDF4OjLWJZFyW3NS3O839cR7xVzs7OUZmPTAO+LnsmDDZkt+761roxKAqmi9uIUCQdIkLddeBNDaXc8lZOVwYQSRdeSuW2jalSwbkgqogitnRWiP+QaCtKT04dIlZ0B47NSiFhlPqvuZNbR8Umkh2gWo= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5126.namprd12.prod.outlook.com (2603:10b6:208:312::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 04:44:39 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::9c44:17db:7f29:1fa8]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::9c44:17db:7f29:1fa8%7]) with mapi id 15.20.5654.017; Thu, 22 Sep 2022 04:44:39 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "nicklew@nvidia.com" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure Thread-Topic: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure Thread-Index: AQHYzbfB9R62NDzcLkyzHjsKl5GRga3q4GSA Date: Thu, 22 Sep 2022 04:44:39 +0000 Message-ID: References: <20220921124233.1474-1-nicklew@nvidia.com> In-Reply-To: <20220921124233.1474-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-22T04:44:38Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d19227be-57f6-4b7f-b9c7-671b637dc81c; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5126:EE_ x-ms-office365-filtering-correlation-id: 659c0535-6f7e-4561-5aad-08da9c5528d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OpAaO41CsrgURE2dX5oK0EtqyquWpevrf7SYoVQ7looMpB1tBzZc1x40HwELjRYROMilIXIhFU36FCWiz51sTVDbFJWOExn/u0jdZmpbHu01WWmYyp20npZ848qCmUKdZHeQr7XNQHgJX6qQTt/NKhzeeXapNdJPsyTU+Plvm+E6GVHvHR/22Vnv1togHCuFlJi1cYYkekw+5HMoYDYMwNUP5WbgIW4AMxdnFAvUEVCJXkL+BRr6SQ4NXfza40hsvfWdApQ0cUnAgNVg5tSuze3AAzmSpBr0UMEWQBXxMuTKhghCmp7TilXYjxGL77SgAPm0EAj9F2xIb1IrMhgu6MGEzaowFY6oOh4WjNE9QR+IlD8tYhumaGv4wiJjlZe1N/U68Xo9yA9TQcFtqs8k2yIn3tTWLPBwoqz09udy9QOrT7q5Bjmx10b0DC1z57xBhwydkHi34/6Qk9RdW5c7PdI313UnnADHsyF/W33+NdDvHQjPHkkbQWIWN3Tzo3wvrkM9fqwSYdOEfdsIJCu9mfZR4/wMhXuyjBSnNh15i0I+o2IplIwjcMVvAoAlT/gV67rchCBlHI41l1NJ7UglBRoUESNoirTy4tHP5seniTjp3i1sLp05oKXkZdvu0EbyFTR9Rll5lfASXHADMFzp6gXPlb9WCGPLlOidwPJw+npL/KGn7WVGcYHnvYES7jwo6frTpEDK9+7iqTqK1vh6YIDAki13SrVCDrSJ06f0jUt9W8rwavmGuEWz+r2527z3lt+ik9E/5vNck3dSzvKRWTIGOq6HHOgJfrpeJw3NUB+wMwKIUbj/48ATJMCkQwwwehj2IgBnMitbJ34kRcaKSw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(376002)(39860400002)(136003)(366004)(451199015)(76116006)(4326008)(66556008)(66476007)(66946007)(966005)(64756008)(66446008)(110136005)(478600001)(8676002)(9686003)(26005)(5660300002)(33656002)(186003)(55016003)(52536014)(86362001)(2906002)(41300700001)(6506007)(7696005)(53546011)(83380400001)(8936002)(316002)(122000001)(38100700002)(71200400001)(38070700005)(45080400002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xkTjTiumNvWkA6tA/7sXmO+VnSHlQjSzP/O4i5+tfog17TLYlEwdy0pXJUfe?= =?us-ascii?Q?ZAAQhgBW4huYomfYHBn4Zsfca8UUnq7KdkUrzgSMiwzrZ9uW8F7VWgpeD2p9?= =?us-ascii?Q?64gIa30biZ5s8K/uBX3XswCIUS8lVF55RXeoV6mNUxTVx1yTiwQqEfCCEjBr?= =?us-ascii?Q?8haOPBmlpq89JGYZoYXxPSZT8jY02T2fGld9vXpLRKAEDVmBzNW8KHg1VYIJ?= =?us-ascii?Q?lAjs3HoYvPlYlc6JKBz42aI++lB/bSoznVBbyl5F0Pnjs6A7LpGBdUQ1Hxqe?= =?us-ascii?Q?woF7K2jaXEmUGuv0YtQbXrIvouG9DLaL4jGIHAcVe0D/5h0ycEyW1AxGC77q?= =?us-ascii?Q?6LBUJQN4XpElnv1SlEb4vhc2GKcr2h5DbWcggKcyUpGlcYmjoJaYsz/c/UCr?= =?us-ascii?Q?rbb8HqVh5hOg684NEG8aGBK1G5Iz2WA6KzbUwM2KvFYX9DOxGergi55haJky?= =?us-ascii?Q?+vJzFuEkCGolRvZzEMX0FPKDBYLgaaiRoZAyWxGBExSwc4EP5cW2D3FFbtRr?= =?us-ascii?Q?CphDDsb7nu4KxttfW6odOCEsEoFfz2UpFpfE1zvg5OitBkRAtiDGvn2WV/jF?= =?us-ascii?Q?A8M/cawBECV1qFKneRPRZb08nrKUOYhwIYHltWXmmxnRwo5+osPRm4Q1BAwK?= =?us-ascii?Q?mtRJklz+QUFBNkl9OaVeGEUvySMRwS739eTUa/rIim/BHP7cf7gi7KlGKaqN?= =?us-ascii?Q?X9GJOm/JcZ4r7/yR7uNHoUeYDWp/z3RChSZtVx8eBCadlHYp8iqoItKIOtyl?= =?us-ascii?Q?y2I+/BIVcZ9iWtxZeBlyXzxWru7hWP4Vf0Ch3a5oMPZ2d7SUZdjMIyBp7bNh?= =?us-ascii?Q?XD2Od6mvDF2eUpROiSfcFrEyGGXWXT5hnHrSlDl50cT9bBUdq2sLJg8oMSp+?= =?us-ascii?Q?YUTzcNgAIQfchdKKdG7F1GJfbRadDrK6Ps3hjmjhH0l5jrkmKtN7ehxXtcWj?= =?us-ascii?Q?bB/oeSza3qKiwnKpXgS95uuPik063L6oCjhhKOnW9EWjpkss/eLvTuGUfjbl?= =?us-ascii?Q?czZj7YVeS9+CjSYvggKQ6XHHGSxTXXRxHyT2ty39F4Pe8CTf2pIE6xYVbYEA?= =?us-ascii?Q?7wmBE+2TFwVd2icetmdn+8EPfre6xP20phD7CPphdXvcqK4O+7jvUHPsgPmN?= =?us-ascii?Q?gkw7+qt2nWC/SlO7c571713mXtEs3smkb8HuHtSX3SEs+aWDJ9ZqtMok5WTh?= =?us-ascii?Q?7OJr/mgOnRGPrs9G+rZ5wvs5SMSdP8v/Tz6qwf7QZk900N/UDmXoOU68l5Lg?= =?us-ascii?Q?kTb49F7lv+7sAX6ioegNAi0yi/kaZuTapY3ENIGo8N08UN76bkgDxdf/fX0F?= =?us-ascii?Q?QABrPd0jIpGTt8BeG4RaQl+bbOV1Zgq0oBnVjcx3ZmABTbjerCISFYKoGn6t?= =?us-ascii?Q?0iJZyP8ENUYmx/FVGokFi7ta1SxOqrPFDFRhDzK3dsu7ezmPB3OuwqXLHxjA?= =?us-ascii?Q?slWFPAg2XBGniFYV463hznVCmWZLVkxo8RtopcI13IGcwRaVNwXOydJJ3q4O?= =?us-ascii?Q?162Xk7Pr4MiLcR4JGj7SR3hyc+8rFboE45JVl5dp3nr/qRgO3wEEkTM428+C?= =?us-ascii?Q?Yq74MIdpEURy2h1UPIq0oWT+49NQZpRHQalkivxZ?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 659c0535-6f7e-4561-5aad-08da9c5528d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 04:44:39.6945 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CH03EdPJ8jHz86cSiJlncvHxxfOm4FNFdQN9PiZUZ6LfWPUlmmRHiHWQgBPJ1fzobuqkk63unmFWegsOeeiWJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5126 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nickle > Wang via groups.io > Sent: Wednesday, September 21, 2022 8:43 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nick Ramirez > > Subject: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failu= re >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > VS2019 reports build failure: "warning C4701: potentially uninitialized l= ocal > variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning of fun= ction. >=20 > Cc: Abner Chang > Cc: Nick Ramirez > Signed-off-by: Nickle Wang > --- > RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c > b/RedfishPkg/Library/JsonLib/JsonLib.c > index 33d5eaef79..88b89bf6f8 100644 > --- a/RedfishPkg/Library/JsonLib/JsonLib.c > +++ b/RedfishPkg/Library/JsonLib/JsonLib.c > @@ -6,6 +6,7 @@ >=20 > Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved= . >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -566,6 +567,7 @= @ > JsonValueGetUnicodeString ( > CONST CHAR8 *Utf8Str; > CHAR16 *Ucs2Str; >=20 > + Ucs2Str =3D NULL; > Utf8Str =3D json_string_value ((json_t *) Json); > if (Utf8Str =3D=3D NULL) { > return NULL; > -- > 2.37.3.windows.1 >=20 >=20 >=20 >=20 >=20