From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.45]) by mx.groups.io with SMTP id smtpd.web11.41467.1671504310126646498 for ; Mon, 19 Dec 2022 18:45:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=1EtG62lc; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.45, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXZUXAY5xTmJHowGhS5D5NFDGIaNalowX8QEx45W2Ck+56MQwNGvBnv6XimEpGu/1tNH+HppUrxGKHUIz5PrEiocwF2ryeZHxyyj1jHkr3UaVi2Quj5nnsww8TbCEPe0LIRN1eRS/75XiUywMOaAteOthpIMLxtFnl1HCHD3AuFMKjLjNd9t+29J+dFGnsI9+TInSSjvH/MiXUBriZIUJTysKRrHdqL3JYlADn1aa2lZolGKiYMBChEFu0hyP4Y9rtB0MoPnJT8l5W2Kv5yYIaOGo4vU6EuRnkYxO/SkeMN1PRXEyL0DNe9flWx68nTae52xJuVTvh2jvXzpY3kzvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uzCfIFo9mr+QoyKZ9d/MGqJm3BYhz9ta5YinwcmfgYs=; b=FUkpCsOoaq51sX86RNuMuTeG7hiMZJS6nOTpxaJQZXmJq7Nnt1kCTY9z6t3pwx1tXRlnk+GndTXsDh/jmde1SvnvcirMtbk+f3/G6ogncsWhhB9ABh0fCP0JHkDMUAB7dVaLn00GFdqVLu/loIYcEwxporfNukBPeMf0vpWU/ZDZitrfBeTF8v0thGjHtY+ck5R1gRHTk8357Gp3okv4m3xtuFQdG4lsNKmrvSokx2BFAT9PS5aUowYJZ37oVO5Unt5QkJOXkT6BIXqI7Kc7eBK1k5dx7RSF0obO4IIow6/PJDqBAOa+iKaNY87ndMkWIQdhfefGx84nSfhm/msDDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzCfIFo9mr+QoyKZ9d/MGqJm3BYhz9ta5YinwcmfgYs=; b=1EtG62lcOxyKHIXOJ+z583TxMGKbyfQbKb94dZKGTh/RM8MgQSxyP4l6BvfudCIVQtHFgCvTQYgSliftCqwR0m9FSxQdBLo6xckMbDyhz9E3ah/XH/jbmLITrk9wLylWyCSCMqEJ1y2Z7+agMG3oXaF79GRwAfFg94wQag72tAA= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5102.namprd12.prod.outlook.com (2603:10b6:5:391::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Tue, 20 Dec 2022 02:45:08 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5924.016; Tue, 20 Dec 2022 02:45:07 +0000 From: "Chang, Abner" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Lin, Kuei-Hung (Timothy)" , "Ni, Ray" , "Kirkendall, Garrett" Subject: Re: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Topic: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Index: AQHZDKlQxCFyQ4+KbkGYDV+p7csXRq5pmfSAgAyGdpA= Date: Tue, 20 Dec 2022 02:45:07 +0000 Message-ID: References: <20221210150824.1231-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-20T02:45:05Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=231f13d3-6129-4509-a8f5-fde34d626288; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5102:EE_ x-ms-office365-filtering-correlation-id: 1e7cec5a-a4ba-4065-feae-08dae23434c6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MhDFApwkTGxibl3QFGNNtZjs99MRyanwLElW0qGSxj1F+DRbBbC+a6XvCfOT6rbRFihlvp7nr8beBPBIJM9Sh4Euokxw+qpoQolEf+gkFi4FR4DllTIGS7m98DJTpkpqAgYnzu6x0V5sXHCFNcTMdFWNyg8Yuvt1g59BDI4JonUjkhVV9Ng/qfwv88EePajHaoE+/EaKLKPybktZ9DAj3mpPadhPVtFgQgbXBtOh1V+VBjOAccb+noG2GJh7h1uT7nQVu3vtJgoBAe771LkZMnqhlnk4gjFngyZgG6IXKuQ8cOUO+5gR8LqOjQVCUzMZtsRbPgvq7kASzyb91uhZrnUgkGUUwNHOqaNtVtlsUF6l2ictSw7HJGyXa1Sy6W3BaCWeC7gD3PMpwF6gDKk41lzVmBcj5S8UeaNmxA1csNZ16GysbugnK4+sAtTHP+4ScfcNwTXd6jsqdtZHnxCmuxMiw+mukEDyZg07voxnmfQemBuNu/2UFbXWyO14Off0eyWaCUEawiwYGEmbXtSEUae1fp3eZUGjnTh2C5hnrJ+6LS4r2TR6B4kpl6STDSzUz+ms1F1OqaY+DlUgdqq+So6I/JVY5PyxadpFSEuy3u07ro/UIsOmurW7rAopTVsTWrrdBu2McRqnaLy2o+MWYgdprrozSu74GBitf8ZNNIwUPPyJpM2DC25S4LUlYCT6VK118q+fyLcT5wsUmOHDDqYloOChUYYpsaSc5s0DJkaKha+9htecLX7bO/H3OBWhGQTVOBJr1cxM7TGhZejDVvRmeA61BtasY6KtZmF+WfA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(366004)(451199015)(6506007)(45080400002)(7696005)(478600001)(966005)(71200400001)(53546011)(9686003)(2906002)(186003)(26005)(41300700001)(8676002)(66446008)(66476007)(76116006)(66556008)(66946007)(64756008)(4326008)(83380400001)(38070700005)(5660300002)(8936002)(52536014)(316002)(19627235002)(122000001)(33656002)(54906003)(55016003)(110136005)(38100700002)(86362001)(64893003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pSBBdc+T34iuW9ulwpTuTLVfUUD0ffTBcqfJeroF48GNfEGYITFxsF9vJklu?= =?us-ascii?Q?aEjQyntNwoART3io1wSdFO+tSMUxDOZoJZkSiB/frZ20IwTc8LrCHyf/noK/?= =?us-ascii?Q?FZEDmD8R6cMYnekI6ubF0G3zcZI0Vwvsx9cVhFj5FUn1bQO8ArMERnXCiB7/?= =?us-ascii?Q?xfS77HFac67rEtFgOuPM9Sxy+/ZjJz684oZMl+8+zX2Zi9C/UatrG3Jx8tfe?= =?us-ascii?Q?mOsqq1S7GXrdW7B95AnVZ2AKXgG5/ppBlujSW0T/03Luh+fSfSOyVvuSGke3?= =?us-ascii?Q?OjuECkOSNQS9Z1TSgOtsebCCK7vnAtsUS9i7bjt9Spqhx3fsPYyG21lBNV9K?= =?us-ascii?Q?GIfdRlWTDmNZD1HknsxaVOcINCUi01qqy2qcFCQZtCgCC3bRRCm/Fc4112Zd?= =?us-ascii?Q?swYvGoot/QrQC3ipEdFXTvM+Rq4jpJhQPLQLbPC31SCU9hBgf9Q7exbyUWoB?= =?us-ascii?Q?JSDcN2T6UONsUcRwlsYp2rFS7EG4z9gFqYdmaOmtKMr2TmwvlQCjMnukCwGf?= =?us-ascii?Q?CNZng2oQsp3RWyZFYaDWROnAWO/p54T1aDB1tkUw8i3d2HpCTeFPaB/hEdZy?= =?us-ascii?Q?pDeuyAPWAQPMRYxKqKzj6Lr9Dfu5VoPscTlQI/XxspM3BeMe8b2+dJvI3GJt?= =?us-ascii?Q?mQjL8bZMguTQNcMJmw7BJHgljFMu1GYcy1gQufAXXWf+ZsPUSC5DvrZYwal1?= =?us-ascii?Q?s33jrc+0up5OgNBYNkx4V9l5Wueml+gopA1Wu3cZZuTiVMQaozUwXB/0o7f6?= =?us-ascii?Q?Mrlw5avdua8YjfDc1sSzAKTsWvwxcmo3YJbSupEbEYUyksejGZEATVW5gMts?= =?us-ascii?Q?GySh3uDtjR8NabUHhQA9AE71oBog4dQipF1IdfBKa31ZpmEWgM9VtNFmWT/j?= =?us-ascii?Q?irN3H5f1lePan4cpB1ybfNPyqzhJ/cdL4k8NHsbrNyHpgL/7DcfwvFfWLxsP?= =?us-ascii?Q?fQkEQknlxgTUI18/eo6yXY5B5PsbecAClTxa1/7kL+EuMgzAPrpt/4Vu6QMR?= =?us-ascii?Q?jDNqwIy3m74U83C2vAAAuFn7NKAzqSpzLV2Mqve6dcybRphoAxrEp7+vrNBS?= =?us-ascii?Q?TPs6eCa3mIiZAS6rwLa7WXv/ZmZMkYiMYMMJplmOoqKgq2mNeYQ/RYJpFDwG?= =?us-ascii?Q?yw7DnCWtxr+GrA5du5ZHnHQpcegQxLHi07zNWaJ/ryiTGX9efaezM4Ym4Q04?= =?us-ascii?Q?71USRbwf5jUgJlBwnHVZCV3UY9piDAPj5y/Nn9UJn8F8D7rNaz4NRon4k8e5?= =?us-ascii?Q?7Q1OHUDmwjsQe8O+aCyjAMQzVNvtDaeJNS8T8Ev8AWOENLjxV0Fze/e5kBn9?= =?us-ascii?Q?Wk3FAx/wNbWTtjxxE25EK0IKShu2oHcax9PhnXoogyfTa/4e+CFhk5I6XRec?= =?us-ascii?Q?eDh3cf4CAngNG3sKLqy1evNR+CmnvMUOBfwyKUTqP+p+rYGA1BOCi8u9mwak?= =?us-ascii?Q?oW71+aAyzfc4j5kerIG8VlhNUhQXmRhlp4ZxHXZu08yTR3Q3nB312o/jsrC0?= =?us-ascii?Q?wcnDYIXz01mf673vfQJFptOEUx6U/Xnmf/0kX8zyGqpvD417lvM9tA4e1XRM?= =?us-ascii?Q?RqLjkCk2u/eDakdEeoHiVkNqyq15xDzMY+yt1J0N?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e7cec5a-a4ba-4065-feae-08dae23434c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 02:45:07.7667 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 28EyAjCNKwieoM5jXYMwU/BbYf+NSzcc5uJXf5km8ygq8f/puZXeXXopfsGmrnZJbNrNadgCzengRLH2uaiI3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5102 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Hao, That is the uncrustify check error. I already fixed it at "[PATCH V3] MdeMo= dulePkg/Usb: Read a large number of blocks." Also, these three patches are passed the CI test. https://github.com/tianocore/edk2/pull/3794 Thanks Abner > -----Original Message----- > From: Wu, Hao A > Sent: Monday, December 12, 2022 11:27 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > ; Kirkendall, Garrett > Subject: RE: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Contex= t > value >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > For the 3 patches: > [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block [PATCH > V2] MdeModulePkg/Usb: Read a large number of blocks [PATCH V3] > MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value >=20 > I found that they will cause CI failures: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Ftianocore%2Fedk2%2Fpull%2F3749&data=3D05%7C01%7Cabn > er.chang%40amd.com%7Cfe921dc0e08b4cdf30a208dadbf0cb8c%7C3dd8961f > e4884e608e11a82d994e183d%7C0%7C0%7C638064124508360013%7CUnknow > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D0iQKJ3X3IJv1CSqe > mjTWyT1hlYvqGZsYPAdwXEi%2B%2FZ4%3D&reserved=3D0 > Could you help to update them and help to ensure they can pass the CI tes= t? > Thanks in advance. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: abner.chang@amd.com > > Sent: Saturday, December 10, 2022 11:08 PM > > To: devel@edk2.groups.io > > Cc: Kuei-Hung.Lin@amd.com; Wu, Hao A ; Ni, Ray > > ; Garrett Kirkendall ; > > Abner Chang > > Subject: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context > > value > > > > From: Abner Chang > > > > In V3: Add AMD copyright. > > In V2: Remove the signed-off-by: Abner Chang. > > > > Initialize XHCI DCI slot's context entries value. > > > > Signed-off-by: Kuei-Hung Lin > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Garrett Kirkendall > > Cc: Abner Chang > > --- > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++ > > MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > index 13b0400e83d..f08722905f3 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > @@ -4,6 +4,7 @@ > > > > Copyright (c) 2011 - 2020, Intel Corporation. All rights > > reserved.
Copyright (c) Microsoft Corporation.
> > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > > +reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext ( > > MaxDci =3D 0; > > > > NumEp =3D IfDesc->NumEndpoints; > > + if (NumEp =3D=3D 0) { > > + MaxDci =3D 1; > > + } > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -3006,6 +3010,9 > > @@ XhcInitializeEndpointContext64 ( > > MaxDci =3D 0; > > > > NumEp =3D IfDesc->NumEndpoints; > > + if (NumEp =3D=3D 0) { > > + MaxDci =3D 1; > > + } > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { diff --git > > a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > index cc597a43717..8400c90f7ad 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based > on > > gPeiUsbControllerPpiGuid which is used to enable recovery function > > from USB Drivers. > > > > Copyright (c) 2014 - 2017, Intel Corporation. All rights > > reserved.
> > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > > +reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd ( > > } > > > > NumEp =3D IfDesc->NumEndpoints; > > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > > + MaxDci =3D 1; > > + } > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -1974,6 > > +1978,9 @@ XhcPeiSetConfigCmd64 ( > > } > > > > NumEp =3D IfDesc->NumEndpoints; > > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > > + MaxDci =3D 1; > > + } > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > > -- > > 2.37.1.windows.1