From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D6034D8004C for ; Thu, 31 Aug 2023 03:28:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JejbN5lpxmO5kD9U6unM7YYfWEpPTz9ZV1QWoV/rA7g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1693452532; v=1; b=uBvWySTzHbuNfsw9EBcB+TJ+TjYoSkFEHUmQ0RzTk0Ifh22C+4rDaFaz75IGmZxEMRQifo1/ DmiQ58XSzPo9CS7yv/X4kIkqk3Jutkpdd0LtWmqJB89NurIXe1a7Y63QZ3TUhMfdgEzNkd683LP uUa0S6v7fK98DWB+20yeSHyI= X-Received: by 127.0.0.2 with SMTP id 6PqxYY7687511x1Fu5ya6lh7; Wed, 30 Aug 2023 20:28:52 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.80]) by mx.groups.io with SMTP id smtpd.web11.9222.1693452531484476905 for ; Wed, 30 Aug 2023 20:28:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0usqAs2MDa0rv0aPQWUpG2yPSO5kvh9SvhDathICjzlngj23dQO9dAuNya9PfSKK277qGj1HfTYX9HrIZfs+kLyjH1VK5V3fYu/FIMQYYdn5Jg/lkKg62JqjcxpYkedQuQgzSnm6WnULwHYHYD5lJsrPfcQWutR63fnyeXYvfO40RG7D1uIEg7PJaoSCvw8FUzQ0CQ/epEXwvyKMJMSLrW76rTM5PEKxWNt1cdeLeWOgNbyt7/W24gjSdL1IcQtLACwjH/al8fEcSWpwqY/x3RGfeS+uxBwuZsWR5amzYBGqX0EEl1i1MavEZ+F4wzVPlozmBX9UWtYxg12XTWO1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QFx4UbEYbPmj0EvceWLFztFYQboDdfg6r62MEf7sAnQ=; b=g7m912WwoXWUbQOQ64cm5O0di8iI8I3piTJ+XknXIPvX/oqXZBbJdsujBkFZETm+1wCmmr99E8XgArdr0hwP6T7JHgqniFG9eWZp1tjYcnbsOIyzpkePuNjhNfnXhyN9Nl0S3skjzS23WskCZ4fc3P+yit9U7Cd7RvNn/m+0dzH2ralfTMR5zkIPFWP7lHJZLdaJZvgmQNEKG/nlPBQ/6PIm895fxkKycdpWazvJrZEujr3ZoFIC6euDhcf7LCaro64uGLZZt1LvJwQK/66a+v2BIEffXMz5xgz9fRbv/djBpfjiCRl/hf3JM1HeuA1hfPx9NyYtlgb5czfgAkRE8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5061.namprd12.prod.outlook.com (2603:10b6:208:310::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.20; Thu, 31 Aug 2023 03:28:48 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e%7]) with mapi id 15.20.6745.020; Thu, 31 Aug 2023 03:28:48 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , Mike Maslenkin , "devel@edk2.groups.io" CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable. Thread-Topic: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable. Thread-Index: AQHZ2k8A1h6yPcng/0Wj+XnGMa/tYrACE00AgAGuXRA= Date: Thu, 31 Aug 2023 03:28:47 +0000 Message-ID: References: <20230829080112.12748-1-mike.maslenkin@gmail.com> <20230829080112.12748-2-mike.maslenkin@gmail.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=9461ad93-cf8b-4c2d-9e03-414eee52bf0f;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-08-31T03:27:59Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5061:EE_ x-ms-office365-filtering-correlation-id: 0a6662d3-0eed-4288-4b86-08dba9d2637f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mz/0rsuEoku+hEOD8dg23MofXHLEa2FPqPOfnPuBWxtVzQ6MWTYpah0+qhmPD+gEntpruLcKWzgqo1kVwGgeIgUnVYs3Z+v/dOwZ2+FQEVTB2KvLVw5C0F3lIhvIiiCQQfsxIT7PX8Y1K7SzCosrA1draVw4cO2/qNqgY5+Ljp5YA4M7s2MYk9xKpX8ga3Z8Waz7doSN2ste1SwBJShsGufufAD6tnrkFRqP1VJ8x4mUwAUdTeCoKjnzXBG2CQl8I0xkllq9o8ZxmrchGWi2XsgFDzihSqGQrH8Mlkrjbp16FTuOazOWDtCJjbuUQXxTGHfjWPplXCT9IGP7FZuCECsJyAoakpqrct3QnJb5JUwF8Jbnjze1wklc7egxP9y2wDM3EYefh04qUS3Y+s2pVMAY6f9nawZAV1/obC/jK/91XniGyLYT9WAPjoPfA6pEc4kAHuCxL7MmhiiU0Tm0BdBMBPpu3PWroy6kr/PCaxDc+JZbyOSO+g2yUI7o25fTurDZhgMcUvpc9O6KSS5fvDB0bRbWE3FoRHx9uEVOHlfXTOynxbiT/uh+Hkn+DF7PsCGLtFfxU8n3VngkTiqHWdguw4Y13t6CsVeJ+O4TLF0HbROvsRpM+fJo8SkiKxYH x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W9dwoKoCtS8Ts9dezAcvoxAAP8E3fXi5JjJD9KVcGulz8c2iRvqX2L8CPpMW?= =?us-ascii?Q?Dvq+nKiVhJWC84ifZ/QUFr7RODzEz8xdxyuBXc6kUWlggHag1uZ0d/WCXaSp?= =?us-ascii?Q?QeQ3jEf4p/qTmO1YM47nDMm1yyLkgy9itFjYKkOdDI+CELNL0JppuT8HqF5x?= =?us-ascii?Q?2GZ0vm3naqHpt21yBktBManKCZQ5gnPy4b81e8vVGalyAHi3C+HIpvfS2SCw?= =?us-ascii?Q?ZXm/zc26GtFIYBAGWAMqIYHa5H2xfxnuiL3EMCAOAUS30HC8/r/G0LgRZByD?= =?us-ascii?Q?HbYk46GJr1ZFTcxU1RpOLAzmeKaOdJj3M62UULVwtazlCZGw409MhxQ6K28U?= =?us-ascii?Q?8rcObwDUc48PNoOExv4M1SRu94nJIhPmS8P3Duip/tcfGvTGWq9szRI9EmqT?= =?us-ascii?Q?Blzhp0yJJ6Xhrocc0ISOWcQ4GUORsNNZhDJ0+Z3NV6gv5Re/x7vCJJQK8m7b?= =?us-ascii?Q?2C744OvFBd03GOARtA6oeMxEnwWrwShHMun1cVlKFivI8VHXw1VZLLmOXpF9?= =?us-ascii?Q?5/nyrToWbhOF9lbZLFi2iHGF9uu/f5rzgRSYSxux+WejD8nzG+vppClyFlPQ?= =?us-ascii?Q?eNALUt5ywSBi8cRPwbn5Iq1aHWzpwDsBEunSaH9XM9+hDmCoK0OV5//nv5/i?= =?us-ascii?Q?AY7bWEssv2g39XzbAA+3kS10vRXvA81PaFmhavity8nUwQZfVgpc9jh6MqDM?= =?us-ascii?Q?+QHRo3j/l6gNBflpzQRVKA/n/XgA3DK56JbXPKDOByF3/s4b5sSxDhoAe6og?= =?us-ascii?Q?VvgHDmkLoKXSz6PWAOpz1EZt76yKwhxpzOeR8EzeZHRVvXnlyHGWXG76oPRZ?= =?us-ascii?Q?0jshCa7nCxstB09NBj+w7R6l4NQlZ5e29uvR71+t1PX0us4FFuxOCi0zXV/l?= =?us-ascii?Q?8GxwSX87WBbFGyMs4Ihk/E4CGABLRjGD6+QnvQ7mDwEHh2T5Jm7Kpb53bOvv?= =?us-ascii?Q?ejCz+epvzVp+lYJh9GWfivfyNHezJcDv+rhBqZfd9zlEPqj+a1afkUqhHXRE?= =?us-ascii?Q?6yOr6jDT3kMaadB4zVU8SVgW3V7ulg14/VZOc7esHdor+YfNU5rMWriVR7kq?= =?us-ascii?Q?iy0tTc5GvW6TaAXFDjyah+zDgzOh/IBTJlpEP2bYsTUMAFPctkxQcoIe4rbE?= =?us-ascii?Q?OY+uzsYJ0R5Zw1MKj/fgt7ocUIRM0gEou/j/1UPco4h0oJ5iJTLv/raVIMv4?= =?us-ascii?Q?+PItHKitb22l1fIE1EY6UtDtZyX4cHwaxCsXzU8yTMLZejr3fskymrF8TnJY?= =?us-ascii?Q?Mga0l2mZ2uyiOblnEdld9RmIhFIkWWo/ScO/cQBsGWcvgJyn00Eg4wrP3mLJ?= =?us-ascii?Q?Rpp3pXpYJm4GeryJFg8i5RJAlNCI8eREIi5keotblPY/R3fkDzONgboIetaK?= =?us-ascii?Q?JgrsMAgUPmwA+wnXrVyoxClU2aM8hTtaglPG0PgLbVCPVESQvIlrba4GGLot?= =?us-ascii?Q?lDwxRaC6iN3zTKcVRRnnzrWBXuAHXYcAVyb7/drQsR3uqgdCNmcHlmoGS9Lk?= =?us-ascii?Q?XC+AXhhR8oCHfLNrLy816p4Cjxyr99OUnpIar41JAj5nyLDuaiUMGsikSw4D?= =?us-ascii?Q?/ISOXELLnlLRXrgzYJI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a6662d3-0eed-4288-4b86-08dba9d2637f X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2023 03:28:47.9978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 23nAmNMY0+2Jje+7LO00WOkrkShxNNc+V3QFEBuZvCT1ICLvyDXBe4WbEpnK0yEMb3h1suto/yYrPO1U0rfGfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5061 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ybgZanr1QStzwhPL55gqPBCwx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB39662B299B651B45664F7AFCEAE5AMN2PR12MB3966namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uBvWySTz; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MN2PR12MB39662B299B651B45664F7AFCEAE5AMN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Yes Nickle, I agree to have a common API for initializing the structure members. Thanks Abner From: Nickle Wang Sent: Wednesday, August 30, 2023 9:48 AM To: Mike Maslenkin ; devel@edk2.groups.io; Chang,= Abner Cc: igork@ami.com Subject: RE: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninia= lized list variable. Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Reviewed-by: Nickle Wang > @abner.chang@amd.com, I am thinking that we may= need to provide allocation function for CS structure so caller does not ne= ed to handle linked-list initialization like this one, or other stuff requi= es understanding to CS structure implementation. Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.chang@amd.com; Nickle Wang >; > igork@ami.com; Mike Maslenkin > > Subject: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uniniali= zed list > variable. > > External email: Use caution opening links or attachments > > > Signed-off-by: Mike Maslenkin > > --- > RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index b9c799e07684..a1738de46fdf 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -97,6 +97,8 @@ RedfishConsumeResourceCommon ( > if (BiosCs->Attributes =3D=3D NULL) { > > BiosCs->Attributes =3D AllocateZeroPool (sizeof > (RedfishBios_V1_0_9_Attributes_CS)); > > ASSERT (BiosCs->Attributes !=3D NULL); > > + // initialize list > > + BiosCs->Attributes->Prop.ForwardLink =3D &BiosCs->Attributes->Prop; > > } > > > > // > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108183): https://edk2.groups.io/g/devel/message/108183 Mute This Topic: https://groups.io/mt/101027003/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN2PR12MB39662B299B651B45664F7AFCEAE5AMN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Yes Nickle,

I agree to have a common API for initializing the st= ructure members.

 

Thanks

Abner

 

From: Nickle Wang <nicklew@nvidia.com> =
Sent: Wednesday, August 30, 2023 9:48 AM
To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.grou= ps.io; Chang, Abner <Abner.Chang@amd.com>
Cc: igork@ami.com
Subject: RE: [PATCH v2 1/6] RedfishClientPkg: fix crash on access to= uninialized list variable.

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

 

@abner.chang@amd.com, I = am thinking that we may need to provide allocation function for CS structure so caller does not need to handle linked-list in= itialization like this one, or other stuff requies understanding to CS stru= cture implementation.

 

Regards,

Nickle

 

> -----Original Message-----

> From: Mike Maslenkin <mike.maslenkin@gmail.com>

> Sent: Tuesday, August 29, 2023 4:01 PM<= /o:p>

> To: = devel@edk2.groups.io

> Cc: a= bner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;

> igork@ami.c= om; Mike Maslenkin <mike= .maslenkin@gmail.com>

> Subject: [PATCH v2 1/6] RedfishClientPkg: fi= x crash on access to uninialized list

> variable.

>

> External email: Use caution opening links or= attachments

>

>

> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

> ---

>  RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/RedfishClientPkg/Features/Bios/= v1_0_9/Common/BiosCommon.c

> b/RedfishClientPkg/Features/Bios/v1_0_9/Comm= on/BiosCommon.c

> index b9c799e07684..a1738de46fdf 100644=

> --- a/RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c

> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/= Common/BiosCommon.c

> @@ -97,6 +97,8 @@ RedfishConsumeResourceComm= on (

>    if (BiosCs->Attributes = =3D=3D NULL) {

>

>      BiosCs->Att= ributes =3D AllocateZeroPool (sizeof

> (RedfishBios_V1_0_9_Attributes_CS));

>

>      ASSERT (BiosCs= ->Attributes !=3D NULL);

>

> +    // initialize list<= /o:p>

>

> +    BiosCs->Attributes-&g= t;Prop.ForwardLink =3D &BiosCs->Attributes->Prop;

>

>    }

>

>

>

>    //

>

> --

> 2.32.0 (Apple Git-132)

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#108183) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN2PR12MB39662B299B651B45664F7AFCEAE5AMN2PR12MB3966namp_--