From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 10763740035 for ; Tue, 26 Dec 2023 01:14:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rwl9YyaTVOcJia6OyWQ4CSjxNEnILer+WlGqhH3tSHk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703553289; v=1; b=JBXXxOHBIdiwTa5IGYk27Yf0d2o1sUcMQ2eQ8Id7c9mRl9/3OOt4L5DFM3Txx3388J7o7wv0 GJdhZF7hUNvHZtb+AuJeSKrA27rTw/9hImfKKNUH74FG17Duk8qy4OAr5cdYidFiLJYj8F/If/8 v8J+MedISvpuF5MHhBkPBJiQ= X-Received: by 127.0.0.2 with SMTP id 6O62YY7687511xSBL5TuzAgf; Mon, 25 Dec 2023 17:14:49 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.65]) by mx.groups.io with SMTP id smtpd.web11.72744.1703553288988587621 for ; Mon, 25 Dec 2023 17:14:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpJuL3qJi28Cu8rov3bP3JJvxoGdEV6LggHHMX6fEB1CZNpR7sD5i75NKdbPD9/SeBOT4tLaaxJmGqKQnQ21PsU1cFaxvxH/G1svcI/PzpAZYSicv0Yhr+8+UVGsphjdo22UdDkP1eDZvV7Aw4/1ze6nEwLuySj9g08yJTlT/4SzfktYh1gBtwfVCKe0v688GM7sVu+ceBKmCuSzUMKxPsxeDTWrCJj400WUzqssfVk+iTa+wON2HhR5vLIRl4lQS6OZyfOX97kGNBQ0yk6Uouy6V4g5a5S5OywjVnBWcv3+WCTAzK2KvlZ4JUYvPgJrH0iYQFmI2HBDrmpLdtRfXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcLK83BCDHW//10k8J2ap6pQgOOflTaOBP8w70/i/Y4=; b=G1mOO5qyyOUCe/d0tG2GFugntfaekVJ6iwn0p9l7l6sQd2L7J91LrGJKKda9BukWLMGS9gphChhc/Ybbwp4x7TUAlflDw97ROwx/jsAdYwTl/6BU8EtI6ohWzlYR38y6aXtAvShZZ0AeSkvVCTtri4heSnG3EIMM5FX6IEWzqUvmaMeuoUMBahvtowrSZWf5OofCrw71u48zeZ1B32ckMoVta/cdqz6rniar4MeGHoWRctBT6028sHYgG3YQOpBxiQ+DYTs7J5oWIr76Rzc+MMUeQ6HdhupMRP9rlZ+eqw+c3+hn86uq2J7ZSBHJVgHEdJwx1HWeC2EDCmlwUqAcPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB6134.namprd12.prod.outlook.com (2603:10b6:8:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 01:14:46 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 01:14:46 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationData helper function Thread-Topic: [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationData helper function Thread-Index: AQHaNrzjoXaabtADqEGsBSoNZLJ6JbC6xFaw Date: Tue, 26 Dec 2023 01:14:46 +0000 Message-ID: References: <20231224225927.9119-1-mike.maslenkin@gmail.com> <20231224225927.9119-11-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-11-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=037f8d3d-6e4a-44a0-a850-9e7244cd88da;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-26T01:14:43Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB6134:EE_ x-ms-office365-filtering-correlation-id: d1d9af21-3bb1-407c-9fb9-08dc05b00cb0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1j0Zonj447fl2FfYHrp3fUxBL4MvqSk4X0TEls0uI7MaTV2R9APbZAEXZ7apWv0WT9IL7/GealFSIodu9Rq0e9jACkhjEy2Xy5SzwQ8keMZd58uVzC01/J8MRHzVWsZNt4GfDWQHW3F93Ykg/7R5z83HTvKr9+yRs4QTCUlQ1KVOXkF8xz+U8Npy4htJ3xN/YrHTP3bItwQQZOnS/4lkI6OENIOCMxwr+CO9CXPYEgAJi9wiNVOGR5aqh1U2UJAxXdlRHND+dlmew0zdR/mfWYN4ZugscdxHyxzF8J/9MpgogEJwxaHXA9yzqBlrtEF7c7NnmOlbNQvFKR2Sw4AX1YoPfc1GIQ6YHgQZrut/N578GgGWvQ6y/hrVjFMAKlpsj/eaghIiN0uLoaFsYxqiiuoPqhiw9MbnifbGRAV3FYL5B39PpebdNIkn7jpxa5e5KVdqPQ/CSIVVwAjnc4B0epEG0lsHDQSt3tUcqvGcyWEF/hxk9bX5+d2xv/lvhueeybDqCi9RMGGYRhaH2wiFcibB3WY2p5EVSBJbMqo0dS1IXwShx/hqR3KICNsJa0oWILB5M19x7umHekXU25SSq57ciUYnZytILLMSmhm7sPgMF1YfjZi3d3cTKx9KkzpryRlAeMWKpUPBTxYiJ82mVz16tqYpGltUjKGamGdZ6c4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gvSC+WkNkiWNuiV5e8NuzHEiOG2VLP2AZa6V5VJJe/UKrpWq6AYBd3wNovQs?= =?us-ascii?Q?ClFNLBsS1amrnJAHPWEXH9LauauquIuu0eRWkrk7Ur7gT5bMObe/qjfR3v79?= =?us-ascii?Q?BzdM/Uv/63PlPVBy4D6Y/wMawB9fCsNcYYNRDwUd2/82+jJwGxi5JEvwQgw8?= =?us-ascii?Q?E1yfa2eijLOzvgGM6aCc+taJTSpONKmYQZMb7ECbKxNkVBToxK9kD4NJfCk+?= =?us-ascii?Q?c5+5YVf4/kKdnmwOMW7qvyhjeciQlLO2CIHmjnlI6z/8Hi5tqXBRr1//c4Wd?= =?us-ascii?Q?hFgtcpwMw/OmKx7aV/bIuxqDG38wf+J5xQwxj/LiF2FNRJaLNFkvlTdLO75F?= =?us-ascii?Q?K0bEv6s8a8VtkiPTschGiCSDqr8nlpoQ04/zCloeL3PZob/TpzpiVrPfHbvF?= =?us-ascii?Q?DhpDXfPJRzg8ABbIk6Mb3gwDVAhgPhcbofpfECL+Mk47i6oeieUmVET653k6?= =?us-ascii?Q?l06mcgRCr0sODEVOBi8eEHFnMs35rMm8YFb99eTYuremnAcGFpTq+Q+5LiUC?= =?us-ascii?Q?zEowH4UqNo5YZMp/FWinkgUjadZLqGoGl4Jn3EnwU3bGNsz4Nx4TKyxkHvV5?= =?us-ascii?Q?Oz7z+IN8CjzNV4DLEHguziEpEHs7hsZb+GCoFzWvmvCdfC9CTyCAla9CsuzB?= =?us-ascii?Q?GnE3qEosaW2PKUpxtOqub9mYZf5Y64BpD5WbG936BySBJHB6O5KSeg/qeVWF?= =?us-ascii?Q?sFSo/wuGjWtEbaA3Chf2/dgPg2zzoXUHg9wfe/qt4El69PQeQMG4tUtQlxxS?= =?us-ascii?Q?ea2pUfSVjRKzjfK8Bzohdo66InZdWcAk9qVKBMySGiKz3If7q2M1ZU2bCxxZ?= =?us-ascii?Q?S0ea/4Qn4dDwPpdM7QA18DPP1vBXLYNjRuygnSOHri+bGyPj6kpBu8YI7abF?= =?us-ascii?Q?HoXVRZxMp8g7gJrTwiqU7V6BHTycSiszNKaaKmf953rGWs21qcQY9zS2CCxv?= =?us-ascii?Q?6LlQskV+535w0bVidWs3cSkZe9irKUavacDmRi/QZtYdiQeYVyqRooWYWsWJ?= =?us-ascii?Q?Q8mE2PzKV7gavBqOPT7O/yk6FR8Fe4uOM7ycSZXAKlcHbHb+9ygslD3wwaPT?= =?us-ascii?Q?k3ZijA6Y6eOJ/uZt2LZxXf/QuGb5/pdxBgzw1hpBITuD9zzygrTRq0m9Z17S?= =?us-ascii?Q?VwmQCtOqneDtp1o7QYm/qXmhYnE1t9ns/iIyipz0JASg7wFoZzF3qAsyQTwG?= =?us-ascii?Q?wVc6YcGfjscZRj7ZE6m2seCl8ZDVlZvk0uILHjtm7SiL8QLVv1NCC2bpDuZK?= =?us-ascii?Q?ZvAce1ulz/hYT2FNgeetacOnhJk90C+4DRqTuCr77zbA8w0Lh1z1R8dUs7LU?= =?us-ascii?Q?8L9pRvIFNgIUQdM83IsJt2Qc/L3o0iFRWJ51LZcdkL/yp5Urs86rq1Wn1TOM?= =?us-ascii?Q?2ESb5l0h1P8WjoRza9Ig3DNuH2IFsXoOcxpyqv11MYnSoSgy2NH+KEpzn5eZ?= =?us-ascii?Q?KxANCspwJ/zRYbkl7xNOTEZHjEYgZzaKukc8TrFkSJOCT8iOIgMsVI40FAXr?= =?us-ascii?Q?yIvI7jS+Q5FuB4fzQ81QrYw8pXP3eW+nnd5xcXeB/Z90PS2+aoch0LsnzgfV?= =?us-ascii?Q?iz7qcfT/4b1oF6jMrYU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1d9af21-3bb1-407c-9fb9-08dc05b00cb0 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 01:14:46.4853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FNmfMG+lk0Rdh9A+rTJDAzA7M6Yw8y7A1Zbz0mbu2D1xZtnRAw8Ufff4c6p7LlJRs657kXZ5Aktk2EC5b2IDrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FtXMpfk8rewWvGVghdaWSTNVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JBXXxOHB; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Monday, December 25, 2023 6:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationDa= ta > helper function > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 ++++++++++++------ > 1 file changed, 74 insertions(+), 34 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index e344e06d8dcc..7aa68b54a61b 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -6,6 +6,7 @@ > Copyright (c) 2022, AMD Incorporated. All rights reserved. > > Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> > + Copyright (c) 2023, Mike Maslenkin
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -711,6 +712,69 @@ DiscoverRedfishHostInterface ( > return Status; > > } > > > > +/** > > + The function initializes particular strings into the structure instanc= e. > > + > > + @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION > > + @param[in] RedfishVersion Redfish version. > > + @param[in] RedfishLocation Redfish location. > > + @param[in] Uuid Service UUID string. > > + @param[in] Os OS string. > > + @param[in] OsVer OS version string. > > + @param[in] Product Product string. > > + @param[in] ProductVer Product version string. > > + > > +**/ > > +STATIC > > +VOID > > +InitInformationData ( > > + IN EFI_REDFISH_DISCOVERED_INFORMATION *Information, > > + IN UINTN *RedfishVersion OPTIONAL, > > + IN CHAR8 *RedfishLocation OPTIONAL, > > + IN CHAR8 *Uuid OPTIONAL, > > + IN CHAR8 *Os OPTIONAL, > > + IN CHAR8 *OsVer OPTIONAL, > > + IN CHAR8 *Product OPTIONAL, > > + IN CHAR8 *ProductVer OPTIONAL > > + ) > > +{ > > + if (RedfishVersion !=3D NULL) { > > + Information->RedfishVersion =3D *RedfishVersion; > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", > Information->RedfishVersion)); > > + } > > + > > + if (RedfishLocation !=3D NULL) { > > + Information->Location =3D (CHAR16 *)AllocatePool (AsciiStrSize ((CON= ST > CHAR8 *)RedfishLocation) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)RedfishLocation, Information- > >Location, AsciiStrSize ((CONST CHAR8 *)RedfishLocation) * sizeof (CHAR16= )); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > + } > > + > > + if (Uuid !=3D NULL) { > > + Information->Uuid =3D (CHAR16 *)AllocatePool (AsciiStrSize ((CONST C= HAR8 > *)Uuid) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)Uuid, Information->Uuid, > AsciiStrSize ((CONST CHAR8 *)Uuid) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information- > >Uuid)); > > + } > > + > > + if (Os !=3D NULL) { > > + Information->Os =3D (CHAR16 *)AllocatePool (AsciiStrSize ((CONST CHA= R8 > *)Os) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)Os, Information->Os, AsciiStrS= ize > ((CONST CHAR8 *)Os) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, > Version:%s.\n", Information->Os, Information->OsVersion)); > > + } > > + > > + if (OsVer !=3D NULL) { > > + Information->OsVersion =3D (CHAR16 *)AllocatePool (AsciiStrSize ((CO= NST > CHAR8 *)OsVer) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)OsVer, Information->OsVersion, > AsciiStrSize ((CONST CHAR8 *)OsVer) * sizeof (CHAR16)); > > + } > > + > > + if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { > > + Information->Product =3D (CHAR16 *)AllocatePool (AsciiStrSize ((CONS= T > CHAR8 *)Product) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)Product, Information->Product, > AsciiStrSize ((CONST CHAR8 *)Product) * sizeof (CHAR16)); > > + Information->ProductVer =3D (CHAR16 *)AllocatePool (AsciiStrSize ((C= ONST > CHAR8 *)ProductVer) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((CONST CHAR8 *)ProductVer, Information- > >ProductVer, AsciiStrSize ((CONST CHAR8 *)ProductVer) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, > Version:%s.\n", Information->Product, Information->ProductVer)); > > + } > > +} > > + > > /** > > The function adds a new found Redfish service to internal list and > > notify client. > > @@ -851,41 +915,17 @@ AddAndSignalNewRedfishService ( > DEBUG ((DEBUG_MANAGEABILITY, "*** Redfish Service Information > ***\n")); > > > > DiscoveredInstance->Information.UseHttps =3D UseHttps; > > - if (RedfishVersion !=3D NULL) { > > - DiscoveredInstance->Information.RedfishVersion =3D *RedfishVersion= ; > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", > DiscoveredInstance->Information.RedfishVersion)); > > - } > > > > - if (RedfishLocation !=3D NULL) { > > - DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocatePoo= l > (AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, > DiscoveredInstance->Information.Location, AsciiStrSize ((const CHAR8 > *)RedfishLocation) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > DiscoveredInstance->Information.Location)); > > - } > > - > > - if (Uuid !=3D NULL) { > > - DiscoveredInstance->Information.Uuid =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, DiscoveredInstance- > >Information.Uuid, AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", > DiscoveredInstance->Information.Uuid)); > > - } > > - > > - if (Os !=3D NULL) { > > - DiscoveredInstance->Information.Os =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Os, DiscoveredInstance- > >Information.Os, AsciiStrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, > Version:%s.\n", DiscoveredInstance->Information.Os, DiscoveredInstance- > >Information.OsVersion)); > > - } > > - > > - if (OsVer !=3D NULL) { > > - DiscoveredInstance->Information.OsVersion =3D (CHAR16 *)AllocatePo= ol > (AsciiStrSize ((const CHAR8 *)OsVer) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)OsVer, DiscoveredInstance- > >Information.OsVersion, AsciiStrSize ((const CHAR8 *)OsVer) * sizeof > (CHAR16)); > > - } > > - > > - if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { > > - DiscoveredInstance->Information.Product =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Product, DiscoveredInstance- > >Information.Product, AsciiStrSize ((const CHAR8 *)Product) * sizeof > (CHAR16)); > > - DiscoveredInstance->Information.ProductVer =3D (CHAR16 *)AllocateP= ool > (AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, DiscoveredInstan= ce- > >Information.ProductVer, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeo= f > (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, > Version:%s.\n", DiscoveredInstance->Information.Product, > DiscoveredInstance->Information.ProductVer)); > > - } > > + InitInformationData ( > > + &DiscoveredInstance->Information, > > + RedfishVersion, > > + RedfishLocation, > > + Uuid, > > + Os, > > + OsVer, > > + Product, > > + ProductVer > > + ); > > > > if (RedfishLocation =3D=3D NULL) { > > // This is the Redfish reported from SMBIOS 42h > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112893): https://edk2.groups.io/g/devel/message/112893 Mute This Topic: https://groups.io/mt/103354129/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-