From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.89]) by mx.groups.io with SMTP id smtpd.web10.33984.1670813448976853356 for ; Sun, 11 Dec 2022 18:50:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Skx8Taq0; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.89, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUA010PBFjlDcr0n5i29CMPQ79IBl/lTdhQg84+2e9+z0zaOl22ZA+JYNjxW8oBuegJezskuRqYK37T0/CVk7gLsdNarXG/O8k/oxrYrT8l4y2GYp95wT1DcHOqPrkOZXrx4lnjopXjn2RY+GooxjHuA8vfZm2/7Nogx24KOICW3GZ6duZCr7V0A1AYpIh14Pbp8Owf0zvhhvIVBSaC16pmrUDA7J5Vavg9eI/XuVQTO2QYee9ApTlAgT6JC/y6NZGqaDL4VO6FEcrkoGhEOixfduRZhLwCYOWUg9BjQnBOrJNuSGnuPIlqJxuz+ahfDFsL5WbfCU3vZUdJZW+HkCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/uceVI7LHFpd4J2at+SBtjG+Y1KKlMvUaWg8NqyLLk=; b=Kr8Lmi1uLh2VxQJ+4bXyk3Ur7kIDJf/dZgd1YCyBr9S0Uxb0b/RvHFPpz/Z7QcSbNFid4tazWL37s/+FYLOSO5LYqjrlxmnnP02y0jBio6Keo5wsL7ll9KkwXa7i9pFtuNzv4rT33jpVJnjpwsBNhHyrEOc5npZf1pWdnRxdySispmeLbeQYrwZq8MdonpxTN35+bFZeRkF8NujpUGjfhmgIZz30qPqPeU0y+eThqaAXOJxX3Mj0liQgQcNyAsGDJ9XZLYtoccVONo+TYGwXr73A55nPHwZFW7umRNju7kgJfK9q6MOmWXLRDElsZIKBTlvpsqfF1wVsuuF8Bj7nnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/uceVI7LHFpd4J2at+SBtjG+Y1KKlMvUaWg8NqyLLk=; b=Skx8Taq0bxO6fvvxngqBBI+CXHdSLRfH2Xf+GL8l6I/DxpFPKw8hnIeL+LhuL9HUNgsmPKRMQL/XkzQl5T848pr1MYr5rdBmxcULxYX6+gCvxHelUaDLOnhynpWSOX0opm+dcgzuvI/tX/Q1NtCnQQw8LqXhnBYd4BWfw1UFGso= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB7441.namprd12.prod.outlook.com (2603:10b6:806:2b3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 02:50:47 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 02:50:47 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Protocol Thread-Topic: [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Protocol Thread-Index: AQHZCknq807qtdcec06KWWiVDAPmp65plHNg Date: Mon, 12 Dec 2022 02:50:46 +0000 Message-ID: References: <20221207144039.310-1-nicklew@nvidia.com> In-Reply-To: <20221207144039.310-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-12T02:50:45Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=05ef1c30-67c1-4eba-a5fe-bbe96330c6ab; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB7441:EE_ x-ms-office365-filtering-correlation-id: 04a67411-1e3b-4a3d-58ab-08dadbebaba7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jJ9XobaaqBrtB4Ky0iTNopgFS2fJD4k37RNHYIDU/GcuEEW8MjGcT8VDWwX/BiCs+K5b0O5XG63xCj33I2lr6TFr3+eRBEcYxU/3WMIlgfpWbvU3cpFp7UXoec/jiXH8WO0ABBOcgCZurJe/0dVIB6fiIQctbn0xW0AY+Ie3tDWfREVBdmklfr1gwvXdCclFE/Tvu13VCplqQ3P575A4vyCzQSwdXV9gF6ikZjzh5n6BADkNVv4BJW8rPJ4t4ubdX2AM6onJR6TXrNhDpTcZP0gQ3uPJGqh53FXutiaeNOUgJJuJDL6HZ87ZA1IIjVatJXxFN4d5o2gmH6n0Jbcoo9fgjmr61YvFn2xI6jbvbFKdkixO57cUc1o9mmRG5yvq4IPvmagCIzmyQFiG/pPn+aP9Xv/7B0kH6Klcj6RLCk81gzwju1Eo2EW+K+2mKgGn3cFG+deywrjtrN6+NpN9Bm9z3PSfKzJA/S9ust2G10Zdn5czKTQXYWRm+4I8AxNFOzqfzMscBVagoWy2PAB1oq/CILoCRanyz5cBIS4ZX24yTfqIOcA05KjQUlKiPqLPpndHQ0nWH0Jya0IA7CFqn/VbajNzTMjWbBFraFfuURdMeDeDGN0pr7O8NoIgeKhZEokVisu4ujmG0iwWYG6k6qyZcnjuJA3JU4f+/wXzW82XIuGFT5IPzPK5S6Nap4qseAAJdWqayC5GeYtvkujpRQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(33656002)(122000001)(86362001)(83380400001)(38100700002)(38070700005)(5660300002)(8676002)(2906002)(66556008)(66476007)(66946007)(8936002)(64756008)(66446008)(4326008)(41300700001)(52536014)(76116006)(55016003)(7696005)(9686003)(53546011)(26005)(6506007)(186003)(110136005)(54906003)(316002)(478600001)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LDMPgjOg6HzfCVyxd3idRxWbFXDU0whEVHgjpG3LqcE5CFMk1xbsqyO0k/pW?= =?us-ascii?Q?2Z+1jKnGCiP+glwqxcCzzdsqDtzeXOCQN6Dgf/hQHDfNh9qOpKmz7aZ6ND67?= =?us-ascii?Q?pw3Msr/IkZvVo8od+yYggrgCcpp6p9bwdbgjzrfyOrYONG3dIhTYBNgVmLs8?= =?us-ascii?Q?f6omNxEi2gydHP3iDlvoOzMc4Pfgycb2MYA46DFniqMISMO3nQM0Pw9gqtWA?= =?us-ascii?Q?cZMJwH5+jxvHcfl5ACEJxcj0EQ5PKd3fc4lBv3N8Iz+Oi7JlxJ5LIY+AIjAx?= =?us-ascii?Q?OLnLhXau5eIZPFngUJ9wO1kxUL548GWoRVy0bUk3nAhxBL/ZR0Qd4FOQtFmR?= =?us-ascii?Q?OeO1DIQL/qvIZLkWPjECg5xeqsNGyfrX3wPrrsQaZ8sNsCV+zV48MWzFVa4C?= =?us-ascii?Q?7RjVJUuKYTyOz3hH8+zEUzMODy8S8YASzrbS5MBFMaTJc3/4ccgXWnjqPvaR?= =?us-ascii?Q?920kaYIqTT/qhphhjA7edydHN5nmAFJWyYBxN7jiG7Zob7/w/ZLy/YOgiIoR?= =?us-ascii?Q?HNnlvOaiABxiCX0+ZHj+vhbV3EjM2fNlcDubzH8Kw6e2JwW+oKxHaIZY7Vof?= =?us-ascii?Q?K+CQ/ZyJDfnAs+rNq4qOvM3jjF8IaoFWlSi0lOUtl/aFpiHgXcNbSA5XaKs2?= =?us-ascii?Q?dUDF7gJOvo6NJzdD3/JqA+NvqjF6RpQ8M8cKOua40+7T9f6ZAR1qo/1Vlnux?= =?us-ascii?Q?hEuCKP4OJrZ4GI9KT2xn7AzTJYOZkZwloWiFKWL+F6xqpa1QgI8Y+YPf6v/X?= =?us-ascii?Q?11CRFLlnnDHAnZNdTihTUvVF6A3IOLkhxa/7klTLf2czNj+ouE8vY6IvqwU4?= =?us-ascii?Q?Tt5r4YNeaHlM7E6X2CS78eL5JXCAnwX1xiTFiLit8EQsdVO3WoY05PKhBnvG?= =?us-ascii?Q?d72z8m39dapbXQZ/hWZvFaDCzJPEWE5EdrtsdNHkusZhb6DY0lVOOcezXyHZ?= =?us-ascii?Q?UyZMrVfO5VnGdREiTAf+b4iy3LkkB3urOt/q99mYBfr92BT6qdFzZpluMB3x?= =?us-ascii?Q?nraEqnV+uhKZnHw915Q3Ny6wvE4SM6550ea3wKDL5LgkBtvbtEa0mFq8ZeNf?= =?us-ascii?Q?KN+mz5n7Ojo+GiBk9gnmBhUUFc8fKU+7/gPlB2kfB/hREomtfywyyoyUCh3K?= =?us-ascii?Q?EyMzc4tjXrS7+epSRl+W9FaLihdZ3ZQAPqWARejsXZgz0xlIRLl4UqMnJbKl?= =?us-ascii?Q?GWJNYhadUS7g0S96Wnsn+M+XSlUxvJ1BjCBCf7/A6P2IxdA/HpkY6RSfKe/S?= =?us-ascii?Q?Zag5cbUpRC+PBnxFajSl70Nhv0uR/yKZdVm7aFYz5jaCAO2Pn2yVRrd3UwXU?= =?us-ascii?Q?E8K/F2gAKYmY3yn72JczygeHhCLMuA6mAfmKFLV+ntIK6ncsKVY3VqFEWGs5?= =?us-ascii?Q?b5QHtlRAdw11VwEn35XSmdPEzsaCB6Z0vdpTHIWHkL48/O+vS39hbVVCpUja?= =?us-ascii?Q?lHCLDCbQgbYJo3zlfKV2xxqJkBkbpCsE3xTd8rkWMa0NJn38Vz5lbCTNDQGP?= =?us-ascii?Q?xITxXpPtCtRQeGX4qXuXa7Nr3VIbOr/a416codNX1C5W3w6Vbht0dng4Hp17?= =?us-ascii?Q?SzYY0zCfwbECv7PRKo4HJvR8E+5wyAJIpC1enaeR?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04a67411-1e3b-4a3d-58ab-08dadbebaba7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 02:50:46.9702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CtV8WZa+XqQqA9KB7h7g94YAlUwgQ437rR4jOkVoZ8oAkdDpmLMoUaP9N27/P3+eeu1L1Ugie79wehiium+ULA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7441 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:41 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add > Redfish Resource Addendum Protocol >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Introduce Redfish Resource Addendum Protocol to Redfish feature driver. > Feature driver uses this protocol to query OEM resource from platform in > order to support Redfish OEM property. This protocol is also used to get > addendum data that is required by BMC to manage Redfish BIOS service. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../EdkIIRedfishResourceAddendumProtocol.h | 77 > +++++++++++++++++++ > RedfishClientPkg/RedfishClientPkg.dec | 2 + > 2 files changed, 79 insertions(+) > create mode 100644 > RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProtocol > .h >=20 > diff --git > a/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProto > col.h > b/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProto > col.h > new file mode 100644 > index 0000000000..462d94fdc1 > --- /dev/null > +++ > b/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProt > +++ ocol.h > @@ -0,0 +1,77 @@ > +/** @file > + This file defines the EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL > interface. > + > + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL_H_ > +#define EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL_H_ > + > +#include > + > +typedef struct _EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL > +EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL; > + > +// > +// The definition of REDFISH_SCHEMA_INFO // typedef struct { > + CHAR8 *Uri; > + CHAR8 *Schema; > + CHAR8 *Version; > +} REDFISH_RESOURCE_SCHEMA_INFO; > + > +/** > + Provising redfish resource with with addendum data in given schema. > + > + @param[in] This Pointer to > EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL instance. > + @param[in] SchemaInfo Redfish schema information. > + @param[in,out] Json On input, this is the Redfish data in= given Uri in > JSON object. > + On output, This is the Redfish data w= ith addendum > information > + which platform would like to add to R= edfish service. > + > + @retval EFI_SUCCESS Addendum data is attached. > + @retval EFI_UNSUPPORTED No addendum data is required in given > schema. > + @retval Others Some error happened. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_REDFISH_RESOURCE_ADDENDUM_PROVISIONING)( > + IN EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL *This, > + IN REDFISH_RESOURCE_SCHEMA_INFO *SchemaInfo, > + IN OUT EDKII_JSON_VALUE Json > + ); > + > +/** > + Provising redfish OEM resource in given schema information. > + > + @param[in] This Pointer to > EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL instance. > + @param[in] SchemaInfo Redfish schema information. > + @param[out] Json This is the Redfish data which is attach= ed to OEM > object in given > + schema. > + > + @retval EFI_SUCCESS OEM data is attached. > + @retval EFI_UNSUPPORTED No OEM data is required in given sche= ma. > + @retval Others Some error happened. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_REDFISH_RESOURCE_ADDENDUM_OEM)( > + IN EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL *This, > + IN REDFISH_RESOURCE_SCHEMA_INFO *SchemaInfo, > + OUT EDKII_JSON_VALUE Json > + ); > + > +struct _EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL { > + UINT64 Revision; > + EDKII_REDFISH_RESOURCE_ADDENDUM_OEM OemCallback; > + EDKII_REDFISH_RESOURCE_ADDENDUM_PROVISIONING > ProvisioningCallback; > +}; > + > +extern EFI_GUID gEdkIIRedfishResourceAddendumProtocolGuid; > + > +#endif > diff --git a/RedfishClientPkg/RedfishClientPkg.dec > b/RedfishClientPkg/RedfishClientPkg.dec > index d3c97ecf68..9d88680415 100644 > --- a/RedfishClientPkg/RedfishClientPkg.dec > +++ b/RedfishClientPkg/RedfishClientPkg.dec > @@ -43,6 +43,8 @@ > gEdkIIRedfishConfigLangMapProtocolGuid =3D { 0x1d9ba9fe, 0x5d5a, 0x= 4b66, > {0x83, 0x5b, 0xe2, 0x5d, 0x13, 0x93, 0x4a, 0x9c } } > ## Include/Protocol/EdkIIRedfishInterchangeData.h > gEdkIIRedfishFeatureInterchangeDataProtocolGuid =3D { 0x4B8FF71C, 0x4A= 7B, > 0x9478, { 0xB7, 0x81, 0x35, 0x9B, 0x0A, 0xF2, 0x00, 0x91 } } > + ## Include/Protocol/EdkIIRedfishResourceAddendumProtocol.h > + gEdkIIRedfishResourceAddendumProtocolGuid =3D { 0xda36b12b, 0xaad4, > + 0x4e90, { 0xba, 0xcb, 0xe3, 0xb5, 0x3b, 0x08, 0xbc, 0x54 } } >=20 > [Guids] > ## Include/Guid/RedfishClientPkgTokenSpace.h > -- > 2.38.1.windows.1