From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.16753.1683248168697617132 for ; Thu, 04 May 2023 17:56:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=vMN1K5Fd; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjAWLrVzjKAR1hBe+p/5PzcfaUVx4uUHUgQ9ygA3zgIzIsH7PTixO7F/BR4At3YiHs5H9BKzZ5f+8Z6EdL3euVuNOvzpr3i/ucvqL3xLOtMfk04XtAv5JVk0fLSsUSd7/MvhQ/E2GinqTDdnrhOPn4V0EnUCEidf1h9mL7157YCJ5YmYTUZXmKuto9hSj5xh9oWB7uUEbs2sWcAdOkkXdcIOkh2pCw25Bi5KxBvTNcGICqOz3ux9ksrsDKlBNm2y71H+LmLGubihD2U5m/k9lNixq5WeyiZu5q/QCx+D+8PKs8I9CJpfIk8INMQPIBHaKyTm5vMXJFeLD2AAhZYsLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ky5vqzc0Z1QfYnWWnENhdLGbdNSnL/bmvbdH7LsseN4=; b=R5yT8FPTitvsX3aS15r+eULWiw5lU8lbFhX75VtcV6yaSuoNtxAIhMWQcRDPNLyCUSdbRgWSlQfbO3/a8f0cZ+Li4lcNdohcXz/B1O4Zoza7tIhPdRrTSegYZ/s6JShPGchnNtaKXw238kF9ZmxjVd2nFuhdPu8py4HyApQDR6qe2Syt+gh9cdbXcJtaOTMnFY3oRmTuoB6HYT1w8KI06DT+QT64iXoo8QdHmx0CHeLwm4G3/Oy6ui5KKVNgX7OkiG9DroeaZZRVSeYiSnS7NFxo55DWGPNn1cVq7rHRTicsiSAY6PU0M6pFeuUn2olFrmnDU1qpvA+5L2Fs+PBb1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ky5vqzc0Z1QfYnWWnENhdLGbdNSnL/bmvbdH7LsseN4=; b=vMN1K5FdanmvJZ39KmXMyH29OXtfBGd0BzBjksljwWMW2MqrkAcBU6MIEwtzJ3uJUwR4RJyrUjCghoFp5nFDWVFfe3HPc8ecAsYfUoW/eNb7rXdqaCmkrvIed6idpgzaPFuHbb1DSpThf9vBhjvOGlFueZ0riTopauT0e1OuT3E= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5128.namprd12.prod.outlook.com (2603:10b6:208:316::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 00:56:06 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 00:56:06 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Thread-Topic: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Thread-Index: AQHZfpPctLMPfs1F3ku05rG8mMpYi69K25Cg Date: Fri, 5 May 2023 00:56:06 +0000 Message-ID: References: <20230504142219.16327-1-nicklew@nvidia.com> In-Reply-To: <20230504142219.16327-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-05T00:56:05Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=daf8fa6c-7f2a-4cd1-b024-93ef1451353e; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5128:EE_ x-ms-office365-filtering-correlation-id: 9ba9d4bf-5d8d-4b9a-7c81-08db4d038222 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sD0DJQ3jmKWhfAmqljjsyp6tJabsC5d63jnuncSoqtlUe1kmZ2rNmHhpbX1fQ8rNZl5T2J9Osrt2XLkCaYM1fyhI1w4h0EQ0/HGB5MjMEWi0sZTlH3NrCWuSOJOtdcGBlG/g40cvFDsbmcGAAXuGaHGXQT45079jM7YppHDXDUHNpExOab0ROaC7YzfOKrGingkUzWyK+FDo1vZvXC7fVumBhfhzT7prrp4ZNWibF1L722m+T9aOw2LXY2lOReSuP5zCQHThStX0vLDTsVOlPyWkpLOg7PZZAfb3WS4aV8Al8yF89HT+Mt1K9je/NvEgTPGRmN7cyvbPbe2pUi6AwlZuf9iIgVLRpP0YBVCxHStczkgJV2CjsfXRy23WbJfzxLP6HKq2lYc79UuALbdceUsNwHKRHQs15vZQI/4Wjc30RCZ2V+QH6+ba/FlDWBsYmlOb2mfBfufpHtYTywyJge9rN2SqKp+/nDBlOpA5wK9cZZWO5FMgm4UthE0KCSMgnltWIxwhLWJBtgNAqPhU2HUvqIKYM4OkcG7IarAW9NaU/Xd1ctbNT7FSoka0z9nOn2IzgqyhlzDYu3S3tUw3GL0m0XWFrXoJZbNkThR61tofC6ba5354f/PyPyYVeXrc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(451199021)(66946007)(66556008)(64756008)(4326008)(38070700005)(83380400001)(66476007)(66446008)(186003)(76116006)(41300700001)(5660300002)(2906002)(110136005)(86362001)(316002)(122000001)(53546011)(8676002)(8936002)(33656002)(38100700002)(9686003)(26005)(6506007)(7696005)(71200400001)(52536014)(55016003)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+pyfWvh/hnZyxQbEljfxrkYMIw7YTH8evZT0eOO0QwgyJ+A3ivCwCTux6ZEj?= =?us-ascii?Q?4VGNK0kjjXPh4PgSKFUOhv38bBh9/x83EiUs3uibpaj8ggXVTyKpeiTfc8CE?= =?us-ascii?Q?X/e55eox2wuSt4ppU8YAZTOu8yS9w/LiMkoWT4CfBmMGRKJV9Rbo+p+bTC4F?= =?us-ascii?Q?C78p/p30p0SFYVKGmlyoRosUFCsb6VvBsB9u6R9I44K5BccEWBA1mMwMLM2a?= =?us-ascii?Q?4zHxsoe153AHePsQHIh2DV7q/hbMhiD7NQEFlH9zsR4SFvsoXknn5ElLQrz7?= =?us-ascii?Q?QV7VVK/B0Mzk87cG8ZpxM0X+2FgUC6sXPYj0obnE9aWtIsGrhjko21BoLDtU?= =?us-ascii?Q?oqvffgk2q2vL+K4VmQAeBXR2J/CqAO+YrtIdgsXw9ZFP9F5ApaieRuFwg9Fg?= =?us-ascii?Q?HPYB0oYwR5oupmv++R0CcuDgfMstHA7pMuwYXd7OPRknZ93HDZv7ZSsh6ZGm?= =?us-ascii?Q?sOqHFBpbHItgzDxmqdWFKu7zzh6B53rsyUKcXNljCMEpDYwIOYwW4o6bzz8C?= =?us-ascii?Q?urHyGujpDs6BPSQ9/E4NvWVlx1xK4ASyzRVVLV2HFtCi1vAX9EHPqK0cjTXk?= =?us-ascii?Q?cLUASvDhW47Jd+ZMTXTuPqxDGkgXqAngGN1EpXtc7Z7WAd5MIL0jzvNEosUI?= =?us-ascii?Q?AgEeFpIdsfxhsulGqenb6zYJfbvK+OhF/Wsro+QaeR1P41xbY4f9ZJA7XfdV?= =?us-ascii?Q?yCsTfhK9Gwgrm+/zytb34OqqutO65+/bXtkNVgzgtG80PCfLSUwNyiVNN64T?= =?us-ascii?Q?B2EMtG+JVsqgfrd7QHOETXm91Nj/PnBvWC9UkNfrYTPNhvECrIy4MFDkihzL?= =?us-ascii?Q?MVD4YUFauwd7l0O8QRer6ISoyfrwS37iIAzHOlJkv69TyblI+GdxOdW+3PFW?= =?us-ascii?Q?lrocp7QD40R81asIBU6Q0ZaREZ5xkVkwtVEsj9Yk044EDCCDuNBXvJI+byLN?= =?us-ascii?Q?nLU9HvCD0Z3YF37q2Yh2mYM2x/Uzvi6uXFyGUROPhhr7wlqd2z29xYsXNewt?= =?us-ascii?Q?gtD/tbJ8VfOX/wYVkrMR0BpCBSFRtHpKsXpFdpHayJFT42d9E9S6bTZ3bYr9?= =?us-ascii?Q?EkQ201kAZYuMEPQ+QDjXHk9vRorzV9LEzUXOxfxvU5g4AWcA0JGUeRX24GZo?= =?us-ascii?Q?b4dMkkSsDRp8YDQckhye7gf6hiWn9CC2mvuJYvYCisAGT0TDcdBzxZga68kR?= =?us-ascii?Q?6qxDExaICOrB3g/AUEARZtzdNJF+ziIIkURLmju7OK7gkv9zhMm6Byd5VkbX?= =?us-ascii?Q?Qb3jOXmlH95yQHJSJEXAhDU+aDuwfhYB3yzioguSequKVV3P6IrKA04qteBN?= =?us-ascii?Q?BPgahnoEMED/YjX1WVuvLTXB1yo11tqHGXDRxLjRLvVpuOeE84+ZGPDa5rVv?= =?us-ascii?Q?x/4cxyquWCWM8Sp/g3aOKyzu8sBXCgavET8W4mh3AozWi5srjGGp2zZlZHEd?= =?us-ascii?Q?qqumBx421Bz2+WSecXglMviM2zIavZGairNkBjVzCkKbr353YZnfKVFniF3l?= =?us-ascii?Q?n4Vq5q+YsnJ0Up4cBwV6gfkl4SDmTmp8a1ipswW+hTzwWMzbxCfsrBEp9Tw6?= =?us-ascii?Q?za09LeqFTVMJSbksqzmfDlTkN3K6GpMj90mWulnm?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba9d4bf-5d8d-4b9a-7c81-08db4d038222 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 00:56:06.6200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +ZB7ZR7AXHV5cjk80gp5WVCyvzr20+drHn7hyMyrZ0xSg17oFfEqEosKqZdVO9/RttzNERiPi3zpPdFweD46iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5128 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, May 4, 2023 10:22 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on > RedfishFeatureCoreDxe >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Action in StartupContext is not set properly. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git > a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > index 5cd89872..3776d52b 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > @@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint ( > EventGuid =3D (EFI_GUID *)PcdGetPtr > (PcdEdkIIRedfishFeatureDriverStartupEventGuid); >=20 > ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof > (REDFISH_FEATURE_STARTUP_CONTEXT)); > - mFeatureDriverStartupContext.This =3D &mRedfishFeatureProtocol; > + mFeatureDriverStartupContext.This =3D &mRedfishFeatureProtocol; > + mFeatureDriverStartupContext.Action =3D CallbackActionStartOperation; >=20 > Status =3D gBS->CreateEventEx ( > EVT_NOTIFY_SIGNAL, > -- > 2.17.1