From: "Chang, Abner" <abner.chang@amd.com>
To: Nickle Wang <nicklew@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors
Date: Wed, 7 Jun 2023 01:39:52 +0000 [thread overview]
Message-ID: <MN2PR12MB396630CFCF18E7A4A15B7452EA53A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230606123219.17063-1-nicklew@nvidia.com>
[AMD Official Use Only - General]
To the entire series: Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, June 6, 2023 8:32 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> V2:
> Instead of modifying ConverterLib, use build option in INF file to
> fix build error
>
> V1:
> Fix RedfishClientPkg build errors and typos. The compiler toolchain
> is GCC5.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
>
> Nickle Wang (9):
> RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error
> RedfishClientPkg/RedfishAddendumLib: Fix build error
> RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error
> RedfishClientPkg/RedfishFeatureUtilityLib: Fix build error
> RedfishClientPkg/RedfishETagDxe: Fix build error
> RedfishClientPkg/RedfishConfigLangMapDxe: Fix build error
> RedfishClientPkg/BiosDxe: Fix build error
> RedfishClientPkg/MemoryDxe: Fix build error
> RedfishClientPkg/ComputerSystemDxe: Fix build error
>
> .../edk2library/Bios/v1_0_9/Lib.inf | 4 +-
> .../edk2library/ComputerSystem/v1_5_0/Lib.inf | 4 +-
> .../ComputerSystemCollection/Lib.inf | 4 +-
> .../edk2library/Memory/v1_7_1/Lib.inf | 4 +-
> .../edk2library/MemoryCollection/Lib.inf | 4 +-
> .../Protocol/EdkIIRedfishETagProtocol.h | 2 +-
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 20 ++++----
> .../v1_5_0/Dxe/ComputerSystemDxe.c | 19 ++++---
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 19 ++++---
> .../EdkIIRedfishResourceConfigLib.c | 4 +-
> .../RedfishAddendumLib/RedfishAddendumLib.c | 4 +-
> .../RedfishFeatureUtilityLib.c | 50 +++++++++----------
> .../RedfishConfigLangMapDxe.c | 3 ++
> .../RedfishETagDxe/RedfishETagDxe.c | 13 +++--
> 14 files changed, 84 insertions(+), 70 deletions(-)
>
> --
> 2.17.1
prev parent reply other threads:[~2023-06-07 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 12:32 [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors Nickle Wang
2023-06-07 1:39 ` Chang, Abner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396630CFCF18E7A4A15B7452EA53A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox