public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Nickle Wang <nicklew@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Add Redfish memory edk2 modules to build
Date: Sun, 7 May 2023 13:44:05 +0000	[thread overview]
Message-ID: <MN2PR12MB39663122C39B7B3F532CACFAEA709@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230507133829.7641-1-nicklew@nvidia.com>

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Sunday, May 7, 2023 9:38 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Add Redfish
> memory edk2 modules to build
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> We plan to modify the build tool to pull in the corresponding Redfish
> resource converters and feature drivers into build according to the "x-uefi-
> redfish" language that applied on HII options in VFR files.
> 
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  RedfishClientPkg/RedfishClientComponents.dsc.inc | 8 +++++---
>  RedfishClientPkg/RedfishClientLibs.dsc.inc       | 3 +++
>  RedfishClientPkg/RedfishClient.fdf.inc           | 3 +++
>  3 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc
> b/RedfishClientPkg/RedfishClientComponents.dsc.inc
> index 70a61076..128bb8b9 100644
> --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc
> +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc
> @@ -15,11 +15,13 @@
>  !if $(REDFISH_CLIENT) == TRUE
>    RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.inf
>    RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf
> +  RedfishClientPkg/Features/Memory/V1_7_1/Dxe/RedfishMemoryDxe.inf
> +
> +
> RedfishClientPkg/Features/RedfishMemoryCollectionDxe/RedfishMemoryC
> oll
> + ectionDxe.inf
>  !endif
> 
>  !if $(REDFISH_CLIENT_ALL_AUTOGENED) == TRUE
>    !include RedfishClientPkg/RedfishJsonStructureDxe.dsc.inc
> +!else
> +
> RedfishClientPkg/Converter/Memory/v1_7_1/RedfishMemory_V1_7_1_Dx
> e.inf
> +
> +RedfishClientPkg/Converter/MemoryCollection/RedfishMemoryCollection
> _Dxe
> +.inf
>  !endif
> -
> -  RedfishClientPkg/Features/Memory/V1_7_1/Dxe/RedfishMemoryDxe.inf
> -
> RedfishClientPkg/Features/RedfishMemoryCollectionDxe/RedfishMemoryC
> ollectionDxe.inf
> diff --git a/RedfishClientPkg/RedfishClientLibs.dsc.inc
> b/RedfishClientPkg/RedfishClientLibs.dsc.inc
> index a23b9478..5456b72a 100644
> --- a/RedfishClientPkg/RedfishClientLibs.dsc.inc
> +++ b/RedfishClientPkg/RedfishClientLibs.dsc.inc
> @@ -12,6 +12,9 @@
>  ##
>  !if $(REDFISH_CLIENT_ALL_AUTOGENED) == TRUE
>   !include RedfishClientPkg/RedfishJsonStructureLib.dsc.inc
> +!else
> +
> +MemoryV1_7_1Lib|RedfishClientPkg/ConverterLib/edk2library/Memory/v
> 1_7_1
> +/Lib.inf
> +
> +MemoryCollectionLib|RedfishClientPkg/ConverterLib/edk2library/Memory
> Col
> +lection/Lib.inf
>  !endif
> 
>    NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> diff --git a/RedfishClientPkg/RedfishClient.fdf.inc
> b/RedfishClientPkg/RedfishClient.fdf.inc
> index cc0da261..8853c93d 100644
> --- a/RedfishClientPkg/RedfishClient.fdf.inc
> +++ b/RedfishClientPkg/RedfishClient.fdf.inc
> @@ -15,4 +15,7 @@
>    INF RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf
>    INF
> RedfishClientPkg/Features/Memory/V1_7_1/Dxe/RedfishMemoryDxe.inf
>    INF
> RedfishClientPkg/Features/RedfishMemoryCollectionDxe/RedfishMemoryC
> ollectionDxe.inf
> +
> +  INF
> +
> RedfishClientPkg/Converter/Memory/v1_7_1/RedfishMemory_V1_7_1_Dx
> e.inf
> +  INF
> +
> RedfishClientPkg/Converter/MemoryCollection/RedfishMemoryCollection_
> Dx
> + e.inf
>  !endif
> --
> 2.17.1

      reply	other threads:[~2023-05-07 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 13:38 [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Add Redfish memory edk2 modules to build Nickle Wang
2023-05-07 13:44 ` Chang, Abner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39663122C39B7B3F532CACFAEA709@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox