From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.42]) by mx.groups.io with SMTP id smtpd.web12.396.1664497260869983313 for ; Thu, 29 Sep 2022 17:21:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=e+q+Wd4K; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.42, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZALDgomFRwuBlwVxJl5ojVFtqcbLISJBUx4LZzyWIcUsFPJwaW7Ncvh5AmD0I0VDSHhr/MsMMGIAed7Z5ksZHHTD+GDiUmKqszhoTlqyxuPZCu2KR3UUiCyiO2kMhUvTxAnUS8p7Bkn/oiQWoH5fHeWGQExRrhg0I5tG9+ODL8v298LFiWLdxjZj7lTPTHhBJNrwWZZ9YTuEZPqkHFnVzx0qPeoz/OH5tiW2p4NNpREYUKKlerrdkyCi5t1LM66CXyx3zm7Vz+ZotzvdhUYEYhd/073ZU0RmpohIWm7o0FTirzfrRMrnbNc+jTmtB1szu+sL6JI6kxbJapoRNyQ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3DqByqyyX1t/aezpivrjN1LuicC3fOv15JP8aX/LZ80=; b=YE/c+mzS88zNiB0TJlTghgX9vJpsKlxu/SVJBafH4FFZ4ZyZ03pocNDhInnZD1UFT6Pb4THCib+FQVXpv06igNBG3qX3eNfVL2RgNpUgLwNCeF0/e+P+JlsWy51Yzidgl55Y9lo4qx1iT1oQYOSA16yH/MhrsEAf5MBZOsSHWyT1ELjn+p4nvFemNeDLVIbvZmft1zrOlCZ0VHQX3Ug1Ho7I7+X3xZ2SHpeNhSC7k/zcaLMlNKu5hKeBtBXqs/iIB1A5jpzo1CPzpF9VGsiBkC2lJZIPgXenjvlEHpnEz03jHuCcJZG7+C2S0IMICt/XWWuG3MhOTPEQqQ0Nf6BqPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3DqByqyyX1t/aezpivrjN1LuicC3fOv15JP8aX/LZ80=; b=e+q+Wd4KdvBkl1mxZ00s0lUpStHmtbCiVCHiYXX88qNPfVdf2SMM6dXsKgu0JMZCq7wzmcISPKJ59IB3KBLhQDMzAwPD7fMvZNGADw0kSv2tF1vHUzZNg3/zsOvXrM2XxYEp77EuQppx487lCOO4qbruQYSW+1HaaOM3Jk/FtFw= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BY5PR12MB4065.namprd12.prod.outlook.com (2603:10b6:a03:202::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Fri, 30 Sep 2022 00:20:58 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::998b:f1a2:b183:43be]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::998b:f1a2:b183:43be%4]) with mapi id 15.20.5676.020; Fri, 30 Sep 2022 00:20:57 +0000 From: "Chang, Abner" To: Sunil V L CC: "devel@edk2.groups.io" , "ray.ni@intel.com" , "Kinney, Michael D" , lichao , "Kirkendall, Garrett" , "Grimes, Paul" , "He, Jiangang" , "Attar, AbdulLateef (Abdul Lateef)" , Leif Lindholm , Andrew Fish Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Topic: [edk2-devel] The principles of EDK2 module reconstruction for archs Thread-Index: AdjPX4ZZG0rDXS4WTdOIWvoiYOLYcgC9rttQAC2dmIAAMr8a8AAOxMIAAAEcwQAAEfXdEA== Date: Fri, 30 Sep 2022 00:20:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-30T00:20:55Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e8c40ae1-a2a2-4827-a4ed-d03839c8a8a5; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BY5PR12MB4065:EE_ x-ms-office365-filtering-correlation-id: 61fa5c4d-eab0-4e34-949d-08daa279a530 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AGH6U302qOy4p4/eOVBfbz+685aHX/cU/7UT2Im4MfKrDpfTiL8ED8SiYBsGq/cz9aU7jkpTzLlrZkJCOILa/m5dDGCxw6In7PCT2fbg4L2Uy+PdjYxHVqX8TCTP4ZWsy4OS8A0QpByvpOtcjBWpJyRat0mJAbU+yhzSYjdpS94roynqG56E8LN7eislYCnhdrYUYq+heqBCdsxxi/4zjstyIEYSGKqY2UANEoQGdfYcovWpUriNcrTRa/5UQvaafzIiybmnrnIhqkc5VTrsJtptSpQAhxV2bvGBU1+1Yi0v31LROoxw8IHDWIADZkW+WWpiDo9HLI/Alx0kYvhDbIfxUHsfARPPaDoQI6y8T//rKzzFAx1Y01IxykQ4hs4jKURfVbOF+H5KQDinTbwMh71kqm3RAlBlO0oovhqwP8SKpTi0a4/EKHrlgEP5gh5IJkRCZCdxqulpNSiYee89isI+mZtlDfMUbcg3Qpa3SeH1VfRupA0bOK2l+pVdwwBXrp/4anZ3kP9mAtTdVkDGrFgR2V2wg2pKsKD30b7uTs9FIZPtAAjasxK0tDEy3JB3OXvgv24znbPn9m/10yF79E+jsiG/B+ynwT906lUV5HPBQpKecievz0tnx64HNgJpEC/o1u7YcFMyT1SOA/Hrz6IYg7GGLVExeXKSLEUBzqildIVhg/zP7HK+m4CllefYg2JdaPjyLslWRiHs9xZv54ntkkXCikwUOV6ZjJiPCRJsyYBqLX4mVQfYU5mp67NFp95Dl7P2vP+VbJySWZzu8eQwZ+AVrj6/67wozbCTuRY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199015)(83380400001)(186003)(38100700002)(122000001)(86362001)(38070700005)(8936002)(52536014)(66446008)(5660300002)(66476007)(66556008)(66946007)(76116006)(64756008)(4326008)(41300700001)(2906002)(478600001)(966005)(7696005)(53546011)(6506007)(26005)(9686003)(316002)(6916009)(54906003)(8676002)(55016003)(33656002)(71200400001)(45080400002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lT1E0a+uBaL1Aw+/qDQJFyij2WcKWHhNFip9HhTIb2/bAh3AZWzNnSKfPm6A?= =?us-ascii?Q?yqlyxeQ2tBRcnVicR2WGT9+/4O2iCwjODeecNDUZruhOlTD0Qu2xu2Wn2T2/?= =?us-ascii?Q?HuKSJI10WVzyp4dLo/6JkUTyV/fbVlxNwsO1W1Jz9H94YXKmq7cvtRf/tGPa?= =?us-ascii?Q?KdLgOZ9qBnFeiKhyki4/SdCuUosmCgNmR10FQ0N1iM+Y4G7nYKh9DxSRZYLf?= =?us-ascii?Q?vGAYLHvGwKSu8wVpcWl8k7qqVtgXU/M5rF5LjgCaNydKTA6nmujzvy0BnCu8?= =?us-ascii?Q?pU+RxUZfjrksMwNb6LP7XOU/pPzPhi2xGGRJP60o97WicIMnvTrteEBRYIai?= =?us-ascii?Q?dDa+gG63p75O3NWq3KMUQDpnUfZITZ1AeeIk+3JD4oHpkgZPpmcAxnRartkV?= =?us-ascii?Q?UIpDNPWlq/LlFeQp7zJB3aANHhp4RzmlR/LUDe1Q6heivgjfjuz/iuCmkv13?= =?us-ascii?Q?8yc7HxVcOBwhADQnP78aHahryR8N2pOWxGaei5o143Q9B+Bz3VGWjKqBRVsX?= =?us-ascii?Q?OR0grbzq7yDWv7+PsCShwDxrUVfwJ47isZ2orY4xm4MNRrvPaXSdl1XoSMJl?= =?us-ascii?Q?wX6TD55K8uGoxUbbGwpP/MJKR8QEu0+kNYKGNTsWwSlN28Bal3GUxqgJSt+J?= =?us-ascii?Q?O9X8DB56k2hdc4qVH9rjLdRMjhmZFFdsxL6dmqurjI6V07XWtHUeAmSlHe6n?= =?us-ascii?Q?N4MpQq9rwhcoiUiqacgecZZ8yNj2Wz/JZr3Z8BH5JGuwqMqZqtqaRdKKZZjh?= =?us-ascii?Q?4aPo/jXXQyFCiiF0PN4b2t1CACc7Ww79sH521PrGxODfZAZfTBHuvm55G0D+?= =?us-ascii?Q?9ci4GyrvxlrdQKeK0/7nMK/xzpJu+r+GrwcRPRt+HXcT2YY11KjS+04G8oFf?= =?us-ascii?Q?8URKEwCXEnKZF8iqwRqxzNlKHyfOMC20xqeTE7CzH2jxhUJElZ6+k9z0otn8?= =?us-ascii?Q?oHpMCGqLzeIHH7ouP5OMZLUeBXu3lQSDAaJG0LgCNxTYMvzgZK+9OxWmnHH7?= =?us-ascii?Q?SHWy/gvg7SPLIBcGC5kbJ72RdvecyxXs699vw+ngL0/n5LT5XchgkTVueUDD?= =?us-ascii?Q?FB4HWzN1JVZ32fwMkOw/LQW8720Xjo3XsUv7Hy+ovLD5pfC42rVMkZWfNjdm?= =?us-ascii?Q?VSsMERHuj6BSSpmxp2SRBwO/WTUbSs5Cr6wAaoi3kA1p88buDgrtKKJWwI3h?= =?us-ascii?Q?eQLgC5pUrFQBMMEuhPlXdHYeOWuNF2O8VP8GV20uVQYtRRtM1lMyg4bAZeZ6?= =?us-ascii?Q?LzQLtlod2wrXgYQmA0ZG5/p8IigViP61eZiQXvOz24kuy+/fDTs63Mgmvqxz?= =?us-ascii?Q?/yUjoTAxrDwIxawnF0KGWTFOGidjkIDAVR4zflvWgOyUsy7jlP5/7w8ESupA?= =?us-ascii?Q?dGmhxxhyoKKSYEr8HVDNnZaZhT0CT8sZYePSfhXJQhnQzPf5Hj3rsHcH96VL?= =?us-ascii?Q?D/laKIPwDto8mqlwV1mkWeyCA0NZoQZ8r3/Gs65tvIfGpawgkBu8Qrjr64Z+?= =?us-ascii?Q?6TCQMAdj0SVhNJIXx/XBR8uuQSHDOphkE+RBflvLv3TqQ6IMw1dkpL1YEPwc?= =?us-ascii?Q?m8Tb7MWFidVKQYyD4Ng=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61fa5c4d-eab0-4e34-949d-08daa279a530 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 00:20:57.2357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qqp0qdgvSyJJWg+xtcuYh+TqhYYtvlSAavlvH5kcSwQR3wVV93kZBxrNbVbVj0SYiHyRqeyVoQAhIwTvkHgj7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4065 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] > -----Original Message----- > From: Sunil V L > Sent: Thursday, September 29, 2022 11:22 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; ray.ni@intel.com; Kinney, Michael D > ; lichao ; Kirkendall, > Garrett ; Grimes, Paul > ; He, Jiangang ; Attar, > AbdulLateef (Abdul Lateef) ; Leif Lindholm > ; Andrew Fish > Subject: Re: [edk2-devel] The principles of EDK2 module reconstruction fo= r > archs >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > On Thu, Sep 29, 2022 at 02:54:05PM +0000, Chang, Abner wrote: > > [AMD Official Use Only - General] > > > > Hi Sunil, > > One more thing other than the module reconstruction for archs before yo= u > sending patch to edk2: > > Not sure how would you do on migrating the RISC-V code from edk2- > platforms to edk2. Did you make some other changes to the RISC-V CpuDxe > on edk2-platform? > > Please keep the files history and send the patch for the migration firs= t. > Then have the follow up patches for your changes if any and also add the > Ventana license. > > > > Below branches could be the reference for this migration, > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > > ub.com%2Fchangab%2Fedk2%2Fcommits%2FRISC-V-MIGRATION-EDK2- > PR&data=3D > > > 05%7C01%7CAbner.Chang%40amd.com%7Cb644f4b61bbd4e096c2308daa22e > 6703%7C3 > > > dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638000617445410044%7C > Unknown > > > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJ > > > XVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DwRnI%2Br4Dunydf77gSClb > 6ghHuY24Qs > > LrZTiPqc7pP1I%3D&reserved=3D0 > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > > ub.com%2Fchangab%2Fedk2-platforms%2Fcommits%2FRISC-V- > MIGRATION-EDK2-PL > > > ATFORM&data=3D05%7C01%7CAbner.Chang%40amd.com%7Cb644f4b61b > bd4e096c23 > > > 08daa22e6703%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63800 > 0617445 > > > 410044%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiLCJ > > > BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D5T2PHJOj > %2Bk6Mmu > > zNn0vsELm0raYiIDiI1X%2FekgZt6ls%3D&reserved=3D0 > > > > Thanks Sunil. > > Abner > > > Thanks Abner. Let me take a look at your branch. >=20 > We have some changes and are not migrating everything from edk2- > platforms. But I am not sure whether we can maintain the commit history > when we migrate from a different repo. I think this should be like a new > review and all old RB tags which were for edk2-platforms need to be > removed. I was used tool to cherry pick from different repo to keep the history. Not= sure if git command line can do this or not. To treat it as a new file that includes HPE and Ventana copyrights is confu= sing because HPE didn't have the collaboration with Ventana on those source= files. I think you would have some files that are modified by Ventana rega= rding the functionality and some files without any change; the copyright sh= ould be applied to the contribution of functionality but not the migration = or build error fix for the migration. I am fine with having a new review pr= ocess, however, I would suggest below steps for the files from edk2-platfor= m if to keep history is difficult. 1. Migrate the code from edk2-platform and fix the build error on edk2. In = the source file keep HPE copyright only. Mention the origin of the file in = the commit message. Please do not add Ventana copyright to the source file = at this moment. 2. Afterward, add Ventana copyright for the further updates. This makes the= contribution clear. 3. Do not delete the one on edk2-platforms. I think we can mention the impl= ementation is obsoleted in the Readme.md under RISC-V PlatformPkg and Proce= ssorPkg. BTW, I can help on CpuDxe X86 migration. Thanks Abner >=20 > For ex: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fchangab%2Fedk2%2Fcommit%2Feca5ff6bea66be94fd58421ba98c > b54d1f4181a6&data=3D05%7C01%7CAbner.Chang%40amd.com%7Cb644f4 > b61bbd4e096c2308daa22e6703%7C3dd8961fe4884e608e11a82d994e183d%7C > 0%7C0%7C638000617445566273%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000 > %7C%7C%7C&sdata=3D2TRD8pySU%2FIhz7ttFwdCHtPpl6JM0YSp%2BZjvo5 > %2FEEZ4%3D&reserved=3D0 >=20 > IMO, RB tag should be removed and should be reviewed fresh when it is > being added to edk2 repo. >=20 > Thanks > Sunil