From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.60]) by mx.groups.io with SMTP id smtpd.web08.3791.1667830708778397446 for ; Mon, 07 Nov 2022 06:18:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=xusm8i+g; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.60, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afulBS6xjvuHiz15pLQ9uAjxFti+uzpl8JfQQfkv331Y1uDWZYzP4WyIBp80PEUv69ygvXifrisyUjDVkzwufnVuxvIRPvHceVmnb9L/5BJSqPZp0o+ACYimSdxYTKa1lxmIlJcqc1yLYe3QfcoeSZbR2nEK96CyXvbwJMtwvM0iG8oDE8fIMuQR5GUDUfGKgsq59vj+/hCxlseVyV9CYF4adId8jlO6/wWhfCGWOC8QcAOfco45aDtvCVa+Tq+6vdYnwFaAXG1YwmnBzIgy1AnGZy7qsHKTzinXGR4o4nkzHGjlBjHEQ21k1BuaFsJ2Xz2L1UUijgwXDGzTi7a/Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=evJwrSbBFdLbJQpIdr26wcHxYtZtpwRn/3dU939Vsdg=; b=HQyHMJFSK8pS99+ZYreAEKQIGya7Q4/tI5FfGrfNRcfBAwZprJeHrqShRVlIC/kUE0Bh2L7JkzhCJepVqhsBy6tqjz7UFdBpqBtRITIQ7jEaKsi6qtWmFLfqKYgQvskHWMZ9W+wQcpW1iV8iBtxvKkhGlDWGNTZJi5O3917mWoazeFr5sLDoyq71EQdvtyChtKNXG1NuE63BIZR5CtJz3IvueA8w3bQhItm83B0AhQfNVCvHCBaSyz8xAolwhijf9ThZFMD7YwHdh8OxSggeLDqdIBszoWW308Ze79Vim8KsTQuQKimsRET19XfDsJmYgxuD0HMQWlOK2WMc0Nj6GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=evJwrSbBFdLbJQpIdr26wcHxYtZtpwRn/3dU939Vsdg=; b=xusm8i+gxGinSUteIwhZIQn+XBlZ2z9fzwpgR39dpahkUvlVFzta70idQbZlY7PNPSRes8VEF+Qqgp6OquLs1oB5D9XtZoFnn8qKwtdqEh5qkt20eEwCjqgziGGJxQZLwqFe9lJqc7pFkKwnn3kVC8prw9xjy1p4Dc2LuY0EoYI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB6663.namprd12.prod.outlook.com (2603:10b6:8:bb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.24; Mon, 7 Nov 2022 14:18:25 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 14:18:23 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "sing.wee@microsoft.com" , Rebecca Cran , "lersek@redhat.com" , "heyi.guo@linaro.org" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Index: AQHY6iTO/YoJYNprhk6n4u7gZgA2Y64j7deAgADKZ8CADnIecA== Date: Mon, 7 Nov 2022 14:18:22 +0000 Message-ID: References: <20221027165416.1610-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-07T14:18:19Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=89531483-e331-4e39-b3d3-ac85f1a23c0a; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB6663:EE_ x-ms-office365-filtering-correlation-id: 3b2c3178-fd9c-43eb-5a63-08dac0caedb5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qm9PjfVM/iI9sX1HV9AfOhw1ty2KTDhxTNZsV17HPkCTfJt1iSNXA+oJcD0B+OgqLF1OnPCxPwMlyUsTXs5QRiRYPtrwb0GC1/X4KVmAIR7C9GF1InTojNBHe7eAQBQT7JguRAVbImedWuLfusY+UDgXLxMHp3yOI7SU4fY4krw9HdLS4W8fSsgNYHl5H8RK46Dvf/HLYUZwBtd45IcL2kBcYTFrgloV5R4aIVb276+qvF9tP9vurf4lfvqnZBA6nsNMIRnM1oSw+ry9XLrkOD1HyAIPNIOBB7buZEaA8PiRlmwoEn6mgI5PJmoy+olMx09u8eybsBe2JfR622RzKkjtqBD6/aot5/62kzgCoYKTLOdS+wSXK8MmFTXhNmch1DdtY0usUXN6UCiKMewwVTJf/r7koPgl+MhEEf9I/DE4A35vzKBbgtUXy0Bj0htSf8dcUucaoZkMSiOezwORnn/HnOvmu7posSpmidVn6Aapu9PaKzGuFyGnbZIVNhuqg4VJkl64DEfC6fNiJ+5TVnzcOBZ0yihKAd8YVxFAzPAwbK2xbB3a6v8LXnnMSSQ6lUxSl8MaeXJszRhpWWqVgdJnpmqT/ALiPQLd3qumphe5r9ygzlw/b3PX6KSb5VdDyelymrz8MiU0pnEO7p7b0GBI81oDExLC1GjfMitHO+ZeOYcWQUinDlRdYYaF2s578+dBvc02AwF07elmNSBwFuKVhfb3TsZa1IU+Zh2DVBB8rcsgLGay8cjl0VBYRJLDh3fCl8tQ0RtfLsAMSRGvge2GhDwcGqhqI1nwYEg/L4QPJJYlpAPF/C4o4Ep6FERePpZ+saq4qEFvahn6oGtQpg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(136003)(346002)(396003)(39860400002)(451199015)(66899015)(33656002)(38070700005)(86362001)(38100700002)(54906003)(966005)(122000001)(316002)(478600001)(55016003)(66446008)(53546011)(71200400001)(6506007)(26005)(9686003)(5660300002)(4326008)(66946007)(2906002)(110136005)(52536014)(8936002)(64756008)(45080400002)(76116006)(66556008)(186003)(83380400001)(66476007)(41300700001)(8676002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G8FxjNYoG86KbwttayQm5yWfLQL4NNp8LgBzU3+SoDEu7CikRzGy6WXIVXXC?= =?us-ascii?Q?2Nd5GDZlV6AkRvuf2HF3bG7H7XIlJR8BSjo6SQsYr9SnRSF+UrNwECbGEH7N?= =?us-ascii?Q?CWSp0EohBR+/YJKSRWZp2RKcqzprzAfaPfoJgSoFFRCyoizgI5hgcjeqgqcS?= =?us-ascii?Q?Cjp3z8IXkokJopBOOi7X563/vt8UzgsgZWQwlYslmd6CwuPjb+II6JMjUYYb?= =?us-ascii?Q?iUvQYRJT/rFyW0ovWKK6lRQ7jojjnBuiHWChsZSEC9pganOdgtiTxEoqokcZ?= =?us-ascii?Q?heHCuMavR3AofwaXkpEctgn9FCbNFOVZXKXXAxBNIzefuSyNgNrelL7ES/13?= =?us-ascii?Q?dVF4pVdkM9KCf0xCvQW7kUHEsszjFZQ4IT3giJI+Jv4JGK0rqWbQujsfj8Sq?= =?us-ascii?Q?Ehfb6lo4olAeSCoJqHe3VhDovMlyW6iZBjcjr997r5NOP8X0St7H8/JOenIN?= =?us-ascii?Q?4+E1I5q/pTISIeBANiriX0vpv4WLvOlGGrnrT/kXPxO0idFdgz95Y5/gJpml?= =?us-ascii?Q?J0Z44SgOa9nSBZ4aa+k6FqWmV9AbOB4DhJQ8UvLRUcly3OWvasKzZX6KmH67?= =?us-ascii?Q?fyJ5xX2kIJWYYj+FarFdlYsakQMjBDUmyeX7/gUDxG7ZfPrB7mFwCa02b0z7?= =?us-ascii?Q?gIjQrEEw1ZeS8XBitr4Jg7ghaNEGkvF+nSu8Pr6PVGLTSe2Ylp5nEUhN1c9v?= =?us-ascii?Q?lnDxxLMF41D8EYtcPWcrg7pTm/uAnQGR7JFSKThcFEN9BETKimy7l/gbecBh?= =?us-ascii?Q?YeKl3/LtJAnwnxD5fW3FBEAszr6P8BeIO7DfKdtVviEwDPLjbRN6VyPlAgfS?= =?us-ascii?Q?oQZ/KKV29DyRCGBrW2OBtsKiBijObUl0RjHdyOXEAtDgzb47Uvsrlb0HUG9A?= =?us-ascii?Q?yUCd2CkWj84Cv/Qa0rgukoDfxE/Ct86LUTcmVxwNFoIQJLScOE4HsxMwb6Bc?= =?us-ascii?Q?T0kB1II3cPkQb0wzeRc15b1oNZPKUiflahgiruXPaEH6/YomXc+FBZENNDCh?= =?us-ascii?Q?E8vLc95qnXypuDPcHJzWuKkCq2bi/EHoD+qbE3d+/7Q/agBNSwtLMm73lwAF?= =?us-ascii?Q?PTEPP5tikWscLF8oPdQSxir8CedBKofmuhcwhWNbofUi1q718fvky0zin1av?= =?us-ascii?Q?YBSaUMA2XsGYa5tHjPav7s9z3jEfcpckmVIGHEDePywWhgzVeTfhMTS5hIBN?= =?us-ascii?Q?vl0HBcHot6CGi5gJcCIbGfwE22TxHIN3u+EabXqRABXJgItTc/pZAT+yMlDh?= =?us-ascii?Q?Rm+IwdV8Aw0zkdbDEOGgcjsbpZc89qnuKBGiQob9fpcDfUDocJFuAKsmzeKy?= =?us-ascii?Q?6C4aeOy3TaC0NYcejQKXUjDH3B37U3Hggf49bi3VMjgZ6MkulGsLxhbEw420?= =?us-ascii?Q?gsbm8WRJoaQ1O7GzK/l0nNpIOq/Vu7a4hOcw3bdVW81v3Q5LBjW5YZ3Z6CsT?= =?us-ascii?Q?UsC6Y1LFw4hQe4wr70FK5cB17jvMr0p4dHG4/WowhnTKEhu8Kqdhbohh+loL?= =?us-ascii?Q?09AemVlcJaE64Zu8Y4+E/clRZ7DuHzQvGt28/Jtm2n0uwkCJ/12ahilVFvX0?= =?us-ascii?Q?sBSAB2y57hLrgn8qpFo=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b2c3178-fd9c-43eb-5a63-08dac0caedb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 14:18:23.0046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dw8dltT58A/ZeOOFClDuG88eMCkRI8nnr4wMVoJ1SbHOBEcrTslPkzwt08QFRgvZQce5LuzsMOuXJOCnzW5UdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6663 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Mike, You probably missed this email. I checked the below C coding standard spec = related BZ and had some comments in line below. > -----Original Message----- > From: Chang, Abner > Sent: Saturday, October 29, 2022 11:33 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > release/2.30 branch >=20 > [AMD Official Use Only - General] >=20 > Hi Mike, > Below are the tickets pulled out from BZ, is there any one you think is n= ot > necessary now? > Abner >=20 > 713 EDK2 Document michael.d.kinney@intel.com CONF --- > Update EDK II C Coding standard to state a stronger preference for 80 > column line widths 2021-07-27 Seems no conclusion from the discussion in BZ. > 1766 EDK2 Document michael.d.kinney@intel.com CONF --- > Remove use of STATIC macros from EDK II C Coding Standard > Specification 2020-12-09 No conclusion yet. > 1698 EDK2 Document michael.d.kinney@intel.com CONF --- > Spurious rule about comment style in CCS 6.2.3 2021-07-27 Had we addressed this issue on the coding standard spec yet? If not, we can= fix this in the version 2.3. > 714 EDK2 Document michael.d.kinney@intel.com CONF --- > Update EDK II C Coding Standards to allow multiple arguments per > line in a function call 2021-07-27 Have these patches been reviewed? [edk2] [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related = to line wrapping [edk2] [edk2-CCodingStandardsSpecification PATCH 1/2] Source Files / Genera= l Rules: limit line lengths to 80 columns [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacin= g / Multi-line func. calls: allow condensed arguments http://mid.mail-archive.com/20170811164851.9466-1-lersek@redhat.com http://mid.mail-archive.com/20170811164851.9466-2-lersek@redhat.com http://mid.mail-archive.com/20170811164851.9466-3-lersek@redhat.com=20 > 2664 EDK2 Document michael.d.kinney@intel.com CONF --- > Discrepancies/inconsistencies in coding standards, style and > examples 2021-10-02 I think we can fix the above inconsistent issues in the version 2.3 release= . Thanks Abner >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Friday, October 28, 2022 11:22 PM > > To: devel@edk2.groups.io; Chang, Abner ; > Kinney, > > Michael D > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > > release/2.30 branch > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Hi Abner, > > > > Have you reviewed the open BZs against the EDK II C Coding Standard. > > > > Are there any other issues that are considered important to fix before > > making a new official release? > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Chang, Abner via groups.io > > > Sent: Thursday, October 27, 2022 9:54 AM > > > To: devel@edk2.groups.io > > > Cc: Abner Chang > > > Subject: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > > > release/2.30 branch > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Abner Chang > > > --- > > > book.json | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/book.json b/book.json > > > index d112b26..1fdd570 100644 > > > --- a/book.json > > > +++ b/book.json > > > @@ -1,8 +1,7 @@ > > > { > > > > > > "variables" : { > > > > > > - "draft" : "yes", > > > > > > "title" : "EDK II C Coding Standards Specification", > > > > > > - "version" : "Revision 2.2" > > > > > > + "version" : "Revision 2.3" > > > > > > }, > > > > > > "plugins": ["puml-aleung"], > > > > > > "pluginsConfig": {} > > > > > > -- > > > 2.37.1.windows.1 > > > > > > > > > > > >=20 > > >