From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E1EE1940F29 for ; Mon, 30 Oct 2023 02:23:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l+fh0Ig+SGFDLm0VwVuIXDsjKtrp1YwQpGFAvrCO0/A=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698632626; v=1; b=AQXXbQRfZTS581F2Jflmu+RIgTv39uHnxNz6FE/x1JMRnTGVtUBtV/1kMnuxJch2bAjdmvqu 5xjqkJPIDEEOMuwF8xx2NL92vXfoKJprA9yNVqpXnDeyBFmw/ynKPpG8Bl4BczLfYXSH/Yo9rMW OTvDoRtiPqip23sBPZF8zAJU= X-Received: by 127.0.0.2 with SMTP id 9uCDYY7687511xPYFqcyceDA; Sun, 29 Oct 2023 19:23:46 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.59]) by mx.groups.io with SMTP id smtpd.web11.140973.1698632625563399171 for ; Sun, 29 Oct 2023 19:23:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZJyp6IEJyDtuVAYMhxx5zoCsUpbMrHydKEamvG9RBKTILCTflz7FEe4IOpcYlQ28pyl3gwbh0DWyHlyWsnvq1YAzU4nWHwwrW/FwnX3x9H//glrigScWDmv4kwHmjoVIrleSHs43lfugVwA1pOTPNGOMhofjT+osT8Vx/8uV9VrtBCMxUcM6Y0c7QF76QFX1vjoJOLcQT+B0am6LVo2uHY/GXsGTe+OsBcXQ70wpPvguBinpXDIVXU9pB2YelYBzt2rxUeaK1J4xCvYN8N7K37SwfzVRFW+gomPDIkTyqsEmkxF8TXKTch6QG0Ry2Nk8785IMXyetziJpdA8CiqGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JPO6OkXs29dhsDKOzw9t+5E0D1DkpsLTW49d0idkBHM=; b=ALfldrf3QeK5idw9y14cPEhJRsZXnkUvBLo27q2oR7XLLrjw70OwjD+dFACI5NTVpXJXOYbK21s/WO6SFDK3ioWw9UQtWg+M9+rK93m8tNyOo+uU+br4lQLP8PWUZS3811aLZNdJaQbpXcvzW+S1A5eLDnh/sGJsLcK8sGCyhGYpLj9sS3CgvIfnvklWYsaYhnQ0tM5AOIAANpb7DRy1mCfH3xiV45ndH6ZrsL7EN/K2IF6oagP1dA4SsyhinrDEE0SF80ylIhTYoPBMDPpCiKdSlTHl/l+b+dlkFF+n/ymDSkYRs2+gTb3tA2TTRzOQiTKFImKCSDcLtUKmIWHohw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN0PR12MB6001.namprd12.prod.outlook.com (2603:10b6:208:37d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.24; Mon, 30 Oct 2023 02:23:42 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.027; Mon, 30 Oct 2023 02:23:41 +0000 From: "Chang, Abner via groups.io" To: Lixia Huang , "devel@edk2.groups.io" CC: Nate DeSimone Subject: Re: [edk2-devel] [PATCH v2 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [PATCH v2 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaCs8pAPIS4XZYckq/xB6Amqq3lrBhlLoA Date: Mon, 30 Oct 2023 02:23:41 +0000 Message-ID: References: <20231030011937.1102-1-lisa.huang@intel.com> In-Reply-To: <20231030011937.1102-1-lisa.huang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=bfce5c16-9ab6-43bc-8ef7-8aec2a5b1ed2;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-30T02:02:44Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN0PR12MB6001:EE_ x-ms-office365-filtering-correlation-id: 3bc9af8c-50eb-4de5-a241-08dbd8ef3bb1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: tiQrBfjBt2hDNZvPrATz7Wz1PQw/6qqTiHpLdmgUqQXErQXXUDMe+C4U20mlX98wwPla+MZ2fAA++hIIxWQ7Likgq23u9An0bFsyR7bf+1RoScc6ugzy76V1r/Fmv7zkgoL4gdtep4zB5tmUElatOc58xDUbXNZ6yFu5rGIougGajSCzTowU3dDNjWz/nL2/n6DDv4fFJfAKGOBtGwfpOL9NKY3DQSo9uQHQR+HbWchh+5jtnXhaHlCcZgsLpUJjGVxwDo+w1eg+2uVUNcUuVdegLx6obMu8fH27HGpuemQQIBMs8ku+FOnIFri6IrYzg0IVf66Q/P2GL0HbyQbhaO2guAxqvSu8GYuEprngxAS06lb1F2GnicAqokeV5JOi8b2lcHyHtOo6qyTGt4AqfxIioNv1Owlit3+pwUHFO/dGpCf9ZZWGSoXOVg1sgPoWeTK4epPklD3JEy6oI4+PGrPjS1VOwURExCgCcv3e/TSRPs9ul0ZizNsRqlVwGAzstoFFpFNuqiXtsvjqMvUAqet75Hpd+ACpumUSDI37VhMVM34xTq+zkx7azbzvi5enzV2LForA2DLxBu+S1icQJhfnmFEXSzdHs18mkzG1ZDefEa5btVxlgd/WXx4tisFseN18TJ0RaQuZlLioIeOw+g2bzYIVMBksgzoa0Jajw6Y= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BmSbA+E8selMBUbzdI5+uJN8s4iw//EMQPz1tR8+sH5rseYa2yEviQOcu0kp?= =?us-ascii?Q?C9+7HHDZbg1ArsGGgjTGq2i4fRIk2cGWvl9Fkayq5O/bedHXJHYPfNivrK6L?= =?us-ascii?Q?tf75vHpFGQBcbyQrcoGfR+CqbGtAgfT9QvqDMHnjDz6OYNzsr0QC7pZ4z6Ek?= =?us-ascii?Q?jFOvzsgCenrqZTDYsoermGIpLg5lsav9qBPrEtrwd7tZolTiLhbgmKr9Y0YW?= =?us-ascii?Q?Kt0wUON0yuMeJQfCe2m/9hv8jwemShYsKGfeQOfxrqG/YROgeTe3OfYuEOtx?= =?us-ascii?Q?gAALKLm40UWS/07+AythFySR6lKvgP+83t5eHegsGHq+/c4i7TeQIhZR3Urf?= =?us-ascii?Q?aIqjoPPmsHq1u0922FK0l2K1gaLWE6m3Gulr1DfAbqV45StJjQcDDptj1T5u?= =?us-ascii?Q?Sk3D1oOlIGfvTi/z7Rr5mdW3TdRDFcHonQ437VVxhf7SvcmHs7x0ygpgBl05?= =?us-ascii?Q?yMOAtolsnp5MxyLL2X/cocXVTTY66dv3AgAvzrxF19D1wsSPdLPvHBHbszTm?= =?us-ascii?Q?9KLyybwIz3iSrw8rfjcNs+idSmfA5bKLFQHnlleLtUt/lpIkFrkwiw48EocX?= =?us-ascii?Q?H99lRN9Pi4Qi8di+m5XpMqT0uffm+22ovX3ltvlEC55ZEgGZro4607OGXODc?= =?us-ascii?Q?0xaDcLjaqp1BDrbb66l/kW3LNUp1gkhuYp2vMrX3qrR6sBz/dza/xH+aOiZM?= =?us-ascii?Q?C6WtaUD/duAmIotOG0GvHbsBGDdyE5ZQKSa+/4+RZT0Ev0tNjNk3VLoLbRzI?= =?us-ascii?Q?aAETFhT80jbJGzjsNDaXYkIt6zRIHRMwDILtfMV36Xm5OB8P+kJcRavE0bso?= =?us-ascii?Q?LlM39NDJdbcSJyzFChBD8yg63xEO0D1LmWYFu2P9lylV/fCh7OpjSrSRUPDO?= =?us-ascii?Q?8D2M52MRVBhtw4gEs5FxuZM838NCZuuq7IYYMUILtyidsH4bA5mej2RNnWXX?= =?us-ascii?Q?bVcdw9BW7QpaarN1GvRrntv8NyMYFoh8N0gKy6zG4ZSI1mJy5of2YawHT2uB?= =?us-ascii?Q?ynAxhK2nR2oqHGZUSiFbg61DCoIqVxOoy9r6ECYW3ZAv/w/GKNVaSAWlv8KK?= =?us-ascii?Q?XRFJvkBDRu8oUe7rneTdXBRR0RS5IKFVreeqBgXfSR2Y6FYr2St3rfkVHkmP?= =?us-ascii?Q?w6RQUWShOOmo4KmAvg09cwAYNlVGUNuTgONtaUQ2KKPjlcT+EOp5wwaYqw2D?= =?us-ascii?Q?QoBLImF9V9SOzod+QTOdy+Wgr013Yxt/p+g5lXlfXwrJKTD0QkDy96Whiar1?= =?us-ascii?Q?Mj+sGULntD3ulBw+p51YtCJdPDU9fZibnm+TN6xHu0bdE8id2qNdkGCdydH3?= =?us-ascii?Q?pUVnJ4n5rznyTCRSZeT588EHvi3BG7jnnSN1SWjep2DghmQwD1+swNBo7W8Y?= =?us-ascii?Q?3VIZLWj7qywarJMxLCAiqOpRSnPBtRLJFwUE/zJC09Amvrl3Ege7MSK1hSbI?= =?us-ascii?Q?/+j3M6Y5Fgz71SUoomF/Dw+tv/S1irruDY6EMEQ7ECOscBspd4jSqJ56ISbd?= =?us-ascii?Q?qptse4HBSNEIpxrqOxNWKeTX1rk+/jEEJHEw5x8S4Z4WoF3BhUoGz+90LtLs?= =?us-ascii?Q?eqNfO1YyFTYMpz5ShC0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bc9af8c-50eb-4de5-a241-08dbd8ef3bb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2023 02:23:41.3049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 44fWyTQjXZ7UKvfzwUVXKxryiyPsiqQk1AJAHZECQXs6WtzHq+6zgNGUT9PbTnJwdl9YW8TGQPVBhva+f5pyQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6001 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A4NjJKYFH26H0fyxeall9TB6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AQXXbQRf; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Lisa, please check the comments in line. > -----Original Message----- > From: Lixia Huang > Sent: Monday, October 30, 2023 9:20 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nate DeSimone > > Subject: [PATCH v2 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > MM > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Abner Chang > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 202 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..a8751f5b1a1d > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,148 @@ > +/** @file > + Generic StandaloneMm IPMI stack driver > + > + @copyright We don't usually have @copyright tag in file header. Is this a new requirem= ent for the patch? > + Copyright 2023 Intel Corporation.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +// > +// Statements that include other files > +// > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "IpmiHooks.h" > +#include "IpmiBmcCommon.h" > +#include "IpmiBmc.h" Could you please move above three include statement below #include ? > +#include > + > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > +EFI_HANDLE mHandle; > + > +EFI_STATUS > +SmmInitializeIpmiKcsPhysicalLayer ( > + VOID > + ) > +/*++ > + > +Routine Description: > + Setup and initialize the BMC for the SMM phase. In order to verify th= e BMC > is functioning > + as expected, the BMC Selftest is performed. The results are then chec= ked > and any errors are > + reported to the error manager. Errors are collected throughout this r= outine > and reported > + just prior to installing the driver. If there are more errors than > MAX_SOFT_COUNT, then they > + will be ignored. > + > +Arguments: > + ImageHandle - Handle of this driver image > + SystemTable - Table containing standard EFI services > + > +Returns: > + EFI_SUCCESS - Successful driver initialization > + > +--*/ You still follow the old Intel coding style? I think we should have functio= n header above the function. Could we relocate the function header? > +{ > + EFI_STATUS Status; > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > + > + Status =3D gMmst->MmAllocatePool ( > + EfiRuntimeServicesData, > + sizeof (IPMI_BMC_INSTANCE_DATA), > + (VOID **)&mIpmiInstance); > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > + return Status; > + } else { > + > + // > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > + // > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > KCS_DELAY_UNIT; > + > + // > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > + // > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > + > + mHandle =3D NULL; > + Status =3D gMmst->MmInstallProtocolInterface ( > + &mHandle, > + &gSmmIpmiTransportProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > + > + return EFI_SUCCESS; > + } > +} > + > +/** > + The module Entry Point of driver. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the MM System Table. [In] [out] tag is missed in above two @param. Abner > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurs when executing this entry poi= nt. > + > +**/ > +EFI_STATUS > +InitializeGenericIpmiStandaloneMm ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *SystemTable > + ) > +{ > + SmmInitializeIpmiKcsPhysicalLayer (); > + return EFI_SUCCESS; > +} > + > +/** > + Unloads an image. > + > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > + > + @retval EFI_SUCCESS The image has been unloaded. > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > + > +**/ > +EFI_STATUS > +EFIAPI > +GenericIpmiStandaloneMmUnload ( > + IN EFI_HANDLE ImageHandle > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D EFI_SUCCESS; > + if (mIpmiInstance !=3D NULL) { > + if (mHandle !=3D NULL) { > + Status =3D gMmst->MmUninstallProtocolInterface ( > + mHandle, > + &gSmmIpmiTransportProtocolGuid, > + &mIpmiInstance->IpmiTransport > + ); > + ASSERT_EFI_ERROR (Status); > + } > + gMmst->MmFreePool (mIpmiInstance); > + } > + > + return Status; > +} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..336e28368ed6 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,52 @@ > +## @file > +# StandaloneMm Generic IPMI SMM Driver. > +# > +# @copyright > +# Copyright 2023 Intel Corporation.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D StandaloneMmGenericIpmi > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > + MODULE_TYPE =3D MM_STANDALONE > + VERSION_STRING =3D 1.0 > + PI_SPECIFICATION_VERSION =3D 0x00010032 > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > + > +[Sources] > + ../Common/IpmiHooks.h > + ../Common/IpmiHooks.c > + ../Common/IpmiBmcCommon.h > + ../Common/KcsBmc.c > + ../Common/KcsBmc.h > + ../Common/IpmiBmc.c > + ../Common/IpmiBmc.h > + StandaloneMmGenericIpmi.c > + > +[Packages] > + MdePkg/MdePkg.dec > + IpmiFeaturePkg/IpmiFeaturePkg.dec > + > +[LibraryClasses] > + MemoryAllocationLib > + BaseLib > + MmServicesTableLib > + DebugLib > + StandaloneMmDriverEntryPoint > + IoLib > + ReportStatusCodeLib > + TimerLib > + > +[Protocols] > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > + > +[Guids] > + > +[Pcd] > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > + > +[Depex] > + gIpmiTransportProtocolGuid > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -129,4 +129,6 @@ > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > + > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > -- > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110282): https://edk2.groups.io/g/devel/message/110282 Mute This Topic: https://groups.io/mt/102267199/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-