From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4FC2B9417C4 for ; Tue, 24 Oct 2023 10:43:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1b5J2n6X/uWGLIIdkfl1ZSxBT6E8w9hiFOO/W0Uh82o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698144193; v=1; b=K1GowsVh4GlhSSFOyMhC2oW8Oufmvin2S+uM7lImWNiuXzNYAe0dIgdrFnF93CAKSfpY6DOG S7FvsG/Kcc83vrGMTvQZMIAFwPL/IOVqOTjHPXxFxkGyjkO91wsakHqTkug2pGsmIIvVZFRBZi9 XN4X3C11m12Y6iQi8v2ZlpgQ= X-Received: by 127.0.0.2 with SMTP id GQ92YY7687511xAtIDAel0Ca; Tue, 24 Oct 2023 03:43:13 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.88]) by mx.groups.io with SMTP id smtpd.web11.15141.1698144192136524294 for ; Tue, 24 Oct 2023 03:43:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YGaRGVKxYsV01j1WNXqoTIS/npILmDIZM6w1/XCtsd2k7kPRz9Z/CY+cK6kRC4IaymjGRgneQK65Y2V4B8Hw5jlXZCy0TLqHnv51Mxk4H9ic145xQmE2nHQCwlJya5jadAT2/bEJM393d19yFksC41hojzdv794vyRY/YJij1otSmfHoNWSLGHQ7Jm60FcM8NkstnpMLlWhXqFAjGHCw8cgJMaLrE3Z9n8RLVJh+6KwoCVMh8uNJ1+2sRSyx5YK1W/g2hsOrpA7IzbBmjfHgDWWj/MbcxazM1nMOGZYrHadlW+RfUThjvDRcBlvCSjXHgRrn4Lh+29OQScY7Mv+8Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OhOdtigC1pczmKsAF+haqwfKFEq2YtszZcPNlYoe5+o=; b=h4uTNeFyrm3C7k0Qqr1XYk0WVOUxHqxNznoE1TzqTBMzECRG6aA7kUWWN4XzOp4nrxlauq70i8fEaFzpDSA0dTD8X8L+eXV/o/LJzOGImN/ZA3EViqg/clUbcW3HdBSbKoLbWsgEfmDTSEOsO2CnyDpdRx1UDfoWo5U03dfa+ESbLkNnwe+o0XAgdsH3vuIm46aEnEtxbeAIEw6mqgAo9xDaxpeUY1HsPLmyHLFqXBQRBERKjes2hC3zLnnO1qA+z/e93Ng0++fjRyUMMR/nyrXXdOKS2yacYHpE6rcCXkgp/xJ1aCHjrFf27e/XucDw53+WbDO0bedT/LM3zQ6S9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW4PR12MB7119.namprd12.prod.outlook.com (2603:10b6:303:220::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 10:43:09 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.019; Tue, 24 Oct 2023 10:43:08 +0000 From: "Chang, Abner via groups.io" To: "Huang, Li-Xia" , "devel@edk2.groups.io" CC: Isaac Oram , "Desimone, Nathaniel L" , "Wu, Yidong" , "Xu, Wei6" Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBUSH3AgAJVdjCAAihEsA== Date: Tue, 24 Oct 2023 10:43:08 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f5680497-faff-4ef9-95fb-0d394246569a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-21T14:03:32Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW4PR12MB7119:EE_ x-ms-office365-filtering-correlation-id: 21199dda-593f-40b5-87e4-08dbd47e02ed x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: V0GKaFxkGFRpfmiqELACleYzwgbk61vdI0j71Xa9nU87OtsEASAfP2Vs4B26yGX8BR8/icWdiixCEIfuz3S9S4tzX2r88DhGjDEeoZHQ62le+1jHs+pQGChN0iLZNN+zaiFGStUPM0yxfOmxAzy9GN7TBVksntY6AjNzPLXT13iY3wjU+GrbN3kvUS5az3OzZaAHuEfmtFYmdEmP8umw0tmexji8Z3qeDgrAq9Doto8OMbp8QNn9ICR2i20Fv0a1NXqLMZuvOGWpRmAIC9K6TgaBPCPc81c5n6nzMVJ9q7VwmhRkIKhu5kgqfgVkmaUh8G9pHYL6Fo4OLkddKCub3sn+PSBdYwNhGLuDignvWH05XiZIZ5NFBYACZIbPxyotalAW9x6dHSQA8HrTF1Aa9YIGlTaKFSqZNwJ/a+ufZeCvmYuJKKi71A0kpO8Su4Cd8KXR8C8m9FLNmdzDwrf52EmDDbEBhFYb6ZJVKs1x2FB706UdUNRmOBim+Ll17oWsns4bMfUdyFt5B5H+If+N4mGC6Lb64IF7vHwzdLeihHYmK3aMY4oqw4OU4JIutW3oumkslgUuprqOIi9E6GFrHH6DLbOJYowvZ43opsVzFEQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/TArFyvhBVXanI6hAxhOkV7nwriCRdAtXjJyyeNgAMh3Y0RkUC/KMbd50i39?= =?us-ascii?Q?jntYH81PRSDYDavJmbmgEUZJxCLECZVsZog2dDFGYGSO//24UcrWvbf7W3i5?= =?us-ascii?Q?gThd/T7v7vqv+XyDhV36g1ab/SzlgaNa1Vu7Iu9HI1BiovjFwE/2nrS8W//X?= =?us-ascii?Q?OPu2mcMZ261/bjeTTqh8rCtQwqQy3noxlWgGJe73l99+QZb9J5ueTq+1y+id?= =?us-ascii?Q?5OEQZ0PIr3BXj0gEBjCTuEiiK4cOE5ik9lwB1mo7Wq9OAh1xSbONwK6C/ZI4?= =?us-ascii?Q?LtNHOodXkR0l90EoHCvYzBRjNsvGLtm09o45HOSCWEsThw1DIHOqoDb1/XEO?= =?us-ascii?Q?78fV4fy1EmTgMHfGNWrbYD+WjYq7LWSV5Il/+XEW68Jh5/R0WLAk4U2ZL+En?= =?us-ascii?Q?3ZES5mIyjexLOpBRFXptducx2tUfaJFO5zTbNO3VBmNrURjFnEeHKV+/8p3v?= =?us-ascii?Q?8rR1Z6BnNUWOnfvyV5zgMzQtJ+72NZWcxN/yT7Wic8YCpIlulbqTWJ/eeOiA?= =?us-ascii?Q?ZFSLJacbDIE1qBwC3vHPqmmWl3tpHBxNtliGbTcnXqJgHZwFXGxgSRvcdhvP?= =?us-ascii?Q?GgLhxVSQx9jdHTURIA/Hdtu3NEHhCa5jS4dfqnvxaocTWaRDX0JpYk+7BEtJ?= =?us-ascii?Q?sYWxZesIl2E/E6tLEpLHUu6zenzYQYjb+ZZP3aD7w/Wr3oexQ0rNnVAGMaAR?= =?us-ascii?Q?aZPuDr/aCb1A/6100FuM1g6jjEHic+8rxkZczMbeyV6xN0NupZLvJ9MVH7wX?= =?us-ascii?Q?jFf8RxqcF9UmMQ0kYD/PbM5iHBwiw6AM0dZxbpSx04lJKh1/MuC0IeWHuV5O?= =?us-ascii?Q?Kmh4q6MXnIPZZs/HUnePiHtJ4P0Qw40khToSxALwb8MNUUyYv77pzmu1NPyZ?= =?us-ascii?Q?qZ9E1PPCVqr9y0AWp7mnhUhMNP9x26WM8CWCRwP6cNypsoeAgT3lPlDFhjWi?= =?us-ascii?Q?3cY3ljkysnU5XQ951z89hUR82npXyrxARArnNLYKwIU0BnQjqmM1TMrKQvgG?= =?us-ascii?Q?wQ2cJd/6nbj5g5XsvHQybStOOtf2eW6ouAdrDRKO/6vuH2GqTLB210IzPMZl?= =?us-ascii?Q?iYceH7yDt3KijnlMrvSKxUBgWJTxfrQQ3h21/96UDt0cGJai9pz3+uSJaE94?= =?us-ascii?Q?O7G38Xr8XhnulZ81Xy1+XueXaA1EBoosJq43h6Swnf2KamyRxHlkUn+rfBf0?= =?us-ascii?Q?Yv3uPWqzNHcRnsLs+cZLefR+NbnSkkdVAxHqQlMfidU8FuerQ2GcGCrj/mJi?= =?us-ascii?Q?1FBw1SRHk8w5rsSnFUJ40IwJXLVj/bB2/EsTMdIVfHT8jxnGreAnjNwrv1I5?= =?us-ascii?Q?2B9hoI/nFejOVXuHin0JxvM4z3q6wllgvh/8GkLkM5boM/0oXrLSKAr71tbo?= =?us-ascii?Q?k+TsLwiUi3G7omQJ+WJM+PIqYiXgLgbFbo6kGoblpiL/9wLN9Xpw6nL1eAc6?= =?us-ascii?Q?239cIJ1efnlTiaGOgXtqZVjcqatfZ9j5QyW7CVZ54Q9z3Wy/VLUq0zSc/vTl?= =?us-ascii?Q?pd7fLqpRoHWOWFswToX4hkcePJsrs1f7clhAS9d22hwfcXPSClU+Rb5o9AlD?= =?us-ascii?Q?k8Jz+5x5HZAErm/c5TkDU5yZoe+nZcVY1iTqyi88?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21199dda-593f-40b5-87e4-08dbd47e02ed X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 10:43:08.2954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JfZswnQh4MtBasEcIyZGx0+ZP78lG/w2/QokJ7F5q1DpnbBnd2kDWvjhie3reHMqOHLi7y7RcGHa7Xf++6E9Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7119 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LPQslYyANLfrFyfjeSFCw0njx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=K1GowsVh; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] BTW Lisa, As Issac told me the implementation which Intel upstream to IpmiFeaturePkg = was from a pretty old intel code base. Also, something like FAST_VIDEO_SUPP= ORT, BmcSlaveAddress and GetBmcStatus seems not used. I think those code sh= ould be removed as well. Abner > -----Original Message----- > From: Huang, Li-Xia > Sent: Monday, October 23, 2023 1:48 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Isaac Oram ; Desimone, Nathaniel L > ; Wu, Yidong ; Xu, > Wei6 > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi Abner, > > Thanks for your feedback. > Since the IPMI implementation in these two packages are diverging now, an= d > my patch has some dependency with common code in IpmiFeaturePkg , it will > be better to resend this patch after the diverging is done. > > Our target schedule is '23 WW51', could you let me know what's the sched= ule > for these two packages'(IpmiFeaturePkg and ManageabilityPkg) diverging? > Thanks. > > Regards, > Lisa > > -----Original Message----- > From: Chang, Abner > Sent: Saturday, October 21, 2023 10:15 PM > To: devel@edk2.groups.io; Huang, Li-Xia > Cc: Isaac Oram ; Desimone, Nathaniel L > > Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > Support Standalone MM > > [AMD Official Use Only - General] > > Hi Lisa, > Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. N= ate > had sent the maintainers update for review. > As the conversation I had with Issac, we all agreed IpmiFeaturePkg should= be > deprecated as the IPMI related drivers are now located under > ManageabilityPkg in edk2-platforms. The IPMI implementation in these two > packages are diverging now, which is not good. > Could you please send this patch against ManageabilityPkg? I can help to > review it, so does Nate as he also proposed himself as the maintainers of > ManageabilityPkg. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Huang, > > Li-Xia via groups.io > > Sent: Friday, October 20, 2023 2:46 PM > > To: devel@edk2.groups.io > > Cc: Isaac Oram ; Nate DeSimone > > > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: > > Support Standalone MM > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > > > Cc: Isaac Oram > > Cc: Nate DeSimone > > Signed-off-by: Lixia Huang > > --- > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > > | 2 + > > 3 files changed, 202 insertions(+) > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > new file mode 100644 > > index 000000000000..52d8d2abdd0d > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.c > > @@ -0,0 +1,148 @@ > > +/** @file > > > > + Generic StandaloneMm IPMI stack driver > > > > + > > > > + @copyright > > > > + Copyright 2023 Intel Corporation.
> > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +**/ > > > > + > > > > +// > > > > +// Statements that include other files > > > > +// > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include "IpmiHooks.h" > > > > +#include "IpmiBmcCommon.h" > > > > +#include "IpmiBmc.h" > > > > +#include > > > > + > > > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > > > +EFI_HANDLE mHandle; > > > > + > > > > +EFI_STATUS > > > > +SmmInitializeIpmiKcsPhysicalLayer ( > > > > + VOID > > > > + ) > > > > +/*++ > > > > + > > > > +Routine Description: > > > > + Setup and initialize the BMC for the SMM phase. In order to verify > > + the BMC > > is functioning > > > > + as expected, the BMC Selftest is performed. The results are then > > + checked > > and any errors are > > > > + reported to the error manager. Errors are collected throughout > > + this routine > > and reported > > > > + just prior to installing the driver. If there are more errors than > > MAX_SOFT_COUNT, then they > > > > + will be ignored. > > > > + > > > > +Arguments: > > > > + ImageHandle - Handle of this driver image > > > > + SystemTable - Table containing standard EFI services > > > > + > > > > +Returns: > > > > + EFI_SUCCESS - Successful driver initialization > > > > + > > > > +--*/ > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > > > > + > > > > + Status =3D gMmst->MmAllocatePool ( > > > > + EfiRuntimeServicesData, > > > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > > > + (VOID **)&mIpmiInstance); > > > > + > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > > Status)); > > > > + return Status; > > > > + } else { > > > > + > > > > + // > > > > + // Initialize the KCS transaction timeout. Assume delay unit is 10= 00 us. > > > > + // > > > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) > / > > KCS_DELAY_UNIT; > > > > + > > > > + // > > > > + // Initialize IPMI IO Base, we still use SMS IO base to get > > + device ID and > > Seltest result since SMM IF may have different cmds supported > > > > + // > > > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > > (PcdIpmiSmmIoBaseAddress); > > > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SI= GNATURE; > > > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDR= ESS; > > > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > > IpmiSendCommand; > > > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStat= us; > > > > + > > > > + mHandle =3D NULL; > > > > + Status =3D gMmst->MmInstallProtocolInterface ( > > > > + &mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + EFI_NATIVE_INTERFACE, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > > > > + > > > > + return EFI_SUCCESS; > > > > + } > > > > +} > > > > + > > > > +/** > > > > + The module Entry Point of driver. > > > > + > > > > + @param ImageHandle The firmware allocated handle for the EFI ima= ge. > > > > + @param SystemTable A pointer to the MM System Table. > > > > + > > > > + @retval EFI_SUCCESS The entry point is executed successfully. > > > > + @retval Other Some error occurs when executing this entry p= oint. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +InitializeGenericIpmiStandaloneMm ( > > > > + IN EFI_HANDLE ImageHandle, > > > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > > > + ) > > > > +{ > > > > + SmmInitializeIpmiKcsPhysicalLayer (); > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +/** > > > > + Unloads an image. > > > > + > > > > + @param[in] ImageHandle Handle that identifies the image to be > > unloaded. > > > > + > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > handle. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +GenericIpmiStandaloneMmUnload ( > > > > + IN EFI_HANDLE ImageHandle > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + Status =3D EFI_SUCCESS; > > > > + if (mIpmiInstance !=3D NULL) { > > > > + if (mHandle !=3D NULL) { > > > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > > > + mHandle, > > > > + &gSmmIpmiTransportProtocolGuid, > > > > + &mIpmiInstance->IpmiTransport > > > > + ); > > > > + ASSERT_EFI_ERROR (Status); > > > > + } > > > > + gMmst->MmFreePool (mIpmiInstance); > > > > + } > > > > + > > > > + return Status; > > > > +} > > \ No newline at end of file > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > new file mode 100644 > > index 000000000000..336e28368ed6 > > --- /dev/null > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > > daloneMm/StandaloneMmGenericIpmi.inf > > @@ -0,0 +1,52 @@ > > +## @file > > > > +# StandaloneMm Generic IPMI SMM Driver. > > > > +# > > > > +# @copyright > > > > +# Copyright 2023 Intel Corporation.
> > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > +## > > > > + > > > > +[Defines] > > > > + INF_VERSION =3D 0x00010017 > > > > + BASE_NAME =3D StandaloneMmGenericIpmi > > > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f= 00f81060 > > > > + MODULE_TYPE =3D MM_STANDALONE > > > > + VERSION_STRING =3D 1.0 > > > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > > > + ENTRY_POINT =3D InitializeGenericIpmiStandal= oneMm > > > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnloa= d > > > > + > > > > +[Sources] > > > > + ../Common/IpmiHooks.h > > > > + ../Common/IpmiHooks.c > > > > + ../Common/IpmiBmcCommon.h > > > > + ../Common/KcsBmc.c > > > > + ../Common/KcsBmc.h > > > > + ../Common/IpmiBmc.c > > > > + ../Common/IpmiBmc.h > > > > + StandaloneMmGenericIpmi.c > > > > + > > > > +[Packages] > > > > + MdePkg/MdePkg.dec > > > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > + > > > > +[LibraryClasses] > > > > + MemoryAllocationLib > > > > + BaseLib > > > > + MmServicesTableLib > > > > + DebugLib > > > > + StandaloneMmDriverEntryPoint > > > > + IoLib > > > > + ReportStatusCodeLib > > > > + TimerLib > > > > + > > > > +[Protocols] > > > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > > ALWAYS_PRODUCED > > > > + > > > > +[Guids] > > > > + > > > > +[Pcd] > > > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > > > + > > > > +[Depex] > > > > + gIpmiTransportProtocolGuid > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > index 5df71300cbd1..73dca30caae9 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > > ec > > @@ -129,4 +129,6 @@ > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > > D0000003 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > > |0xD0000004 > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > > 0xD0000005 > > > > + > > > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > > > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > > 6|0xD0000006 > > > > -- > > 2.26.2.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#109823): > > https://edk2.groups.io/g/devel/message/109823 > > Mute This Topic: https://groups.io/mt/102076516/7039027 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [abner.chang@amd.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109997): https://edk2.groups.io/g/devel/message/109997 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-