Re: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Hi Rebecca,
I can only give you reviewed-by for RedfishPlatformHostInterfaceLib.c.

Reviewed-by: Abner Chang <Abner.Chang@amd.com>

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn>;
> Michael D Kinney <michael.d.kinney@intel.com>; Guomin Jiang
> <guomin.jiang@intel.com>; Wei6 Xu <wei6.xu@intel.com>; Guo Dong
> <guo.dong@intel.com>; Ray Ni <ray.ni@intel.com>; Sean Rhodes
> <sean@starlabs.systems>; James Lu <james.lu@intel.com>; Gua Guo
> <gua.guo@intel.com>; Andrew Fish <afish@apple.com>; Hao A Wu
> <hao.a.wu@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>;
> Siyuan Fu <siyuan.fu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Jian
> J Wang <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyu1.lu@intel.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar
> <sami.mujawar@arm.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>;
> Daniel Schaefer <git@danielschaefer.me>; Min Xu <min.m.xu@intel.com>;
> Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Peter Grehan <grehan@freebsd.org>; Erdem Aktas
> <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>;
> Lendacky, Thomas <Thomas.Lendacky@amd.com>; Roth, Michael
> <Michael.Roth@amd.com>; Sunil V L <sunilvl@ventanamicro.com>; Andrei
> Warkentin <andrei.warkentin@intel.com>
> Subject: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant
> by using __func__
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
> others support, while __func__ was standardized in C99.
> 
> Since it's more standard, replace __FUNCTION__ with __func__ throughout
> EmulatorPkg.
> 
> Visual Studio versions before VS 2015 don't support __func__ and so will fail
> to compile. A workaround is to define __func__ as __FUNCTION__ :
> 
>   #define __func__ __FUNCTION__
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> 
> EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostI
> nterfaceLib.c | 2 +-
>  EmulatorPkg/Win/Host/WinPacketFilter.c                                                | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> index 4361bd4170e3..4332caa71016 100644
> ---
> a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> +++ b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatfor
> +++ mHostInterfaceLib.c
> @@ -538,7 +538,7 @@ RedfishPlatformHostInterfaceConstructor (
>    EFI_STATUS  Status;
> 
>    Status = GetRedfishRecordFromVariable (&mRedfishOverIpProtocolData,
> &mRedfishProtocolDataSize);
> -  DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n",
> __FUNCTION__, Status));
> +  DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n",
> + __func__, Status));
>    if (!EFI_ERROR (Status)) {
>      DumpRedfishIpProtocolData (mRedfishOverIpProtocolData,
> mRedfishProtocolDataSize);
>    }
> diff --git a/EmulatorPkg/Win/Host/WinPacketFilter.c
> b/EmulatorPkg/Win/Host/WinPacketFilter.c
> index 21859897c85f..a71c7e8c131b 100644
> --- a/EmulatorPkg/Win/Host/WinPacketFilter.c
> +++ b/EmulatorPkg/Win/Host/WinPacketFilter.c
> @@ -966,7 +966,7 @@ WintNtInitializeNetUtilityData (
>      goto ErrorReturn;
>    }
> 
> -  DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n",
> __FUNCTION__, InterfaceCount));
> +  DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", __func__,
> + InterfaceCount));
>    //
>    // Active interface index is set to first interface if given instance does
>    // not exist.
> --
> 2.34.1