From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.58]) by mx.groups.io with SMTP id smtpd.web11.2894.1680855813827392091 for ; Fri, 07 Apr 2023 01:23:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=VqNHRYlx; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.58, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TyOKI59whW1csnKMJnKdyL36rg3Cw5xUptJ+M+gLq7cArZGapm9nucHAsro04It7u2xoRlUmjct3yhxtoDB865oDvIAzVl66T7mL9J2SRJIB/ktwFOmIfvubMhiErxe8vVTtpqZgJxL+4ho2hVXHBABiemYwcyQn+ueLVAbejP7681aB5oXV1riwrYimy+PSz6u/Z7+Vo90VuXkvhM69/elJGVLIXhXff3tcliF6IixI2mP4ykswrUnldpDlbyGjQ1TCMkTWvsz7tyFBedxJhaZeZcyy5QNb01Oy2h00E6U99jVNyyjU/JzhT5cNvzeud+EeHgamjLuazqopiUH5RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J67ETmJoCT9PWNoZkF/0LZHM9HmEoywH3CcB7cQCIMY=; b=aJHJZWvmm50z8pRhF4YhgbQasXskcnrJYKMoke9k8yxPWB8Y/EpsPsnA9u7WB+2D0tuemSvx5ffVSIAiajSHFWVSCUqOEG/lJqF1lgItLYgz/Ie6WB1flzlLt9IfLwnC7GRSpqGM2rlpARYCi34GFwnt9mMgmNnc9APA1hBXQa3+kY+xLYm5kvX4SEYjB/ThaU21pAADzT4uKmGEaHT/doHkzpltm2IIKPtl3zMZOe0VGmq2W4wvycGLbn0Z+5qWmzukPy+Hz0ddi7APgZenXVh0anCS5omgPs04HWJpx6e9pMu1n+Z8mgVbasR+oV9zcm4905/duvtjlg7iHGfyRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J67ETmJoCT9PWNoZkF/0LZHM9HmEoywH3CcB7cQCIMY=; b=VqNHRYlxTehsj8fCtrfcbtIfxdAqvjSvIjceStTMC1zZaJS4i/RkRnZQtG5Ht8ywLefSlGDPEpY0HwwQZ4WPiX+dDowwFMDznJCW5GTz4Dq3b64RN6F+IZ4rPly9cbK0peX5IYTP73xyqtXtTLd8ADoMmyhHZyQ5xKLVk+Bnz5M= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5142.namprd12.prod.outlook.com (2603:10b6:208:312::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Fri, 7 Apr 2023 08:23:31 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::30f:bd83:40dd:8f1]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::30f:bd83:40dd:8f1%3]) with mapi id 15.20.6277.030; Fri, 7 Apr 2023 08:23:31 +0000 From: "Chang, Abner" To: Rebecca Cran , "devel@edk2.groups.io" , Liming Gao , Michael D Kinney , Guomin Jiang , Wei6 Xu , Guo Dong , Ray Ni , Sean Rhodes , James Lu , Gua Guo , Andrew Fish , Hao A Wu , Maciej Rabeda , Siyuan Fu , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , Nate DeSimone , Sean Brogan CC: Leif Lindholm , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , Min Xu , Jordan Justen , Gerd Hoffmann , Peter Grehan , Erdem Aktas , James Bottomley , "Lendacky, Thomas" , "Roth, Michael" , Sunil V L , Andrei Warkentin Subject: Re: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__ Thread-Topic: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant by using __func__ Thread-Index: AQHZaNaYOXi3TrjBm0iiH1c8J4k6uq8fgnAQ Date: Fri, 7 Apr 2023 08:23:31 +0000 Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-17-rebecca@bsdio.com> In-Reply-To: <20230406222319.2281263-17-rebecca@bsdio.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-07T08:23:28Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fc12f808-92c9-40b9-97ea-35808a83b062; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5142:EE_ x-ms-office365-filtering-correlation-id: 722009f7-d338-4c0d-999f-08db37415f58 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xsyVuqn+uuJJFEV2VycyM8rVy3gloFtB9mS5iYCdAeX75lU8rzDAdh9Dz/IYSo0RYQEXjDNR4hgtZ/CYSkKBxKZODnoYEbfygoi6trNwpDE/IQ9+Ol7Q9yG/flqef3P+YFJDQ9Pl/jA/LPPLJ2JoKUSTjrD4pWn46e7yl1Qu7RvAQOihdA0weoL97MXlwMmQeTkPSHw8I+Hv5UgToYXooRxYIz3C8y3riTHqaEH6wBaZ8q+qsEs4YcXV44k+MrCagqnX2JmPx3IB2TZp9l2fRrFh5pcpchQM206PC5YaMBtp6Rjs7u4GLtuRQ3k8IYSpjyjjNIbcu5JPZ/XLe9k6Aw+/rIzKArIdUDXWqKJ+EK7cc/9KjMYcgk4Y52fPDUMYBUjaTNFbPzWHuwuzsLExbtmX33cu0WR9vZQ7q+tqSOptPWWExvwsGSmEtY9QWkgYGisro9cowaP9pgQZlyzNW2KeyyTkqBDffgb8i173+G+/39PZEnucxmg+cMrpf90FcxxnpJO+NWHOHDIVpzBDaMp0andWGApAw5tIJPoVkIncjfgmaufCvUNiBGQrkp4cl9qwg+z/GOTcQzIxS2mXPBdcDKRiSdTtndUrI8m6fGRR25q4b2tst9B3mfXzjv5p/PHiYCB5WMeSZ3/dkPwOhQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(451199021)(33656002)(38100700002)(2906002)(4326008)(15650500001)(5660300002)(7416002)(7406005)(66476007)(55016003)(66446008)(8936002)(52536014)(122000001)(64756008)(66946007)(66556008)(8676002)(86362001)(38070700005)(41300700001)(76116006)(921005)(83380400001)(54906003)(9686003)(186003)(6506007)(26005)(71200400001)(110136005)(53546011)(316002)(7696005)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2Zo0hOlTxlNJVnF1R3zXmKgIaJm5Vfrx9YwYhBP/u9cTVk35E2eoYndB+odr?= =?us-ascii?Q?+oA4Am8yTGa3tygHjVhTy+D93GyhFXA9lOUR7NB0j3Tge398kJZhmbLOBcHN?= =?us-ascii?Q?1le9AmLEUNmEpmNcF4LLW133iqSAlTvGa/d1Pw5MZE9TA5zwHfnodw+cJwJz?= =?us-ascii?Q?dPhVaw00Axta8hjhSM9QKRJ8cUBltI1KQLX6FTo4G84sGgRXiEUSNaTq+4D8?= =?us-ascii?Q?90GwKi401XEstZEkR1CSuoyC2s1xMUB6ITmM3bVXs0XBeE8dR8d06sbPZobb?= =?us-ascii?Q?An62epnZMgPwR2wBbHPLjtKpiODM/QvwhpVoj8iriFRadOy9GjlifGyU+r3e?= =?us-ascii?Q?fr8JBG0VZ4CMfzRsS6xgphRiFtI4f+t6nVLq/U2xgUOvnTK7y5qnPBkil0QD?= =?us-ascii?Q?TQ/DtOu8qwPb6JfQP+78PGtQM+B2QXQVQF8upIruSGbAjzncyCkGFpNV6pt7?= =?us-ascii?Q?ZdxM1U1iPX5LiEBxq2Cxbm0ri6E9yOJGfRYSp689Izrb2Xx/ufcJGkG9b8fq?= =?us-ascii?Q?GpWHrmhyKXSJWPXlAFKYaop9rQaniG1VBrboSP2lKcYxG53oyLfCBMjVmxCE?= =?us-ascii?Q?zUQ54IpXudouLkZQrNEU2B4c8cpWNd/vp5GZsJptUoyRS1DafJ9e59GHt6+B?= =?us-ascii?Q?h68vz/mAqZ4Ry2jeIsVay/ZetQki0uMOK8BhAiT1usQ/kq08ss/A6Yofr2Fv?= =?us-ascii?Q?j6n5O5hkToTQ4N6l7/brxmMt3U9Vt1JqP7gma7s6QDYmrN23FkDudCrn5H7+?= =?us-ascii?Q?/pJsSwiP4EyicOWVVFk6XQMWBQ/nAr5mm0nKxDd035oI1LlWxrszvwEBc23y?= =?us-ascii?Q?CnfNMlt/Dr5WETOIa0kjIso3xqpo/rJLh0dF3AavhL3EHsWkczvcgmqWHYIb?= =?us-ascii?Q?895cRTz7OeLqGz7hWZG21XJYJN61HML59PpTjNDAppRbwBD9ydmcLTSWAWK3?= =?us-ascii?Q?L8he4wX7ahaaA4zDsuhRoYsPpZIsk2pa/c7/LTPdiLcLYih0lkjwVw/Or4HF?= =?us-ascii?Q?RlAAxBzMX9sJ2MYwD5+FZzpWv366WMeR+XKB3YUtoo/5GeD9ZLeknY9vRRYj?= =?us-ascii?Q?O2GE2WFle01qVwMFe0r7eh5QT4XAPVCLIg8/xpi97IikHmiMkcGG2gHTKQcK?= =?us-ascii?Q?SGYMB0T1hVS/lMEXWrzkCCkXqGQ3mFlorMWUGn2hGwMZt6wNndm9+ON2C048?= =?us-ascii?Q?9Dc90EdxrAsfIAjPUbkfN1c8ghwihI7Q/IWQ4X37eBbzx3CSWMjfSGb+UEHc?= =?us-ascii?Q?l7lUjd2Wmd5+1VR8M1my2KA80htZ3sl/44TkvLstBF4NxGEVczAXnSGpmFkX?= =?us-ascii?Q?R5Ikm8e94f/fDBVgJYb9He4rLRYZ14xvB/FcSJQaceGgOfgrjFefuJJM4BmH?= =?us-ascii?Q?rF8tJ+7WWO3rkjSVvvO0Iab0Pt9rwIxxYfLv/3RCdq7aHALJeODC/Z9iJ7XX?= =?us-ascii?Q?WgpnOrcLjtoEaBXryddPMaT0HVwcEzgGB4qV+CvZU2bT9FNDlc3qvX4pSYfW?= =?us-ascii?Q?dZ9qFkp9/1dlgzfodIreCkGvyzTauaHwHtWEylc+7NLgU1kv1JG1Stie5Cxs?= =?us-ascii?Q?IRmgnKKCWVE9ObT5ZGk=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 722009f7-d338-4c0d-999f-08db37415f58 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2023 08:23:31.4978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G7E9lpnMEyFV6LJweYe0jb+AUJOZTiEtwqoc3UTR2kKKp6yNWuTapOpuJsqv1H0xvb33Q7eeR5DCMONZetsLug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5142 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Rebecca, I can only give you reviewed-by for RedfishPlatformHostInterfaceLib.c. Reviewed-by: Abner Chang > -----Original Message----- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Liming Gao ; > Michael D Kinney ; Guomin Jiang > ; Wei6 Xu ; Guo Dong > ; Ray Ni ; Sean Rhodes > ; James Lu ; Gua Guo > ; Andrew Fish ; Hao A Wu > ; Maciej Rabeda ; > Siyuan Fu ; Jiewen Yao ; Jian > J Wang ; Xiaoyu Lu ; Ard > Biesheuvel ; Sami Mujawar > ; Supreeth Venkatesh > ; Michael Kubacki > ; Nate DeSimone > ; Sean Brogan > > Cc: Rebecca Cran ; Leif Lindholm > ; Chang, Abner ; > Nickle Wang ; Igor Kulchytskyy ; > Daniel Schaefer ; Min Xu ; > Jordan Justen ; Gerd Hoffmann > ; Peter Grehan ; Erdem Aktas > ; James Bottomley ; > Lendacky, Thomas ; Roth, Michael > ; Sunil V L ; Andrei > Warkentin > Subject: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant > by using __func__ >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. >=20 > Since it's more standard, replace __FUNCTION__ with __func__ throughout > EmulatorPkg. >=20 > Visual Studio versions before VS 2015 don't support __func__ and so will = fail > to compile. A workaround is to define __func__ as __FUNCTION__ : >=20 > #define __func__ __FUNCTION__ >=20 > Signed-off-by: Rebecca Cran > --- >=20 > EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostI > nterfaceLib.c | 2 +- > EmulatorPkg/Win/Host/WinPacketFilter.c = | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > index 4361bd4170e3..4332caa71016 100644 > --- > a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo > stInterfaceLib.c > +++ b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatfor > +++ mHostInterfaceLib.c > @@ -538,7 +538,7 @@ RedfishPlatformHostInterfaceConstructor ( > EFI_STATUS Status; >=20 > Status =3D GetRedfishRecordFromVariable (&mRedfishOverIpProtocolData, > &mRedfishProtocolDataSize); > - DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > __FUNCTION__, Status)); > + DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n", > + __func__, Status)); > if (!EFI_ERROR (Status)) { > DumpRedfishIpProtocolData (mRedfishOverIpProtocolData, > mRedfishProtocolDataSize); > } > diff --git a/EmulatorPkg/Win/Host/WinPacketFilter.c > b/EmulatorPkg/Win/Host/WinPacketFilter.c > index 21859897c85f..a71c7e8c131b 100644 > --- a/EmulatorPkg/Win/Host/WinPacketFilter.c > +++ b/EmulatorPkg/Win/Host/WinPacketFilter.c > @@ -966,7 +966,7 @@ WintNtInitializeNetUtilityData ( > goto ErrorReturn; > } >=20 > - DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", > __FUNCTION__, InterfaceCount)); > + DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", __func__, > + InterfaceCount)); > // > // Active interface index is set to first interface if given instance = does > // not exist. > -- > 2.34.1