From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.76]) by mx.groups.io with SMTP id smtpd.web11.59317.1673539528632643649 for ; Thu, 12 Jan 2023 08:05:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=er5jeweG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.76, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiwUkr0q5+9D4gjb7qLqg9Fg52jvmRGDIjonITBEp81PEybbVTSRtwZENVEuvx4Ks3+CiefhatFafAzJGIM4y1cKsE8rJabDoPH6wn6EgA5wgPZXbMLQ022fHcu4jhlXJzicXN93LtfXJD8IL3HzY6pcElZbktvrBdwAvoTqUXA9HBoriF5UNdBOYPwooFuyHZgxa401gD0BNuTVp8P2at5YigDfeo9/IlzfZYIbQYTqrOcoExWiNLglQd9nn0mDPL9/H7JkrKbXkos6NA7FrXkTAUPbej6by7ZgFKDg6pUWH4NaDQ5o+y0qYAE+KOGKPdBNp3VUxtYEv0S9U6PqPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L8/SFw9i3KL5NgFhQZlS3FoslWg0xWOAh/xTF8ZWje4=; b=YFnxD87wSEsS07AtY0nBCPLwLQ0db7oj96tjDYahHXNYpKY3OooWGuU1l3iCjMAm+odq5y1zLpqy6Nb4bchu7Zuh8cKcpZCNtkMXLgMaF8rlHLcRK61d/yb7gYaHXZBOs2yMlAr4DM+sbL2nMAck8LehPlDAX2BNuSlTY5aIsbEMB76dL1Fi+zFay6Qe1o6MtZSmllUu2WFOGGxST5yX23M69Ijl8VQlRdutjyBSZEyarmN+72Gn7bkL7vKXe6Lt0H0wSV56dwTDQccY3z4iML0vSNBSbVHuvvuFWW5C1Q5p7793EqidaQ5w+47fITXBDbkiLpoyPFNH5PqIyWO6IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L8/SFw9i3KL5NgFhQZlS3FoslWg0xWOAh/xTF8ZWje4=; b=er5jeweGOG7xkJy558Cy1avIHPdCjT0IPBN0jWudxy0xgZxJuCx1SIhbQi1gItOkyUubrg2t0JelgZMLkawa8G3Cw2/VNKw7tKt4+6pnCdl6666hgVKSUM1tl9kh9zbNw7BkuX2Zu2FELgVscN2uUFnU6L3z2Dv5TbgN0qpqsh4= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN2PR12MB4376.namprd12.prod.outlook.com (2603:10b6:208:26c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 16:05:26 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 16:05:26 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Kirkendall, Garrett" , "Kinney, Michael D" , "He, Jiangang" Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Topic: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Index: AQHZJkP0ez06IqtD6EWknFffBlQE0q6a5zQAgAAK7eM= Date: Thu, 12 Jan 2023 16:05:26 +0000 Message-ID: References: <20230112050822.1940-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-12T16:02:54.5750706Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN2PR12MB4376:EE_ x-ms-office365-filtering-correlation-id: 54f64120-16d1-4309-5b76-08daf4b6d178 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9NIsetfV6ZUgyroNliGEEALqNHciWHDCQHxq1mC2hgKTu939WkL0Al68/7k9Q8XpFpipYucvE+4d6/ukzgw1nkwPDid3IE5DDf+vtzSvhQA+9J/C9Bp7+GNkT28gNYJ71RsjJNrCKcmwN7ElkHc7BcUN6hhvABUSon2qi+3cct8tx1VrK7Uxqiv/SmFhZRdMIPNJGOhoRZH4WFEZrTLqwvlq99ysXPzd32d/vmjo4jwar9MLEiUec1padYzTOKbNWHn7kM1zHQsd2MucD3YZLDkjPy1lI4eVsn6ArDFN8BoqI0dWv1qmF+S4e0w/asHlsHk6cO6U/ILfFxRat9MpwRNre6b3XbZbHP2V3GwL1kU7Ku88Rnj5UHTnfzZIHHHMA9GZeN4WQfQny6wKupi6LVhrDmKfTfqNXwhrFtSaTI5xGqhdFqjvQlc9S6N8g7V3rGu+y9ZIsUMJGiZnKGVqfv+c1fsFUOTHM4jkLjDjf2ZGoW0c1a6SsrCrWcXss8Tv1kY+c6m/CU0X9DjKtv0K0N6Nsjefxo9B2jKo3R9VqecctwcE1OLvf7RWsobDZeircVewYHJZoq1RIw/tkm7DThoLDYXHntlG7/iwHy1BCnvosC1YsUUYOwpuZemVt4j1UfR6wdiN3phDis+3XkRGiCqzyEcHFFfmbmyKAyZVw6sm/rNcxiRotq5zmtUrmdkSkxPBrCP8bEDK+mdlMBiDHvgc8bOnSOqT9bwAjBF4U+F84A4PAeX4ONQRkny6HX+IHE/nSGfMuy8/os9PtMZpYQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(33656002)(316002)(7696005)(9686003)(86362001)(71200400001)(26005)(5660300002)(186003)(478600001)(966005)(45080400002)(91956017)(64756008)(41300700001)(66556008)(66946007)(66446008)(54906003)(4326008)(66476007)(110136005)(76116006)(52536014)(38070700005)(8936002)(83380400001)(8676002)(55016003)(53546011)(6506007)(122000001)(38100700002)(2906002)(66899015)(166002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yhAGAOblTULNUeQJyqgRQh9SU/qVnEK4aCQP0PhNJ/kyIbMdJbGzTLH7wNY2?= =?us-ascii?Q?d+312SYFO0kqOB32zr8+IE0EUs+3zDcI8wDn+qYgdVjSixPbbEwPF3cN0+wa?= =?us-ascii?Q?K+SqjOjMw8ivL1KNbi4PreiDSPL44NhgmUGgQ5NxeOiYnSImOcuxRQLJf9KV?= =?us-ascii?Q?4sQm9BCv9QtyC1oPlsZ+MAoqrwIvN4t1OOUnTZhUYhTSQjHurD0Pxmbu40TH?= =?us-ascii?Q?Y0dC5Ov2sY1m9ikcwguKDL+ZU8sIuJ3j2bdkdg6O/SThRF7SJERHsyS7HoIS?= =?us-ascii?Q?LCpOifYKHQ975qSRGLvBvDmx+PH284hedqRHyHr+gq8KuwyYCO83ayiF94mJ?= =?us-ascii?Q?tHe6zgCGEsAE9WYRQH5SzXa/aZU9JVOG5AmZr5fLM4pCYoFWNu0LLDpckIWC?= =?us-ascii?Q?2u+HMcL2BI8Nt9zMxARUiCs22DEitc+75IRolsusaHZM+SwLL+pzXTuNdu5D?= =?us-ascii?Q?saIr7kUZSAKvoL3RLxpSO+O2Z6iWangqp32dddESfzbyOMdMxYXWR9TSB1T+?= =?us-ascii?Q?sAuAMISX+pQnw5o4IqttpEzVUweSGvv8ppAeI2ruECSGj1i6aY4RJyrIcO+0?= =?us-ascii?Q?yQtZ64KxwiJJr5V3r/ZVKjMZlB4e9XVZXC1yqeM8hJW1h2iHTawpgRTToZxJ?= =?us-ascii?Q?LGn6tVkONAwThqg1WWDk8xLoR34kBFOpgAYuDBRorlflcaovp6wYetGAdY7O?= =?us-ascii?Q?t7U3tycZ9eqtMw17JLSdb7S0E7EDiw39aIq7+aOqflNPnZZS9VB75YnmOJtr?= =?us-ascii?Q?Zzqf7oX4WBXBtDMJ0ETyKebAZLp6JfZBwMkdEGZr13GP8rQM9D97jLi8ayYA?= =?us-ascii?Q?ysfx5czVyhP4oEo+IUFTu7gi7xFX4RKU1KqccXmA/0FI81gLiHXcLE4oPqeu?= =?us-ascii?Q?ta3mzlrEjGZlv+zVRkbsCp8f+bW2uw0GfiOgN2gNPlH9HqJftrJjCBoM6lyK?= =?us-ascii?Q?cAWxNnTik0N7Wd2SfzgGX4V4/t2hC61aLv+G3GFF37QjaYMHj/S+G72NW72j?= =?us-ascii?Q?ObDMFBoIXwa1cJvc6Syr4F1nT8r5SsFHHsN2We4NE01QbPddxc0nkKpK/h2Q?= =?us-ascii?Q?Esa5Xpv3S4R5jEJetOVIkuKj6/FTAjj7EP1euaFcd4CrGyDSptVwbkHZPL++?= =?us-ascii?Q?7nCmAx5Blo8/vxyMBc1kdyQFDT+nojojrtsDahOIe+g7uBhmKZb7NXqLkbCi?= =?us-ascii?Q?8icG0JnHdO5oWzyg7JLU6kpKbvPEu8BjSm8xTcbX8Q+BWepMUcFWIKXjiKTw?= =?us-ascii?Q?PSaX6IFE7OuMLDUN4SScK3vn8aUTbTuOPHBcfjq69rsph4th6zwCeh9ndPQn?= =?us-ascii?Q?B/By6ZxSB2nEus2tnjC4Yn/m8TFTt/b+wX7gJkrybbzJ8SCfYDomKO+Bqf5t?= =?us-ascii?Q?zrqnGA0hZE27hdngMtoFyZEP4hKC26FnEwvi5llWy2ImcD0cqACNS8h3p0w8?= =?us-ascii?Q?0jM2SM3jQ8hU+eFkzMZisRyoKl/tr70huIeelK/EJq+MTzNfqm4bNa9W51tD?= =?us-ascii?Q?g5qlC+R9JGzm2ftj4sHrenYS+8x+Riy1IwAD7L51r9/V1mW0XyoHugr+V1/8?= =?us-ascii?Q?Yk0Y1/hYryUt1xD5kiCEfk7s+ZnofOoy+ICLFGqJ?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54f64120-16d1-4309-5b76-08daf4b6d178 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 16:05:26.1741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0oFqeQzfK2VaIuiJunSFvXtGMkOGqCHOhlJ9xzvkFAY7RhqeC9UnbjCW1kyHzbgsQPjhO8LF453oige0OBdBIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4376 Content-Language: zh-CN Content-Type: multipart/alternative; boundary="_000_MN2PR12MB396636EF5E28A3B8B3FD4CE2EAFD9MN2PR12MB3966namp_" --_000_MN2PR12MB396636EF5E28A3B8B3FD4CE2EAFD9MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Mike, CC Jiangang, he can give the clear answer. Thanks Abner Get Outlook for Android ________________________________ From: Kinney, Michael D Sent: Thursday, January 12, 2023 11:23:48 PM To: devel@edk2.groups.io ; Chang, Abner Cc: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, What was the failure before this change? This looks like something that would always break the build of source files= were missing. Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er via groups.io > Sent: Wednesday, January 11, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; Garrett Kirkendall ; > Abner Chang > Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing sou= rce file to Brotli library > > From: Abner Chang > > Add missing source files to Brotli library INF. > > Signed-off-by: Jiangang He > Cc: Dandan Bi > Cc: Liming Gao > Cc: Garrett Kirkendall > Cc: Abner Chang > --- > .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomD= ecompressLib.inf > b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLi= b.inf > index 525e92408d6..244c2e35023 100644 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > @@ -5,6 +5,7 @@ > # Brotli was released on the website https://github.com/google/brotli. > # > # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved. > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -41,6 +42,10 @@ > # Wrapper header files end # > brotli/c/common/dictionary.c > brotli/c/common/transform.c > + brotli/c/common/context.c > + brotli/c/common/platform.c > + brotli/c/common/constants.c > + brotli/c/common/shared_dictionary.c > brotli/c/dec/bit_reader.c > brotli/c/dec/decode.c > brotli/c/dec/huffman.c > -- > 2.37.1.windows.1 > > > >=20 > --_000_MN2PR12MB396636EF5E28A3B8B3FD4CE2EAFD9MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Mike, 
CC Jiangang, he can give the clear answer.

Thanks
Abner 

From: Kinney, Michael D <= ;michael.d.kinney@intel.com>
Sent: Thursday, January 12, 2023 11:23:48 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner = <Abner.Chang@amd.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaolimin= g@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>= ;; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library
 
Caution: This message originated from an External = Source. Use proper caution when opening attachments, clicking links, or res= ponding.


Hi Abner,

What was the failure before this change?

This looks like something that would always break the build of source files= were missing.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of C= hang, Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@= byosoft.com.cn>; Garrett Kirkendall <garrett.kirkendall@amd.com>;<= br> > Abner Chang <abner.chang@amd.com>
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing = source file to Brotli library
>
> From: Abner Chang <abner.chang@amd.com>
>
> Add missing source files to Brotli library INF.
>
> Signed-off-by: Jiangang He <jiangang.he@amd.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
>  .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf = ; | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCust= omDecompressLib.inf
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompres= sLib.inf
> index 525e92408d6..244c2e35023 100644
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> @@ -5,6 +5,7 @@
>  #  Brotli was released on the website https://github.com/google/brotli.
>  #
>  #  Copyright (c) 2017 - 2020, Intel Corporation. All rights= reserved.<BR>
> +#  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights re= served.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -41,6 +42,10 @@
>    # Wrapper header files end #
>    brotli/c/common/dictionary.c
>    brotli/c/common/transform.c
> +  brotli/c/common/context.c
> +  brotli/c/common/platform.c
> +  brotli/c/common/constants.c
> +  brotli/c/common/shared_dictionary.c
>    brotli/c/dec/bit_reader.c
>    brotli/c/dec/decode.c
>    brotli/c/dec/huffman.c
> --
> 2.37.1.windows.1
>
>
>
>
>

--_000_MN2PR12MB396636EF5E28A3B8B3FD4CE2EAFD9MN2PR12MB3966namp_--