From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.82]) by mx.groups.io with SMTP id smtpd.web09.28771.1658980023720960066 for ; Wed, 27 Jul 2022 20:47:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=kReyUQcm; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.82, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NC/icpmy+mVM+ROTQES/qc2C3x0xVggIF71H64Xix+Np+TwNQn0y/9Jde8fW18/4CMNo3jeQZuD9qq3VEdXr8I/UfV97L7yr4Q5cl1eHiP5LVNpDtaXCSU15WhjuG8Wh7Dzmh90x7ZaqUQvQkVJpOQVoeeNhHQgG0ysEwkFZiEtsmqTCT0r6wUPw5Ps8jEv2SVpciwyEAQafbR7IZEAOBVQV11zBJWKho6L0eooHPM1ajX0QehTpfpLadDAlWsz1PIOEJqFLya+C+5K7yMuq7fj9w0aSSpyzDPuAQE1F2wX7GAG8BRLMxns7RjBECwmwVPjRE6KUoUgyOGSwrrzWMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zoxwZIaHibxvRr2sGo1OLXnVfxJK3t3n2TdwieEy/Ps=; b=AnJeITACmsrCmwqm8aOLHsScR8WaC2fdfHiIaf4znpdp/eOFohiyFCxn7hgAwO/DN54iT8DiY+7D9iyo+OyUx4k7dIMrArg2Jgg1xhNZBDEW9e58fXa3qfSGfdLeKApuocEfxtFohy6+3PiS02o+f5xktXYQ4Goowmxvu7AKQchHmAQCL2NDVCdrmF+hnrqhMRV2zlB9jbhaPkXCRodP1ZfdbFbNW4nAyfwNxkKISViYJGvMj7VVknDKiiXo7fOh6fzhljeVVwUhUT6N76TOryDuzIJR+jJbHwDLHncn2yLYVF3ooplWr+QVKSunCTxu1iWlFS9mIrEE3zimi2nUsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoxwZIaHibxvRr2sGo1OLXnVfxJK3t3n2TdwieEy/Ps=; b=kReyUQcmeaZ/Wm/RxocQcXuHEO0OvrveGvNZxS18wnZ3ZBAw8TIOW6nIZI9fgzfeIODXBwyQsPJHb3+cthnkgeLn4QjPuEOgHl6FHvg3d59ti/DhTNGoLz4X0d7SuFgagLahtxVlYjAFpviy0kOqzMMa3PDnhYxSUPGNrSgbxBU= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CY4PR1201MB2486.namprd12.prod.outlook.com (2603:10b6:903:d6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 03:46:59 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06%5]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 03:46:59 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: "Yang, Atom" , Nick Ramirez Subject: Re: [edk2-staging][PATCH v3 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver Thread-Topic: [edk2-staging][PATCH v3 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver Thread-Index: AQHYoVmUaNpB6mZMEU6k6Lsl8Ih6Gq2TJnNg Date: Thu, 28 Jul 2022 03:46:59 +0000 Message-ID: References: <20220727013802.247-1-nickle.wang@hpe.com> <20220727013802.247-14-nickle.wang@hpe.com> In-Reply-To: <20220727013802.247-14-nickle.wang@hpe.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-28T03:46:55Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d7cd90c0-6b2a-4dbf-b879-2b3c9bf623a8; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc46147c-f04b-4ae2-4f53-08da704bd35b x-ms-traffictypediagnostic: CY4PR1201MB2486:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eIBzWrKHOSEnOvHIChd9QN1lFnqVfQ94aghDIQWOM9DiErUEZFZYl5+dgXaA29kZfnoxV76WRQcBvq+CGWdchaL+tBQB0WM2ERyDvRtIguxjMzznKNFzI0TzaCFzJD0sfnh+QX7/CdSW6Vcz1hBRwMre/dJZnvfvmivcKWmYSqWg1sgQWawM/Jbl0Uuepti6+LWqB09CncZ2ADUXnZOLgOib2r0XxmNpteGbwyp8ntN1CFowDNfBzOfTTf10Q5WEfXUPlhe6U4Mh90teZlpYcWBTfmxUUhFzRHpBryYjq0dtILjEmqnZwgKYKDVmA3uM4IfKR7xZoj6EjLyptgt9pqQ3DiYYrrvZ5yZ9ZHNJMY26Y03rJVuaw1xmFYvMspq6TFhvDdNOFW8o+EmUKlCV67953WZWwIraZT6W9QU/y74sSHWyn9dAGqLLoK0ig9Ghzc5qvo9Bc2kgYnF/rC7+Y52Xtk7jWNDX1rcomyZoOowjhkcUHJZ/wVrHEcggpYq5XS4cUOYEzreZN1PzROAJxKo5gI2nxJjnuxV0cEIrWZdyQcIwm1ihAj24sNgTFVQxsIhp9qf0ixtWo+/dyfptqMZJpYOLwvhRtz1YW7SFPOBTWArQPnYnVX36B4vrZd48Le1MQin1yp3oGZdsx0lY7YAIyMYHyZ9ArTTsvElCbUYH5KM1zm+DOiR6SIZ3DqyTE1l77jAsbr14UqQNSLz/xyUyp0gEw0deIdfpfzHYKoeeFupZN+AW7NrN+MQcobW3zHj+mEIn6tO+AjlDW6ODOYCIrchY8KD0L/cQQgCLK/reJKf2x1yp6tbpIpLnJ+d61eFqAjvaNCbh5oxT0zWjnw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(6506007)(52536014)(5660300002)(8936002)(30864003)(64756008)(66476007)(66556008)(66446008)(4326008)(8676002)(296002)(55016003)(316002)(2906002)(33656002)(71200400001)(38100700002)(7696005)(26005)(54906003)(110136005)(41300700001)(478600001)(86362001)(122000001)(9686003)(53546011)(66946007)(83380400001)(76116006)(186003)(38070700005)(579004)(559001)(44824005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5cx05wQhyMDYvRbwgAW38Y5kknx/hdj4T6a66xe/A7uc7gCQYDdI03qrtgfG?= =?us-ascii?Q?l2ASZ6b6uj3Ba3Oa4k1X84zzzy7UaIhteI+dRBvAyrKkt9SNNj/9mUw8Vm38?= =?us-ascii?Q?/tNY3Ug1FreqNgVVyg2r7bUmQ0AUre9RaRwvIOxnIYJATzgo+SHhAD3VvdAH?= =?us-ascii?Q?ikwNSCe3dumFzMdJRn9k/9eauch17KCV8XNH7pruuF0yatOfnU/mSr4gRRqR?= =?us-ascii?Q?2SAXWp7KK0tdAuD8YcJq9EZSRz5+zrMACZ+XNv85SpPckIxS2yYBvYshRcwS?= =?us-ascii?Q?2MYPFCZC8Si7gS8WKkjLclxVaZov/9Z46ICdYKPM0254ZyPaCEzvTGnKDyDm?= =?us-ascii?Q?9Q7yH+Dt2laHfgl15B7hjbX4tuK4g3MhHLMzzI6HVhdImV5wEQE+oq9/ldjv?= =?us-ascii?Q?xPnjs0GxKXa+ChvqVvlN+f4MLZULSRDzGG7TYJEkkSuDL7L7IasPRvZKIFEA?= =?us-ascii?Q?bYc60IstAPLlY2l1ZDRaLGHv7FQ1Hsv2DJpxCr0vOWklJUS+IiorO/zJpy5e?= =?us-ascii?Q?GVCY1R4Af0CRreN6T1DTwkV7CQB8E1cJhbiTp76UqhW2X1oNFSlpg5q6Xv9f?= =?us-ascii?Q?c+CiMilfgAGrAfRvHmZopStsi3H0c0Pzt9iAvlx//FQenE9TNj4+ShP8m3Xm?= =?us-ascii?Q?inm1ZjX0uF6N0WNaUWclkdjgijO8+v39LnlZg5UjzqLqvMOrGPlPwFXz0Vg5?= =?us-ascii?Q?kFsDFBwfcRmcxUtrL+pV+Fzdfolz7rGy4zSkAl66KC9BYEkXZMwiVTmc8XQA?= =?us-ascii?Q?BPGptCeOeLwtoaWdvbvN6IujUz5ATlDmywl4oh5qzpRYoG+NxCRlRl4NWmeV?= =?us-ascii?Q?Wp5zK3gEQgrdb7Tao745Y2W2fVJjUEl5PCNDkN2qfuZDqr1/sESTD0WYitPe?= =?us-ascii?Q?DtqE+D4RlPVyRno9sMVCM0sWIEcyai0qbNFAxgzkkhH4YosnQrVYMwoXHQlu?= =?us-ascii?Q?Qr6PMLAAg7buqKE1Q2X2RAX1ZHY7jAs4qH5xUX9OMsjhSbbrGRjeCWRJCEX8?= =?us-ascii?Q?6Q05FodS1J4Qbc8o2s3VQqKzo0hiNNVZT5eBKiaDNYmlnfvDjjr3ZaLI/ljm?= =?us-ascii?Q?l8mVoAyZp9H5FUGRFxI9qYbHHacMy1rLbBZJ/bRVpxUMGl9PKCl+OnuIXxZZ?= =?us-ascii?Q?WiVHa8+PaFxPw3DfrPBZKCLhARrtH3cxwck84grULO/bJRpsF29qzGprrvwx?= =?us-ascii?Q?LSuo7pk4iDiCDTfwDGqDx0WhCKb1I5PYU+DdxBMDhcu0OQM3eVSUKy24EpW+?= =?us-ascii?Q?RP8KQ+8IfPkp9NPG3KBLAZB7pAq0sV5gHwIqt1ei0zipolsIe7AITe/nlk7G?= =?us-ascii?Q?TAuP3jCM6hKTxSyncFxuSlXrR5q2oLlbkJBWeD7kql3fbTz6I+b5CuXh+TFG?= =?us-ascii?Q?+wK2b3pCl8MPsFpcsbXG4CvOvaomRvHE6Z85cBFVc34Xk8t9HH4LIYo1icCT?= =?us-ascii?Q?z7x4sqCBNalWU3O10/PvDBlgYYZ4kfodyzKmkmTqewnnPW7jLfOaUVvxTUnp?= =?us-ascii?Q?5aZVqr3uJaz7tbnCY4uf+J2gdfyoxxOjzq/Bd9XnOwAjouH6yZtonThO7y1v?= =?us-ascii?Q?lfQlEWaXtYZ9JhuNz8/SzcXdm85O5NspUjwxukTH?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc46147c-f04b-4ae2-4f53-08da704bd35b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 03:46:59.6556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uczKJln+5HkXdYcsossO7u4xdFV+HF3DumSXQjddzRmugxT8A5WvPvdH0Osv2zEg4PjyT9LZbnzj2qjsz4krZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB2486 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, July 27, 2022 9:38 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v3 13/15] edk2-staging/RedfishClientPkg: > Introduce Computer System collection driver >=20 > [CAUTION: External Email] >=20 > Introduce new feature driver to support Computer System Collection > schema. Update corresponding FDF and DSC file to enable this feature driv= er. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Yang Atom > Cc: Nick Ramirez > --- > .../ComputerSystemCollectionDxe.c | 667 ++++++++++++++++++ > .../ComputerSystemCollectionDxe.h | 21 + > .../ComputerSystemCollectionDxe.inf | 56 ++ > RedfishClientPkg/RedfishClient.fdf.inc | 2 + > .../RedfishClientComponents.dsc.inc | 2 + > RedfishClientPkg/RedfishClientLibs.dsc.inc | 1 + > 6 files changed, 749 insertions(+) > create mode 100644 > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > create mode 100644 > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.h > create mode 100644 > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.inf >=20 > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.c > new file mode 100644 > index 0000000000..dbf5ab3395 > --- /dev/null > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > +++ emCollectionDxe.c > @@ -0,0 +1,667 @@ > +/** @file > + > + Redfish feature driver implementation - ComputerSystemCollection > + > + (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include "ComputerSystemCollectionDxe.h" > + > +REDFISH_COLLECTION_PRIVATE *mRedfishCollectionPrivate =3D NULL; > + > +EFI_STATUS > +HandleResource ( > + IN REDFISH_COLLECTION_PRIVATE *Private, > + IN EFI_STRING Uri > + ) > +{ > + EFI_STATUS Status; > + REDFISH_SCHEMA_INFO SchemaInfo; > + EFI_STRING ConfigLang; > + EFI_STRING ReturnedConfigLang; > + UINTN Index; > + > + if (Private =3D=3D NULL || IS_EMPTY_STRING (Uri)) { > + return EFI_INVALID_PARAMETER; > + } > + > + // > + // Resource match > + // > + > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > + __FUNCTION__, Uri)); > + > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, > + Private->JsonStructProtocol, Uri, &SchemaInfo); if (EFI_ERROR (Status)= ) { > + DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: %s > %r\n", __FUNCTION__, Uri, Status)); > + return Status; > + } > + // > + // Check and see if this is target resource that we want to handle. > + // Some resource is handled by other provider so we have to make sure > this first. > + // > + DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __FUNCTION__, > + Uri)); ConfigLang =3D RedfishGetConfigLanguage (Uri); if (ConfigLang > + =3D=3D NULL) { > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > + if (EFI_ERROR (Status)) { > + if (Status =3D=3D EFI_UNSUPPORTED) { > + DEBUG ((DEBUG_INFO, "%a, \"%s\" is not handled by us\n", > __FUNCTION__, Uri)); > + return EFI_SUCCESS; > + } > + > + DEBUG ((DEBUG_ERROR, "%a, fail to identify resource: \"%s\": %r\n"= , > __FUNCTION__, Uri, Status)); > + return Status; > + } > + } else { > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, history record found: %s\n", > __FUNCTION__, ConfigLang)); > + // > + // Set exchange information > + // > + Status =3D GetArrayIndexFromArrayTypeConfigureLang (ConfigLang, > &ReturnedConfigLang, &Index); > + if (!EFI_ERROR (Status) || Status =3D=3D EFI_NOT_FOUND) { > + Private->InformationExchange->ReturnedInformation.Type =3D > InformationTypeCollectionMemberConfigLanguage; > + Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.Count =3D 1; > + Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List =3D > + AllocateZeroPool(sizeof > + (REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG)); > + > + if (Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List =3D=3D NULL) { > + DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG.\n", __FUNCTION__)); > + return EFI_OUT_OF_RESOURCES; > + } > + Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List [0].Index =3D Index; > + Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List [0].ConfigureLang =3D > + (EFI_STRING)AllocateCopyPool(StrSize(ReturnedConfigLang), (VOI= D > *)ReturnedConfigLang); > + } else { > + DEBUG ((DEBUG_ERROR, "%a, > GetArrayIndexFromArrayTypeConfigureLang fail: %r\n", __FUNCTION__, > Status)); > + } > + FreePool (ConfigLang); > + } > + > + // > + // Check and see if target property exist or not even when collection > memeber exists. > + // If not, we sill do provision. > + // > + DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __FUNCTION__, > + Uri)); Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > + if (EFI_ERROR (Status)) { > + // > + // The target property does not exist, do the provision to create pr= operty. > + // > + DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", > __FUNCTION__, Uri)); > + Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Uri= , > Private->InformationExchange, FALSE); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n"= , > __FUNCTION__, Status)); > + } > + > + return Status; > + } > + > + // > + // Consume first. > + // > + DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", > __FUNCTION__, > + Uri)); Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri)= ; > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to consume resoruce for: %s: > + %r\n", __FUNCTION__, Uri, Status)); } > + > + // > + // Patch. > + // > + DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __FUNCTION__, > + Uri)); Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to update resoruce for: %s: %r\n", > + __FUNCTION__, Uri, Status)); } > + > + return Status; > +} > + > +EFI_STATUS > +HandleCollectionResource ( > + IN REDFISH_COLLECTION_PRIVATE *Private > + ) > +{ > + EFI_STATUS Status; > + EFI_REDFISH_COMPUTERSYSTEMCOLLECTION *Collection; > + EFI_REDFISH_COMPUTERSYSTEMCOLLECTION_CS *CollectionCs; > + RedfishCS_Link *List; > + RedfishCS_Header *Header; > + RedfishCS_Type_Uri_Data *UriData; > + EFI_STRING MemberUri; > + > + if (Private =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + if (Private->JsonStructProtocol =3D=3D NULL || Private->CollectionJson= =3D=3D > NULL) { > + return EFI_NOT_READY; > + } > + > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, process collection for: %s\n", > + __FUNCTION__, Private->CollectionUri)); > + > + // > + // Convert JSON text to C structure. > + // > + Status =3D Private->JsonStructProtocol->ToStructure ( > + Private->JsonStructProtocol, > + NULL, > + Private->CollectionJson, > + (EFI_REST_JSON_STRUCTURE_HEADE= R **)&Collection > + ); if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, ToStructure() failed: %r\n", > __FUNCTION__, Status)); > + return Status; > + } > + > + CollectionCs =3D Collection->ComputerSystemCollection; > + > + if (*CollectionCs->Membersodata_count =3D=3D 0) { > + return EFI_NOT_FOUND; > + } > + > + if (IsLinkEmpty (&CollectionCs->Members)) { > + return EFI_NOT_FOUND; > + } > + > + List =3D GetFirstLink (&CollectionCs->Members); while (TRUE) { > + > + Header =3D (RedfishCS_Header *)List; > + if (Header->ResourceType =3D=3D RedfishCS_Type_Uri) { > + UriData =3D (RedfishCS_Type_Uri_Data *)Header; > + MemberUri =3D NULL; > + MemberUri =3D StrAsciiToUnicode (UriData->Uri); > + ASSERT (MemberUri !=3D NULL); > + if (MemberUri !=3D NULL) { > + Status =3D HandleResource (Private, MemberUri); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, process ComputerSystemCollection > resource: %a failed: %r\n", __FUNCTION__, UriData->Uri, Status)); > + } > + > + FreePool (MemberUri); > + } > + } > + > + if (IsLinkAtEnd (&CollectionCs->Members, List)) { > + break; > + } > + > + List =3D GetNextLink (&CollectionCs->Members, List); } > + > + // > + // Release resource. > + // > + Private->JsonStructProtocol->DestoryStructure > + (Private->JsonStructProtocol, (EFI_REST_JSON_STRUCTURE_HEADER > + *)Collection); > + > + return EFI_SUCCESS; > +} > + > +EFI_STATUS > +CreateCollectionResource ( > + IN REDFISH_COLLECTION_PRIVATE *Private > + ) > +{ > + EFI_STATUS Status; > + REDFISH_SCHEMA_INFO SchemaInfo; > + > + if (Private =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, create resource for collection for: > + %s\n", __FUNCTION__, Private->CollectionUri)); > + > + Status =3D GetSupportedSchemaVersion (REDFISH_SCHEMA_NAME, > + &SchemaInfo); if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to find supported schema from HII > database: %r\n", __FUNCTION__, Status)); > + return Status; > + } > + > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, supported schema: %a > %a.%a.%a\n", > + __FUNCTION__, SchemaInfo.Schema, SchemaInfo.Major, > SchemaInfo.Minor, > + SchemaInfo.Errata)); > + > + Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, > + Private->CollectionUri, Private->InformationExchange, TRUE); if > (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to create resoruce for: %s: %r\n", > + __FUNCTION__, Private->CollectionUri, Status)); } > + > + return Status; > +} > + > +EFI_STATUS > +ReleaseCollectionResource ( > + IN REDFISH_COLLECTION_PRIVATE *Private > + ) > +{ > + > + if (Private =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + // > + // Release resource > + // > + if (Private->RedResponse.Payload !=3D NULL) { > + RedfishFreeResponse ( > + Private->RedResponse.StatusCode, > + Private->RedResponse.HeaderCount, > + Private->RedResponse.Headers, > + Private->RedResponse.Payload > + ); > + Private->RedResponse.StatusCode =3D NULL; > + Private->RedResponse.HeaderCount =3D 0; > + Private->RedResponse.Headers =3D NULL; > + Private->RedResponse.Payload =3D NULL; } > + > + if (Private->CollectionJson !=3D NULL) { > + FreePool (Private->CollectionJson); > + Private->CollectionJson =3D NULL; > + } > + > + if (Private->RedfishVersion !=3D NULL) { > + FreePool (Private->RedfishVersion); > + Private->RedfishVersion =3D NULL; > + } > + > + return EFI_SUCCESS; > +} > + > +EFI_STATUS > +CollectionHandler ( > + IN REDFISH_COLLECTION_PRIVATE *Private > + ) > +{ > + EFI_STATUS Status; > + > + if (Private =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + DEBUG ((REDFISH_DEBUG_TRACE, "%a, collection handler for %s\n", > + __FUNCTION__, Private->CollectionUri)); > + > + // > + // Query collection from Redfish service. > + // > + Status =3D GetResourceByUri (Private->RedfishService, > + Private->CollectionUri, &Private->RedResponse); if (EFI_ERROR (Status)= ) { > + DEBUG ((DEBUG_ERROR, "%a, unable to get resource from: %s :%r\n", > __FUNCTION__, Private->CollectionUri, Status)); > + goto ON_RELEASE; > + } > + > + Private->CollectionPayload =3D Private->RedResponse.Payload; ASSERT > + (Private->CollectionPayload !=3D NULL); > + > + Private->CollectionJson =3D JsonDumpString (RedfishJsonInPayload > + (Private->CollectionPayload), EDKII_JSON_COMPACT); ASSERT > + (Private->CollectionJson !=3D NULL); > + > + Status =3D HandleCollectionResource (Private); if (EFI_ERROR (Status) > + && Status =3D=3D EFI_NOT_FOUND) { > + Status =3D CreateCollectionResource (Private); } > + > +ON_RELEASE: > + > + ReleaseCollectionResource (Private); > + > + return Status; > +} > + > +/** > + The callback function provided by Redfish Feature driver. > + > + @param[in] This Pointer to EDKII_REDFISH_FEATURE_PR= OTOCOL > instance. > + @param[in] FeatureAction The action Redfish feature driver s= hould > take. > + @param[in] Uri The collection URI. > + @param[in] Context The context of Redfish feature driv= er. > + @param[in,out] InformationExchange The pointer to > + RESOURCE_INFORMATION_EXCHANGE > + > + @retval EFI_SUCCESS Redfish feature driver callback is ex= ecuted > successfully. > + @retval Others Some errors happened. > + > + @retval EFI_SUCCESS Redfish feature driver callback is ex= ecuted > successfully. > + @retval Others Some errors happened. > + > +**/ > +EFI_STATUS > +EFIAPI > +RedfishCollectionFeatureCallback ( > + IN EDKII_REDFISH_FEATURE_PROTOCOL *This, > + IN FEATURE_CALLBACK_ACTION FeatureAction, > + IN VOID *Context, > + IN OUT RESOURCE_INFORMATION_EXCHANGE *InformationExchange > + ) > +{ > + EFI_STATUS Status; > + REDFISH_SERVICE RedfishService; > + REDFISH_COLLECTION_PRIVATE *Private; > + EFI_STRING ResourceUri; > + > + if (FeatureAction !=3D CallbackActionStartOperation) { > + return EFI_UNSUPPORTED; > + } > + > + Private =3D (REDFISH_COLLECTION_PRIVATE *)Context; > + > + RedfishService =3D Private->RedfishService; if (RedfishService =3D=3D > + NULL) { > + return EFI_NOT_READY; > + } > + > + // > + // Save in private structure. > + // > + Private->InformationExchange =3D InformationExchange; > + > + // > + // Find Redfish version on BMC > + // > + Private->RedfishVersion =3D RedfishGetVersion (RedfishService); > + > + // > + // Create the full URI from Redfish service root. > + // > + ResourceUri =3D (EFI_STRING)AllocateZeroPool (MAX_URI_LENGTH * > + sizeof(CHAR16)); if (ResourceUri =3D=3D NULL) { > + DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for full URI.\n", > __FUNCTION__)); > + return EFI_OUT_OF_RESOURCES; > + } > + StrCatS (ResourceUri, MAX_URI_LENGTH, Private->RedfishVersion); > + StrCatS (ResourceUri, MAX_URI_LENGTH, > + InformationExchange->SendInformation.FullUri); > + > + // > + // Initialize collection path > + // > + Private->CollectionUri =3D RedfishGetUri (ResourceUri); if > + (Private->CollectionUri =3D=3D NULL) { > + ASSERT (FALSE); > + return EFI_OUT_OF_RESOURCES; > + } > + > + Status =3D CollectionHandler (Private); if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, CollectionHandler failure: %r\n", > + __FUNCTION__, Status)); } > + > + return EFI_SUCCESS; > +} > + > +/** > + Initialize a Redfish configure handler. > + > + This function will be called by the Redfish config driver to > + initialize each Redfish configure handler. > + > + @param[in] This Pointer to > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > + @param[in] RedfishConfigServiceInfo Redfish service informaion. > + > + @retval EFI_SUCCESS The handler has been initialized = successfully. > + @retval EFI_DEVICE_ERROR Failed to create or configure the= REST EX > protocol instance. > + @retval EFI_ALREADY_STARTED This handler has already been > initialized. > + @retval Other Error happens during the initiali= zation. > + > +**/ > +EFI_STATUS > +EFIAPI > +RedfishCollectionInit ( > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This, > + IN REDFISH_CONFIG_SERVICE_INFORMATION > *RedfishConfigServiceInfo > + ) > +{ > + REDFISH_COLLECTION_PRIVATE *Private; > + > + Private =3D REDFISH_COLLECTION_PRIVATE_DATA_FROM_PROTOCOL (This); > + > + Private->RedfishService =3D RedfishCreateService > + (RedfishConfigServiceInfo); if (Private->RedfishService =3D=3D NULL) { > + return EFI_DEVICE_ERROR; > + } > + > + return EFI_SUCCESS; > +} > + > +/** > + Stop a Redfish configure handler. > + > + @param[in] This Pointer to > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > + > + @retval EFI_SUCCESS This handler has been stoped successf= ully. > + @retval Others Some error happened. > + > +**/ > +EFI_STATUS > +EFIAPI > +RedfishCollectionStop ( > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This > + ) > +{ > + REDFISH_COLLECTION_PRIVATE *Private; > + > + Private =3D REDFISH_COLLECTION_PRIVATE_DATA_FROM_PROTOCOL (This); > + > + if (Private->RedfishService !=3D NULL) { > + RedfishCleanupService (Private->RedfishService); > + Private->RedfishService =3D NULL; > + } > + > + ReleaseCollectionResource (Private); > + > + if (Private->FeatureProtocol !=3D NULL) { > + Private->FeatureProtocol->Unregister ( > + Private->FeatureProtocol, > + REDFISH_MANAGED_URI, > + NULL > + ); > + } > + > + return EFI_SUCCESS; > +} > + > +/** > + Callback function when gEfiRestJsonStructureProtocolGuid is installed. > + > + @param[in] Event Event whose notification function is being invoked= . > + @param[in] Context Pointer to the notification function's context. > +**/ > +VOID > +EFIAPI > +EfiRestJasonStructureProtocolIsReady > + ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + EFI_STATUS Status; > + > + if (mRedfishCollectionPrivate =3D=3D NULL) { > + return; > + } > + > + if (mRedfishCollectionPrivate->JsonStructProtocol !=3D NULL) { > + return; > + } > + > + Status =3D gBS->LocateProtocol ( > + &gEfiRestJsonStructureProtocolGuid, > + NULL, > + (VOID **)&mRedfishCollectionPrivate->JsonStructProtocol > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to locate > + gEfiRestJsonStructureProtocolGuid: %r\n", __FUNCTION__, Status)); } > + > + gBS->CloseEvent (Event); > +} > + > +/** > + Callback function when gEdkIIRedfishFeatureProtocolGuid is installed. > + > + @param[in] Event Event whose notification function is being invoked= . > + @param[in] Context Pointer to the notification function's context. > +**/ > +VOID > +EFIAPI > +EdkIIRedfishFeatureProtocolIsReady > + ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + EFI_STATUS Status; > + EDKII_REDFISH_FEATURE_PROTOCOL *FeatureProtocol; > + > + if (mRedfishCollectionPrivate =3D=3D NULL) { > + return; > + } > + > + if (mRedfishCollectionPrivate->FeatureProtocol !=3D NULL) { > + return; > + } > + > + Status =3D gBS->LocateProtocol ( > + &gEdkIIRedfishFeatureProtocolGuid, > + NULL, > + (VOID **)&FeatureProtocol > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to locate > gEdkIIRedfishFeatureProtocolGuid: %r\n", __FUNCTION__, Status)); > + gBS->CloseEvent (Event); > + return; > + } > + > + Status =3D FeatureProtocol->Register ( > + FeatureProtocol, > + REDFISH_MANAGED_URI, > + RedfishCollectionFeatureCallback, > + (VOID *)mRedfishCollectionPrivate > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "%a, failed to register %s: %r\n", > + __FUNCTION__, REDFISH_MANAGED_URI, Status)); } > + > + mRedfishCollectionPrivate->FeatureProtocol =3D FeatureProtocol; > + > + gBS->CloseEvent (Event); > +} > + > +/** > + Unloads an image. > + > + @param ImageHandle Handle that identifies the image to be > unloaded. > + > + @retval EFI_SUCCESS The image has been unloaded. > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > handle. > + > +**/ > +EFI_STATUS > +EFIAPI > +RedfishCollectionUnload ( > + IN EFI_HANDLE ImageHandle > + ) > +{ > + EFI_STATUS Status; > + EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; > + > + if (mRedfishCollectionPrivate =3D=3D NULL) { > + return EFI_NOT_READY; > + } > + > + ConfigHandler =3D NULL; > + > + // > + // Firstly, find ConfigHandler Protocol interface in this ImageHandle. > + // > + Status =3D gBS->OpenProtocol ( > + ImageHandle, > + &gEdkIIRedfishConfigHandlerProtocolGuid, > + (VOID **) &ConfigHandler, > + NULL, > + NULL, > + EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL > + ); > + if (EFI_ERROR (Status) || ConfigHandler =3D=3D NULL) { > + return Status; > + } > + > + ConfigHandler->Stop (ConfigHandler); > + > + // > + // Last, uninstall ConfigHandler Protocol. > + // > + Status =3D gBS->UninstallMultipleProtocolInterfaces ( > + ImageHandle, > + &gEdkIIRedfishConfigHandlerProtocolGuid, > + ConfigHandler, > + NULL > + ); > + > + FreePool (mRedfishCollectionPrivate); mRedfishCollectionPrivate =3D > + NULL; > + > + return Status; > +} > + > +EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL mRedfishConfigHandler =3D { > + RedfishCollectionInit, > + RedfishCollectionStop > +}; > + > +/** > + This is the declaration of an EFI image entry point. This entry point > +is > + the same for UEFI Applications, UEFI OS Loaders, and UEFI Drivers > +including > + both device drivers and bus drivers. It initialize the global > +variables and > + publish the driver binding protocol. > + > + @param[in] ImageHandle The firmware allocated handle for the UE= FI > image. > + @param[in] SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The operation completed successfully. > + @retval EFI_ACCESS_DENIED EFI_ISCSI_INITIATOR_NAME_PROTOCOL > was installed unexpectedly. > + @retval Others Other errors as indicated. > +**/ > +EFI_STATUS > +EFIAPI > +RedfishCollectionEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + VOID *Registration; > + > + if (mRedfishCollectionPrivate !=3D NULL) { > + return EFI_ALREADY_STARTED; > + } > + > + mRedfishCollectionPrivate =3D AllocateZeroPool (sizeof > + (REDFISH_COLLECTION_PRIVATE)); CopyMem > + (&mRedfishCollectionPrivate->ConfigHandler, &mRedfishConfigHandler, > + sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); > + > + Status =3D gBS->InstallProtocolInterface ( > + &ImageHandle, > + &gEdkIIRedfishConfigHandlerProtocolGuid, > + EFI_NATIVE_INTERFACE, > + &mRedfishCollectionPrivate->ConfigHandler > + ); > + > + EfiCreateProtocolNotifyEvent ( > + &gEfiRestJsonStructureProtocolGuid, > + TPL_CALLBACK, > + EfiRestJasonStructureProtocolIsReady, > + NULL, > + &Registration > + ); > + > + EfiCreateProtocolNotifyEvent ( > + &gEdkIIRedfishFeatureProtocolGuid, > + TPL_CALLBACK, > + EdkIIRedfishFeatureProtocolIsReady, > + NULL, > + &Registration > + ); > + > + return Status; > +} > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.h > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.h > new file mode 100644 > index 0000000000..a4778c1012 > --- /dev/null > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > +++ emCollectionDxe.h > @@ -0,0 +1,21 @@ > +/** @file > + > + Redfish feature driver implementation - internal header file > + > + (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef EFI_REDFISH_COMPUTERSYSTEM_COLLECTION_H_ > +#define EFI_REDFISH_COMPUTERSYSTEM_COLLECTION_H_ > + > +#include > + ect > +ion.h> > +#include > + > +#define REDFISH_SCHEMA_NAME "ComputerSystem" > +#define REDFISH_MANAGED_URI L"Systems/{}" > +#define MAX_URI_LENGTH 256 > + > +#endif > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.inf > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > emCollectionDxe.inf > new file mode 100644 > index 0000000000..107d6c0769 > --- /dev/null > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyst > +++ emCollectionDxe.inf > @@ -0,0 +1,56 @@ > +## @file > +# > +# Redfish ComputerSystemCollection collection driver. > +# > +# (C) Copyright 2020-2022 Hewlett Packard Enterprise Development > +LP
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D ComputerSystemCollectionDxe > + FILE_GUID =3D df883f2e-9f58-4514-9cc9-06cbe6f63073 > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + ENTRY_POINT =3D RedfishCollectionEntryPoint > + UNLOAD_IMAGE =3D RedfishCollectionUnload > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + RedfishPkg/RedfishPkg.dec > + RedfishClientPkg/RedfishClientPkg.dec > + > +[Sources] > + ComputerSystemCollectionDxe.h > + ComputerSystemCollectionDxe.c > + > +[LibraryClasses] > + DebugLib > + BaseMemoryLib > + ConverterCommonLib > + MemoryAllocationLib > + RedfishFeatureUtilityLib > + RedfishLib > + UefiLib > + UefiDriverEntryPoint > + UefiBootServicesTableLib > + EdkIIRedfishResourceConfigLib > + RedfishVersionLib > + > +[Protocols] > + gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMED > + gEfiRestJsonStructureProtocolGuid ## CONSUMED > + gEdkIIRedfishFeatureProtocolGuid ## CONSUMED > + > +[Guids] > + > +[Pcd] > + gEfiRedfishClientPkgTokenSpaceGuid.PcdMaxRedfishSchemaStringSize > + gEfiRedfishClientPkgTokenSpaceGuid.PcdMaxRedfishSchemaVersionSize > + > +[Depex] > + TRUE > diff --git a/RedfishClientPkg/RedfishClient.fdf.inc > b/RedfishClientPkg/RedfishClient.fdf.inc > index 5c4b9670b0..7d5de56591 100644 > --- a/RedfishClientPkg/RedfishClient.fdf.inc > +++ b/RedfishClientPkg/RedfishClient.fdf.inc > @@ -16,6 +16,7 @@ > INF > RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > INF RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.inf > INF > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf > + INF > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.inf >=20 > !include RedfishClientPkg/RedfishJsonStructureDxe.fdf.inc > # > @@ -23,4 +24,5 @@ > # > INF > RedfishClientPkg/Converter/Memory/v1_7_1/RedfishMemory_V1_7_1_Dx > e.inf > INF > RedfishClientPkg/Converter/MemoryCollection/RedfishMemoryCollection_ > Dxe.inf > + INF > RedfishClientPkg/Converter/ComputerSystemCollection/RedfishComputerS > ystemCollection_Dxe.inf > !endif > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc > b/RedfishClientPkg/RedfishClientComponents.dsc.inc > index 031d87558e..d4a33385f6 100644 > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc > @@ -21,6 +21,7 @@ > # > RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.inf >=20 > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf > + > RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.inf >=20 > !include RedfishClientPkg/RedfishJsonStructureDxe.dsc.inc >=20 > @@ -30,3 +31,4 @@ >=20 > RedfishClientPkg/Converter/Memory/v1_7_1/RedfishMemory_V1_7_1_Dx > e.inf >=20 > RedfishClientPkg/Converter/MemoryCollection/RedfishMemoryCollection_ > Dxe.inf > !endif > + > RedfishClientPkg/Converter/ComputerSystemCollection/RedfishComputerS > ystemCollection_Dxe.inf > diff --git a/RedfishClientPkg/RedfishClientLibs.dsc.inc > b/RedfishClientPkg/RedfishClientLibs.dsc.inc > index 413b83a732..21595613f5 100644 > --- a/RedfishClientPkg/RedfishClientLibs.dsc.inc > +++ b/RedfishClientPkg/RedfishClientLibs.dsc.inc > @@ -19,6 +19,7 @@ > # >=20 > MemoryV1_7_1Lib|RedfishClientPkg/ConverterLib/edk2library/Memory/v1 > _7_1/Lib.inf >=20 > MemoryCollectionLib|RedfishClientPkg/ConverterLib/edk2library/MemoryC > ollection/Lib.inf > + > ComputerSystemCollectionLib|RedfishClientPkg/ConverterLib/edk2library/C > omputerSystemCollection/Lib.inf >=20 > NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > HttpLib|NetworkPkg/Library/DxeHttpLib/DxeHttpLib.inf > -- > 2.32.0.windows.2