From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.44]) by mx.groups.io with SMTP id smtpd.web10.27705.1658972761529048975 for ; Wed, 27 Jul 2022 18:46:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TXAT8NUf; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.44, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=huue3P7izP9/bvylYbRRJeeRr89glC87j5EXmegOzSOVYyT1VJdwjr569dX/WguW/MACNtHzjuvgQogWV9XWY1cv+Mk8eJBtC53/GsZ4i9tTYPPgJGZIdk8RG8HLvIZhUFLJ00YWW5h2pCa9nsqBETZk69m5Fu/y9xOzoO/NcqDOt1zZZjvCbaWJ8/zo2TMA/S2fVUcxmgEU9PE9KCOLmK9betpGb4gGi1rlWMDnn8DCeA/3eXDjHJoRHGcXHwhD/Mh2tKzsyWNNZDHkLe/xY7oUvZe2dKRcRKZpSrk9PYj+MmCoq8aoFWDz9DJDnA9LMdCcvEXwakyldfWrj4KIuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvaDMp70jdypju+tYgloZKL0EqKj7sEINZFOPdchQxA=; b=HhBQtVPW2S/WuucVNXav+zT3RH/oB04Knk8/+oMJ1Ahmbt+yj9U2VN09ZDixatYgykD3+bWMvcOeS86H7p8biskachZ/603pvtUdApe9pjr1ZaYpypU078O+2BaZ/Dh5mEFd+fWufwgZwRyztFtuBrr3DUZmUb5dzqvneKCuO/GfLLyPVnBXlpMApUhltLuYZee2dh/7xaYVcvI3Yp2GUyR4pgotf9SepvZYZaMtug9/NiL4TdVn/+jlLeeK3uq2k/j2ap5ceu+cIYUdd6mdPKFY79M+9jWPXGTX+/AttOWDm1PlfH15JAC0MyY74nDqJizmaD2OucYbTaR9GGa1OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvaDMp70jdypju+tYgloZKL0EqKj7sEINZFOPdchQxA=; b=TXAT8NUfHKRJYuIcqltw5rlLWRyP1AGlzRwN+7qrzAx201Dchdyy5qL/PVVSE7UunTRb8FlXz5y76QFkkzz0TOSOwcQw81lzycuPqQ1Q3DLd0rVeBGfjKAz7t4HM59wgnWDR5BoEC8U+fNfxMWb7v9LhxnYCU4g95Zr9plVcyYc= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BN9PR12MB5258.namprd12.prod.outlook.com (2603:10b6:408:11f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 01:45:59 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06%5]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 01:45:59 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: "Yang, Atom" , Nick Ramirez Subject: Re: [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientPkg: Update ETag driver Thread-Topic: [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientPkg: Update ETag driver Thread-Index: AQHYoVmOo95AmO5ijEiIaLe9FkwV1a2TBM7A Date: Thu, 28 Jul 2022 01:45:59 +0000 Message-ID: References: <20220727013802.247-1-nickle.wang@hpe.com> <20220727013802.247-8-nickle.wang@hpe.com> In-Reply-To: <20220727013802.247-8-nickle.wang@hpe.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-28T01:45:57Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=95eda270-8a85-471c-92ea-9c83c16c07c3; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47ebda44-b919-4450-027c-08da703aebf4 x-ms-traffictypediagnostic: BN9PR12MB5258:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7VED1rTvROsxiHKQBMnCwXA5i8g1kGHvzbt8yoP9EsNv/0Ieg5J1KHic9J+f1JeaRXt5lnC7A92sl0pCg11Es7US006KwpoRdEnMNAjw26RBO4pCmIYDBjbihlZAphWDZN4NrM13aadOBP9a2eU/pszXEXg/0PtGe9p+gYnBw3Lj0vwO6w+j8om9ZJuZl/XWgRFONVUrnlbapXj8CmvJGE7/BLf7nZCbQJjhWwvcCwQfnGFEEUgMM3f/gSUrP1VZZ0yHjvj1bxTZhTpxHluyYbp9k0UNDMHglFOz3ox/WTbmH3v8/Qnmc4sVO+HVN3Kbc8w+6dRnSQjRUQ3uJe9eD+Qq1eEVpHXYtfZ55ociOhDXEq85temJQRGx85clYxvC+Ofd1ppbtq5hEzmB1fY1Wb1qXG6HG9XH8KmWuv1CQVaVzPbdegWaf4E+AFEmgFf6KfoTfWOGKJX7H/ldH1g2Izelq4C02KdYiNHE6N+SNe1ElYdxERMwaBEzbxzLoJWhmSZqV+k2OTYAtXo+rHHlO11V5AD9ta4vASVRgZa+2Aw+PkmpBiJ2mLsS2ht9MgzJNT70lzgRIo8bsAGUUxKsDBtgV6EZ2424lofxxf1fiPTacLQknXcCeYlFl8UgNpjY/sLgN7xhdPuYxvvCbB2cMURrzcjEGx/qSKgDkuJl6YZoImKtidbJdBfoZc+6Hm4yScadAjG7jAsGQaQ6YvBMlHCs+WKC5qzkOj4jx79DH92bWGSFlXxmzYLtEUJQshmBLNAodA35E32S3Cgd1Gcug1EpDAJToL3X8tcww+qjBUEJx24Qzod2abvcwzAwttQa x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(122000001)(33656002)(86362001)(26005)(2906002)(52536014)(38070700005)(38100700002)(83380400001)(41300700001)(53546011)(7696005)(478600001)(54906003)(9686003)(66946007)(15650500001)(6506007)(296002)(8936002)(186003)(110136005)(316002)(66476007)(71200400001)(4326008)(5660300002)(64756008)(8676002)(66446008)(66556008)(76116006)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wLyLKIoPuWiY3II+IdFz6yelIx1NvpON6cAqgRv1kqwS1a1x9QsrvAF/ZTtl?= =?us-ascii?Q?4D3XT0AHDT4hk3+QXuVT0UjJ62JFw2qGlhBEglWzylV0xwnKa5lbKrEgziJ+?= =?us-ascii?Q?0XWpjBQPbksu/QzZiHBRFAPjZiHZA6AAv4Gvx4PTvKZyzYLKcVBRB1Ky7bkO?= =?us-ascii?Q?+X3OGAm8Gshr9NJaNvcSYQWQGYhXCQW6UklOf0YXxQKp0cS5SPf3xnDS+9KA?= =?us-ascii?Q?hWx+3qtX0aGzARkyVhpIB4FLtbkpHkt9/Xe4mk2FhhHV3zhk8KyAXPAR/ZXS?= =?us-ascii?Q?QnSGq5ptz6p8IkjlEtB9MMiQp+ebVI/EZ477y4+pKw1FH+PtpQSsXJPGHrsg?= =?us-ascii?Q?D79s52W7Y88Mb2kJpejwX9cwlDkxv6KrI7/sCguAz4utY/zoY+EC4AAa/+2p?= =?us-ascii?Q?/Vr5EowIA91GYZUg8eVVoEaNT7gdZVWQCG8/DR2zCZmAxo6bc/mVyBcwkf0O?= =?us-ascii?Q?EIJjM4Rj7XaXBRvriZGLhdMz8v2sCqy5aA1oJcoyawBZuRV7LXeIv1HCW3sp?= =?us-ascii?Q?v2wzvKY+4+ipJWsUPSeMMjqVeCendekFlQwvz6iGrQpL+/HvnRW48E82P3nz?= =?us-ascii?Q?SAQUfzIWjfn/ALZisM2ROx/b1q/uy1EwT9jVdFv1fNAuQEHMhN8Btx56iryE?= =?us-ascii?Q?TfU34Ov85eGwqvWlMbjp6sWcI8K9QK7qpKBYyTJu+Q3794G9ZjiHd/uZL7Qr?= =?us-ascii?Q?0GEAQwcCbq/SUX2NGWVfszL2rmTzImao4dh/T+W/fAnweivHsCB9YD3Kt6z3?= =?us-ascii?Q?CCVNOL/qHzQsuI3arVYxahqrLVspDDFBNn3IgObBgFDk3OixB7j8ram+6mDU?= =?us-ascii?Q?flhuwK6GTeFes479O+7Uh7bsJh4PpYEvzpZpjMrJTu8sEpO9CkR6mA1510jm?= =?us-ascii?Q?zpc5jr2OSxzfiewZ275vXtcHkfj2XtCNiowEtk0crfKWQqJLUvYPj/F+PqaM?= =?us-ascii?Q?kjX1HUNVpRR/uwEbI09biQHw7uVGLIdT25BqurnA/uceDHnm2Sgg6Z7JDQx2?= =?us-ascii?Q?NMAB3v755OHpKS2zXbRWogkS+cb5Q8gMRWeK2U3O7fSkla800fDsEDAEmO4G?= =?us-ascii?Q?UKRg3/pB/4B1XBRbNXJ5lPhjebNsdYpR3WR0ZU8ZsbKq0NKW/RxN40w92F9U?= =?us-ascii?Q?1w16ueB+p7cFvlw2XFW26vyQNsI0yKp2X61uI6VA8e9vKJ/0Ujy5q4+ySN4X?= =?us-ascii?Q?aOgRlALwJYfgwA1nK5ds50l+SUabudQF+SrUFBED9aBpxe7MRmqtBq94YvkQ?= =?us-ascii?Q?SO5v8Az34Vihsih6AWNI+VlIHhpoTeywKg28DyTuy11MMEEVJLY4O7GQNxXp?= =?us-ascii?Q?pGBVaHLFOuPCfpYX+zVIX7TOSrX8/tVsDcUNL+xSFLhVYYh1OCggQ6ZzcIM6?= =?us-ascii?Q?t3epDCFC7aTeQmQw4un3hUfRAL6DW+A03hT+S0se5X/IEVClvD29CuDR6eQg?= =?us-ascii?Q?C/25f/DrRvMLO/j8HQ9+v5EIKtDdXv5WwMqbUHPKAFscFKzasdeW9S1ye8bS?= =?us-ascii?Q?Za3Jde00gG43ZAw5xWaZm2ynUpgmx7T39t3ifd+ynXG2rEx1mq7CyPiQSSEB?= =?us-ascii?Q?36iXd5Hnn1StX7tO/48=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47ebda44-b919-4450-027c-08da703aebf4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 01:45:59.5085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lAYSOW+EDXHMvzhz8vJe9zkIKDD0fuw0nG9p62C2mUWkPbX9lRTOHZ1V6JVbXdAYgPSEHkQg/mGbnQTf3khZrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5258 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, July 27, 2022 9:38 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientPkg: > Update ETag driver >=20 > [CAUTION: External Email] >=20 > Update ETag driver and use specific variable GUID. Also fix the typo in > comment. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Yang Atom > Cc: Nick Ramirez > --- > RedfishClientPkg/RedfishClientPkg.dec | 2 +- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +++++----- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/RedfishClientPkg/RedfishClientPkg.dec > b/RedfishClientPkg/RedfishClientPkg.dec > index 7bdab5be0c..67929341df 100644 > --- a/RedfishClientPkg/RedfishClientPkg.dec > +++ b/RedfishClientPkg/RedfishClientPkg.dec > @@ -36,7 +36,7 @@ > gEdkIIRedfishFeatureProtocolGuid =3D { 0x785CC694, 0x4930, 0xEF= BF, > { 0x2A, 0xCB, 0xA4, 0xB6, 0xA1, 0xCC, 0xAA, 0x34 } } > ## Include/Protocol/EdkIIRedfishResourceConfigProtocol.h > gEdkIIRedfishResourceConfigProtocolGuid =3D { 0x6f164c68, 0xfb09, 0x46= 46, > { 0xa8, 0xd3, 0x24, 0x11, 0x5d, 0xab, 0x3e, 0xe7 } } > - ## Include/Protocol/EdkiiRedfishETagProtocol.h > + ## Include/Protocol/EdkIIRedfishETagProtocol.h > gEdkIIRedfishETagProtocolGuid =3D { 0x5706d368, 0xaf66, 0x48= f5, { 0x89, > 0xfc, 0xa6, 0x61, 0xce, 0xb5, 0xa6, 0xa9 } } > ## Include/Protocol/EdkIIRedfishConfigLangMapProtocol.h > gEdkIIRedfishConfigLangMapProtocolGuid =3D { 0x1d9ba9fe, 0x5d5a, 0x= 4b66, > {0x83, 0x5b, 0xe2, 0x5d, 0x13, 0x93, 0x4a, 0x9c } } > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > index 73d3a8c39a..52015672f9 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -398,17 +398,17 @@ SaveETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &gEfiCallerIdGuid, > + &mRedfishVariableGuid, > (VOID *)&Data, > NULL > ); > if (!EFI_ERROR (Status)) { > FreePool (Data); > - gRT->SetVariable (VariableName, &gEfiCallerIdGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > + gRT->SetVariable (VariableName, &mRedfishVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > } >=20 >=20 > - return gRT->SetVariable (VariableName, &gEfiCallerIdGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > + return gRT->SetVariable (VariableName, &mRedfishVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > } >=20 > /** > @@ -444,7 +444,7 @@ InitialETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &gEfiCallerIdGuid, > + &mRedfishVariableGuid, > (VOID *)&VarData, > &VariableSize > ); > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > index 58925b4a51..3deab377dc 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > @@ -1,7 +1,7 @@ > /** @file > Common header file for RedfishETagDxe driver. >=20 > - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -11,6 +11,7 @@ > #define REDFISH_ETAG_DXE_H_ >=20 > #include > +#include >=20 > // > // Libraries > @@ -30,7 +31,6 @@ > #include >=20 > #define ETAG_VARIABLE_NAME L"RedfishETag" > -#define IS_EMPTY_STRING(a) ((a) =3D=3D NULL || (a)[0] =3D=3D '\0') > #define ETAG_DEBUG_ENABLED 0x00 >=20 > // > -- > 2.32.0.windows.2