public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: minhnampere <minhnguyen1@os.amperecomputing.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>,
	"nicklew@nvidia.com" <nicklew@nvidia.com>,
	"igork@ami.com" <igork@ami.com>,
	"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>,
	"tinhnguyen@os.amperecomputing.com"
	<tinhnguyen@os.amperecomputing.com>
Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Date: Fri, 5 May 2023 07:38:04 +0000	[thread overview]
Message-ID: <MN2PR12MB3966379E9CD02AF571C3E572EA729@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com>

[AMD Official Use Only - General]

Hi Minh,
Please add my RB for 3/5 in commit message and push to minhnampere:Adding_necessary_changes_for_RedfishPkg again.   I will check the PR and merge it once it passes CI.

Thank for your contribution.
Abner

> -----Original Message-----
> From: minhnampere <minhnguyen1@os.amperecomputing.com>
> Sent: Friday, May 5, 2023 2:46 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; Chang, Abner
> <Abner.Chang@amd.com>; nicklew@nvidia.com; igork@ami.com;
> nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com;
> minhnampere <minhnguyen1@os.amperecomputing.com>
> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> This patchset adds necessary changes for RedfishPkg to avoid some
> unexpected cases and fix compilation.
> 
> Changes since v3:
>  + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
> Changes since v2:
>  + Added "Cc:" to maintainers in commit message.
>  + Corrected patch format subject prefix.
> Changes since v1:
>  + Removed redundant change and change the commit message for more
> precise in PATCH 2/5.
> 
> Nhi Pham (1):
>   RedfishPkg: Add missing newline character
> 
> Vu Nguyen (4):
>   RedfishPkg: Correct variable type to prevent memory corruption
>   RedfishPkg: Fix condition checking of error status
>   RedfishPkg: Create RestEx child on selected interface
>   RedfishPkg: Fix compile issue on Linux
> 
>  RedfishPkg/Include/Library/RestExLib.h                       |   3 +
>  RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
>  RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
>  RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153 ++++++++----
> --------
>  RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
>  RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
>  6 files changed, 73 insertions(+), 98 deletions(-)
> 
> --
> 2.39.0

  parent reply	other threads:[~2023-05-05  7:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  6:45 [PATCH V3 0/5] Adding necessary changes for RedfishPkg minhnampere
2023-05-05  6:45 ` [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption minhnampere
2023-05-05  6:45 ` [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status minhnampere
2023-05-05  6:45 ` [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface minhnampere
2023-05-05  7:36   ` Chang, Abner
2023-05-05  6:45 ` [PATCH V3 4/5] RedfishPkg: Add missing newline character minhnampere
2023-05-05  6:46 ` [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux minhnampere
2023-05-05  7:38 ` Chang, Abner [this message]
2023-05-05  7:47   ` [PATCH V3 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  3:58 Minh Nguyen
2023-05-05  5:03 ` Chang, Abner
2023-05-05  5:35   ` Minh Nguyen
2023-05-05  5:45     ` Chang, Abner
2023-05-05  6:01       ` Minh Nguyen
2023-05-05  6:50         ` Minh Nguyen
2023-05-08 13:45           ` Chang, Abner
2023-05-09  0:46             ` Minh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966379E9CD02AF571C3E572EA729@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox