From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.46]) by mx.groups.io with SMTP id smtpd.web10.21799.1683272286019246535 for ; Fri, 05 May 2023 00:38:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=FfeSQRsv; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.46, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cI9jdtD7iHc4d/gRIFBgI8zepYhXsenHLLd0qJza0of1OBaAgRpeKHj3iPP2yTiUMuGe6/dsAvRmYRplhGXMg2zObJwAMF4X/BR4YCxyXtygLmtcloBCkU+RfPrGnt3OR4jQ+E11AQjCZ2EYpoDG+VQFYiutSCPN9oBEMBpKnW1qDbibzGG7lhNRKRZ1cLDHwoaQxZ6mzTOUQMcSBSdMcvFWs7k/gp5Gae8sXuqKv7VP5kzWwNTCOQ5IpThSacUIy3O4+Lwx+s1Zc0UVG7AMjpjLZ6RCDxGSNwhh6YgeV9HDGjQ+IR2QCSLpkZjQtJIPOckjRiyeKoKt449UyWyOkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gFayaAM6ucYgDXJ8ZBtdfo/CDjTpmvrUzbBvI3Ig8is=; b=oWbntlzAsdSNfBWONL1Aq3suFH4C5tVyZbFUPIImzieWPJrjbkfl7rJeBqwmUVYARqbm3ZaC0F6ZfmhDbc8zp44OX368/0ESBuq3X57NpY2rKux9ZdhkKdRv5hlFXDfhvhwn6Rn9T2rT3SOhFSnQcVIummfCqewzJSHH4xWBvPJW1hMJtKg1g7qrQVQ2X95uuv6EoG+CBe7/PCXffJEuloSWN8eypqHfzvijVwi80NJXCloNNUyTpEtDNr+mEy/HJF2sBRzPdGxzsBJmFcoROe0Ce4tL+jpj75xuBMqwNbY48P8dLhwhmsymWnAbm18zMxQ5vExH11hVwVjjfvi/1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFayaAM6ucYgDXJ8ZBtdfo/CDjTpmvrUzbBvI3Ig8is=; b=FfeSQRsvwzpZVKPbihU4eHfD6hBEnxTvX55bPtQ4kpNbjXZdXW2/zqhIk4HVlUnd4tNLvBfSfOnbIzLZ2sUKy0Rv3l3uiBKGJjb3pHzxYfFlDl5spsFT+fS1913IDc6iTxeYKkiBcLsA5uR2oKgPYd5sLOz68VmdMCulCJ1Zars= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5350.namprd12.prod.outlook.com (2603:10b6:208:31d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 07:38:04 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 07:38:04 +0000 From: "Chang, Abner" To: minhnampere , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "nicklew@nvidia.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" , "tinhnguyen@os.amperecomputing.com" Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg Thread-Topic: [PATCH V3 0/5] Adding necessary changes for RedfishPkg Thread-Index: AQHZfx1UBEyv4eB8U0eeGMOjWL2uoa9LSmCw Date: Fri, 5 May 2023 07:38:04 +0000 Message-ID: References: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230505064600.1478461-1-minhnguyen1@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-05T07:38:02Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cf83c886-faed-4745-96ba-7fa6f3c0abd0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5350:EE_ x-ms-office365-filtering-correlation-id: a926cc60-13b0-42b6-d66b-08db4d3ba96e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wK4TusIpA4xQ8IMoIkyta5pdvSbXLl6gzf0vlUMSLM7Mgncpou4UW6EQw78NA92zLLnjL//QTMQ9PAb4ef5pAzhquILAmKld89obqcGYCPUWjS+OBtKFB1WokJtta2L1IZI9/qeM3Jd7M/y5ptiWUBgajjwGp1lThUi5B8pPriARf1b9HdzFGMdzka3n0wo1YhfSmAlnwKsN1kefM/+4F59swz7oJCbnUpWxujJ6L9sY2ORm74N7MbCN0N1NFBISU/acLLBiG2i45eVMgj6KZe9KV8TyG1dzA/Xu/w6MJppvKsCUSWBHPubhUbMZZNpOzdmR/TeJJB4xteypFhee9wjUijlShFJoUbQgty2T/KLaL9AMybhsAJeA0yHQoOOFpodiqT7q9mbsDWV6SIQEeDFrTu/0t/sdxU4RQ28/ebUaRIIQB5SnSgI/trYk3SQnsSOyzGFTAguXvWZqcXZmpwMOcD6c8DeEsFqCBXpz5V9G5qzhhigQDFlZ4YQQAjdYBGA/Inzgir3YblsS87mRqpSqvWiGT70XPO9MuUR3VqjijFJw9/ogU57WNbmLvPz+PRaMJfegHHSYIyxhxwgO86dAYvu3dEFiiBFFUKW/wcGRbWmyWI/lOX7DgxZ+5ybl x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(366004)(396003)(39860400002)(376002)(451199021)(33656002)(86362001)(71200400001)(110136005)(316002)(54906003)(64756008)(4326008)(76116006)(66446008)(66476007)(66946007)(7696005)(66556008)(478600001)(41300700001)(55016003)(5660300002)(52536014)(8676002)(8936002)(2906002)(38070700005)(38100700002)(122000001)(186003)(9686003)(53546011)(6506007)(26005)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tIuGZwfTqWJhyrFOtzc7r3m0g95avlkqzMS+wuCX+6H6mgQei+V3h7lQDKyi?= =?us-ascii?Q?wHKAbpxEPlu4VPWjuhnz0vpc1o2yZPzOQy+no/Ipd1vWgBG4RTQDfThs913r?= =?us-ascii?Q?kB9KxA+uCQ2PNg8hHOP/x60aArzmBw8/EzfFiB2uOjB0+mEe7ETcJbFNjOay?= =?us-ascii?Q?X2yuoU+9OTwl3a+/UtTXlCosCQKZP47yJpJqaX2iK93J0CciYoJCfsLcKZbn?= =?us-ascii?Q?r73UBezAxh/ulKN348QJYtyStmsvDGgBnEOpmh9ujIJXkXEkYXUTHXjxGIua?= =?us-ascii?Q?1O3c78w+uvWkTBLkZzH7tthdfLaMLE4Tg0+qjZxDK38C/FeKfQWTN9n5punR?= =?us-ascii?Q?do/9uNxjidp8rLiqMOzhUFbMHgJZnGO2FdcTJz7gbEq8wOff1HJAIS5GBM0N?= =?us-ascii?Q?1TqUYfLUMUKLOnwEP7CbuxVZM2UMr0zBZCzkaTrB7Afw1kVDrjqYxznLUzU+?= =?us-ascii?Q?VnNjoLx/vnghRhM5cyg/NELSUs4lsasuv99uxVlByRJPF+v2Hyqp+C6JkY/d?= =?us-ascii?Q?QZL7PsZ93fWOtHZqZOMeWmGpKm0baFxbADc1iOjgIf3V+5heIUOMOohsjNgn?= =?us-ascii?Q?EWZD19vfG1wXBQm+xYn2q2QNKhnCAsg6FdEyV1R88NXHnwNe/ZyJ7GWRLdX4?= =?us-ascii?Q?nlVhirGNtgmeeBJCNbX6o9QM7asqPsSZZk78ELO76BMxiu7mnpUK5EzUFybV?= =?us-ascii?Q?LvN65cqWPFWCHlU5vFDuUg4v4YACPb5E5PUox481NcZFZfXV4XT8guuo3lc+?= =?us-ascii?Q?z7qKnTQwK48wD9K89Zrlc+U+Sahicgsyi4iuDl0i9ISt4pgQckP6KtnCgBOa?= =?us-ascii?Q?9xpoTn1eJJgtoeq5GoySzCV9QXp8e01VX+1p8z2mZtOu3ydn1Jr36R1gDSgw?= =?us-ascii?Q?bDbXHLppUQT0fXZOvACmsUmvwGu9nNN8ynJ4amnZ/2pv1egpan9vg/vL/MzO?= =?us-ascii?Q?22B5/+r7vKEGAo1LL0AvmjbFfSwmfcVhXHf66BQnPn03QoWDhl6daXNEpA49?= =?us-ascii?Q?rwXQKk0RHSyJxsweqHCRXwBHi7FVpZXCeBWXgCJDLxzaXP8WPyVw09fpVQK/?= =?us-ascii?Q?vqcaNzDa8VK2b+abejWpjvNHfs5alFz5h7Y4d2oakY9tFyOVDydy5xWZ2BbK?= =?us-ascii?Q?eRbVPwukO13UbS3wdTVLARUqi4ks2jFVo9aOV63miyDFAqOd6tIkkrQsDWFq?= =?us-ascii?Q?xwwJfrmGuWC9K2GgPbwa/awxrj9XfpdpEUCBHf7eKIPzpLybGFS3JVijyiPw?= =?us-ascii?Q?F1//f5TkMwJ3+X/AJMAn1K//1GuLeJeX2vNTWVXJBM598sgYgp7Qm8DewuQ0?= =?us-ascii?Q?JGuD00CO1Vr6ZN4eY8hPife7YIOXMhX3LXF/dA1reEADBzqPjYAg2nJg+KxT?= =?us-ascii?Q?3/tHmb+/vvgMn+HJCpAvuGa3gg4iQOImVEO+USBi3Zdhg1CQBDv0dvKv2LAj?= =?us-ascii?Q?jL88GvL1uJm5r7IiB/c0hwUy4s+SDH6y2QMrOIixF7+QUqd4beeptliTJ49s?= =?us-ascii?Q?6sitfMz27JMkX+hN2XJuIX6Jmq0zwah4FRt+P5m1wPtIA3abIwEn7rHyb3gt?= =?us-ascii?Q?fksAGuf6oB+J7nSxJLWwMoxcIPYMmMJNwUVzcnme?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a926cc60-13b0-42b6-d66b-08db4d3ba96e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 07:38:04.3598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9LLFgMmI/G4b9cnCh81E0ebuLwoIlvE6gDdl/6YwB6d+oF1G8+ih6ksNdUa0ngHYgF891f3BSSyrN1Rb0TBP8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5350 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Minh, Please add my RB for 3/5 in commit message and push to minhnampere:Adding_n= ecessary_changes_for_RedfishPkg again. I will check the PR and merge it o= nce it passes CI. Thank for your contribution. Abner > -----Original Message----- > From: minhnampere > Sent: Friday, May 5, 2023 2:46 PM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; Chang, Abner > ; nicklew@nvidia.com; igork@ami.com; > nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com; > minhnampere > Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > This patchset adds necessary changes for RedfishPkg to avoid some > unexpected cases and fix compilation. >=20 > Changes since v3: > + Replaced __FUNCTION__ with __func__ to be more C11 compliant. > Changes since v2: > + Added "Cc:" to maintainers in commit message. > + Corrected patch format subject prefix. > Changes since v1: > + Removed redundant change and change the commit message for more > precise in PATCH 2/5. >=20 > Nhi Pham (1): > RedfishPkg: Add missing newline character >=20 > Vu Nguyen (4): > RedfishPkg: Correct variable type to prevent memory corruption > RedfishPkg: Fix condition checking of error status > RedfishPkg: Create RestEx child on selected interface > RedfishPkg: Fix compile issue on Linux >=20 > RedfishPkg/Include/Library/RestExLib.h | 3 + > RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +- > RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +- > RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 +++++= +++---- > -------- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +- > 6 files changed, 73 insertions(+), 98 deletions(-) >=20 > -- > 2.39.0