From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.8277.1688523227018720454 for ; Tue, 04 Jul 2023 19:13:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=FQpo8kSB; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXwsRY+fkZuZSllfNT6XFIV3uAaj6fAvrOp7dM3EFYpd6ny7IOM7WEFTaIvWjr+lqKhFMoH/CDODBU1bv8ZElqRiMXgdaERVcJjv0cdmFCV9Z7x92U6VJLB7B0hiWtwitToeuD33a30ijAyKRXmevKx9ClNCYhcvjNn7C46SCHhmLOT5QTVHQ68+EzDvpr6g8BDQMI1dtWPM8Z9JrC0TGix4tPPWtLqZKChjRjYrFtxcrB9zzYEbVCIZZWP2/nBKdM9x97i/HEstKlUvi9NZwJjCewCMwKGw2Vn8tO2x00H812aBoZJuZUneZb8r+2NNnOdO7YA5s50EKAdRt8ADGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7dzk0GyKLpuIfRnR4jJ4UOYJ9g19df8YlgEf8hQ+/CY=; b=dAR/LO2hfOBEgWr/oVoFG2OunMlRb9kDnQ9c2Hj/xWYG+A4fdbyoF1K+tku+kZy5FdcMXYUZJmb/8HMiGtfe7QJdJxgHD5UaR4AMOlzTilrsYW+tBSJkLJR0XZxrT+nZ2IcHcZjX7E5Ux+sKttVaU3wH73ZjL/SLKoYrEp4EiUgEyaw7v25WKkBCaeE+nouXHe0OTQcAvgOSVGM/R5V3e5MUvrnlF7JN8fM6JlCup464FDX6pvpJ8MB+4apZVsL1xl8VglPQJXUeCkpfocy9CwcNH70IafvkOA0JYr+HDmBg6bwMZD8Eeo7Y6z176VBVRv00PuONri+RntDTr2YV4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7dzk0GyKLpuIfRnR4jJ4UOYJ9g19df8YlgEf8hQ+/CY=; b=FQpo8kSBQA2Iae1xZQ2lwluMxcO948QXEXhEkyb7UqVw+Bfaf3F3X5bxUytQn1zwIvhb17gRsC0G38JUB/JWdoKDehlkSq80lHYNyBRpVKScVLH/Sx9rRpNVuqMzq7jpOhGdIeQQ8nsnA8PO0pnZOMKdlsrdjEB1tgM2NmwNKzA= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW5PR12MB5598.namprd12.prod.outlook.com (2603:10b6:303:193::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 02:13:44 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6544.024; Wed, 5 Jul 2023 02:13:44 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe Thread-Topic: [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe Thread-Index: AQHZrbEloEISfoHAy062LvOBN+0K56+qcSkw Date: Wed, 5 Jul 2023 02:13:44 +0000 Message-ID: References: <20230703132016.7097-1-nicklew@nvidia.com> In-Reply-To: <20230703132016.7097-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=86d49e1c-0d05-4a69-b344-4e12f2f17642;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-05T02:13:22Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW5PR12MB5598:EE_ x-ms-office365-filtering-correlation-id: 3b92e3a6-a88a-4b55-21b1-08db7cfd756f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kF5KmGCCi+BMc0bMKyQ7MTja6Cz/7dYhqYhrnrKs2MQJ9irZeHOwS5M8Kt1zQnf4BpuhcjUd/y2FehSkAXzUyU2hKSH56pvHn8k9TvNOptjcMAf8ES0oaHqTs7QYboDRYhF3qQYxmzY3kl2HOmEodDcFIE8r4ot1RHxWriKDivzjtISm0Ig76vIRX806Dyfrvn0l8lThbbXA0fjvXbp511x8ROhfN2ISle30IIGfpwWQgZaeGhX2iIOlH+ua6SMR76aSWaiIhx6pj979cuZtEiX9DsQgajOvUyjthAl/ufpWxm8KoSvFM+5FQfAd1yfpQQ0MqCHwU45Nxt2g1bp/qyJDm5yaFFjVc2NT+psqfuVmzwRArog0vJKqykgDfHJ35VZFeD5esOl4wqGTRFu4ARUelOW1WXIsJE+aBY6q7T/8QFz6lpwm7TLURL95Rpe6xY1gJM1V27pK2impL9fzCmkqq7nFUWmaZ59E6tH4lhNECF4GGwa10PqZkJBDy4FzRU0VHvV6oRek13Rl1pih/SVm5clTR0fGRO+YkQWeAKQllDCFEKyr/f2YMV1vo/NXQBcbCRt1oz1OEnAkTccO7sP0U2ecwYvtK48Fiwljvg/dAqqWaB/Kvc1a5ZBoJcvw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199021)(2906002)(52536014)(8676002)(86362001)(55016003)(8936002)(5660300002)(110136005)(54906003)(53546011)(26005)(478600001)(7696005)(71200400001)(6506007)(186003)(33656002)(9686003)(38100700002)(38070700005)(122000001)(83380400001)(4326008)(316002)(66446008)(66476007)(66556008)(66946007)(76116006)(64756008)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ixdTdsd8qqeg4BUU+yfiORD3iKWv7+ciH97YsHtLZlzsKkoY0u099LREibvP?= =?us-ascii?Q?DzWXgLx13orND0dfTS+ECzoIiYCR/KnZY8XRHKovK0HphrlKTrBPuNWOi3jO?= =?us-ascii?Q?MtylHViJ1FaZvsOJ+oU4OzPXKXMU66b/TeLM4s8X9wDSNslIx9mZPjdI14cA?= =?us-ascii?Q?g/Xot1jvI/yMeVKGUewTtyfmfDoUBPVvPlvXst0J9XJstPHgEO2pScNxxXpZ?= =?us-ascii?Q?aaHqdhZYU1Vs7uZjIQqmsyMdrKzi9Ml6CvpvLB5wrHey1jV35k/sy1Um90f2?= =?us-ascii?Q?eIn70G9PS8D9IT3Vqa2rvsnVZS2vxkPKv+lwOOKwjMOKuOf19660KZEeVCcb?= =?us-ascii?Q?CpTDgM88fw6NCKJHVyD3wRzuZVFPn+VQoysa4PxQsy0wKBzx9jOi23fHokMw?= =?us-ascii?Q?WyXX1IQ8OCG4zj5fPIF2HpSGVCEXQLLvQ0pzVNP2PPUAcEb1GFOA0HU0c4Sj?= =?us-ascii?Q?i4CmZ6oDTKEUK/SoaQYL871jZqV00OHbU3dX9yQaivYL0Sz+z0zwXG/zrRjb?= =?us-ascii?Q?hIn7G6lc8WS5KoVTEe7xxesUBBvUymiUSIW1PFCYxpoSD6/zelTYVUkOT50L?= =?us-ascii?Q?qMvgfQly8auZ3P7FFpYx6affaZ39iae6buAaQRO84MKygxU4lnru1NJNol9Y?= =?us-ascii?Q?Fn8nbqSeNhlL5z2BLMKSpaKsia2XM8C4JUqtO+7V+HxScdSjs8Fvw/7U/0XV?= =?us-ascii?Q?uP9x26VCQ4jJYBPIZaCzQ9GqhCvtZAov/d+slngSWeVv4A7g8mS5Ik2+3vZh?= =?us-ascii?Q?EtePFjRmzuEai8vofPvMPNlHliy9juz3DFATCuKAGe+g26NUu6CiT8PF5f4P?= =?us-ascii?Q?lUBLnhBLRJ4rBkE4YnupI+wGlWEmVHMPws4VRi8eSJFmZbXbpph+d8gHjyAo?= =?us-ascii?Q?4vsNb1WciTFa9QlWuBC9wPVWgZ+Igbn/xgEi6GkKKNUdnrrGbM+kwxdUsaX8?= =?us-ascii?Q?J4GjMIOozwORhr/gMkSOgQVG+vAnApgJWLyLiD/klACUCo0O2xFJmOtjwmtv?= =?us-ascii?Q?fQhik2PlBo7P4XsJqrZZXZRWk06jpgsJ43JQFpEfIxTkkhgcqEcvTMnWlCWO?= =?us-ascii?Q?wUCvOZWq8WStH0YXZDD9GTs4n5h5W3lNJGezHMEx7KfDHUL5Z72alDyI3WUS?= =?us-ascii?Q?wXMt28Z0uLYAZB3/G86HJ9auoX6RsLPGK4ax/Zp07vXnrdmvET7gCnZ2hGBo?= =?us-ascii?Q?F9LR/K1Zxn0QSflWHjncwGrf8i8o6Rz7a7mMXnFXuZaa92pwY0XUUiYc+drB?= =?us-ascii?Q?OIaFzlDaGuxwJSJR52/ZKI7+aYArfcQvQn+xucXQylU27dIN9HXi5LkflNwJ?= =?us-ascii?Q?wYKzvhhMwQ8xNnoJTtwuFQVMMicaOXft2umQAJWF5EGopLwrcYO1HzBvWDQK?= =?us-ascii?Q?X57U8OHx5VRjOnmA7XU0Pv22aE92mrl+AwuVMHM2V45vLrrVTLlly/HV/5JO?= =?us-ascii?Q?RDbEYFgp8OtasnB+Uw5cDWxTse+Z6goiN1DmUHgAhB8/hpQVl1oNieTnWwET?= =?us-ascii?Q?jCxVRZlovPr0mlh5cvDqRSzEr210YWr18hA8W8Y6Jv94sbEEMgSUOY8jXWZ/?= =?us-ascii?Q?fkORA3aGOU3wg8OcUSc=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b92e3a6-a88a-4b55-21b1-08db7cfd756f X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 02:13:44.1611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BfuoJve1W8s88n3agFR6IgWtmdH2CS/2Y0cr0fU7xVTyAK3J75F9FZSY9VT0CW8Pekprg0QKOgx7TagI10a7Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Monday, July 3, 2023 9:20 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy ; > Nick Ramirez > Subject: [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in > RedfishRestExDxe > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > RedfishRestExDxe driver failed to uninstall service binding protocol > when driver binding stop is called. Application drivers may still > use RedfishRestExDxe after it is disconnected in system. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > index ad65ae213ae0..7036aed42683 100644 > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c > @@ -3,6 +3,7 @@ > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -57,6 +58,7 @@ RestExDestroyChildEntryInHandleBuffer ( > ChildHandleBuffer =3D ((RESTEX_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT > *)Context)->ChildHandleBuffer; > > if (!NetIsInHandleBuffer (Instance->ChildHandle, NumberOfChildren, > ChildHandleBuffer)) { > + RemoveEntryList (&Instance->Link); > return EFI_SUCCESS; > } > > @@ -563,7 +565,7 @@ RedfishRestExDriverBindingStop ( > ); > } > > - if ((NumberOfChildren =3D=3D 0) && IsListEmpty (&RestExSb->RestExChild= renList)) { > + if (IsListEmpty (&RestExSb->RestExChildrenList)) { > gBS->UninstallProtocolInterface ( > NicHandle, > &gEfiRestExServiceBindingProtocolGuid, > -- > 2.17.1