From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C220B740033 for ; Mon, 24 Jul 2023 02:05:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PTVzcBSn5jb3xusJut0lVCHBCRwzOoY7OqS3kzJLVTo=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-OriginatorOrg:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeadersStamped:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To: List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690164306; v=1; b=GXF6qUfmaQ8mkF4DroeL1vRblrTLzWqL/OFpBJaDTjDM450Df0MEFNKnXTOXhsuGbaXCmKuv +vyqfT48qFHscGETGnu97/LyL5exkWm3eVF55qh/Nxs7MH7v/DssO1RN5n5nUTyEUpu3OvU5TeE g7bNlReLfPqhyLjBOlfXwLgo= X-Received: by 127.0.0.2 with SMTP id mx1lYY7687511x5vg00M6Du2; Sun, 23 Jul 2023 19:05:06 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.55]) by mx.groups.io with SMTP id smtpd.web11.39351.1690164305602796443 for ; Sun, 23 Jul 2023 19:05:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNSsEfS65ymqEWD0qW63aw5hqSPozS9az6hU94J3j5SbXdSY0263gbVncM1L/7PXdPopYJk4JdLdv5bmxcBknyXGQpLW2Kl6IaO9cEl6WLLLTNrEaQWoZasFMWKco7XDwRcWnJVSfEslRO/+3//HzqldGoXOTQXsVVX7GaV1e95AVQIRlk3Zt7pmsn79hdWKKcNfQviMm7qK36jcm6xX/nwYawpNRwaM33bidjJkjckcKKAZ6AJASB1uTCtMlX6uz8mZKVE4S3timveoWWEHEMAocK+JjgCHm3fbNQtUCl348iHYMO1ruQVZLMfeblkDcNIDm75EH3/4fcv3MHmwbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAyFM0Kk8RORz1XjE3lyd+EHXa4pmN1F1WmFEDEW0ws=; b=XF4e7s52xkaHa18gnH6of144ILuIz/7tXA7XEws5YpH92OaEHKoDjhGpT9ZD0BHdZV5Ode/0rQ05RmVDV+yM656lYvpwV2Ed7YhclxSjalDhYz+h5uMZXhB5cnZc1eIscXgMfX/JzCk6CBJKdzPcZnq0t1ZfC2wTBBT9Jf9fqoe741hWHgXrdTOgpd74J6gMueG1uIqo99T+UmzXUob8EDInhiMWkZqvCcd30f8PZHtwF+oW5DvzPNtrS72Rjbv1lHqWpyLWKOQIullwrz4k5y0Lhyjemgxbfw1N0d5AzvQnmFv1I9oQUHzRXpkkK9t4UqVebSbhce89TjYEE6z91Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB8796.namprd12.prod.outlook.com (2603:10b6:510:272::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Mon, 24 Jul 2023 02:05:03 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e%7]) with mapi id 15.20.6609.031; Mon, 24 Jul 2023 02:05:02 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Topic: [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Index: AQHZvHUdvFiKLrr+V0SvhTogFMnsqq/ILZXQ Date: Mon, 24 Jul 2023 02:05:02 +0000 Message-ID: References: <20230722081826.301-1-nicklew@nvidia.com> In-Reply-To: <20230722081826.301-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=624e22f0-8e49-4ddb-b4e0-ffe8213d45da;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-24T02:04:58Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB8796:EE_ x-ms-office365-filtering-correlation-id: cc782a07-cea1-4c68-8c13-08db8bea648d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SsnmKYFJH6ssuc5KdVgxzFcVFm/KAabi7TtOVfwBQpSkjGmwsGRW8rdOkGcKF2taru0jXgcKo9K0zTy8GHE7Nt0Aa0dr2XwnVp2ICFzdllDPwUIlJXtCSWmxPClnpgkm//CGjXRu+UsZrEJPPsjc3es2PjKaCFOPOJW/mON2JxmTQm3OG8ADBC3gI/ZxzB3nrxwC8vM7umgAGiNY0L5FMQW7vqzZiBCgFgBwe8qC7ozJpWD2lilsE9qEpGDE747EDgmkiC4RR7uUQNopMBNfG7TaFk5s59rSO2ru8lVOY2ptLn6DNGNlUoTPw2n1+A9T7X2f7FriFH0kQ8cL4rWxz3L/qtU4v7Ru1nGBl1Vl0JV2ZRkaTwTO+qZ5BrPgwQ1h5c4iMuyHyh1NYFIiqA0+u7d2yZ3H8vjCgCYcnbXiZmQwEz/lJp6QiBcdpbWZK3xv8OtrFNV2GNeuApdpjPkx88gE+MjpOeFMkK9P8Czvje0GYNBeCOInUSP3F2xosuXXVTWq1dMZ9gBol9jPgZq+MSFANZxss5ITlPEdG+rm0zT9PrgtLuHP1LoN4rj8zQsWHgcrITWQR3O7/15rNtyAOCNZyeQs9wgbXXJJxA3Am5BS5njK6OfsbQnoHA3d5S0V x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xRxIUO+yPPREEx6nzx37XgpbZTfz8UQVzBv2sDBjC0r7x+JVEPcfHhLwp160?= =?us-ascii?Q?uokccpZQTXUpMg8F6uqNDtiIwQPlgKOKxW8uHKGeM28hiSohc8Zn+bvsbL+i?= =?us-ascii?Q?hd2X6Bm5htfglMhY5k+mPxGi8ZecUsPNIznOV65wEqBrNaumDHJgooQQZXwS?= =?us-ascii?Q?r3RGAbm5nbTyS3u0stnYyJz86NlIy2nM59uKd7w0RCXbN80ZoouzlulR8w2P?= =?us-ascii?Q?Z//5/GD1ANl0Gt5us3R/KIOvXH3Rv9WiI40rbDDJ6DDif8coM4YmYWyXRrpN?= =?us-ascii?Q?bGBEm/XciTpbodr7KMD0vDxpHqFiNzhg9RcM2tJXGm3ubY76gedCp4LJ33qT?= =?us-ascii?Q?B0z3/0Pri3+Hvq7QWZamm9S+HP9MoytgJnbZCuM3W9vONjqfG3ZcCLZC38b6?= =?us-ascii?Q?eq0ixqIm6vIDOxcecLI4y2AA9yp68rAyWSfOtEvA3RXlSjIy0FC2gVRz4XBU?= =?us-ascii?Q?d2JTAu0FcXC2NF+pgrXL2obp5ZtpRMscwd51dQTSn4mjXyayLl4VtTLfptSb?= =?us-ascii?Q?HG2gJmKnssxgwpKg3alzRWScd5KxkIk6nO3hWarLFT1/qyEUwARE4/+FdsBx?= =?us-ascii?Q?x9jpEnCiiCTffJPiZHaTQ1UDPTtS9UusscfVDp9IMnw1Q3DkCeemqS5Ogrwl?= =?us-ascii?Q?i22QGH7t5H76tDOwOBpAznG2xcETTh9dmokf6y/7DYFPsiqeDioqEVLjeTw0?= =?us-ascii?Q?e33rqiIXZBDvCZEUUo3MP+MiaKDy8wRl03ob7FikWiC+AbfsIKBTGJCknVJX?= =?us-ascii?Q?0qd/rmMi5g5SrvhcBjsOrqM9c9SR5AyKZKCET7nTGT7pZRZEWWYMnoCRR3Vl?= =?us-ascii?Q?DTM4bHx17yXa4dFgEF1LKZwXVAPDhk3lUafi1DpnWielHKvRf9fdP8F6/oXY?= =?us-ascii?Q?0T4x5jisB7tWigMrwseXQehqkN53v/GeK8WH5fnXOpHO7ZjmUFj4zWE8R8DN?= =?us-ascii?Q?CIq72PtS6SsbBN6P54gBi40WvJFAjd9BMGxgFkdCL5LNqF4JD8YiZ7qh5Cdf?= =?us-ascii?Q?RUaCsSFaiipolcxnasqflCdB9GvDdA3nEblbqrs0wCB4NzmPRFXKdU5t8ED7?= =?us-ascii?Q?gf2gLZidYmUqEbA0f0E0e8VN27iPor58L0qXfQjrUFrh6OCFoe1vCJDvUnDc?= =?us-ascii?Q?4ATFKm6t9BPgNOn2Mx0gnQsozw8hQG8pR3rwaVkyI8AUXHWQl7XZOOBid6bQ?= =?us-ascii?Q?UNd9k+Fqcs2Q/ERpccZyeOFW8n/yWqkJV68jZk8v65yjrjL3MdN3bZJI1h+3?= =?us-ascii?Q?wmu2P8MhNj2YXGXq8DwS+xBFE/867C5HJxXVw1om2EjCxNKjj4k0VsVH07FQ?= =?us-ascii?Q?RtzkMXnqIm+29Akr6Hvq3OqKb/nF30Pe1bAobCBic/TzbQXaZUoo8Rs62ZcY?= =?us-ascii?Q?A6HjBwQO04T6c80nn38jQsK2V1yDGihHpGwVISFdorrL8YMoGAiBmnNbc+YR?= =?us-ascii?Q?fGJcKojStHgTnTrTrlPaCNKafPQuYmCz/wuWWrakVizVBg7Uqltt3Mi6v9FE?= =?us-ascii?Q?C12A8+W/L7EJjikEhOCgWYWPE2KRZJmg7315exJkYdn2iIx9l8mPVz5Prr8B?= =?us-ascii?Q?Wz4MgPjT30xu8fiuj1I=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc782a07-cea1-4c68-8c13-08db8bea648d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2023 02:05:02.8378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y0dFDVYawCS+V089NUuHCgEico8V0yEDbH0+/q9kzERsoE0ZPrCO5xIFAjQB/d9u7so6Ouwmwz2djeGzT0dC2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8796 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: b4zBF2s8q9TuIQQPPo7PE3Tbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GXF6qUfm; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Saturday, July 22, 2023 4:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to > caller. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Return unsupported HTTP status code to caller so caller can handle > HTTP error status code. Current implementation only return EFI error > to caller. Without knowing the HTTP status code, caller has trouble > to handle HTTP request failure. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishRestExDxe/RedfishRestExProtocol.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > index 90973619f2bc..f11cee8542fb 100644 > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c > @@ -320,6 +320,18 @@ ReSendRequest:; > DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n")); > DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData- > >Response.StatusCode); > Status =3D EFI_UNSUPPORTED; > + > + // > + // Deliver status code back to caller so caller can handle it. > + // > + ResponseMessage->Data.Response =3D AllocateZeroPool (sizeof > (EFI_HTTP_RESPONSE_DATA)); > + if (ResponseMessage->Data.Response =3D=3D NULL) { > + Status =3D EFI_OUT_OF_RESOURCES; > + goto ON_EXIT; > + } > + > + ResponseMessage->Data.Response->StatusCode =3D ResponseData- > >Response.StatusCode; > + > goto ON_EXIT; > } > > @@ -444,11 +456,6 @@ ON_EXIT: > } > > if (EFI_ERROR (Status)) { > - if (ResponseMessage->Data.Response !=3D NULL) { > - FreePool (ResponseMessage->Data.Response); > - ResponseMessage->Data.Response =3D NULL; > - } > - > if (ResponseMessage->Body !=3D NULL) { > FreePool (ResponseMessage->Body); > ResponseMessage->Body =3D NULL; > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107153): https://edk2.groups.io/g/devel/message/107153 Mute This Topic: https://groups.io/mt/100292372/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-