[edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Nickle Wang via groups.io]

Return unsupported HTTP status code to caller so caller can handle
HTTP error status code. Current implementation only return EFI error
to caller. Without knowing the HTTP status code, caller has trouble
to handle HTTP request failure.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
 .../RedfishRestExDxe/RedfishRestExProtocol.c    | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
index 90973619f2bc..f11cee8542fb 100644
--- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
+++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
@@ -320,6 +320,18 @@ ReSendRequest:;
     DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n"));
     DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData->Response.StatusCode);
     Status = EFI_UNSUPPORTED;
+
+    //
+    // Deliver status code back to caller so caller can handle it.
+    //
+    ResponseMessage->Data.Response = AllocateZeroPool (sizeof (EFI_HTTP_RESPONSE_DATA));
+    if (ResponseMessage->Data.Response == NULL) {
+      Status = EFI_OUT_OF_RESOURCES;
+      goto ON_EXIT;
+    }
+
+    ResponseMessage->Data.Response->StatusCode = ResponseData->Response.StatusCode;
+
     goto ON_EXIT;
   }
 
@@ -444,11 +456,6 @@ ON_EXIT:
   }
 
   if (EFI_ERROR (Status)) {
-    if (ResponseMessage->Data.Response != NULL) {
-      FreePool (ResponseMessage->Data.Response);
-      ResponseMessage->Data.Response = NULL;
-    }
-
     if (ResponseMessage->Body != NULL) {
       FreePool (ResponseMessage->Body);
       ResponseMessage->Body = NULL;
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107141): https://edk2.groups.io/g/devel/message/107141
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Mike Maslenkin]

On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io
<nicklew=nvidia.com@groups.io> wrote:
>
> Return unsupported HTTP status code to caller so caller can handle
> HTTP error status code. Current implementation only return EFI error
> to caller. Without knowing the HTTP status code, caller has trouble
> to handle HTTP request failure.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  .../RedfishRestExDxe/RedfishRestExProtocol.c    | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> index 90973619f2bc..f11cee8542fb 100644
> --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> @@ -320,6 +320,18 @@ ReSendRequest:;
>      DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n"));
>      DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData->Response.StatusCode);
>      Status = EFI_UNSUPPORTED;
> +
> +    //
> +    // Deliver status code back to caller so caller can handle it.
> +    //
> +    ResponseMessage->Data.Response = AllocateZeroPool (sizeof (EFI_HTTP_RESPONSE_DATA));
> +    if (ResponseMessage->Data.Response == NULL) {
> +      Status = EFI_OUT_OF_RESOURCES;
> +      goto ON_EXIT;
> +    }
> +
> +    ResponseMessage->Data.Response->StatusCode = ResponseData->Response.StatusCode;
> +
>      goto ON_EXIT;
>    }
>
> @@ -444,11 +456,6 @@ ON_EXIT:
>    }
>
>    if (EFI_ERROR (Status)) {
> -    if (ResponseMessage->Data.Response != NULL) {
> -      FreePool (ResponseMessage->Data.Response);
> -      ResponseMessage->Data.Response = NULL;
> -    }
> -
This doesn't make code cleaner.
What about resource deallocation after  AllocateZeroPool (sizeof
(EFI_HTTP_RESPONSE_DATA)) for the common case?
I guess this resource deallocation was added for this and there are a
lot of 'goto ON_EXIT;' after original AllocateZeroPool call.
I would suggest to remove this `if (EFI_ERROR (Status)) {` block at all.
As I can see, the only callers of this function are
RedfishPkg//PrivateLibrary/RedfishLib/edk2libredfish/src/service.c and
edk2-redfish-client//RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c.
And both use the same pattern of an explicit response data
deallocation (RestConfigFreeHttpMessage() call)  in case of error
status returned.
I.e. caller is responsible for the response data deallocation as it owns it.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107142): https://edk2.groups.io/g/devel/message/107142
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Nickle Wang via groups.io]

Hi Make,

> I would suggest to remove this `if (EFI_ERROR (Status)) {` block at all.

Are you suggesting to not release "ResponseMessage->Body"[1] while error happens because caller will handle this too?

[1]: Line 452 - 454 at: https://github.com/tianocore/edk2/pull/4672/files#diff-18a31a76c495b9a145b0ffa6a68fe5de887cbdddc925c5eb3a759e81694f59c9L452

Thanks,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, July 22, 2023 8:09 PM
> To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>;
> Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> status code to caller.
> 
> External email: Use caution opening links or attachments
> 
> 
> On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io
> <nicklew=nvidia.com@groups.io> wrote:
> >
> > Return unsupported HTTP status code to caller so caller can handle
> > HTTP error status code. Current implementation only return EFI error
> > to caller. Without knowing the HTTP status code, caller has trouble to
> > handle HTTP request failure.
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: Nick Ramirez <nramirez@nvidia.com>
> > ---
> >  .../RedfishRestExDxe/RedfishRestExProtocol.c    | 17 ++++++++++++-----
> >  1 file changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> > b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> > index 90973619f2bc..f11cee8542fb 100644
> > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> > @@ -320,6 +320,18 @@ ReSendRequest:;
> >      DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n"));
> >      DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData-
> >Response.StatusCode);
> >      Status = EFI_UNSUPPORTED;
> > +
> > +    //
> > +    // Deliver status code back to caller so caller can handle it.
> > +    //
> > +    ResponseMessage->Data.Response = AllocateZeroPool (sizeof
> (EFI_HTTP_RESPONSE_DATA));
> > +    if (ResponseMessage->Data.Response == NULL) {
> > +      Status = EFI_OUT_OF_RESOURCES;
> > +      goto ON_EXIT;
> > +    }
> > +
> > +    ResponseMessage->Data.Response->StatusCode =
> > + ResponseData->Response.StatusCode;
> > +
> >      goto ON_EXIT;
> >    }
> >
> > @@ -444,11 +456,6 @@ ON_EXIT:
> >    }
> >
> >    if (EFI_ERROR (Status)) {
> > -    if (ResponseMessage->Data.Response != NULL) {
> > -      FreePool (ResponseMessage->Data.Response);
> > -      ResponseMessage->Data.Response = NULL;
> > -    }
> > -
> This doesn't make code cleaner.
> What about resource deallocation after  AllocateZeroPool (sizeof
> (EFI_HTTP_RESPONSE_DATA)) for the common case?
> I guess this resource deallocation was added for this and there are a lot of 'goto
> ON_EXIT;' after original AllocateZeroPool call.
> I would suggest to remove this `if (EFI_ERROR (Status)) {` block at all.
> As I can see, the only callers of this function are
> RedfishPkg//PrivateLibrary/RedfishLib/edk2libredfish/src/service.c and edk2-
> redfish-
> client//RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c.
> And both use the same pattern of an explicit response data deallocation
> (RestConfigFreeHttpMessage() call)  in case of error status returned.
> I.e. caller is responsible for the response data deallocation as it owns it.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107517): https://edk2.groups.io/g/devel/message/107517
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Mike Maslenkin]

Yes. I suggest not to release ResponseMessage->Body

There is a function RestConfigFreeHttpMessage releasing Message->Body
as well as Message->Data.Response
https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L134

called from:
https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L555
https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L734
https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L921
https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L1080

So I guess RestConfigFreeHttpMessage() makes a proper resource
deallocation otherwise patch introduces
a memory leak for error handling path, for example here:
https://github.com/tianocore/edk2/blob/master/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c#L429
and
https://github.com/tianocore/edk2/blob/master/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c#L364
and so on.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107529): https://edk2.groups.io/g/devel/message/107529
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Nickle Wang via groups.io]

Hi Mike,

Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance.

Thanks,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, August 3, 2023 6:16 PM
> To: Nickle Wang <nicklew@nvidia.com>
> Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor
> Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> status code to caller.
>
> External email: Use caution opening links or attachments
>
>
> Yes. I suggest not to release ResponseMessage->Body
>
> There is a function RestConfigFreeHttpMessage releasing Message->Body as well
> as Message->Data.Response
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=05%7C01%7Cni
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UWjhhvnVOQAF6TwHrjD%2FUxq
> zvmKXviZDa%2FW6iyDZyC8%3D&reserved=0
>
> called from:
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=05%7C01%7Cni
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4KQJiTuPrYeiLHpe0IL5mxTG04n
> m5W7nwPSPeE1MNoo%3D&reserved=0
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=05%7C01%7Cni
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pPYswuNST%2BrOjNgSbfWVtGSF
> G4OV%2BuIiy69Pb1VlxHg%3D&reserved=0
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=05%7C01%7Cni
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l162YPCSVbXo%2Fz0tyC7WVK1Z
> I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=0
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=05%7C01%7Cn
> icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w%2BsMb1C313iW3mAyd61r%2
> BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=0
>
> So I guess RestConfigFreeHttpMessage() makes a proper resource deallocation
> otherwise patch introduces a memory leak for error handling path, for example
> here:
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> %2FRedfishRestExProtocol.c%23L429&data=05%7C01%7Cnicklew%40nvidia.com
> %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%7C%7C&sdata=kh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D
> &reserved=0
> and
> https://github.co/
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> %2FRedfishRestExProtocol.c%23L364&data=05%7C01%7Cnicklew%40nvidia.com
> %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%7C%7C&sdata=Oa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd%
> 2FE%3D&reserved=0
> and so on.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108779): https://edk2.groups.io/g/devel/message/108779
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Mike Maslenkin]

Hi Nickle,
patch looks good to me.

You can add my acked-by/reviewed-by if you wish.

Thanks,
Mike.

On Mon, Sep 18, 2023 at 4:15 PM Nickle Wang <nicklew@nvidia.com> wrote:
>
> Hi Mike,
>
> Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance.
>
> Thanks,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, August 3, 2023 6:16 PM
> > To: Nickle Wang <nicklew@nvidia.com>
> > Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor
> > Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> > status code to caller.
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Yes. I suggest not to release ResponseMessage->Body
> >
> > There is a function RestConfigFreeHttpMessage releasing Message->Body as well
> > as Message->Data.Response
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UWjhhvnVOQAF6TwHrjD%2FUxq
> > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=0
> >
> > called from:
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4KQJiTuPrYeiLHpe0IL5mxTG04n
> > m5W7nwPSPeE1MNoo%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pPYswuNST%2BrOjNgSbfWVtGSF
> > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=05%7C01%7Cni
> > cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l162YPCSVbXo%2Fz0tyC7WVK1Z
> > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=0
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2F
> > RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=05%7C01%7Cn
> > icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w%2BsMb1C313iW3mAyd61r%2
> > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=0
> >
> > So I guess RestConfigFreeHttpMessage() makes a proper resource deallocation
> > otherwise patch introduces a memory leak for error handling path, for example
> > here:
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > %2FRedfishRestExProtocol.c%23L429&data=05%7C01%7Cnicklew%40nvidia.com
> > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > 000%7C%7C%7C&sdata=kh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D
> > &reserved=0
> > and
> > https://github.co/
> > m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > %2FRedfishRestExProtocol.c%23L364&data=05%7C01%7Cnicklew%40nvidia.com
> > %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > 000%7C%7C%7C&sdata=Oa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd%
> > 2FE%3D&reserved=0
> > and so on.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108831): https://edk2.groups.io/g/devel/message/108831
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Nickle Wang via groups.io]

Thanks, Mike! I will add your acked-by to commit message and merge it.

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, September 19, 2023 9:54 PM
> To: Nickle Wang <nicklew@nvidia.com>
> Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor
> Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> status code to caller.
>
> External email: Use caution opening links or attachments
>
>
> Hi Nickle,
> patch looks good to me.
>
> You can add my acked-by/reviewed-by if you wish.
>
> Thanks,
> Mike.
>
> On Mon, Sep 18, 2023 at 4:15 PM Nickle Wang <nicklew@nvidia.com> wrote:
> >
> > Hi Mike,
> >
> > Sorry for my late response. Version2 is here:
> https://edk2.gro/
> ups.io%2Fg%2Fdevel%2Fmessage%2F108778&data=05%7C01%7Cnicklew%40nvi
> dia.com%7Cd4cfd7e420c14ae5270508dbb917e83c%7C43083d15727340c1b7db
> 39efd9ccc17a%7C0%7C0%7C638307284588970555%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C3000%7C%7C%7C&sdata=SHMWZdAFfWkX8OoWFC1AVHNR3QpaMopnrr
> iSimMW59E%3D&reserved=0 Please help me to review it while you have chance.
> >
> > Thanks,
> > Nickle
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Thursday, August 3, 2023 6:16 PM
> > > To: Nickle Wang <nicklew@nvidia.com>
> > > Cc: devel@edk2.groups.io; Abner Chang <abner.chang@amd.com>; Igor
> > > Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe:
> > > return HTTP status code to caller.
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Yes. I suggest not to release ResponseMessage->Body
> > >
> > > There is a function RestConfigFreeHttpMessage releasing
> > > Message->Body as well as Message->Data.Response
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2
> > > F
> > >
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L134&data=05%7C01%7C
> > > ni
> > >
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > >
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > >
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UWjhhvnVOQAF6TwHrjD%2FUxq
> > > zvmKXviZDa%2FW6iyDZyC8%3D&reserved=0
> > >
> > > called from:
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2
> > > F
> > >
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L555&data=05%7C01%7C
> > > ni
> > >
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > >
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > >
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4KQJiTuPrYeiLHpe0IL5mxTG04n
> > > m5W7nwPSPeE1MNoo%3D&reserved=0
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2
> > > F
> > >
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L734&data=05%7C01%7C
> > > ni
> > >
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > >
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > >
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pPYswuNST%2BrOjNgSbfWVtGSF
> > > G4OV%2BuIiy69Pb1VlxHg%3D&reserved=0
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2
> > > F
> > >
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L921&data=05%7C01%7C
> > > ni
> > >
> cklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > >
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > >
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l162YPCSVbXo%2Fz0tyC7WVK1Z
> > > I4rvIEU%2F%2FdX79E8w8mY%3D&reserved=0
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FPrivateLibrary%2
> > > F
> > >
> RedfishLib%2Fedk2libredfish%2Fsrc%2Fservice.c%23L1080&data=05%7C01%7
> > > Cn
> > >
> icklew%40nvidia.com%7C2da77c0b5cd947e5509808db940ac84a%7C43083d157
> > >
> 27340c1b7db39efd9ccc17a%7C0%7C0%7C638266546261240909%7CUnknown
> > >
> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w%2BsMb1C313iW3mAyd61r%2
> > > BVKLUkHO5%2BfdROfdT6dkgUU%3D&reserved=0
> > >
> > > So I guess RestConfigFreeHttpMessage() makes a proper resource
> > > deallocation otherwise patch introduces a memory leak for error
> > > handling path, for example
> > > here:
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > >
> %2FRedfishRestExProtocol.c%23L429&data=05%7C01%7Cnicklew%40nvidia.co
> > > m
> %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > >
> cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > >
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > >
> 000%7C%7C%7C&sdata=kh65FknkTo6LcogwQ4fjIPjaFL6Cv6rv%2FtrO2njgxzg%3D
> > > &reserved=0
> > > and
> > > https://gi/
> > >
> thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd4cfd7e420c14ae52
> 70
> > >
> 508dbb917e83c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63830
> 7284
> > >
> 588970555%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMz
> > >
> IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MXEihUGlfH
> net
> > > Zatuho2yPpunOvXT57ZQ2352oqESXk%3D&reserved=0
> > >
> m%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FRedfishPkg%2FRedfishRestExDxe
> > >
> %2FRedfishRestExProtocol.c%23L364&data=05%7C01%7Cnicklew%40nvidia.co
> > > m
> %7C2da77c0b5cd947e5509808db940ac84a%7C43083d15727340c1b7db39efd9c
> > >
> cc17a%7C0%7C0%7C638266546261240909%7CUnknown%7CTWFpbGZsb3d8eyJ
> > >
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> > >
> 000%7C%7C%7C&sdata=Oa8dIM9YxGdtkM60HiwgpoOqKPT9YaJms%2BE3RIlZd%
> > > 2FE%3D&reserved=0
> > > and so on.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108836): https://edk2.groups.io/g/devel/message/108836
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Saturday, July 22, 2023 4:18 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to
> caller.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Return unsupported HTTP status code to caller so caller can handle
> HTTP error status code. Current implementation only return EFI error
> to caller. Without knowing the HTTP status code, caller has trouble
> to handle HTTP request failure.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  .../RedfishRestExDxe/RedfishRestExProtocol.c    | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> index 90973619f2bc..f11cee8542fb 100644
> --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
> @@ -320,6 +320,18 @@ ReSendRequest:;
>      DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n"));
>      DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData-
> >Response.StatusCode);
>      Status = EFI_UNSUPPORTED;
> +
> +    //
> +    // Deliver status code back to caller so caller can handle it.
> +    //
> +    ResponseMessage->Data.Response = AllocateZeroPool (sizeof
> (EFI_HTTP_RESPONSE_DATA));
> +    if (ResponseMessage->Data.Response == NULL) {
> +      Status = EFI_OUT_OF_RESOURCES;
> +      goto ON_EXIT;
> +    }
> +
> +    ResponseMessage->Data.Response->StatusCode = ResponseData-
> >Response.StatusCode;
> +
>      goto ON_EXIT;
>    }
>
> @@ -444,11 +456,6 @@ ON_EXIT:
>    }
>
>    if (EFI_ERROR (Status)) {
> -    if (ResponseMessage->Data.Response != NULL) {
> -      FreePool (ResponseMessage->Data.Response);
> -      ResponseMessage->Data.Response = NULL;
> -    }
> -
>      if (ResponseMessage->Body != NULL) {
>        FreePool (ResponseMessage->Body);
>        ResponseMessage->Body = NULL;
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107153): https://edk2.groups.io/g/devel/message/107153
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

[Igor Kulchytskyy via groups.io]

Reviewed-by: Igor Kulchytskyy  <igork@ami.com>

-----Original Message-----
From: Nickle Wang <nicklew@nvidia.com>
Sent: Saturday, July 22, 2023 4:18 AM
To: devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Return unsupported HTTP status code to caller so caller can handle
HTTP error status code. Current implementation only return EFI error
to caller. Without knowing the HTTP status code, caller has trouble
to handle HTTP request failure.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
 .../RedfishRestExDxe/RedfishRestExProtocol.c    | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
index 90973619f2bc..f11cee8542fb 100644
--- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
+++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c
@@ -320,6 +320,18 @@ ReSendRequest:;
     DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n"));
     DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData->Response.StatusCode);
     Status = EFI_UNSUPPORTED;
+
+    //
+    // Deliver status code back to caller so caller can handle it.
+    //
+    ResponseMessage->Data.Response = AllocateZeroPool (sizeof (EFI_HTTP_RESPONSE_DATA));
+    if (ResponseMessage->Data.Response == NULL) {
+      Status = EFI_OUT_OF_RESOURCES;
+      goto ON_EXIT;
+    }
+
+    ResponseMessage->Data.Response->StatusCode = ResponseData->Response.StatusCode;
+
     goto ON_EXIT;
   }

@@ -444,11 +456,6 @@ ON_EXIT:
   }

   if (EFI_ERROR (Status)) {
-    if (ResponseMessage->Data.Response != NULL) {
-      FreePool (ResponseMessage->Data.Response);
-      ResponseMessage->Data.Response = NULL;
-    }
-
     if (ResponseMessage->Body != NULL) {
       FreePool (ResponseMessage->Body);
       ResponseMessage->Body = NULL;
--
2.17.1

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107154): https://edk2.groups.io/g/devel/message/107154
Mute This Topic: https://groups.io/mt/100292372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-