From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 021C5740035 for ; Mon, 2 Oct 2023 02:56:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pTiPoL8BjwSxTunLy8JT3H993Dmh/EtrEzErV3ZQWZE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696215400; v=1; b=LOWbXTjJVsE4A9tLdHT5nCx/kQodRgO4/MrzaazbNjWqpNSkQNUT5E6A7KDfQ2hqmKOvOgpw ob6D0rLYbjhpSIBkM+KAG3hB4CSj+C+73CgmZRnFdQUfo0KzT4RFApA/v4yGExyybkJUqjFlvTV Zj/TosTkT+IBAi6UrDz0tblQ= X-Received: by 127.0.0.2 with SMTP id PWw4YY7687511xGKX7AcoyuJ; Sun, 01 Oct 2023 19:56:40 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.58]) by mx.groups.io with SMTP id smtpd.web11.74040.1696215399755204564 for ; Sun, 01 Oct 2023 19:56:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OSSG6K2K0+Qf7QDR/rwZSaDQHgutnH2n7rFQtrqDM2HU1w0W3ImFYrraj4HK/yIeys1BSlV023UijQMg+7NkncyIv5c2xZgQvabaTY9jwSgO0rsMZ3qKypzep8k4xJAU7eTfiX75a+XXt+VF9EFYZ4MasUUnmXUCv/Sz2nA+jRVsa1uty2rfqc0wRXcVsE6z2isGYrW1vSONjC+8NFeJv2tHs8FfUVmv+ocle3Vhie1/UshKEHubNrGQyzlLj9WDqeKH3mPMTMG/XvKxP2yjuKaFGPJrnZi4leOaDs/DNZxEeuvKTukLgSOEhTHLYm4mMCft+35jVSR9KGq7oL1lqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZNVXv/Dh/YD0WOBk1jiorqI7f1RCoUMOM8Tp/fMnf8=; b=aLtiiJ/PRQ286VBvjWI7uawLpbA2U/iAPU0XoPUSApCkb7mBMDGEVpAerD8mLWRMYUU+SFS+uIa+NfceaEs3BKo7t95n6F0dRM3X7/aSD0mViHyElQRH9z14EJuAwmN6JMIwKm24Bnerb8en+8yagEb1CViZ7ewietsjG8gCzLVO5TvabULI6RYiE36dj/dN+m5mDNtZ5skdR6hzbKcyS1C45HThTsf0TPW+fJrgo6eE1Z86jK9JgpFe51oOU8Vh/KUPTG4UEgLbBX5RVaJr/7Pha/SprP0nt4uEvW0/SKZBS9U3Oe6iZF9uHJdqd/bCnD2w1LinL59MFLI7RuEdwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB5518.namprd12.prod.outlook.com (2603:10b6:5:1b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.30; Mon, 2 Oct 2023 02:56:36 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:56:35 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments Thread-Topic: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments Thread-Index: AQHZ8yA59013FBz6dkOLy8bL0SorRbA10R2Q Date: Mon, 2 Oct 2023 02:56:35 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-10-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-10-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e1cf003c-07a4-4477-aea9-8b88dce48cc3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:53:55Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB5518:EE_ x-ms-office365-filtering-correlation-id: 7a0fc092-4384-4cd3-eab2-08dbc2f33108 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: xVEhA+XsEIhEHYRwUtzI6uX4AvBbzFZvfBxqF3gpCBtkocVG2oK6cql6F40UeGdBIlVIqAjRXHNI5WUo4JmgukSjTCAhYpXLW3+JtRi7/+BbAeOggcOl7rRTeun7/KDF6EPZywk2zrlMxGxaMr4AAPItXFCIrCvZKRn0eVxYzRsdGMAQ1mQYDo/9GFxYTF1HZ6uwCthHq/uJNKlAv1JLXRoX35G1OhaKIyecNsQcx72MYHgTfxX8FGow9/tTec43v/6u+hiFTIpkPE7vfFehjNQomg2MghQIFvEYmnGjLLmOF+rQzm8xhh3+4qdumEmKHOCQPEkMNVD7XWKgbyZrftG9MNvn4Kz1PFHVTDCNd5EtnmC2MIbQPIJzEdqODkCUqtB4edrhQ7FodAZknsRL58L+vc5h9Cv7epoPrAFchrFoZz/uUUFrw+M7CbMTkiDGSCqxQ3VjXARRNWfoT7zuicPX8aLJAqjGLoaY64BRqOJK+GKR1xFAlKMT+GINEkMpVXM0/Dblsuz0ei6yGO50cWhmjFmjyQYj5plHC9yL78BM+vRnLUeCBja/PRQx806F3TZn0i9hTrph77w8nQt8meuI/qD3VRDHKBBQTydQlJolV1qd/LWCdxvvx8Lf0PVL x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YUWwqeuqf3c/NseNtSbGZxxm6OX6Yz+NLdB5maEx8hc5A7xgq1+MnrpJB4kW?= =?us-ascii?Q?I0y6GuqrIxkH3v/oVXRh3kkRPwchS+DLuoIw2qfFMgdK5ybv1YMf9AKzKsH1?= =?us-ascii?Q?4OJliB4EsM/Bm+Ra45E67iqXdm1HCjl3mzX0wKHrs5yCzN0eiQyB99H6ierf?= =?us-ascii?Q?6+zopnnLYcCNXABnxjf89E07JYWB77wzl/gtspU8pRiZpVb5aI6UnMK69sTu?= =?us-ascii?Q?ZsbefRucvd9y7cnWQPnGYL0XwR4vpZf+N9wN+440A+HwZ+yQZqyBGgXuMslJ?= =?us-ascii?Q?KQku+D1+67uCbBPpVj5y9KDrEEbCjZ138U2GcZIUBwj+iGIyEpcimxjo5R2Z?= =?us-ascii?Q?4QxFmLj/2h/0UmskboPH4PjyqgU1t9q8rBLUrwehNV+aHxYxtuK63R8BJf1i?= =?us-ascii?Q?JVL+NE36y55gpuc3itL2w3NDvKddlOWOmACG1hSIp3QgBL86uErgedQHd7MK?= =?us-ascii?Q?7aEEyw+HbTZzpAdjJhUF/MKs89JLetm9dnB9uOPo+KJ9ntlj8NOcdCxmps+O?= =?us-ascii?Q?SfvQPbMN0TW89d6Psf+I4NTDViULFTdaVEC4ILJJ9TvlDX5EGYr1O/Qldh4n?= =?us-ascii?Q?zlZyBXZEyHuB6DFrWT/lwIh2aYpjmZdXggRYZm5a3f8HnS6ncARAHe185TZL?= =?us-ascii?Q?h6hYwn+SZ5FGWhSHf9tCZpVUjeviyjlTWQWaDFHV7FO3cvHcY6KUOXjCTO2K?= =?us-ascii?Q?oae3nJzkNqo0RDZTpbGj2T3noSTqtXAzeZFEzQC/C0zG+v6AFMFj8Bxr+aow?= =?us-ascii?Q?9wosZRVr71/yC2BhU98jO/nLQ1VgiGHUR258J/8CvkotzvAJYFTO1ihth6Hl?= =?us-ascii?Q?8RV+197SaeQFh+JX76v0gejdMQfPCiN2gsI63yomrKED9WJuJ9bsHu+5o53q?= =?us-ascii?Q?gF0UlMMH0qg7atjBSUr29qLnLK5rdZezAAmgdX0QjNHY/l8VcTPj3CMdI9hf?= =?us-ascii?Q?txUO7E4gURr1SGSsSopcXllCp29QVCiLoTZ+fl4KmChVTFlynxJfOQ+rZj6Y?= =?us-ascii?Q?OU4qi7AXgtAzETfdTB4HqfUpTsKD97vtg4Cv2TJa2GaDFc3TbenGuCZKjDm1?= =?us-ascii?Q?iZ2AO1eQCmPMTwM146b9xnQihdlGZVUjwWyHKPIIkYoV7pKvzxG1RmQwWUat?= =?us-ascii?Q?ykdlPKqsuQVFfAQkylLR7F/gg5SgREQMU4lNedIR3dUr9pOoNeczi2/986fM?= =?us-ascii?Q?7+xuPUZRGjxH9K4pWWc9wZuGDNbbPFkcxlLeIh8QYEINuAXgkUStWQzGjyb+?= =?us-ascii?Q?xiQahzpWf8LBGwHV2ySbSW7cMW4U7MHbHRc9BK/w2pOBddKoZ+38+PhKaDAX?= =?us-ascii?Q?9SGPCvZyesUwI52YY3e8ncOAa11uN9Hjivyh9NlbS0/28hIQlGpdVig0ftbQ?= =?us-ascii?Q?DTGjNgQsq9IESZi89Fqd03iUbPqv79IaamJwQdGTl9OHvYPNYilA1t6wCOEe?= =?us-ascii?Q?PMqGaBSmWmWGGUGxwnavqe+OJl3OZ2i5b1HSxtMm39p/AjMyN55BHUmLT4jh?= =?us-ascii?Q?bE0Q4Y7uGokyk1HqqWhcS/dL+pCPA5fRzW7ZpoZWXRFr/9Hi7royDoc55PPt?= =?us-ascii?Q?GYSrJxQQql4eaXk3vPE=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0fc092-4384-4cd3-eab2-08dbc2f33108 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:56:35.8471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GZebf7Ru6HRuAHEVjGx7EBzTbKkWFOrEaEbFe9lW5hpV0+/L/xi+k48ryZd1rPtPcPpgKkLhI7ar09Z9XFUNCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5518 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: I9Nv8OtgfbpBMvNYn3GSBWWlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LOWbXTjJ; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > StrnCpyS accepts string length in characters, not in bytes. > > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe= .c > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > index 8ac165dec59e..c19d4a46d6af 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > @@ -331,7 +331,7 @@ NewInternalInstance ( > } > > > > NewInternalData->NodeName =3D AllocateZeroPool (StrSize (NodeName)); > > - StrnCpyS (NewInternalData->NodeName, StrSize (NodeName), (CONST > CHAR16 *)NodeName, StrLen (NodeName)); > > + StrnCpyS (NewInternalData->NodeName, StrLen (NodeName) + 1, (CONST > CHAR16 *)NodeName, StrLen (NodeName)); The original code is already the size of string that includes NULL terminat= or. However, we should check if NewInternalData->NodeName is NULL or not be= fore copying the string. Mike, could you please help to add this check? Thanks Abner > > NewInternalData->SiblingList =3D NULL; > > NewInternalData->ChildList =3D NULL; > > if (NodeIsCollection) { > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109249): https://edk2.groups.io/g/devel/message/109249 Mute This Topic: https://groups.io/mt/101667469/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-