From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.53]) by mx.groups.io with SMTP id smtpd.web10.8614.1683076387767125658 for ; Tue, 02 May 2023 18:13:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=qDIqMLpK; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.53, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fImBLZ4R06Q6dVijr415pts+t1rY5fuDpxwZVGaBdZkoK4wQGy9D3kdm2XnQoLwUjPK+qXH2HDB5PqbkgEzck8fvR65CEUDrbZAICrddKCHSjBZ6lYy5KFB0Qq02WZKozEFqIBVHMI29RwaNkRtKC3jTox1lr/PVd163YnEnN7vDuC62HGtmddWO6n+BnbWZdJTOhdJGVC2xfLKpqvBfLuLfmXuQVfAkoiL7EHq+hyUmuR6sNXcdAurr2tEB2ZSg8CLbuEru05ZIEsPhp6BLBe6nSv34nJWyvRv6lfEfDmPEvkQRAGladBtSpd7K69aKstuOtPHmnumIpd+bOszcjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sau1T8KbT5MlxRQaMCi+jwUlWOTWo2FI8yB7ALQvXMk=; b=HvNPOYvA+njWfyLsJsUs16CWdV0WS7Pu2mQYOzdqUAoQc3MnQybLz/qD4kxMG7b0721cOfw3knxsoiqYNxWziLcHugM8Kbd8hthr3jqvyKgV8x4AHR4ljkDWPa+u/uAwYZ7VXYhkKJOGVFY+/WYDHH18vl7yPP4Y98rjoQUwaHR7j8gwJv9mno9Zs9SWR5icD9KNWQaVoVgMX5MtGKF7lNXGymjbHXWzKYTet3XltyTTxP3rfbiFUtEHlWJZA4+bz98fTGILw+kHHM5Xp2p4IL0J0vXnEmVVJqV5mNL9A0nrP9ZNvzpDAjDNQ1H4IFzyXom463cRFDTj706AjFMWuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sau1T8KbT5MlxRQaMCi+jwUlWOTWo2FI8yB7ALQvXMk=; b=qDIqMLpKJSIo4TM4Y73QJMaobn+MhQ4u6vsrzVb8Kcgt/LtDLRwfXUFoL3AJ+VNnQbjYvZDbBxhI38wLZo4IXbVUIPTdiJfkimYv0a2OZxF0n5Ut3hVS1QH/ZtFu89LM2uyRYtIbSUHOPDdNxsP9+X7ggVQ2qqbuTzWXaQi5FJk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5149.namprd12.prod.outlook.com (2603:10b6:5:390::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.20; Wed, 3 May 2023 01:13:05 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 01:13:05 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF Thread-Topic: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF Thread-Index: AQHZfR6M/sNp5mxZG0iUOeBtgvOwt69HvnkA Date: Wed, 3 May 2023 01:13:05 +0000 Message-ID: References: <20230502174926.2016955-1-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230502174926.2016955-1-tinhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-03T01:13:04Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6b8c57fe-28fe-4ed5-942c-9cfbf6dc4908; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5149:EE_ x-ms-office365-filtering-correlation-id: 846574eb-61e7-447b-32f9-08db4b738cbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H1mqcYk7MfB+pH5CXz0qa1QlgO73R+yDzqgKqG9xdnp4aoHbmjeeOWdIYFTqTsAY8y0tlu4YgXXferDU193ptzT0dUkjR1idPizK5uVrpFzU6ginzUX2SrzzN192opp1Hxdgc1i25NggHPeamewTBL0Bg6mgF9ovoqjtnA45VEsFeb4jVh+aN07DUUleIstx+2DLznq66HeZGUcretpzibvZrNhVuX5yeWsVkqz/dPb9YhJtBmflWU0eerdlYdR0j0rLFPRFJoTnhXkSSUqhAshNEwVzhESErAzmywy3wW99t5W1PeIxa0JfqOTcf7IuXiUkwFd2Cwga9ZoFI0clEeUducw/aWB+z/kGWGeAvqD/WvVqejDOcIBw/JIu4OvDYtEI7zgMzgFRE56JFUwgaBK83sdPDAchgkBowNNEHDSfRlW+MkJFPRVRBNcwcg63H18uFwHMRI42p4Yj91Ut4AVf7OEV3bSbaxhX5dND/38HlfGCTJNHxuOk8aSY6hmGJKwVCqJzodZir0BMzbG3WUuqVBfyXcA7OkKeuJYJGaE+swQKE6yhjTJ6yX9p3B3MwgEwI6MQGo/T7/5EYTlXu9EyFskbk7wbgGXi6+HFBmo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(451199021)(122000001)(2906002)(38100700002)(8936002)(5660300002)(52536014)(33656002)(86362001)(55016003)(8676002)(38070700005)(478600001)(110136005)(54906003)(6506007)(26005)(9686003)(53546011)(7696005)(186003)(83380400001)(71200400001)(966005)(76116006)(66476007)(66446008)(4326008)(66556008)(64756008)(41300700001)(66946007)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oGsaEzwxoXu/n6l0tqHZ64hf8A5XK6gbHfTZlqw5c4K41wZjlYeVQ79cq6AR?= =?us-ascii?Q?POvuVwpYBUD+lrH9+8iXuj3rMy4+eXBvIPJY3SbOgkNAwyq5QCIdghZMM/M/?= =?us-ascii?Q?l9BCtXkmXTKZl3hJX17KPUzLDEo1u5+Z1wwhkZ+MJhcxGPEJDmvPiKn+VwxP?= =?us-ascii?Q?eWl6T0W/HK2eWTOkC/yIrRVASvvkWqxiKzG2I0wT+gHMUle4K0C61ZzvZsTP?= =?us-ascii?Q?+OnjO1iPwEJ+Y6rYwdAwI6dZvHO3zxh+29KK2eYsnV10pzGzUkA23i2y/2uv?= =?us-ascii?Q?PyhDU7kTBoG6ewQHJdEdC77ZInDnvO4rWjllD5G69szaOyVDkNDtIUJ3ZCWD?= =?us-ascii?Q?oOb9io6x7gkFHGczFoDUnp3yeOnuKOM3efKQK2HNJAkHITcU84yw2mk/lELW?= =?us-ascii?Q?ey12u6bDlLhwP207nASRQwsKnJJ7p1oSZLiTOeFonuLJLJ7AYTiip1kWZsw5?= =?us-ascii?Q?SpH6iXXFwSPorfpWe9m43u39vrC01/KNXr8khXPDU7QgJpgeEssADWyeRkpm?= =?us-ascii?Q?CiKm05g8zo7EU/Tz5sNgzfnWAfRGVJT3Zf7KSalz0KlPJBYlaRfXHLqyB3OL?= =?us-ascii?Q?0+TrWHyJBAs57Tqjs3jComcbsOx9iQ8MeEGutdd/Cj/wUCR6KdaRbWTPieeR?= =?us-ascii?Q?T0ofD0FWG+KrjNAUmuOglzeks9DcER9iBmJa9fCafw7c3ix79uBSefFBOoxq?= =?us-ascii?Q?0OdyYVWTIf1B+DBcDlePwMq2RYucZnDyWHa1yb7mP5Sn5rlFCxxxSckZZKRR?= =?us-ascii?Q?F1BkU7kPdrrfM/Z4iYG1aVR+8bZOG3cxyqHvtrtSPDFie9VzR8lgngSvSAlQ?= =?us-ascii?Q?/KaN+33aTgUDTgCAivw3LmZCn5fB0mfR2iRYtEn7s80M1VBR7Mko79DmFX+Z?= =?us-ascii?Q?Zm/VCfDnX8s/Rmhkbxs5n1dDEcVQl0RoMDW4gKAQjA42F9kPfT5XRqsHHnWY?= =?us-ascii?Q?ZpGJPL5/fb4EOHBF9W6wPcOcZ80rrwR758cLZ9vpvXYyBKjGeFz/gY0Xv00I?= =?us-ascii?Q?gD1TDkAOHGoj6qhNgZ1f33lrVQg2vVVSEDt2aqtUfYLalDZipOMFrPdtwdh+?= =?us-ascii?Q?4m2I0c8K3FxfbacGmAOPHx70dCoUD/m6l7pSVs0mrxHgvwLWh43cxqVmYMAt?= =?us-ascii?Q?USK2jgPf0LjbESrgiIYov8adpUj27Mx/Ls2+jEM5Dbepl00bBd7ymJo3nG2m?= =?us-ascii?Q?5Nu9kpzII/nTNPbeySCMfLwAs726u/db/OPBDisjbccZ9pKmICUk30qN8/lv?= =?us-ascii?Q?KsVN4ADxJT+zcLO0XMlzu3ThfJrCwq+nQSrrGRGBKUPLcaUU1w3MP/hYxBIJ?= =?us-ascii?Q?D+yNJQK9QEVXkis5/3p1YKyP7Ez6m2MYYyYhd6aeKjIRZo30gIY6BhAQaKe3?= =?us-ascii?Q?OiCo17vHtbPh7zUmbnsf+N5+hoybRTJvFiuTJs4WMsRRqFYJLme8VdzVpGut?= =?us-ascii?Q?zMylnM5bgAGqb3eKWp0juLJuiz+13fQKXTe30vUU6Frbrty1KTJVU9uKuM7c?= =?us-ascii?Q?H6HKMPnziF8hCP5KWPA6BYWLBLSixkr8r5a+xiIFFZGdJulznwK+uxfghRPM?= =?us-ascii?Q?mYrwxtqB/DcEbdmwLsvGhaPuMEaoJCP6KfozpLV5?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846574eb-61e7-447b-32f9-08db4b738cbb X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 01:13:05.6874 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9rH8850rJue37UcjQ/zagxZclwfV3n0CCvnQmGYdK9lIXo1eXvWIlo1TgReejZQf+qWz31o1XYpQsfxIhVqO3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5149 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Acked-by: Abner Chang > -----Original Message----- > From: Tinh Nguyen > Sent: Wednesday, May 3, 2023 1:49 AM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > ; Tinh Nguyen > > Subject: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > This change adds new PCDs for IPMI SSIF. >=20 > Specification reference: > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > pmi-second-gen-interface-spec-v2-rev1-1.html >=20 > Signed-off-by: Tinh Nguyen > --- > MdePkg/MdePkg.dec | 26 ++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > 7488ccda7a00..b840092382cb 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -10,6 +10,7 @@ > # Copyright (c) 2022, Loongson Technology Corporation Limited. All right= s > reserved.
# Copyright (c) 2021 - 2022, Arm Limited. All rights > reserved.
# Copyright (C) 2023 Advanced Micro Devices, Inc. All righ= ts > reserved.
> +# Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2353,6 +2354,31 @@ > [PcdsFixedAtBuild,PcdsPatchableInModule] > # @Prompt IPMI KCS Interface I/O Base Address >=20 > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00 > 000031 >=20 > + ## This is SMBus slave address for the SSIF to the BMC. > + # The recommended value defined by IPMI specification is 0x20 (sectio= n > 12.12). > + # @Prompt IPMI SSIF SMBus slave address > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifSmbusSlaveAddr|0x20|UINT8|0x00 > 0000 > + 32 > + > + ## This is the maximum number of IPMI SSIF request retries. > + # The IPMI specification specified min value is 5 (section 12.17). > + # @Prompt Number of IPMI SSIF request retries. > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryCount|0x05|UINT8|0 > x000 > + 00033 > + > + ## This is the required interval for each IPMI request retry. > + # The IPMI specification specified a time range of 60ms to 250ms (sec= tion > 12.17). > + # The default setting is min. > + # @Prompt Time between IPMI SSIF request retries. > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryIntervalMicrosecond| > 60 > + 000|UINT32|0x00000034 > + > + ## This value is the maximum retries of an IPMI SSIF response # > + @Prompt Number of IPMI SSIF response retries. > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryCount|250|UINT8|0 > x000 > + 00035 > + > + ## This is the required interval for each IPMI response retry. > + # The IPMI specification specified min value is 60ms (section 12.17). > + # @Prompt Time-out for a response, internal > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond > |6 > + 0000|UINT32|0x00000036 > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## This value is used to set the base address of PCI express hierarchy= . > # @Prompt PCI Express Base Address. > -- > 2.40.0