From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 80228740034 for ; Tue, 26 Dec 2023 01:39:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=trTRgBmoq3ZevEpAWhR0yTHTy5/8GMhb9jTlqcN6rSw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703554760; v=1; b=Y7dR3s207jDUz/PvJptIRHeeUhEfXtWBYjd3gZXyb8l4gh/Z+uxZ172l+T4rjxL5WAl9PLdo Sq1EsTsoc4fSAMVRzvg0zBXoTWpA47oSffb0s41cnIkL8TCSZT7DRzQX/gHKD5dcqAaLR2mzUfS EOmlkY4gAtO5gzwkCnSQ1aHQ= X-Received: by 127.0.0.2 with SMTP id NB0XYY7687511xp94BDhvEf6; Mon, 25 Dec 2023 17:39:20 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.73042.1703554759108405647 for ; Mon, 25 Dec 2023 17:39:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JKFOOkcjFWCvu+/Bz36cbZlv6841tZPTGJPQrxKZK/6sQCgqB/x+96KsLzi9ajBD27tUcVwmi+N5ahKiLjFcWDrGXJpeqKzDMtiJGQlIVfM7xZFGAXYyXsutV1ilo60rMpDvfz8zL7qkEb6y7jSUsFWek5cxYVxQhZNeSgXJfFH0DvyijEQ+54M5HCYLaCumEhEtk6TIA1L07viC13YcGgEc9/zYe1TnCf8TagZEbg4Nz5q02QSV7V4zTS99F41tOLl6A2JUD3O1CLnd8N5LN8frKTQJgfU2YwWntUR3+9DqhljRRVuxYJKkO9zkPzph4xtzdpl2T/yCKET0lmmFjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZY6blpWaslHL2Jf53Ej66V1gvWL8Hb0VJKTx4JadB1M=; b=n+erUdC62EdKQgCGkXelhvIk9PLkhTgnr02Ys+Wjmi3HdVMFazyyuhIwgTrH+uvxtIPAg5i2zIwGfphEE6jsLAh+nhpJq4EJpeAkEhFO8j3qHV6sauiUrcZ1GUPTna7RXcagB53pU/aGgohubsP6ocncepcx7vhb2/vw75sByIkBSZL6kz0+hB+MjrC4+YbhNTZrmjk+Z2LihRYLz5fXh5JdGwSd/1ztK4lStUUygsBlpYD05k9NMY7Jpw15NGgmcC9/JmGBWfsiFF6rsRgWvhXPs82NMtyg1qx7wsKG3mH+38ZNP3bbLzyDy5g6SzmmbniiFOhlFr7OUleQEK+VFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CYYPR12MB8964.namprd12.prod.outlook.com (2603:10b6:930:bc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 01:39:15 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 01:39:15 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Topic: [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Index: AQHaNrzkifgbl+8E50iX8QdHjM9acrC6yytg Date: Tue, 26 Dec 2023 01:39:15 +0000 Message-ID: References: <20231224225927.9119-1-mike.maslenkin@gmail.com> <20231224225927.9119-17-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-17-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f655d703-02d4-404c-bffb-90be4e4abbe6;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-26T01:39:10Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CYYPR12MB8964:EE_ x-ms-office365-filtering-correlation-id: 4dd4f139-64bb-4e6a-aa27-08dc05b3781d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: gU7TTfzC+IVndydmnqvVMGU9MrHqvGqDr5sAQbDcceRA/EkIE8f6IioZPIuNF4JgM//BLFxQaujGAvFUKP4KT3ZYKgdQ7Rig7fNMXsZsqoTB8sQ6+OJQRi1QQ1AxtzdESM/tQ4duebeUU3x1snV7cA4UDtHZoJrcVtzXnzpKm2SHW8XZChwkAF57oKNsKmS/RmPjaRwxuEzCa2pRhL2zTkTf4/r97OIjgdj0Wpg9Q1cUQxX03MTlXX9Y+42JGKJcADmLsATMttaqklMlxWCiPLiIY6rYieRencbl38GqRfW0ty1BZgMneRReVCk4itOeXdxqM8CNljJHinF+nVNCKvfTo0WWkKy7z5dlN756p5mp4ltX+4fTlsUh2BK+wP19MsLeoQL7FQLIiNyVvQcdtmQb303HgXA3IIEIX1pJM+2ERy1mX98a9p1FIxV6KqqHhAOOP7+MsnRilNLZREAE6j2PsjA0vsVfGkyYDKHOBKdovG8ODYXb8BI5zsWBeEVU+38TnPdS3e/ICVeFmOsOVTFPZXLFFUAUuy9uTOL5t+xx6ZIyF63hhIU3S0hohfHWFzt6UgODTqe/52Q8JM/srWJot0CzaL41mRoSB6DXKGiTXxNvHMkWzJ2gWnc/tmk787NafhvZlM940j/ozMcDCJ4/crWnPxBWNqH+KuuoMh4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qg5pDc2/1O4iqC6s8iu8wBQrwyK2tVoqOZtHjVImi4ulL0HliKH3EBGZq/wB?= =?us-ascii?Q?7ui1o7AVdnY87zfdsJztBNF5kMHjfatuFygZAd9SNZOlB/QPTTWcV7Y5Lh3G?= =?us-ascii?Q?Y8Pan6itEfTa3Tjx2veI+YD4K0hO2Wi0O6y12WX3gSQW7DQJ2FRGxhCwE2bz?= =?us-ascii?Q?5vaLG4jpx+2aSH08KXJ2faZlZzb0qjQi12VN1i5KIo9htfK56hZx5UluaEbv?= =?us-ascii?Q?4m/y6prI7jKxg4MzZBLYnVgszcPK5fRC7CKFQ87o6zxb5dtEO0pxDfrG6cwn?= =?us-ascii?Q?yO2fg+XMJMkDRJy5MogfeqFx+xLus9T4TxYV/2+55g3cZtpa5BqapQLsN5Ia?= =?us-ascii?Q?YKzX4THNu40n+LGKzKnQmFzuU1L2Cvd+gt/7VdWGr18Xg/hxH1eoxS//sgO5?= =?us-ascii?Q?YcN1JZ8ocDg2wHGm1+H5QeWai1lGiE7RFzigIkbnWKhvfZFMNWlmp1W6j/Nh?= =?us-ascii?Q?3M1J+EsPFcdPZblXBwWFt6YNrmSqY/tp+axAIRezRRf5US7qejTyV9UCBSnR?= =?us-ascii?Q?B6znr7YMzR50LThIOvr0ABtpQjLRrUgWKu5jylD2VGOl+iBL5BgMSQVTnz0D?= =?us-ascii?Q?qL9J/CFWrfSdVVwXxdiVNjozo3VjZVhLzE/UBep6tXCBvntrQbYA/HUEo56G?= =?us-ascii?Q?nQihHK9SbBpZFgTvfi4VFzYFRzAWujwcybBxSNUkINopFivYl9EezQvEagTs?= =?us-ascii?Q?oZtHslsceYQASyr933K/5xCYigvUcXavzB7VO9xdUqG6xB4RclFzAbosJjkr?= =?us-ascii?Q?yQ2JASoS6Xvd7BHzQMSRE26oR1PKzGwIX+xokK4chhfNQfVZIooozyrJsK5N?= =?us-ascii?Q?AxdqzaWEPX8Lm1LJUgnGnoGoBqZE5oG3U8JE53YEGIIv8BU382dU5KLUs5a3?= =?us-ascii?Q?V5JpJFrdqJ9NSUycjuPv7pN4/Ugf3YQhtq0ax/kcodTxlrVKyykqJcSo0BKw?= =?us-ascii?Q?DyqSP6Ssk3SvEMwZKwGibttMxHCFJmJiJZs/LVMhrDL/56doput+ymoPZ+Hw?= =?us-ascii?Q?Zt4xwd2baN7avEeKsS6WSYeYem66pFMqBEAy+qTFd0YbykVta+ymDEM/Chh3?= =?us-ascii?Q?g04x/enV51xTMx4a/EFvIICci21jcE0Gty+oqQZiuHBwB/yGW9RaBSriKz4c?= =?us-ascii?Q?K7Sc7+7ns5K/+skKLYCwawCRbhaYDwlCNKv+kb7M3jC8Wz6Upz2MpcOXwt88?= =?us-ascii?Q?/O66xmS1MbgjFV+kGekRNaS09B4LZk1wSsC2ypEEFa+pnl6HYnlW9HRui4NO?= =?us-ascii?Q?Nl4zH7704MMY1N9ZyRa7eQVIK8o7rEdDZ+coQW3tALQfVKYAdi2iwSW8B2Hl?= =?us-ascii?Q?EA+xY5iR+DBg3EiHf89pBhZQvrbg+nyGmoqhX6VTyNLW/D95qVXEziSWei3i?= =?us-ascii?Q?SRKAiJO9EEpqFVwym677dmF1U9bXsk64utOgmZ6aitX5Qv0b+OfEgilWFQg0?= =?us-ascii?Q?4KrnFNRkhOijaNwbj3pwpprWALDOGhsgsc7TOYABlspRhk62JDfBHL5qxqDW?= =?us-ascii?Q?fX6i49RLEMcmS2hGG6vTxKKwUbCZJpuMtB86tnd3DsjfS+V6LgIOZ1Bl3ULF?= =?us-ascii?Q?RUU0x9Thw/VxRZf72yU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd4f139-64bb-4e6a-aa27-08dc05b3781d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 01:39:15.1930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n8k4L1kGpr16zj7r6PE3x3/e+67L/A+kreo+ofDt0DSgO8MR6yMUBNzZX1pyiWBA7YBbeWWReVycd+65Q3q1TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8964 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: blbJkDMRODwi9oLMHIc4gkn1x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Y7dR3s20; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Monday, December 25, 2023 6:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets= to > URI for IPv6 addresses > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > URI is generated based on the RedfishLocation containing an ASCII string > representing the IP address. So, in the case of IPv4 the canonical > representation of an IPv4 address was inserted into the resulting Unicode > string i.e: "http{,s}://X.X.X.X/". > > In the case of IPv6, to access resources, the IP address must be specifie= d > in brackets, i.e. the resulting string should look like: > "http{,s}://[X::X:X:X:X]/". > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 1022ab090df8..238039b57717 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -759,6 +759,7 @@ FreeInformationData ( > The function initializes particular strings into the structure instanc= e. > > > > @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION > > + @param[in] IsIpv6 Flag indicating IP version 6 protoco= l is used > > @param[in] RedfishVersion Redfish version. > > @param[in] RedfishLocation Redfish location. > > @param[in] Uuid Service UUID string. > > @@ -772,6 +773,7 @@ STATIC > VOID > > InitInformationData ( > > IN EFI_REDFISH_DISCOVERED_INFORMATION *Information, > > + IN BOOLEAN IsIpv6, > > IN UINTN *RedfishVersion OPTIONAL, > > IN CONST CHAR8 *RedfishLocation OPTIONAL, > > IN CONST CHAR8 *Uuid OPTIONAL, > > @@ -789,10 +791,20 @@ InitInformationData ( > } > > > > if (RedfishLocation !=3D NULL) { > > - AllocationSize =3D AsciiStrSize (RedfishLocation) * sizeof (C= HAR16); > > + AllocationSize =3D AsciiStrSize (RedfishLocation) * sizeof (CHAR16); > > + > > + if (IsIpv6) { > > + AllocationSize +=3D 2 * sizeof (CHAR16); // take into account '[' = and ']' > > + } > > + > > Information->Location =3D AllocatePool (AllocationSize); > > if (Information->Location !=3D NULL) { > > - AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > + if (IsIpv6) { > > + UnicodeSPrintAsciiFormat (Information->Location, AllocationSize, > "[%a]", RedfishLocation); > > + } else { > > + AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > + } > > + > > DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > } else { > > DEBUG (( > > @@ -1038,6 +1050,7 @@ AddAndSignalNewRedfishService ( > > > InitInformationData ( > > &DiscoveredInstance->Information, > > + CheckIsIpVersion6 (NetworkInterface), > > RedfishVersion, > > RedfishLocation, > > Uuid, > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112897): https://edk2.groups.io/g/devel/message/112897 Mute This Topic: https://groups.io/mt/103354135/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-