From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 265D1D80A07 for ; Mon, 2 Oct 2023 02:18:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RQa4rs8Dj5fHhL6jjq54+hUXuPTN/IZqIBW6F4sCKG0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696213088; v=1; b=Ah+X5uN+X6dQMxmitfc0cmkycXyO4SFa4g/lg/U1nKGoGugjZ6bocU3IhdN98YRUSLzQGnZ/ owlgart4Wa1Obu5AOoSnd87MYd8Wvx9+FhwPYwvAtr91HTjOL4/d8pIy/ARC8MS2S8dZnxGfnTH KmttxqGKLiOZi6cBPekMHH9A= X-Received: by 127.0.0.2 with SMTP id VTKIYY7687511x6u5Qzb0LmT; Sun, 01 Oct 2023 19:18:08 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.75]) by mx.groups.io with SMTP id smtpd.web10.73627.1696213083298025510 for ; Sun, 01 Oct 2023 19:18:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+4pCcUHSa9oo+CZlDBCXaBJ7ie33lbqsFMUKVouZYYFoU2oYgx94r57tilWYyXw7+MRm/VCTRIoyDonRoy5MyCm+H41jfdcJDqVq3WEQlnOpdYTj6ertLRUZ1lV+A0cXdCitJFDrftmBOehvPPiAZaQd+fVBrpEPwQl2R1qo5J2Bq3jbmXxOrQz40rmc82gXdF+1KeSr7xfM/Mns8ufATLcBohCEPpQFNJu42MAjPWMAHdn/H/ttt3c8/kmkTZIAidmXVI8sCAZ6XlgljSEgpR4kb+jCuciRfpwSWqnjA2OheAV0/WHn39aLvXYYqecv+13lUbn98YvR5aMAq3E+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kPftTXNt8aZlBwqo8TVskB4pPV0JvJGn2ZW6BIbpbjw=; b=IuhZYQQZ9H15BZo83yNRd0dfY5Xsjs0Afm80NzWs9F0OsKPdBdQV22w4WG2n/kFGqQmPdAQhcFX7InGtLm9Kr46+PZqcOFksBNHWa9qOfWoi4dD+pqE67noS8YDRGlRsH2CkVz+/pLDDeTYK0upW9vq3cc23TqiYRJm2kh0IxRNh55IiaU9EyQVsgu/59yQleAQuy3xI7iUlQkDCRT4Y8e27avSV9Zp8Yj3SCPsbFoF3JG2yuiexR8PkmTpuZChGNnFG47HRx3di0aq0dRJs3vgP1wUyXIU0GmHpd++IHn+26cGqMGMy7wfarOh3LYUHb8k0mFjlm+QDp/dA4BlaGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5118.namprd12.prod.outlook.com (2603:10b6:5:391::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Mon, 2 Oct 2023 02:18:01 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:18:01 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 3/9] RedfishLib: remove redudant zeroing Thread-Topic: [PATCH 3/9] RedfishLib: remove redudant zeroing Thread-Index: AQHZ8yA2pQo4dEYht0Kx6Yv1x9Z3orA1xwOg Date: Mon, 2 Oct 2023 02:18:01 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-4-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-4-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=8f77da62-b395-46c5-87ff-d7db19e045ba;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:17:46Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5118:EE_ x-ms-office365-filtering-correlation-id: 1ccfac61-4b9a-4a18-cd6d-08dbc2edcd63 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: BnMumMpbPtpCh0FGcnZURs50FmDh8olWVQg27I5sHQzRVdG3uQDfaj0Nsa4j+IrJUDqWdGfK3RDySpx1tkTiyraO11q8+9st//zbfq/Q6j8vOW+ULqDknZggAWPOMHA96seEPuXcrmFZuDOYAn9aeHFX73LTUr5oYPAa2+z7zUCnVvmNb/k/4T/5U779sqwoZYoN9WIYqO1JU2ExMaciabIRlTxo0g8311rfScSMPFPZZbgYFJJDzXA/nxpXZpFRC1foH6aHV9FOPb+EGAVbkoC+gzZXmgrVeEyGT2yk+BjUmjQ2gnIFwQee+6cs9+orMrqliblQHI/ulH60GFgFVJThyi5SeXQDqUmcMgtU0XktiTF/dbvoRab4Fm+f6hXl2VhR9SQFq5R1s0lMbr6kFdN+WEphMD2j8JNqcVZYQcFdgLbudyMkkASsALYORBNXrp+KYobTBAI8feRpzR3Ls0RCOwRxvqlqvGZd9JhYX8BgN8FSIdKP/C6BwDyKQYdmVx1/XgzC6MC/Yngt2nTC7fq5cs4bwTL1+DCww4PpzcRcupNAljVh2+AweGOiLA0zQ/QjbogTZKK4X3bAEmJ0GX6HNNcFb+XliXduGEZeSY8lECIjG6DSDiQVhySF0zLN x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k+iTJXT6n7pJ5PhHHppk/51xoh6gKFx969m+pyCckDaEGo4BregxE6OsJaE5?= =?us-ascii?Q?hunH8k0NCYla2U+3c3sA7nAer2DUVQFLa5cRDzWVETh8Dr3Z4f8dRNwz9tvP?= =?us-ascii?Q?RPAU8ssd0DmuVm6PYx7a95Z84Dbu3FORhJIv+x+ozBVu56CWoSJJmC1haNT8?= =?us-ascii?Q?NIidI+aoNA59wVVHI3N1vUarb/clI4orTKwURrjtrd3Mnw2u8jQ9EO6XNPTe?= =?us-ascii?Q?tPgo/4NzKykVipxH9E4O3RARFPpOMshuxt7Y6069o/JVe/pzoAELroxfSUu2?= =?us-ascii?Q?1I5LCTA0R7gUHmOjHpCHS8x0lxhxF1cp656dozNWXACqpGs++fFTWV8Yd9UI?= =?us-ascii?Q?oazODNfOAEtXZVvbbgoKBclsDnp7kCPftRNAl81LcANEfyo7/3nBZnVtebvt?= =?us-ascii?Q?36Jh6a6J1HLmdIvljJYTGsDSxsZpXWxonZ53ed7H5Fhj05HUOuWIas19gk5L?= =?us-ascii?Q?rC270GJ5MyQ8Eh+faRAWST0XdU36NXDXC6lmZ63HTBS5f7stWpbagHU2XxfZ?= =?us-ascii?Q?1CkhYZD5cZz2TfbqAFIUftFJfBbs7bcfDCiknYhqlqjRx4U23/XEfN/mwkAe?= =?us-ascii?Q?HqDojpbroYCauXypE1eHgUCgqR/4ZKCCltgJia5VTFsCz28v8eTnatrdmtID?= =?us-ascii?Q?ZS9amf2UF2Xgfjg1sYIXOHBRxhybNlKJMPpFxY4d/mDt7DmLCZbXNFRosoXo?= =?us-ascii?Q?Q5FxUYvXu8TRAU75r/4dYPBaQNiO76akh/kKGSOvG5xh3ADDANWr4J77dduE?= =?us-ascii?Q?ipEMAS++aFvgawq0q+Z178UUqMuBO0kU6gUf48oMQSzpDddbGpDCcJEYz89n?= =?us-ascii?Q?tBUTeuwfzSIZIa9qohJ9y/dJcs7JpKLsQoQ7puZHMo1102jh3NM+O2erCHBB?= =?us-ascii?Q?qr4kPD54w0gZz/QNQo9gDHP64hcZVQh+o7vE7yJCi/Ap+IEbYR9MeBjzt8/F?= =?us-ascii?Q?BnxhsS5U7HpU4aEaO4XInSKe9hk/B9FGW+MaiwzoKuZbFe0uvk4wIlgMx0f3?= =?us-ascii?Q?v0UcHB0fiAUU2whbBxjJWn57I+o8dmTc54pHBIhn81V5DhoDmGYHYA6OnlVO?= =?us-ascii?Q?kAsseVtCKQmpTdOJeOOrXP3P5YLpNFOb2UdbQLLT7Tnzh7PMTi/VdOyczbKK?= =?us-ascii?Q?jiV/KbQsftsyZYWJrn85H0N11YkT2adVEG2RYpuZe48LCNtLUAISwJO1H6W5?= =?us-ascii?Q?bsdbMqNVBidbd0h1xmLip6p4+H9VaPghCxT95gc4qEf03YxKdM6LqoHKWb+e?= =?us-ascii?Q?MffIY54LuYIkC8YyEHfUAD29EIPSEAxKPpez6wMylAYbWYe+S/7N74eMgZ/J?= =?us-ascii?Q?9sNTVAK3HIbNMOeI+MeiEfqLyR/eiZVT1t7CLIx8/hPhzCFQoRMdmuY9KX47?= =?us-ascii?Q?daUDoTOHkDnWZBXtBQ0tlDK7b26Ho40PPuvQ3BvvzxlWYMXQB4x9wCD4vZVu?= =?us-ascii?Q?wlasH5hvX+Vrjpvm0BN77HYbuMqcgoIxt7cLylkdzYFSF/HJvQbzN/W6JbM7?= =?us-ascii?Q?3KKLbRDL+JcptpcEoqPAKLAtw+S4P2CQj2FayhSVxANgJcddCIbhjRQ8454N?= =?us-ascii?Q?MByxXpVVLs0sY+T0iJk=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ccfac61-4b9a-4a18-cd6d-08dbc2edcd63 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:18:01.1398 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /fYeMtJQdCcic0DJ52WUKcwXSPEKuzHw5QjDhHpZ+tkQgQvkP39FBZkZ4AyEZXiiNoIkONqYrt6XWpq33S64yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5118 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: id8acjXWjm33uxsEnXDPLwHDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ah+X5uN+; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 3/9] RedfishLib: remove redudant zeroing > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Memory allocated by calloc() is filled with bytes of value zero. > > Signed-off-by: Mike Maslenkin > --- > .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git > a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > index a38bdfbea65f..0ffc23725d37 100644 > --- a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/servi= ce.c > +++ > b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c > @@ -1773,7 +1773,6 @@ createServiceEnumeratorNoAuth ( > char *HostStart; > > > > ret =3D (redfishService *)calloc (1, sizeof (redfishService)); > > - ZeroMem (ret, sizeof (redfishService)); > > if (initRest (ret, restProtocol) !=3D 0) { > > free (ret); > > return NULL; > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109244): https://edk2.groups.io/g/devel/message/109244 Mute This Topic: https://groups.io/mt/101667462/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-