From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F0A80740039 for ; Mon, 18 Dec 2023 02:38:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9BVO9yheuf997XJcHO1P3rvzadXeLLFggdLN5UYQZxc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702867120; v=1; b=q4LiOizl9BuE6ECYeOqhE8GNJl4jJSXmE3m5MfHbxJ3uhocj1PylVLF4EmcTZKGVEpuJx/VA dvkOWswXYDWvdogdIuNIGYIJkVxk6JAcB1ntqDtRnVF34GEz+CgnmU4EDelw/r8BxwSrs3qmFCb SRXF5+a6pIloWGs4QZpEfffY= X-Received: by 127.0.0.2 with SMTP id gYCMYY7687511xDczHb8ctBm; Sun, 17 Dec 2023 18:38:40 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.70]) by mx.groups.io with SMTP id smtpd.web10.33818.1702867119811672887 for ; Sun, 17 Dec 2023 18:38:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f99i/8YAXJ+wmhDfYtZPbRuZcED5UXaqctkS4G8v6hkVg9fLeDIlRPpCv9p2Q6H6T++3KGDr2grN9ViSPAI/Xf39hG2cSFYol1TZetOzpouKtgt8KSRuvW5BIjdbpRb8LpFHRZcWuSvgxtz8WZHkbeBchUYy/t/zK50Ij+UD1J8Vh+ejm313lz3MnlOsbmXQtqD7EwkQd9FMqefNs4qWswI/o7n9VjaFuZUmCfAHdShclvxY9LgssP1cpwFYPC9FHywB7KLIziOLRMxqZm7ZBAQDrfeo3VcC6mscqiMQFZK2E2O2MzeVG752uc5GSgnEH8p15nkZk+WOVMkvZSbJjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YhsWQmCbXVY2VYItOWUR2s8L0pIeojcUcWGgGAsvVz0=; b=mwNWSZwt/Pf9df5NE41vZiy8wPUW3H9p8/dSEarZiJ8zHxZijDK86iLb6B56a3/h1V3mdRcJ/UPBJEdYfAEcm8PDDk7G3RaKIU4Sf4kPXZzbp7ql/pNC4b/iqvDNFeoM3UZSbBL9wwh42/1uhCzYtyUFJxH/z/31bs0++/iRPypQYhKei/stI8Yoe1vL8redqh8b/kEjgUYOk7cHA7eMfUVCi+zGhntcyntSxn6mZFc5/0wsXqVY7o9N8J5OPYcajpfosjfJJBzbOodimx4brhnOgaGFhxbwCkoiMDPN+DfetLVeJnxtnmCUISxOLsXJBS3sYmCHzGkYzvt5rJdn6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW3PR12MB4521.namprd12.prod.outlook.com (2603:10b6:303:53::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 02:38:37 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 02:38:37 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Thread-Topic: [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Thread-Index: AQHaLuTGro7cDfDIdEOb4P6LQ2BYKLCuWBfw Date: Mon, 18 Dec 2023 02:38:37 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-4-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-4-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=0d0df291-8f7f-47e6-8282-99e02857f8e6;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-12-18T02:37:44Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW3PR12MB4521:EE_ x-ms-office365-filtering-correlation-id: 045f4665-f0d6-45cc-d128-08dbff726fd6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 9gwVK40nfK8J/kQEjV4Uo4sC5imOOB00AozwwMdL67E72dZwWEBOFvQWm8N6TTVNHYjfoByaVg6VzP2kqOOXvrc20sUH7u0n6guaIoGMHUBo+64i8NQ1+4xNd+1iAZ5awQ6SQjjAs5avbRA4nR0pDiqfqQNCAQfuhf1DVlmuKMmLAQoVRTSTPZOVutILCAEJw90LQi8lD+Xxazb3qDXJxK2teb2d1CAe3CWludXyxpZHE0JT5Bq7uFrgH55JDyQmrNKwWIZ3UVC5o03QON5Zzlmyfeg3Cs1lTwYPYUq87xLTiAzC4b8faBmSNuYFpVrmxlOoRrZIBosRrWWqZnuXShWRuGVug7Z9u/aw2gFH784Xlj026YshYtBAvDu3S1pxDe1G1o5a00TysmY2V976M5lnU+RvIBoaKGUUGypnOZ2B7ulXt1kmggSRbjMnS1FJ5O2vNiiaOyEoTPXOfhOw8nvgChtY/x8Jwo9TPZ2K4BpNcwJBZInG5V0r17gm/Ebjl0eY4owXoNi/WF6MgbzFsG5qa9jMwRl7/P6yzP9nDJ6AH3Wbm+daLO0tQfzxJWj9vK291x9sMykOrALu3zqbx+PTuoo+sy1F/5H0KGysCuFHY2N+jOlj0BAuazGUD+PHELNntbAXBPCV+s29sPF4R+r58jntQNv7nyN2qlxdpmz8o4TPtJs9pmg4XALeVJqP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1oOuvilVhI3bVVHUPcwd3kM0AmdVd4MM7lzVJPH9v5EWsarr/Tg1Eonlj63l?= =?us-ascii?Q?AcHxMCO3uxO68W+Jj/Dupml5EPKUvG+4asjQBUGe5Sk5DdPjWG0qr1EuO6Mv?= =?us-ascii?Q?lmW+GpbqOxmB4GEea5cez/8g0W0eXmwo/TYi+QdBMkkaYyOaGdoh4bW+Of+d?= =?us-ascii?Q?VAAZz29rKast9ssT0NDS+WLSfjForJmrdTchhHp3anqD8rfrOw0CGBmCHfup?= =?us-ascii?Q?d5kPxuYwV9oEAHKCIYqYSZl2UpRerEAdLfYLAZN9kcAqzO3ryEKgT2VIENvK?= =?us-ascii?Q?ynnoPAl4RmyfBBRhwZiqu2srOOLRWIYczX9lHSgRDvcd7ZUZ2QBa+fsxCfyf?= =?us-ascii?Q?vve6sCoiL3Uh+q0S7AbTX5ZrZemwbPTFAI6HHY7IeOomov0Ok/e89MoX1k1D?= =?us-ascii?Q?JYjbL+LYjkBao7Kf8IP74OXMkQT7LBBw7D5uCZhUHmv4DVDY+ctEfpMDLBah?= =?us-ascii?Q?nBdFfZE6bGgadVtaTNeg9Tcup35YP4HZYAJSFaWesSjErh2/SlqdPBrnkcvY?= =?us-ascii?Q?nP2LTVvKn8uH1MwNjBJ3xgd36AyuqNBWAaqlwTLtwTw+TN/C39+sdE/PZEYC?= =?us-ascii?Q?3N8kmMzM3Xb3FPR2euv3YMsMzmFa0413zJ22EmGQY/uMk698Oe9T30T9eIHY?= =?us-ascii?Q?CUP7SZFpjUMFBQYo2z9n5sWIgCUfobWvdYeCCXLx5VoGiKXBt0fXLcF9xDJs?= =?us-ascii?Q?Uxgb6jfDSuErIq80Daw/+M3OxGKkv/lbfUEraktP56rYKQUf468jC8uxwA/2?= =?us-ascii?Q?Vz7YGnUbr4rc0avHA7LMVVNVi4JVtl3iQ8r06EajEeBX+GUvrydJUKSvsH6T?= =?us-ascii?Q?tniG9vFEHgG1f4xVYORMlEg5/EbSpGD3sYkZxmx8K7IyGiCcdcLwq0VyUD6/?= =?us-ascii?Q?7uDciWaQGVduKHnZwaz7YyFjIek5qh0son8tv1DJhJSZ5fhYosOhZg69ugtv?= =?us-ascii?Q?e4Ki74wF/uLdvk2o4Cw657vJ1VhXWCGSgmxVqzS8ek5T3fywMke4E/T4k6iq?= =?us-ascii?Q?4A238aqY2CP8WvqYY2wzLZHNFpVrkDQU6x5EF9geHGZpuJyfnDCRM9WBrLSa?= =?us-ascii?Q?A/MKVDlGWta5IV1q7+xkJDjdcsiXw0SNPiU2N/6ImKu060djvfibAv92I7JF?= =?us-ascii?Q?OT4l0H1/7Iq+5V3kOjljO9DPv49ElQJyba+baN26DnSkE3WW15N+mEC1/uhB?= =?us-ascii?Q?UHt/AvexO0tVfOii7BRflxhvZUZ4uSb8op/SWZIo5kArrYBX/ECXjLiSknlD?= =?us-ascii?Q?b/6jGvvnJOxLmKoomRutaBhirUgO0VC20JJPS1aUDIyQ2+F5Ts60sD762csK?= =?us-ascii?Q?8t/bmAznndIlRYbapW4Vrr6AHiviPMcBahG03q90UTvZ+/dlWYzjl5t5Zbip?= =?us-ascii?Q?PhUx4OpCiAeQkHhiUAtS6lf/lcDjik17Xb+vb7AT5VskCIySOwi3yg3MVbMf?= =?us-ascii?Q?GEabMQs9vDZkIo70lprDIjmIACS3pYF9YkbORuPTgTApGgvHe3WlNMba2Tvf?= =?us-ascii?Q?g4qWAOvAaRWMZxUUEMJu8WvfiYkX73bzE4qFWfuqTkEaX8COpDgDg3Xg089i?= =?us-ascii?Q?9h6FBvtghwpm9/15n4w=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 045f4665-f0d6-45cc-d128-08dbff726fd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 02:38:37.0362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MQUcMcH2dG8EZjOnKvAvhpe3Jkyzoeddr5II1f5ZufNYR6F9L4bwlDHyBg/Ln6OuJwv1F007yEO18ZgQ5sEv5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4521 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HxQpIdUIHayUEgFtMncyExBIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=q4LiOizl; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [Public] Not able to apply this patch from either email or group.io. You may want to= try option "--transfer-encoding=3D8bit" when git send-email. Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from > RedfishCrtLib.h > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > It seems that initial implementation of this header file is based on > CrtLibSupport.h from CryptoPkg. But uid, euid, gid, egid and sa_family_t > sre not used in RedfishPkg. So remove them. > > Also take "true" and "false" definition from MdePkg's LibFdtSupport.h > header file, that also seems based on a header mentioned above. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++++++---------------- > 1 file changed, 11 insertions(+), 34 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h > b/RedfishPkg/Include/Library/RedfishCrtLib.h > index ac6c5162ad6a..0c51a03d0e1a 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -69,20 +69,17 @@ > // > > // Basic types mapping > > // > > -typedef UINTN size_t; > > -typedef INTN ssize_t; > > -typedef INT32 time_t; > > -typedef UINT8 __uint8_t; > > -typedef UINT8 sa_family_t; > > -typedef UINT32 uid_t; > > -typedef UINT32 gid_t; > > -typedef INT32 int32_t; > > -typedef UINT32 uint32_t; > > -typedef UINT16 uint16_t; > > -typedef UINT8 uint8_t; > > -typedef enum { > > - false, true > > -} bool; > > +typedef UINTN size_t; > > +typedef INTN ssize_t; > > +typedef INT32 time_t; > > +typedef INT32 int32_t; > > +typedef UINT32 uint32_t; > > +typedef UINT16 uint16_t; > > +typedef UINT8 uint8_t; > > +typedef BOOLEAN bool; > > + > > +#define true (1 =3D=3D 1) > > +#define false (1 =3D=3D 0) > > > > // > > // File operations are not required for EFI building, > > @@ -343,26 +340,6 @@ fgetc ( > FILE *_File > > ); > > > > -uid_t > > -getuid ( > > - void > > - ); > > - > > -uid_t > > -geteuid ( > > - void > > - ); > > - > > -gid_t > > -getgid ( > > - void > > - ); > > - > > -gid_t > > -getegid ( > > - void > > - ); > > - > > void > > qsort ( > > void *, > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112619): https://edk2.groups.io/g/devel/message/112619 Mute This Topic: https://groups.io/mt/103181038/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-