From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Nickle Wang <nicklew@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>,
Nick Ramirez <nramirez@nvidia.com>,
Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.
Date: Thu, 26 Oct 2023 02:32:43 +0000 [thread overview]
Message-ID: <MN2PR12MB3966476BE9342F498062A00FEADDA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231025102454.2434-1-nicklew@nvidia.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Wednesday, October 25, 2023 6:25 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> There are two definitions for below functions in RedfishCrtLib.h. Create
> this change to remote duplicated functions.
> Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and
> memchr().
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
> RedfishPkg/Include/Library/RedfishCrtLib.h | 86 ----------------------
> 1 file changed, 86 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h
> b/RedfishPkg/Include/Library/RedfishCrtLib.h
> index 23c6acfca33e..1e4c234ae00d 100644
> --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -172,20 +172,6 @@ free (
> void *
> );
>
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -int
> -memcmp (
> - const void *,
> - const void *,
> - size_t
> - );
> -
> int
> isdigit (
> int
> @@ -216,27 +202,6 @@ isalnum (
> int
> );
>
> -void *
> -memcpy (
> - void *,
> - const void *,
> - size_t
> - );
> -
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -void *
> -memchr (
> - const void *,
> - int,
> - size_t
> - );
> -
> int
> memcmp (
> const void *,
> @@ -251,12 +216,6 @@ memmove (
> size_t
> );
>
> -int
> -strcmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncmp (
> const char *,
> @@ -264,35 +223,11 @@ strncmp (
> size_t
> );
>
> -char *
> -strcpy (
> - char *,
> - const char *
> - );
> -
> size_t
> strlen (
> const char *
> );
>
> -char *
> -strcat (
> - char *,
> - const char *
> - );
> -
> -char *
> -strchr (
> - const char *,
> - int
> - );
> -
> -int
> -strcasecmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncasecmp (
> const char *,
> @@ -300,21 +235,6 @@ strncasecmp (
> size_t
> );
>
> -char *
> -strncpy (
> - char *,
> - size_t,
> - const char *,
> - size_t
> - );
> -
> -int
> -strncmp (
> - const char *,
> - const char *,
> - size_t
> - );
> -
> char *
> strrchr (
> const char *,
> @@ -328,12 +248,6 @@ strtoul (
> int
> );
>
> -char *
> -strstr (
> - const char *s1,
> - const char *s2
> - );
> -
> long
> strtol (
> const char *,
> --
> 2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110068): https://edk2.groups.io/g/devel/message/110068
Mute This Topic: https://groups.io/mt/102175113/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-26 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:24 [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
2023-10-26 2:32 ` Chang, Abner via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3966476BE9342F498062A00FEADDA@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox