From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8465AAC0B00 for ; Thu, 26 Oct 2023 02:32:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ParBOtOn1SHl8N1+Nuu6mdKY55JiD8EKFJIt0vYnujc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698287567; v=1; b=hwzNcD8eNcZ3m1ZhfooioXUOvEVvD4HogSKjGsZ+OTGLK5k7YMivCINXSkVoZ+ktQSF+xmOd 9TJQiocF9S6LZxwH3I53Gq2kE5mS3amfnLbu4W/nopLMpUb3Ez+Ien2GuRWaC9bgE+rqADY/AFY 3i97sGWo3bSqiQ9ilMENTuzE= X-Received: by 127.0.0.2 with SMTP id hr1gYY7687511xhMUVYoUZ6p; Wed, 25 Oct 2023 19:32:47 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.66]) by mx.groups.io with SMTP id smtpd.web11.61985.1698287566376098639 for ; Wed, 25 Oct 2023 19:32:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHv0Tko10ciOYzG7XVP6OUhhhhmv9FRF1yNjMPsNp0Xao0DN9v+CrVTS7QcXn9pzsDh/ABgvU0qQ28PMfbByDMiuH0jifWDQZE/H/wDfI1RwhQ0nS1akmbBaZ8cfWhfNnMDdq2DsIf8Pl4KZzwrO144xHbIS/8n6U+h4oSenCLWjJ/Z8dUyfvm/bGa2QAA1dHk4kkTopSDVAEFyLfqJSrv4EIXikNCigl3REwn6NgUDe3QP/9XQYJpdsqU1qtnCv+hlAUuroY/lmknmDw8ueMIBrCN/Fx6KK1vyblo8GGWBC5k1RnO29WQ9uw5yz5j5kzbndmUenWNX38NWPcYX9KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MaoQq4jj/qEMO049fy+z3/jr47/7Ogd+qS7YwVpakK0=; b=Tigcm45HiZq+po5gNF5AJqBhSvQlP9mCycPux4GjDdPNwRu5bugAVYeq0BeRyP2L9EarP5uHJYtr+BiXm9x4ZHtmNeOAifcRsFhjn39G0UQL1XmsEecW1bsUCzwPqTMkqcJpA0lZBKzVEeHxqS6/dLn+aFY6vm9XSa+t7QQAdpuxr8q1HVNCqz9LG0teL91BbmsnqamCtKiTgOO8WblRquZhKCBDy+e3nfdz0pqu+NYkJTLKEEBAkOpvsr+E8ro4nDakE0D/0e/S8sPv8ej5XzVbIAwwNoEWCKA7wZqxS0PM2K394mVb22m0VD/XMtRWe9PonFEEQ5G86cFINQjs9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA3PR12MB7973.namprd12.prod.outlook.com (2603:10b6:806:305::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct 2023 02:32:44 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.019; Thu, 26 Oct 2023 02:32:44 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions. Thread-Topic: [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions. Thread-Index: AQHaBy2KTTV6x/dYTU+McaVAKvup5LBbWvCg Date: Thu, 26 Oct 2023 02:32:43 +0000 Message-ID: References: <20231025102454.2434-1-nicklew@nvidia.com> In-Reply-To: <20231025102454.2434-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=4a2963f0-62b6-4162-b83b-1c57b84a7368;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T02:32:21Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA3PR12MB7973:EE_ x-ms-office365-filtering-correlation-id: af01d069-7032-4c56-b0fe-08dbd5cbd57f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: EOpXzB3XV6U3mBFwCN/XSZgRXrhopVvVHju4SOhr50svf/cLGiAVxoP8Yc/PUk7s/iex/Bgy7le8c75ZwpjFzBucJfhojEMR7O/9ttuhD7Bf10LbeAtFGuuZ1lndOpyYHMMWUlXE9A2ELzsfUtL2tM8UwCxQ4rNYYmHZnROCVYK70t/FoHuiP588T0saepG9H6aanRYXL0trqMf8fe1VbvSRsgUpYEfqR0RPEhBlR8nYDjiWur2rmAEbtfl6k+lkHiFBVIvRWRArCsclC08uZHx6Fj4Y6qvW2L+Neprmca5alA2IUm0eEcWR0YGA4MjY6ctZ95g42P8TvS/La0vcx5pwCPWqiELSn6qbUaVR21Xzv2mxQAccKO1bt2Bp4xKVMuJhrO0cgkmU6wVL3jclXLcMccqn761sz63sM/Sk0n/fzSnc6fh33K9GfdeIDlneBZd+8CDXjZGqMEmjRUBa8zHsTFKd53iRbHxgE7lqhAFctf5r/BMpjHFiKFI1tLM9orESZiydll64VN3DgCLdPFY2vZ2J5lq21+Nl7KTbv4bXFTGX0zQbkFHoLEzOgWx5MWMLYH6rabD73nUKrx/vaFyCYxHnjikway7FAiSaGGmMd0KGyasKcxtUwqzB3L7Y x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TiU1Pwpc3AMSBz+E5E86+AzRXF6LVgGlavgtwXe7byrY10JzgZ8FtoBfYxai?= =?us-ascii?Q?w4DIE8u0h+YtpnKgsa4bysnrznRd8B0thrym6F9aOr3ms0IKclNDy/s4rEZZ?= =?us-ascii?Q?IztHliPPnQUD+x+rrmlmQxZKHl4GCaG2X4VAQt05YM/cERqciKyVk/SLMRSR?= =?us-ascii?Q?9kaoVOXAbkDJfoZu9X9YPo+xVYUatL1V2tlcO1rXAEgpUPkk+65XN+zDmlW/?= =?us-ascii?Q?V1m1U22DUSxhntVuaNwbZkCA9beVZcPgQchXDoFA3R77hLeUjm3Dm2hgx/tO?= =?us-ascii?Q?zMtxWybp99dz/pXp1RIXKrME2pZRq5nuFpZKYbyUcYnryncATmsMq0lwDbhV?= =?us-ascii?Q?ZsZ/jDuzYmL1r9a0kSqw6MeGLr0a4fHskfnXAl4xMAAi+S9uCC5PXdnBobyS?= =?us-ascii?Q?FXhha8llSi64c5OP5dKsLT/3I/savBVR3HujQMHnh4Ar+raApeVnBtjLG5tU?= =?us-ascii?Q?7mf8TtLrlvq3poq2m0QWyzq+ooHLoEr2PbttiamUGyw+fIK+mOPy+KvMPNzG?= =?us-ascii?Q?beZ3PCSSY7p+gYjkvajWnqoVR204H186qjlJ5pojhQ1xTY3m9DYGdbj1ZqeW?= =?us-ascii?Q?W05P4iR1E3YiBpEnxkB6DhSibeLECIeVfJsoD+1a7O9uJ4uIyEah7VRlgcNN?= =?us-ascii?Q?rS6UyZ7EWP+GNmz+4pFCsLzRAEzKkrvCYqyaNrl8qzfOJcoEhwHtvjim/1HJ?= =?us-ascii?Q?ApWnLXyL5JZUy0/17QqRkNQ6jeX2cKbAuoaIoz248B64WQ/am/S0F5SVu9zi?= =?us-ascii?Q?/SLtCBGdESPU+Xcp2D/jK9RFRTbamauVo5pJGEA1uOaVlXye/0wBzATJ8SKZ?= =?us-ascii?Q?fJJAiQ6m0O5oxXFU8F+/g7dLHgEhJ8YbWfq1hFSUOXDPWnszsL4qflCqdQbx?= =?us-ascii?Q?clReaTYDbVYSI3dcM4LYHVW11qNfn0V/tR5ma9yBv3SPkkftb3rUV+4nuRMv?= =?us-ascii?Q?WRjiRpUHwb9z9ewtuF9A5zcRHOGfdAVDViH/oBKcdZNcLmViMq4WalJTsZ/s?= =?us-ascii?Q?ZZQFh4NWYiu1EkGk15ubuO8PFipHiaKpEOr3pVZRIn1+gA134Y0dtVQVgPKA?= =?us-ascii?Q?hooInclnCSaROr1eeFhUWHPASxprNaSzX4G6I6WeUdlXqJvXSP6wBsrIZMqh?= =?us-ascii?Q?S361ITxTmA7OvILLwzPuos8WMhyVKyxN0AzcuSTQ1iSFdQNqnRVckRTHcSp6?= =?us-ascii?Q?QPDqjsSQ4jAY7C8hspo95hKTAuZhHlXx0HpIYXY50C7aMu4QlI77kZPzw40X?= =?us-ascii?Q?t5T88eE7N5j89uLxTXpCZVEB5+Z2j+kpPgGAkoFPJkI7VBWQ5YDB8Bf7GKWf?= =?us-ascii?Q?YlLgLIhjpYAQgxhe+UPhiBuN2DzNxImivFfaP1kD8dh2CWdor92/98OoVOX1?= =?us-ascii?Q?IgOebUkfddnJhpc1dSW3y1Wmjgel8Z3Odebj15DExROwDjA9xAbGJY8r0yLC?= =?us-ascii?Q?cfelLszqAdGFqZ3zRlGJNVXDjsRVxE+AD6vUQEFJCMAmi8bt9cQipLydYb2G?= =?us-ascii?Q?acggaBMGlURYTiJrN+TxAeKugFOsC5Y6cozJ6QRVTi4H3lJPsI/EISxLAlah?= =?us-ascii?Q?GQvlIS4PhgUSUew1wfA=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af01d069-7032-4c56-b0fe-08dbd5cbd57f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 02:32:43.9479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3q7kYaFrnLgyoe98xS2kTL+Q362gDZwn5ytMUHCO7nGLlZbZY9RasjA/SBOKw2J00diJoRLPFXrlarP/lp0lDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7973 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: My3RpfckaFIfCCr2OYGgFIEXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hwzNcD8e; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, October 25, 2023 6:25 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez ; Mike Maslenkin > > Subject: [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions= . > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), > strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and > memchr(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 86 ---------------------- > 1 file changed, 86 deletions(-) > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h > b/RedfishPkg/Include/Library/RedfishCrtLib.h > index 23c6acfca33e..1e4c234ae00d 100644 > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > @@ -172,20 +172,6 @@ free ( > void * > ); > > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -int > -memcmp ( > - const void *, > - const void *, > - size_t > - ); > - > int > isdigit ( > int > @@ -216,27 +202,6 @@ isalnum ( > int > ); > > -void * > -memcpy ( > - void *, > - const void *, > - size_t > - ); > - > -void * > -memset ( > - void *, > - int, > - size_t > - ); > - > -void * > -memchr ( > - const void *, > - int, > - size_t > - ); > - > int > memcmp ( > const void *, > @@ -251,12 +216,6 @@ memmove ( > size_t > ); > > -int > -strcmp ( > - const char *, > - const char * > - ); > - > int > strncmp ( > const char *, > @@ -264,35 +223,11 @@ strncmp ( > size_t > ); > > -char * > -strcpy ( > - char *, > - const char * > - ); > - > size_t > strlen ( > const char * > ); > > -char * > -strcat ( > - char *, > - const char * > - ); > - > -char * > -strchr ( > - const char *, > - int > - ); > - > -int > -strcasecmp ( > - const char *, > - const char * > - ); > - > int > strncasecmp ( > const char *, > @@ -300,21 +235,6 @@ strncasecmp ( > size_t > ); > > -char * > -strncpy ( > - char *, > - size_t, > - const char *, > - size_t > - ); > - > -int > -strncmp ( > - const char *, > - const char *, > - size_t > - ); > - > char * > strrchr ( > const char *, > @@ -328,12 +248,6 @@ strtoul ( > int > ); > > -char * > -strstr ( > - const char *s1, > - const char *s2 > - ); > - > long > strtol ( > const char *, > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110068): https://edk2.groups.io/g/devel/message/110068 Mute This Topic: https://groups.io/mt/102175113/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-