* [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.
@ 2023-10-25 10:24 Nickle Wang via groups.io
2023-10-26 2:32 ` Chang, Abner via groups.io
0 siblings, 1 reply; 2+ messages in thread
From: Nickle Wang via groups.io @ 2023-10-25 10:24 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez, Mike Maslenkin
There are two definitions for below functions in RedfishCrtLib.h. Create
this change to remote duplicated functions.
Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and
memchr().
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 86 ----------------------
1 file changed, 86 deletions(-)
diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h b/RedfishPkg/Include/Library/RedfishCrtLib.h
index 23c6acfca33e..1e4c234ae00d 100644
--- a/RedfishPkg/Include/Library/RedfishCrtLib.h
+++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
@@ -172,20 +172,6 @@ free (
void *
);
-void *
-memset (
- void *,
- int,
- size_t
- );
-
-int
-memcmp (
- const void *,
- const void *,
- size_t
- );
-
int
isdigit (
int
@@ -216,27 +202,6 @@ isalnum (
int
);
-void *
-memcpy (
- void *,
- const void *,
- size_t
- );
-
-void *
-memset (
- void *,
- int,
- size_t
- );
-
-void *
-memchr (
- const void *,
- int,
- size_t
- );
-
int
memcmp (
const void *,
@@ -251,12 +216,6 @@ memmove (
size_t
);
-int
-strcmp (
- const char *,
- const char *
- );
-
int
strncmp (
const char *,
@@ -264,35 +223,11 @@ strncmp (
size_t
);
-char *
-strcpy (
- char *,
- const char *
- );
-
size_t
strlen (
const char *
);
-char *
-strcat (
- char *,
- const char *
- );
-
-char *
-strchr (
- const char *,
- int
- );
-
-int
-strcasecmp (
- const char *,
- const char *
- );
-
int
strncasecmp (
const char *,
@@ -300,21 +235,6 @@ strncasecmp (
size_t
);
-char *
-strncpy (
- char *,
- size_t,
- const char *,
- size_t
- );
-
-int
-strncmp (
- const char *,
- const char *,
- size_t
- );
-
char *
strrchr (
const char *,
@@ -328,12 +248,6 @@ strtoul (
int
);
-char *
-strstr (
- const char *s1,
- const char *s2
- );
-
long
strtol (
const char *,
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110033): https://edk2.groups.io/g/devel/message/110033
Mute This Topic: https://groups.io/mt/102175113/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.
2023-10-25 10:24 [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
@ 2023-10-26 2:32 ` Chang, Abner via groups.io
0 siblings, 0 replies; 2+ messages in thread
From: Chang, Abner via groups.io @ 2023-10-26 2:32 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io
Cc: Igor Kulchytskyy, Nick Ramirez, Mike Maslenkin
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Wednesday, October 25, 2023 6:25 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>
> Subject: [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> There are two definitions for below functions in RedfishCrtLib.h. Create
> this change to remote duplicated functions.
> Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(),
> strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy() and
> memchr().
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
> RedfishPkg/Include/Library/RedfishCrtLib.h | 86 ----------------------
> 1 file changed, 86 deletions(-)
>
> diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h
> b/RedfishPkg/Include/Library/RedfishCrtLib.h
> index 23c6acfca33e..1e4c234ae00d 100644
> --- a/RedfishPkg/Include/Library/RedfishCrtLib.h
> +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h
> @@ -172,20 +172,6 @@ free (
> void *
> );
>
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -int
> -memcmp (
> - const void *,
> - const void *,
> - size_t
> - );
> -
> int
> isdigit (
> int
> @@ -216,27 +202,6 @@ isalnum (
> int
> );
>
> -void *
> -memcpy (
> - void *,
> - const void *,
> - size_t
> - );
> -
> -void *
> -memset (
> - void *,
> - int,
> - size_t
> - );
> -
> -void *
> -memchr (
> - const void *,
> - int,
> - size_t
> - );
> -
> int
> memcmp (
> const void *,
> @@ -251,12 +216,6 @@ memmove (
> size_t
> );
>
> -int
> -strcmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncmp (
> const char *,
> @@ -264,35 +223,11 @@ strncmp (
> size_t
> );
>
> -char *
> -strcpy (
> - char *,
> - const char *
> - );
> -
> size_t
> strlen (
> const char *
> );
>
> -char *
> -strcat (
> - char *,
> - const char *
> - );
> -
> -char *
> -strchr (
> - const char *,
> - int
> - );
> -
> -int
> -strcasecmp (
> - const char *,
> - const char *
> - );
> -
> int
> strncasecmp (
> const char *,
> @@ -300,21 +235,6 @@ strncasecmp (
> size_t
> );
>
> -char *
> -strncpy (
> - char *,
> - size_t,
> - const char *,
> - size_t
> - );
> -
> -int
> -strncmp (
> - const char *,
> - const char *,
> - size_t
> - );
> -
> char *
> strrchr (
> const char *,
> @@ -328,12 +248,6 @@ strtoul (
> int
> );
>
> -char *
> -strstr (
> - const char *s1,
> - const char *s2
> - );
> -
> long
> strtol (
> const char *,
> --
> 2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110068): https://edk2.groups.io/g/devel/message/110068
Mute This Topic: https://groups.io/mt/102175113/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-26 2:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 10:24 [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: remove multiple definitions Nickle Wang via groups.io
2023-10-26 2:32 ` Chang, Abner via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox