From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.69]) by mx.groups.io with SMTP id smtpd.web11.45241.1685347830745647244 for ; Mon, 29 May 2023 01:10:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=BVAqWPSD; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.69, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTV12RV5YTkNNmVDOdnVHhEUOWnqD/jL15Ad8Q5XcZoomcBY9e3Qhil3lgCUP/w3BNDoaA5Ocl1e8m1sCeLqjDcJ1MMB4cyYhjO+zRnNRq740HhoXO21t7BebiagAzkKiL2L3vOOwqEBynI7Wi+40MCeYm9Ym21xrWbfNEqya71xmuH8UJ69cF4zJyW66AodYar7p+2DtSWActZEPGfas5/rxsVsu5Bly7pv0BlfZGKIWRnmnYCSECs+8+cWNtIs0PUMO+qH0jrx9uxz7gbFogZ09BzOkpDsQEtwOYTnFb2B7bdDfBlc6rZHFW+VKtFVtyf/sr2OgpcrOGEpMk6BbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ML+CAUI/7AD5jvfF6uDa2EKY8myfvSpuGswbn8tWX2U=; b=Sl2E0JXlFRKXhY4DDCnoT+rUGUr67ImOoju5jDgiatA1LhWYggoBqzGXNWKpBcxnZDTBKALZPzUy/hEaQJfPWvPwCIJn2xSF5lR86cw3I+h+Ug9tyNX0553Df6O71l+jGcgJUs4Vy+i5yrTgNTHCj4a/AlQP1xAnMRcK38nqI7WhgLYEeDB3ab4B8ztVPs0gXAgoX91Zxq1Xfyhfq/ZJsXaW6aO+G6BRwG9B4azG2HbdJS7Ziu+Bbj4c5cX82WxWNiU26GZAKQ2UJhas6YugfWCCIEvjDCxWWERuHIHRF9f9vkGxARYzukEoxn+auLdsBybCW3Z8RApT4YMoAFIUQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ML+CAUI/7AD5jvfF6uDa2EKY8myfvSpuGswbn8tWX2U=; b=BVAqWPSDXiCzAYuQbmWSSEBiC17Oe4V+Ecq+gIX9iUbH72PP7wRV1C9oXNpTk45FXh4adJsPTO/1ofjeJbREiQeqVh4GsEwZaplNA6Sj9o3u6fmGA0tSUmhV+/T9kByOH12oNf0gZlbk1sOJiwP8oElyria3LMtkYalwwZF7VCU= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW4PR12MB6730.namprd12.prod.outlook.com (2603:10b6:303:1ec::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 08:10:28 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6433.022; Mon, 29 May 2023 08:10:28 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. Thread-Topic: [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. Thread-Index: AQHZkfYvZL4DvdPYYUGemK5XB3jvBq9w5hGg Date: Mon, 29 May 2023 08:10:27 +0000 Message-ID: References: <20230529062401.1263-1-nicklew@nvidia.com> In-Reply-To: <20230529062401.1263-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7e31bd99-2fc9-4080-b0d2-e9d4b466dc37;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-29T08:10:13Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW4PR12MB6730:EE_ x-ms-office365-filtering-correlation-id: d66e600a-688d-4edd-09c0-08db601c29c0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NsSlqEWo8cR6dK4LHF55Osa2RMmiQVhLuuCznhqSzPmJKtEjYCEhJijvo0SvCBTpQdYfYYNHWJ47UiCVBZOOQiG8JVRqnzEZkuGED+Aa4ZWgH+DqLknT4t/dXk/hn21Fa5SF4tTipLqyw0D/8GuF7NivJYLuSJXwfZr8HFVXqLCJ0dDhtR8+SwwE3MkUjrELzjYfHKz/EatE8LxdDVpit8EZa3TA2Q5bQ2rHHrYg4uv818TqVJrELZPpFQd4zI/hfEfFePEGIWTiArbV5ZBJonJT3VCykmEhmmHNSkL5N5/RvmHs7cQeH0VZr1SoxSNnYub7SFRls2C8HxsKaEKm9LfAWrmBIpp++woG6AmZdG/Apeope0QkqKY0YER/MCAz3x9s/gJ2RDr43sQ1PMrD+AEuBE7msU6IKSLsUYeBa56OJo7duwHa56rTPSOrGpm+1oB53DOwCTzZSuw9AMl8PNxWyclKdHLBnwYFjJs2GijDWcxZEvfo2xxmOxmaOYXPoinMdgl2oSsEWzCZWKCWaYJJzMcHPKCHbWOzroW5cv27Ig3iPAAGUNm10QzF1YAGIjsPkNVC/gwLp/cZwP85jLNaecvifKwZmFE0YUSLRbQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(33656002)(186003)(26005)(53546011)(9686003)(6506007)(7696005)(316002)(2906002)(71200400001)(55016003)(52536014)(5660300002)(41300700001)(8676002)(8936002)(478600001)(122000001)(38100700002)(110136005)(4326008)(86362001)(76116006)(66946007)(38070700005)(83380400001)(66556008)(66446008)(64756008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rx+UfrFU56XhhPy4Zmhla8enHZ8h5wRwz02kSxkJlSSEgYVNILo4U5a8OT2M?= =?us-ascii?Q?TfrAyc2/PlHIx4WHZYWF5aS6RMgXXSHb0fmy9lVn0z+m2Fy/4ab9sN9+HpBM?= =?us-ascii?Q?N5IEORONPk9rmwqgD2CQ+sUVxhRTzVSajodOe9N0+we/AE63vyJ/HWpRvWaP?= =?us-ascii?Q?Ge1RUMQ7sbHZfbjqHkDfPcQqRnD8QtSqTRWs9oN3bfXZwXei+sCK/w9dj18F?= =?us-ascii?Q?Cl7mPrZPnOqNsSj+W5a6fAidfGWHB28BxbBQu1xB+rkdFbijMx9MHavKP54B?= =?us-ascii?Q?/U7uUWIiCrYNSugwwnEdP5IMZUgmM/0JqKwDkXMm5ow5KNC9tMezP7aygcwZ?= =?us-ascii?Q?f8fXMWJgL9dijR7m9WDSHr9ZNZP6ZyCvLQbWIC8HTQsPDKn5os3qZEncwqi8?= =?us-ascii?Q?zUpgPtfEpZkdcF1mWgcEP4emwEWHaG8TWdxT9GAZ7Xu4DXMAD14yIf26zCFR?= =?us-ascii?Q?ty6Yg5bXh8v9oWrMoWu5INb7N7D8NPeaaLm1UbXBET1MojRr59qi+5iTFhmw?= =?us-ascii?Q?UJK1c4P01Xo93sR+lQLp7hZlg9+7kDNbm+4JISLDcWCXdDaL7wvjHAkwdy4T?= =?us-ascii?Q?x9Ll92fYbFb+Xn8pkEfyuvf17gH73tN773w5T/EimilEwRZ+jEXCRQcTDO2x?= =?us-ascii?Q?O/P8TH84eqIQpuvKBk8ByR3eapF0YfAWv8TK0YnxFXIuCHaJmUEoQBrWX0LX?= =?us-ascii?Q?EucDZPmAevelrzFS0e1XcKyaLFI4asOPerDwITkKWgkEtGt1yJgQNDZCA0sU?= =?us-ascii?Q?atXTl7hi/kYfnLC0Mx/l9OOMP4epcl3eZotic8Fjro7dN3eYOhH/+pwDBWCF?= =?us-ascii?Q?5UexNdi+t3vvo5mR69+PnE94NSwes9HKb07q9ZbvylGTeaVgb14e+RyU2ZFf?= =?us-ascii?Q?uW05/bEm+AC3CywKkcK1AyTrnpNEIvdRiWbSjQFS1G/At2IOAVvI+ovEUV5R?= =?us-ascii?Q?A2fG4Ek8M/AdLjyDFDJBCd53usQoGIvHoicr3xYIEUOQ7GCoL2TNptVlFrPd?= =?us-ascii?Q?K4b2BitFDIRxeYfFlW2yTu1/5Dk9SJQC0YXpuTP1j8+CgNq76UfDuBX9z4BP?= =?us-ascii?Q?cBH/t/p7PtwOsbWVa8qMJt091TGiDJsPtR+JYooQJIWnzzKaUT2swJQRVuva?= =?us-ascii?Q?A86Lv12C1BZxZxuAwcU7NTIHWC5ZZSMFyyu4ZWlrSbNu6clGqOf0KbdgnSfH?= =?us-ascii?Q?LvhTTXVX8rKYDCOqUzkVntriagt/cgi3XwZNbd+k3S8WzVIhi7ollqe50jEO?= =?us-ascii?Q?tLC5InUMwN/B7BQkSeEFuHjCPYL5z81m4tvPgxcQ86KHmnpzFRO3qVmHtaeO?= =?us-ascii?Q?pzmvGFfzUXWGSucwmaQus3pA1jMBPOI0dZvi67GZ/H6bxF/xpqW3OtptmhBn?= =?us-ascii?Q?j8QvlPlZUpT5MacFxrqUnWVU2zTG+Cxogjx89sgkaq3wQKH2mbO+kQcVx60w?= =?us-ascii?Q?R+hMOq6FQJCd/mYOGgH2HHoPF5oVnB9hYQRryl2QTrxj92isEpOXN9bBbKwd?= =?us-ascii?Q?LF5e/X1wnKAYMPmENJGwDMQonBMlltuyl+Unx2vnqKFl0vDZC1qC8b16mmlw?= =?us-ascii?Q?88eiLAFMWFzARslgr2Q=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d66e600a-688d-4edd-09c0-08db601c29c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 08:10:27.8234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k07iWXucvU1meSyp4sJo1Gi7h0JLR2RN0bSmCKdJtXCe0eTlF6p5iKGn02FgCAeUNoKMDrJq9SEe8moQftSLzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6730 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Monday, May 29, 2023 2:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issu= e. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Fix incorrect value type issue for checked-box op-code. > When the variable for checked-box is defined as UINT8 in > varstore structure, IFR compiler assign its value type to > EFI_IFR_TYPE_NUM_SIZE_8 instead of EFI_IFR_TYPE_BOOLEAN. > However, the value type for checked-box is boolean value. > Redfish service may return error because of incorrect value > type passed to BIOS attribute registry. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > .../RedfishPlatformConfigDxe.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index 1172d1094b06..462f269f6a3f 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -1221,6 +1221,16 @@ HiiValueToRedfishValue ( > RedfishValue->Type =3D RedfishValueTypeString; > break; > case EFI_IFR_CHECKBOX_OP: > + // > + // There is case where HII driver defines UINT8 for checked-box op= code > storage. > + // IFR compiler will assign EFI_IFR_TYPE_NUM_SIZE_8 to its value t= ype > instead of > + // EFI_IFR_TYPE_BOOLEAN. We do a patch here and use boolean value > type for this > + // case. > + // > + if (Value->Type !=3D EFI_IFR_TYPE_BOOLEAN) { > + Value->Type =3D EFI_IFR_TYPE_BOOLEAN; > + } > + > case EFI_IFR_NUMERIC_OP: > Status =3D HiiValueToRedfishNumeric (Value, RedfishValue); > if (EFI_ERROR (Status)) { > -- > 2.17.1