From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Nhi Pham <nhi@os.amperecomputing.com>,
Nickle Wang <nicklew@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules
Date: Wed, 11 Oct 2023 05:14:26 +0000 [thread overview]
Message-ID: <MN2PR12MB39664A3AE079B99E50EE1F41EACCA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <d5c2a83e-c154-9b9e-a2ec-2b67e9b3d13f@os.amperecomputing.com>
[AMD Official Use Only - General]
https://github.com/tianocore/edk2/pull/4906 is merged.
Abner
> -----Original Message-----
> From: Nhi Pham <nhi@os.amperecomputing.com>
> Sent: Wednesday, October 11, 2023 12:14 PM
> To: Nickle Wang <nicklew@nvidia.com>; Chang, Abner
> <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [PATCH] RedfishPkg: Use base version SortLib for the specific
> modules
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Thanks for writing this patch.
>
> Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
> Tested-by: Nhi Pham <nhi@os.amperecomputing.com>
>
> Regards,
> Nhi
>
> On 10/11/2023 10:49 AM, Nickle Wang wrote:
> >
> > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> >
> > Regards,
> > Nickle
> >
> >> -----Original Message-----
> >> From: abner.chang@amd.com <abner.chang@amd.com>
> >> Sent: Wednesday, October 11, 2023 11:41 AM
> >> To: devel@edk2.groups.io
> >> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy
> <igork@ami.com>; Nhi
> >> Pham <nhi@os.amperecomputing.com>
> >> Subject: [PATCH] RedfishPkg: Use base version SortLib for the specific
> modules
> >>
> >> External email: Use caution opening links or attachments
> >>
> >>
> >> From: Abner Chang <abner.chang@amd.com>
> >>
> >> BZ #: 4566
> >>
> >> Update Redfish modules to use the small footprint version of base SortLib
> by the
> >> means of module scoped subelement <LibraryClass>. With this the platform
> level
> >> SortLib (full version) is not impacted if Redfish.dsc.inc is included in
> platform DSC.
> >>
> >> Signed-off-by: Abner Chang <abner.chang@amd.com>
> >> Cc: Nickle Wang <nicklew@nvidia.com>
> >> Cc: Igor Kulchytskyy <igork@ami.com>
> >> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> >> ---
> >> RedfishPkg/RedfishComponents.dsc.inc | 10 ++++++++--
> >> RedfishPkg/RedfishLibs.dsc.inc | 1 -
> >> 2 files changed, 8 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/RedfishPkg/RedfishComponents.dsc.inc
> >> b/RedfishPkg/RedfishComponents.dsc.inc
> >> index 1c4284d3ecf..464ffc86064 100644
> >> --- a/RedfishPkg/RedfishComponents.dsc.inc
> >> +++ b/RedfishPkg/RedfishComponents.dsc.inc
> >> @@ -16,9 +16,15 @@
> >> !if $(REDFISH_ENABLE) == TRUE
> >> RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf
> >> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
> >> - RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf
> >> + RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf {
> >> + <LibraryClasses>
> >> + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> >> + }
> >> RedfishPkg/RedfishCredentialDxe/RedfishCredentialDxe.inf
> >> - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf
> >> + RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf {
> >> + <LibraryClasses>
> >> + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> >> + }
> >> RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf
> >> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf
> >>
> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> >> diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> b/RedfishPkg/RedfishLibs.dsc.inc index
> >> 03b7ef6f328..5426957da87 100644
> >> --- a/RedfishPkg/RedfishLibs.dsc.inc
> >> +++ b/RedfishPkg/RedfishLibs.dsc.inc
> >> @@ -14,7 +14,6 @@
> >> !if $(REDFISH_ENABLE) == TRUE
> >> RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> >> Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> >> - SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> >> RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> >> JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> >> RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> >> --
> >> 2.37.1.windows.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109515): https://edk2.groups.io/g/devel/message/109515
Mute This Topic: https://groups.io/mt/101890398/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-11 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 3:41 [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules Chang, Abner via groups.io
2023-10-11 3:49 ` Nickle Wang via groups.io
2023-10-11 4:13 ` Nhi Pham via groups.io
2023-10-11 5:14 ` Chang, Abner via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB39664A3AE079B99E50EE1F41EACCA@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox