From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B0A90D80696 for ; Mon, 2 Oct 2023 02:37:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=t753IwYS5PoqBzZ98Itl09K+Dp9nrvREB53NTJ1Teic=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696214221; v=1; b=TpDsR/U2O9jnvpIzCjE9l8GM+VpftyD6fwZrysfkp75jRR+2LXrTmFFznHOdtwjsPJbjqJBS bSbDriP2OQIR3JaVTSAEglv1EXbWw1Qks9/QRVUyTpjn9hFHr14uE3KUIbk+mwbiJPBHGQth6kc iC5i50S7DrYaiAVBg6xasAmw= X-Received: by 127.0.0.2 with SMTP id lbeNYY7687511xv8xxoR1Fv6; Sun, 01 Oct 2023 19:37:01 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.84]) by mx.groups.io with SMTP id smtpd.web10.73865.1696214221048934024 for ; Sun, 01 Oct 2023 19:37:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4CcQQGPqp6hx/4hHLvv8jWzxvvsOx1nGESO15O3+gr7mxCAFjjDmSO2H5S6A3QCyQSc3NoQsURPi5jxEqyP2MEa5cQjY8MpsfBvA6Zmoo541iShOJoIqQJFYe9CVGcMqO02vsg74XrbAfuJ+V1bT0RBXdm+mRSvi+b2HXFADvD8m0F+he6RgcrPrAbdrgVwAx7pfaA5R5V78NB8EG8D9/NX5RHP34Rh2wfvuP7gko9aYoYkRLMXR0YpOSRbk03nz2KyDhcZeMbtU+rIiOofp1PAORqNXCyo2aTeAJEY9+WhiVbQtCwjCvGwg7b6/yDp2Wpt4+0x0bjkeewlwlp5KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjC5terjuqI4LaRViXmUy/18w+upJa7CJd0fY0Z56E0=; b=CbZxHENk+LTTlYbh//fYm3+q1qkdrV2+od6WVUBXOBWmKXAo+JSNhFcpw4vlU7lHWw/b11PnPTNeFIZW5w2SO8YWf0WGHEzg7jTXF1aUEqsvjv5oK22vt1AfdJFXdZ/iRJIOdSABnd6RKBpUmF5eLR2joZVImsSSjpU7iLh4Fc1yAavaPV1/LZcqEsj55MXXQ/+/e9sLA6Wa7sgdc3BjiL90WynTCJYZpOPJO4RVrgahIAUL4UrcxMw+8SLKSZtAjsM2tpBSl0wL1KyY3vBU414oc35TVHOXBPFGPtx1zQ3jES9nDcpJ8ZwZMr9Xw9YaMv3h8R8JBQxebyHd0zjJBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB9152.namprd12.prod.outlook.com (2603:10b6:510:2ec::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.24; Mon, 2 Oct 2023 02:36:55 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:36:55 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 7/9] RedfishClientPkg: fix memory leak Thread-Topic: [PATCH 7/9] RedfishClientPkg: fix memory leak Thread-Index: AQHZ8yA5yVeHACb7OEmITelJpUlF7bA1zFiw Date: Mon, 2 Oct 2023 02:36:55 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-8-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-8-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a5cd03a8-04dc-4b3d-8975-b60bfcbe9166;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:36:51Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB9152:EE_ x-ms-office365-filtering-correlation-id: 0d25bcde-6955-4147-554a-08dbc2f0713e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: BGLu1UMkBzQAoPxhbWUxREH5dFAUhOKeihDQyIbJWkCVACOdOd59JyfLT0uwweXBvAP7ti0UyoVhrqoqzcew39rkfrE+tJCfzFjqCVMqXPxshS3i9nKFhfLEeWH1nR4Hqg9KhpAQCmlFj8puvlxeASKm9N2+hA9/O+EmI+dT1/xBVwsk37O8cxLCJIBanXChVQQQ2JC7GErI0pPGdcgfg/bTfMWspK50SNR5RYx2WKuixRaq1Zo0eqQyeSoB8nrR2ubWbdgb/Tehdx4lFXY+V0lsap/i50GCcAbNK570i7NHrUPE4L6FmxRuzFvFdB7fP9TJ/h+rFAv2cQZwn/fSiDUlt1LClDJHeF5Yqu0fWdU1vXmnMN8oXtBPv8hRmbczonO7RbJ9tVfVrPfRSkDD2oshaKe6M5ljGdWKehedYHl7O4/2F+Lq8TRtM+M+7FGHydB8lCtM9p8MnxH93vDxRq72mpIU8gijn2yH5TFPekssFa+N5vKo4M3Fo5ChhQYLstOT7ndEoL1tqij0lt4KgkOvJkzZilJAEHtEWMisnhydyjA5fe5L74J9O83XM2jec7PSHi058oOXDhiKSnPjvtryTNgABcklqbzdHlszR/8RSCWx33Jn26NCUvGiy8W8 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ic0BGr6hyqCTlB8WQKWL6mcbhX0GMi+x4p996hnwFfuKrjTfg6I5PNczydn9?= =?us-ascii?Q?by2fQcDzbuUzQ72jPdfkuJni6imoqF9WJZzfPN3XfeK2iwVhfYBstC+3XZVj?= =?us-ascii?Q?zgNXcYuprKxYnOlC2YmlAwCVXxQq2XVkg4Nodz4/2mZWzO5D2X+wq2DoAJSM?= =?us-ascii?Q?MMxiWDWxnYQpEFsm46OVPwlBWHW7qBctyCX4pMPUcLaxgjux88OYfw8A66qk?= =?us-ascii?Q?vOjqFJd23Jpz/B+YU1d0WsAZ0oZDxc6pKXZqiDFtbfCTerNYYi3/p9zUwAZr?= =?us-ascii?Q?NrA2r4yyJD/F+4WD5cdLfG3WjMGNWJouH41xk1zBJSF69ksR1YJetUM9k2XF?= =?us-ascii?Q?jj04VWggwOExj2XUXboXRb4HdAVdjo5YCF/c+1jQinoYS24BxlW0YXLjaXRu?= =?us-ascii?Q?/YcIQQKwgxzwJ5wP6E1HO6UDcPUY4i7kUd1l2g4+2xegwSMJw+oLzZVNqB7+?= =?us-ascii?Q?X1L81kMGLA/MW6OdY970W+RYq0d1y7R7ClAVbrjMo832AOrs6/4ocmlP0liE?= =?us-ascii?Q?L2sPsab6Ykq3OUa+iY53SyEMkYmtNtTfmfukNvi+vTpKZGebJAspxiks+xd9?= =?us-ascii?Q?GYs1UBHEzvYl59/5vUrOzn9sR0yAaHm1v0VkuTN9X1FYAK3QjFYz4gyqhwn9?= =?us-ascii?Q?VK0Wa2iJeIrzE1TZdYSFFsDOyXNTiDGM824QtGKqukkOT+RclWE/MNODhQ8g?= =?us-ascii?Q?zBM84ssyh/kBV7repbFvaqNbD6B9RGFjLBO6ZPRvQ3WiRxo9z5+JKC25BPtH?= =?us-ascii?Q?lc0zA7e7leTJcGyMuad/msoyFV/S1TeW5+723FSRQqQav1UDprXzA2iKnBCY?= =?us-ascii?Q?7Dz0DdW9IEEOYW8eDimIWugQg5NBol4ibGpyzUsvxEke7XPW66wl3L67ZT0w?= =?us-ascii?Q?9A/3/OwFu/FoZfChI+rPeIRn9/sYnNlL6b09oyP6qihJi9FBtUkYMiFquIaS?= =?us-ascii?Q?aKpvqOxBLwBk3t0EiUfBeSQ4Z/S7JVmWEQWiB2DWZHzzn8tpk1DbdI73SGPO?= =?us-ascii?Q?POeG5d2ZS3W679GEDyE93IN1vTd1T2O321LiEgXTNxLzDHcO+19i1bzufI4l?= =?us-ascii?Q?iDAb5Jnio/V8+65qrEVZKq7wYvhXrqJhnh3ST9WqdOZNqjjDwOntJ5GZhgza?= =?us-ascii?Q?kmGX2joE8VuBAXjfcmND48PI67OGcCbBl6JqY7SY+qNIzpMz4XXkVv1MsQ8W?= =?us-ascii?Q?hidnUu0x3uXseHiZ4EHsvxoeYuADKIYMnVyjWYhoeWExUzDrD5Xb1OkFyUAX?= =?us-ascii?Q?8BUDwH59nJ4tpxeWye9Y7sqPBSMcj9cEyj/0Awe/lWs8SipzCEss08Qb2Pjj?= =?us-ascii?Q?pKdKAQog77WLprrfPxdqwAs8jkcb4psRmAM0CC3QUjtvE5U+PjHwDdZMMDFf?= =?us-ascii?Q?BJBVaRfdcY+ViPLARg+XGsP2cTwiVWyCgaDTXBrIs2N7gbNrjVn9NKjV1DfO?= =?us-ascii?Q?CzV1Xadpg2PcAKmpwYkI2XOkGp1Pv146PBFCxLq0RPvgMad657Vso58F9TEk?= =?us-ascii?Q?mn58ZCjWey/8hXO0KiBWzUs7c2NuiswCsgDQvSYkciSacSVnp7E0EwS3rCZh?= =?us-ascii?Q?EBQQMOU1/Dnlv/njD4o=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d25bcde-6955-4147-554a-08dbc2f0713e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:36:55.0576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Ni4YZMpx+Vu6/cccB8mnp/kwFvMbWoXGwPPFYGFhTScsD/Plbc/0vuIruELCRqu6p/sc965WpgHltQ4dzF4Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9152 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dLZdGckcrFukFE9zdkoCrv9ex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="TpDsR/U2"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 7/9] RedfishClientPkg: fix memory leak > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This patch fixes leak in RedfishExternalResourceResourceFeatureCallback > function. > > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index 32dca964aa0a..9b336d3de479 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -718,6 +718,7 @@ RedfishExternalResourceResourceFeatureCallback ( > Private->Uri =3D RedfishGetUri (ResourceUri); > > if (Private->Uri =3D=3D NULL) { > > ASSERT (FALSE); > > + FreePool (ResourceUri); > > return EFI_OUT_OF_RESOURCES; > > } > > > > @@ -727,6 +728,7 @@ RedfishExternalResourceResourceFeatureCallback ( > } > > > > FreePool (Private->Uri); > > + FreePool (ResourceUri); > > return Status; > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109247): https://edk2.groups.io/g/devel/message/109247 Mute This Topic: https://groups.io/mt/101667467/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-