From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nvidia.com>, Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement
Date: Tue, 5 Dec 2023 01:49:58 +0000 [thread overview]
Message-ID: <MN2PR12MB39664FB5B9EC1AE50A4AA75EEA85A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAL77WPAWYLEj2VBZFW4n7tMingL_Wm=Q6q0WrvLZO3Z=6FCg5g@mail.gmail.com>
[AMD Official Use Only - General]
That's fine Mike, I will just create a PR and update it with your Acked-by.
Abner
> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Monday, December 4, 2023 6:59 PM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and
> Redfish service enablement
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> You can add my Acked-by to each commit, if it won't take to much time
> for resending series, etc.
>
> Regards,
> Mike
>
>
> On Mon, Dec 4, 2023 at 12:08 PM Chang, Abner via groups.io
> <abner.chang=amd.com@groups.io> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Mike, would you like to having you Acked-by on each commit?
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Monday, December 4, 2023 3:18 PM
> > > To: Chang, Abner <Abner.Chang@amd.com>
> > > Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>; Igor
> > > Kulchytskyy <igork@ami.com>
> > > Subject: Re: [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish
> > > service enablement
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Mon, Nov 27, 2023 at 8:31 AM <abner.chang@amd.com> wrote:
> > > >
> > > > From: Abner Chang <abner.chang@amd.com>
> > > >
> > > > In V3: Address Mike's comments to V2.
> > > >
> > > > In V2: Send additional two patches those are missed
> > > > in V1.
> > > >
> > > > This patch set updates the algorithm of BMC USB
> > > > NIC discovery and fixes some bugs.
> > > >
> > > > - Add a new protocol to trigger the notification
> > > > of Redfish Host Interface readiness.
> > > > This fixes the issue Redfish config handler driver
> > > > acquires Redfish service before Redfish Host
> > > > Interface is published.
> > > > - Add more error debug messages.
> > > > - Address some minor issues
> > > >
> > > > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > >
> > > > Abner Chang (9):
> > > > RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm
> > > > RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness
> > > > notification
> > > > RedfishPkg/RedfishConfigHandler: Use Redfish HI readiness notification
> > > > RedfishPkg/RedfishConfigHandler: Correct the prototype of callback
> > > > function
> > > > RedfishPkg/RedfishDiscovery: Add more debug message
> > > > RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code
> > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC
> > > > address pointer
> > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record
> > > > size
> > > > RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption
> > > > issue
> > > >
> > > > RedfishPkg/RedfishPkg.dec | 3 +
> > > > .../RedfishConfigHandlerDriver.inf | 9 +-
> > > > .../RedfishHostInterfaceDxe.inf | 3 +-
> > > > .../RedfishDiscoverInternal.h | 2 +
> > > > .../PlatformHostInterfaceBmcUsbNicLib.c | 196 ++++++++++++------
> > > > .../RedfishConfigHandlerDriver.c | 170 +++++++++------
> > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 23 ++
> > > > .../RedfishSmbiosHostInterface.c | 20 +-
> > > > .../RedfishHostInterfaceDxe.c | 18 ++
> > > > 9 files changed, 315 insertions(+), 129 deletions(-)
> > > >
> > > > --
> > > > 2.37.1.windows.1
> > > >
> > >
> > > Looks good to me.
> > > Thank you.
> > >
> > > Regards,
> > > Mike
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112059): https://edk2.groups.io/g/devel/message/112059
Mute This Topic: https://groups.io/mt/102824306/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-12-05 1:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 5:30 [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement Chang, Abner via groups.io
2023-11-27 5:30 ` [edk2-devel] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm Chang, Abner via groups.io
2023-12-01 23:27 ` Igor Kulchytskyy via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 2/9] RedfishPkg/RedfishHostInterfaceDxe: Add Redfish HI readiness notification Chang, Abner via groups.io
2023-12-04 7:16 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 3/9] RedfishPkg/RedfishConfigHandler: Use " Chang, Abner via groups.io
2023-12-04 7:17 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 4/9] RedfishPkg/RedfishConfigHandler: Correct the prototype of callback function Chang, Abner via groups.io
2023-12-04 7:17 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 5/9] RedfishPkg/RedfishDiscovery: Add more debug message Chang, Abner via groups.io
2023-12-04 7:18 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 6/9] RedfishPkg/RedfishDiscovery: Refine SMBIOS 42h code Chang, Abner via groups.io
2023-12-04 7:18 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect reference of MAC address pointer Chang, Abner via groups.io
2023-12-04 7:19 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Chang, Abner via groups.io
2023-12-04 7:19 ` Nickle Wang via groups.io
2023-11-27 5:31 ` [edk2-devel] [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption issue Chang, Abner via groups.io
2023-12-04 7:20 ` Nickle Wang via groups.io
[not found] ` <179B63DFD0330B10.32091@groups.io>
2023-12-04 7:14 ` [edk2-devel] [PATCH V3 1/9] RedfishPkg/BmcUsbNicLib: Update BMC USB NIC searching algorithm Nickle Wang via groups.io
2023-12-04 7:18 ` [edk2-devel] [PATCH V3 0/9] Refine BMC USB NIC discovery and Redfish service enablement Mike Maslenkin
2023-12-04 9:08 ` Chang, Abner via groups.io
2023-12-04 10:59 ` Mike Maslenkin
2023-12-05 1:49 ` Chang, Abner via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB39664FB5B9EC1AE50A4AA75EEA85A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox