From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0F786AC0ACC for ; Mon, 18 Dec 2023 03:30:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4GuTqOnP+4fqHrqcL7ZZtZcqBRuriTxMFFDa+5jEqrY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702870208; v=1; b=CI25NyZucf9sHvz9lyAjcNW5pPXwZy2yXS1r8U0t2nhdvtu5UQkDvMRLDVwOT58VLk2TK+DD LhBt3CZC4ZaR676uKv9/MUXNz10BULnBpRVN5W4TAFZA8QnVZ/fLd6jahbFi7PK77umGywoV0UP Tr9qnnq8Gg6az0G6NjhlqgP8= X-Received: by 127.0.0.2 with SMTP id VXcsYY7687511xkCit1WPNPh; Sun, 17 Dec 2023 19:30:08 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.80]) by mx.groups.io with SMTP id smtpd.web11.34896.1702870207872433340 for ; Sun, 17 Dec 2023 19:30:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DF9rCLieJBOEkm7EwC6Xgqw1I7INhLi/7I8pI0k25WJ2e+x+E7nx88ItyCRADvZo2tv83/go2ccM/ZCrSHwwcnXvixX3O8Cr1TVUjX2jOtwv2i/ldMzxn9GqvA2R6PrsdpRVctv4hopf6YgD+02OHC55XQ/PEpY9+PvTtU2Qmjx8WPF2Xki8PxlOegqe5ysibBIC1dAU1v5AivqVwDLgeM+XxGU4qq2hHCMqMcuZFwEQODUGP0CtQ/ZySpxzlj/ZY0bOmc/om6DOHYnxIWGYheOeGrrlEqgFhJWUDEzxzH2+nmulBCdIaA/zuoHT2jQ2nRBzjnrJBJaOZ53pIrVukA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5/M27Pme9XFAP0i03FOSPLnFeG4LTUZ665fxjk1+pec=; b=SWRYqLyqoppR5jn9HAZA+j92usmFFWPIq3DPWeyPqaqC2O3bc9ZX/I+OtrP0HbkAxxC10b/nF7mAdeF+RgpHRzbgx84B0VlgRV3h38qQz4YgUGscnczbOLQQrSpu3dWc+qGKE3/X8Ja3jdwh0/ifronjRLQs5oHaBvGRPm6r9AGITLGGsCtJlMROQQPHuJgUbPI0OXKLY/7z6gXNXiujFI6KJ5M6xzd6RL4fG4bd7BPgMK/UqJs+ZX4xBq7PVVcD/XkmzI53oHys+F6XrxkvKKO+5Y7AeZYgZhnmkdc8dY9+gfiAArELTpQJ1GV/wzBRX7zw5D3Pu4QtfhEw4OdR7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS7PR12MB5790.namprd12.prod.outlook.com (2603:10b6:8:75::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 03:30:05 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 03:30:05 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Thread-Topic: [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Thread-Index: AQHaLuTIichWTyoXoUOuW6J0kTnY9LCuZy7w Date: Mon, 18 Dec 2023 03:30:05 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-9-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-9-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=045bbb70-4e4a-4726-8f31-9dbaa355171b;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T03:30:01Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS7PR12MB5790:EE_ x-ms-office365-filtering-correlation-id: a7caee02-10f6-4c02-cd53-08dbff79a0b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: DZGvxGC7ND4qF7AjdkgrKbTTSrjT3ajpmRf9AN83KoRhEkD74z7NOT6w/WgtwQiw3i58BUZU0UJa2BpMm7mmXm5oiDBNBIhgD2q8imWYdCRyG1eTC7IZ4VzBUXJ4OndFCY4M8uDT0WJ2yQQDMDvQstMAm8CswxXPXhU+P4Zr8of1E/XZ9sZ+WAeKeysGE4m1HD6VVS/41998u5/iZEZsaVESLi3H/qqSlfREsF5JSvaHNoZ0WowIynSG0L0N4WnAOO+SRbD+Wbv9PzoMb3jmTEu++nkfTBKi5Sz2/+61Sie+6BW6tL2fygfRwKzJaxVXzyFvoB3ioyo39UE2tLxt3qk94akCHUR2RDRc7vgPy/A8oU6EcYesi9o2touKBPsCaZGDsXqHsCalmGcaMGVJwbHjGiOuXE9hJOuMTSMlfRAg5fkyYyr7mqhvLSeTPEiNJgJjA+VdP2h3d2vRNYOKF+Lr3gJA9RvE38SEoMa65LwBH/iDfa7FK+7wNcyzYqjBL0uBzUwAZ/BhzxvcNlhLfqZV67hiJLadQltvO0UbuMoYBhZwceFeTVDdTVyCNEqT2ymc3Em/3R/TnOc9mFun226DfkPNQ23rSjgypkEuh5kWSuv9FtkJik7kGwwAInNcRUVqKUyJR5cMYqa79MIFxA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KSwkNejxeNfx1hPA0HUrPGlFKvvpXVJVB8nA4WgHbI6BLH6Bsv42v3PVc2DT?= =?us-ascii?Q?PwM8PjYnVPAiKtfr4q9T1oIJXsqfaV7S3HjoeSt/SSTLYhaWJrJBSWTehmTf?= =?us-ascii?Q?y2yC0G7wZlCcQnMrtzsd4wpNtsdIdvu3uirBNT1pb7thi7xNxgsxf+RrRvGc?= =?us-ascii?Q?sMJN2kfkY0gK+SKoe/I51GjQ75uHWwfFfYEo+fToc40Vw1NH+NtY6XAPhI93?= =?us-ascii?Q?LFY+B+awzJ2ejwM00wzq44UsdMyAzMtYM7kYZctesqsYuR47Ca+CpAooknfC?= =?us-ascii?Q?p58yxUOhs6FYfMXHmk2pFN9ZIEBJgHEVcz5sr3eaVlFHbx9fGfwwXQIRgOIr?= =?us-ascii?Q?lHk6dBnJScyJLjDD1wO+0swqrLoURQs8xH5VuVRhaGsYHgUCif/TW2JfYLv4?= =?us-ascii?Q?DFlB/1RhXW2GUBdHvSobGQJjVUU9egMgG53SMVj6HZ+1VW22jWJsubipfwz3?= =?us-ascii?Q?ZR0cbyeiYzY9i2NFVguQKQE6yKjS2cITcSr03TgNbgHvEel/6xNCdaejFcor?= =?us-ascii?Q?MKWNHXkzcFUegK4zZTAK0QK694LRh+/0l8SoaUiJm4YJMr+QLIL2z0QO1WIw?= =?us-ascii?Q?0c4sccQ7FQj3MWIrrReki2wmU7uR7892HlOvHAJTVU56vOwGTqSTwlx7Wyjh?= =?us-ascii?Q?Oy2maCD8yWEMvJmK6HRAH5x6jc1QuuxJEng2hBtBckX+BH+69K9m7qrQ6PtJ?= =?us-ascii?Q?lloSHMQbpzpWrNqmig3uruV3pkVqKKWiWqEkxVcJL7Ad37HguHmBn378oXUF?= =?us-ascii?Q?/hCzYFv9Msewd8QbRTI8oVZCtNsPP837uhFBFK0t/L28ZHkYnu4awp1nU/Kf?= =?us-ascii?Q?0xzJMyqFeayKQA7Rz127JQay5BRWTyyl5FfToU9n6YWTJ/Xz0qRJV7P3fcZW?= =?us-ascii?Q?phwOeXGs/8esrAPdCgWUVg0h2M63A8jwZ8/qYGiiP7mv3XI1FUz70hUUK1V/?= =?us-ascii?Q?RHGrV6xMBQA4TzDqH4bhDT0Q4OFQUIxG8dMMhrcAfgxTuGcPYP7yVBpdvo4B?= =?us-ascii?Q?VgE2cFZcIkcpfOyj+04rX+cvWDRUWgO8kxiG11iCUNHqWmPg1dEHugTYHPH3?= =?us-ascii?Q?Dgo+18EKibaJ8G9eZ7HYYkiHI64X4K1z+cTXJGbpMpln/DqIQ6JndDfWT//e?= =?us-ascii?Q?IZLGNJv86hb8IIOahJJxmZtqwVTHCVNgkencznvexHG/4CmcvQVrBLleyb1S?= =?us-ascii?Q?oSRrThhRilgrKBO8FR53AFipQpNryWnZfKbK2qbMN+WcTtfWuz9/oDhqmtWG?= =?us-ascii?Q?7MBk2/Fv8WJ5bkbg/CE+h5cKjbFsbK2e4Ri3mc9w5d2WqQxP75/BcMLlT7rV?= =?us-ascii?Q?pdnvs/v+jGmLYWdNGeuAH92//Zz7JPrEA+xiguXjcW9OhyLBPAKgx4tz9oS4?= =?us-ascii?Q?V/bvcPwkcQ7Rm3eUBrjEZbadcMkstJmA1WjqbJh3Rmw6B8qIjzn9nnw+oLSf?= =?us-ascii?Q?mHeYOy5CYBQnSckfMEuQRVsBdPfBdBOWvzgkBTeDbeMYKHe6S2kIcBjL4cl5?= =?us-ascii?Q?o/Bt3AHXfRpkVUE2ioqD3mf7cEVH8DD2evnIR5SR74osXfZMrypeVExiyaeg?= =?us-ascii?Q?+YNAyx1HQeBNYbHcY8+GxtC3XAzboJt7ZHshuI05?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7caee02-10f6-4c02-cd53-08dbff79a0b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 03:30:05.4573 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vIaqD3YFp9UxZiSeD/5YjjQWUNjLyRihFZEStnotkI0XjyIv/nB6lMND+9h/iL6ZYA5jC5MW4MHH2Ps+WZTkPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5790 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9YA5pXC6tNEoOPaRgwE94uW3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CI25NyZu; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> > PcdRedfishService > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Mike Maslenkin > --- > EmulatorPkg/EmulatorPkg.dec | 8 ++++---- > .../RedfishPlatformCredentialLib.c | 12 ++++++------ > .../RedfishPlatformCredentialLib.inf | 8 ++++---- > 3 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec > index fe81652b0478..c2a92923e9b7 100644 > --- a/EmulatorPkg/EmulatorPkg.dec > +++ b/EmulatorPkg/EmulatorPkg.dec > @@ -77,15 +77,15 @@ > ## Platform level Redfish Service control PCD > > # These PCDs are used to stop the Redfish sevice when secure boot is > disabled > > # or exit boot service. > > - > gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TR > UE|BOOLEAN|0x00001020 > > - > gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE| > BOOLEAN|0x00001021 > > + > gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|T > RUE|BOOLEAN|0x00001020 > > + > gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE| > BOOLEAN|0x00001021 > > ## > > # edk2 Redfish implementation on Emulator package is designed to acces= s > > # to Redfish simulator. > > # https://github.com/DMTF/Redfish-Profile-Simulator > > # The user ID and password are fixed as below. > > - > gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x00 > 001022 > > - > gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOI > D*|0x00001023 > > + > gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x0 > 0001022 > > + > gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|V > OID*|0x00001023 > > > gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT3 > 2|0x00001024 > > > > [PcdsFixedAtBuild, PcdsPatchableInModule] > > diff --git > a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.c > b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.c > index 614eaebb0d0e..5c167fcdea56 100644 > --- > a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.c > +++ > b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.c > @@ -57,8 +57,8 @@ GetRedfishCredential ( > // > > // User ID and Password. > > // > > - UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUse= rId)); > > - PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr > (PcdRedfishServiePassword)); > > + UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUs= erId)); > > + PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr > (PcdRedfishServicePassword)); > > if ((UserIdSize =3D=3D 0) || (PasswordSize =3D=3D 0)) { > > DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for > REdfish service.\n")); > > return EFI_INVALID_PARAMETER; > > @@ -69,7 +69,7 @@ GetRedfishCredential ( > return EFI_OUT_OF_RESOURCES; > > } > > > > - CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), > UserIdSize); > > + CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), > UserIdSize); > > > > *Password =3D AllocateZeroPool (PasswordSize); > > if (*Password =3D=3D NULL) { > > @@ -77,7 +77,7 @@ GetRedfishCredential ( > return EFI_OUT_OF_RESOURCES; > > } > > > > - CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), > PasswordSize); > > + CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), > PasswordSize); > > return EFI_SUCCESS; > > } > > > > @@ -177,7 +177,7 @@ LibStopRedfishService ( > // Check platform PCD to determine the action for stopping > > // Redfish service due to secure boot is disabled. > > // > > - if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) { > > + if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) { > > return EFI_UNSUPPORTED; > > } else { > > // > > @@ -198,7 +198,7 @@ LibStopRedfishService ( > // Check platform PCD to determine the action for stopping > > // Redfish service due to exit boot service. > > // > > - if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) { > > + if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) { > > return EFI_UNSUPPORTED; > > } else { > > mStopRedfishService =3D TRUE; > > diff --git > a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.inf > b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.inf > index 41c389c4a292..9d151f14ee17 100644 > --- > a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.inf > +++ > b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCreden > tialLib.inf > @@ -36,10 +36,10 @@ > UefiLib > > > > [Pcd] > > - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled > ## CONSUMES > > - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## > CONSUMES > > - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## > CONSUMES > > - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## > CONSUMES > > + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled > ## CONSUMES > > + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService #= # > CONSUMES > > + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId #= # > CONSUMES > > + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword #= # > CONSUMES > > > > [Guids] > > gEfiGlobalVariableGuid > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112626): https://edk2.groups.io/g/devel/message/112626 Mute This Topic: https://groups.io/mt/103181043/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-