From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Nickle Wang <nicklew@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>, Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library
Date: Wed, 3 Jan 2024 13:05:36 +0000 [thread overview]
Message-ID: <MN2PR12MB396652C8AC135F35A3F04391EA60A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240103120148.62548-1-nicklew@nvidia.com>
[AMD Official Use Only - General]
Besides the comment given to patch 1/10, for all others Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Wednesday, January 3, 2024 8:02 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce
> Redfish HTTP cache library
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Introduce RedfishHttpCacheLib to improve HTTP GET performance in Redfish
> feature drivers. Feature drivers often query same Redfish resource
> multiple times for different purpose. Add HTTP cache mechanism to improve
> the performance.
>
> An enhanced Redfish HTTP driver is under development and it will replace
> RedfishHttpCacheLib in the future when it is ready. Now, adding
> RedfishHttpCacheLib is to unblock several upstream tasks.
>
> Pull request is opened here for CI testing:
> https://github.com/tianocore/edk2-redfish-client/pull/66
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
>
> Nickle Wang (10):
> RedfishClientPkg: introduce Redfish HTTP cache library
> RedfishClientPkg: use HTTP cache lib
> RedfishClientPkg/ComputerSystemCollectionDxe: use HTTP cache lib
> RedfishClientPkg/ComputerSystem: use HTTP cache lib
> RedfishClientPkg/MemoryCollectionDxe: use HTTP cache lib
> RedfishClientPkg/Memory: use HTTP cache lib
> RedfishClientPkg/Bios: use HTTP cache lib
> RedfishClientPkg/EdkIIRedfishResourceConfigLib: use HTTP cache lib
> RedfishClientPkg/RedfishVersionLib: use HTTP cache lib
> RedfishClientPkg/RedfishFeatureUtilityLib: use HTTP cache lib
>
> RedfishClientPkg/RedfishClientPkg.dec | 3 +-
> RedfishClientPkg/RedfishClientLibs.dsc.inc | 3 +-
> RedfishClientPkg/RedfishClientPkg.dsc | 3 +-
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +-
> .../ComputerSystemCollectionDxe.inf | 2 +
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +-
> .../MemoryCollectionDxe.inf | 2 +
> .../EdkIIRedfishResourceConfigLib.inf | 2 +
> .../RedfishFeatureUtilityLib.inf | 3 +-
> .../RedfishHttpCacheLib.inf | 48 ++
> .../RedfishVersionLib/RedfishVersionLib.inf | 3 +
> .../Library/RedfishFeatureUtilityLib.h | 21 +-
> .../Include/Library/RedfishHttpCacheLib.h | 59 ++
> .../Include/RedfishCollectionCommon.h | 4 +-
> .../Include/RedfishResourceCommon.h | 3 +-
> .../RedfishFeatureUtilityInternal.h | 3 +-
> .../RedfishHttpCacheLibInternal.h | 63 ++
> .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 80 +-
> .../v1_5_0/Dxe/ComputerSystemDxe.c | 70 +-
> .../ComputerSystemCollectionDxe.c | 24 +-
> .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 70 +-
> .../MemoryCollectionDxe/MemoryCollectionDxe.c | 24 +-
> .../EdkIIRedfishResourceConfigLib.c | 6 +-
> .../RedfishFeatureUtilityLib.c | 67 +-
> .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ++++++++++++++++++
> .../RedfishVersionLib/RedfishVersionLib.c | 30 +-
> 27 files changed, 1174 insertions(+), 202 deletions(-)
> create mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.inf
> create mode 100644
> RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h
> create mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLibInternal.h
> create mode 100644
> RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHttpCacheLib.c
>
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113086): https://edk2.groups.io/g/devel/message/113086
Mute This Topic: https://groups.io/mt/103500346/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-03 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 12:01 [edk2-devel] [edk2-redfish-client][PATCH 00/10] RedfishClientPkg: introduce Redfish HTTP cache library Nickle Wang via groups.io
2024-01-03 13:05 ` Chang, Abner via groups.io [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-03 11:58 Nickle Wang via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396652C8AC135F35A3F04391EA60A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox