Re: [edk2-devel] [PATCH v4 8/9] ManageabilityPkg: Add IpmiProtocol to Manageability Package

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Hi Tinh,
Apparently I missed some of your feedback, it was moved to other email folder that I don’t expect it should be.
I will add those modules for AARCH64.
Thanks
Abner

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> Sent: Tuesday, March 28, 2023 8:23 PM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Isaac Oram
> <isaac.w.oram@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [PATCH v4 8/9] ManageabilityPkg: Add
> IpmiProtocol to Manageability Package
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> The DXE and PEI modules should work on aarch64.
> 
> Please see my suggestion below.
> 
> On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote:
> > From: Abner Chang <abner.chang@amd.com>
> >
> > Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg.
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > ---
> >   Features/ManageabilityPkg/Include/Dsc/Manageability.dsc | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > index 994c93f17c..0d868fdf4a 100644
> > --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > @@ -16,3 +16,10 @@
> >     NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> >     ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>    ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>    BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> 
> [LibraryClasses.AARCH64.PEIM]
> PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiS
> ervicesTablePointerLib.inf
> >
> > +[Components.IA32]
> > +  ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> > +
> > +[Components.X64]
> > +  ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
> > +  ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf
> > +
> 
> [Components.IA32, Components.AARCH64]
>    ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> 
> [Components.X64, Components.AARCH64]
>    ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf
> 
> [Components.X64]
>    ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf