From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 738C4D801DB for ; Wed, 8 Nov 2023 03:22:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JnYzuQ674tbrS8a+OaCz3+1nCDtz8/OeQKa+zZt/XnA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699413751; v=1; b=NPmUxsNtqr/atXr2YgdglRT3cQctCb3XNq3HzEbaLhm5t3J1Dk/V2e2eUW5xHIgabp1bW8Br 3vmDx91KxkL93H+7zIeeey+41D+u0Oxys8NdpuyD8ifSYgQ2M/0AyPiz27FpBuLF+N2ew9TnO9c moAo+fIqj3lWwae6JacEgj+I= X-Received: by 127.0.0.2 with SMTP id X5k2YY7687511xma1Fk4xKEC; Tue, 07 Nov 2023 19:22:31 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.42]) by mx.groups.io with SMTP id smtpd.web10.6384.1699413750164514684 for ; Tue, 07 Nov 2023 19:22:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZiLl/oBbVO+ifq0Ft+z6QzdqnPS8pwLktnDuUMppKpIcK+7AQk9rKIVOHtkYoqMVhfIRXb5SEtiXkpCC1QfJ2ucLRLexHggJlG5Sggt5Mafso5qa6+5h+x9ogf5QSHYf40FuV2oll1BWXrezvhgJmnTQAFvnlBclpomdNg3rpnkPUua5f0df2Y6XVc9US6SgtG/2TqAxpbS5+Z2TuwWhbFDOXaw84A8FfyINIZwgCD5MAjo5Lkec3SSb1tIt4+gr9sZLpR5TLwowGBFUR8Qd3aZpkS7QqB/aPwO1BKqEG67n3NtoyrEpOnAlul3o81hwItyYX287pFzSEAsB0orf9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=po0UCbRo96Jm7ddeoWE1d1bdZcdt9KojpBablXfTQQc=; b=b+IuJLWF3X9vBsm1m1VH/AamrEQP3LGPKCqyiN0VlEGavihIWevRrQ8MnYhkVVu6QgEwIJEdUpzNfWp1owlr6Ta/JHagDJzgg86jp8mBPnm2+Su0G7DnmYEz2sySCRY9y+DbQCFOGOdEKZzamNS/4Tey1o1ei1dmgpKlUZMnirxAP5r4JgH+1xGf/BmC8zP2uBtMnWMKk+T1RZW3EZmZ2pKWFQY349Tm7K+HVV4FiE7aruEq8oRAQ6Kk5dmPgiQfkcAGCvGrauuAKFFqW4fFC5N2FJ51e+9+fbBJ2OE+thN1YdiVxowN6wbQenrPfrj1mtB3FXSkxq+Yn2un3DGHEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH2PR12MB4038.namprd12.prod.outlook.com (2603:10b6:610:7b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Wed, 8 Nov 2023 03:22:25 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%7]) with mapi id 15.20.6954.027; Wed, 8 Nov 2023 03:22:25 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" CC: Nate DeSimone , Liming Gao , Chasel Chiu , Li-Xia Huang , "Attar, AbdulLateef (Abdul Lateef)" , Nickle Wang Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg Thread-Index: AQHaCv6iwdZNd+kgZkG7nijXrEEr5rBvzymA Date: Wed, 8 Nov 2023 03:22:25 +0000 Message-ID: References: <1792D0690F720C15.7262@groups.io> In-Reply-To: <1792D0690F720C15.7262@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d8f319ea-a9f8-4aba-ae75-b14c07658554;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-08T03:20:51Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH2PR12MB4038:EE_ x-ms-office365-filtering-correlation-id: 46a4240f-0380-4628-d54f-08dbe009edcd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LwYfDlt38aI8i5sgtqNm+PxgQfp7D7JjQ6agOXhVTiuqYcjDKR7KA0/vX/ePskyamx9tK4pvW+Qm5bFehvwaNrhB07UmIq3oXtWlqrOaS2TSktLN9llKwU1Nf9CsyLSs2vRKGnIPoZzZAt9FTg2hGN78hWO8j6DelA/GOkGJCi3irgoqK3LJlVNjoGu8i6vCDwkvd5xNVqhsz1RPEvSeEqIAk0sijZsn65nlaX+98gndHJhGycUu8oAfDr1IS8AE5AI2AHxAhs1LWS8y5yI0z/WNho54QL3mEUvqHwobCqwh2Gq179kaRwaNWwaAqPzMiKsqykgfxQSMpDh9mnqSu/Ohdi8CVEaleyXAL1GcpHHAiW2gkqIYPCLNQYoEfIHhmeGCKZk+YYCFQEIFspqQOuREfZztZFHs1v4haaO2dxX97Vq1ZL4ru1Sp5hoxSGO9ymLVO0/n4ztpGLQEtLafKF5tRomjTGxhy725NUxM3s9sTJ7xFOmUm0AMDzfrp2s92/LpSGurPjx6t0Wy/vT5KuzndHWVwTsFH4RnUCOb4EvAITVnVvBuzLxtF4NK87CwbJKKWkemDtai7KYkWxZdAHtQ1Xx89rRkcX085ciE7R+KZZtzM4MgHHpD0eWEIbPdCBTyI9Q31zmumu78WG6CP/N4k9NXQ0KytWMrtnVCI6NpnuixVJaIqPp+6kjtwrmZ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dfLATkHmBuxX/mLVeMUmbDtXnDCBNPkO7tdkzx8i1M9BoP4GpuMuWEkhavhq?= =?us-ascii?Q?51eJ5X10rvZUYgOnL6cNE5/PiY+/1uga4QFi/P7kNTCocpQ/8SMdsn0t6c9I?= =?us-ascii?Q?DA5vt2kGuLu/cT1oDQE8kFmS8usvFNWWxzemEvjOR0sCC0TfjRPqWe8E3Ogm?= =?us-ascii?Q?BAVQaCCb6Ro8opf0nI7hsuRvCvXknW/G5W41AZqOtO4g9NIRX7qXxJKiVI5V?= =?us-ascii?Q?ACXYM1xt8ZpgsEU6WpHKFenn7Qfdlgsi+uY7YuisH34yyJ/VzSxkT9APxkcf?= =?us-ascii?Q?q+o0hlOv0bjD8fR9Z8robFouGR+nRQWKkEv/3dpdIUG9Rf/N7E+aC34/zrKl?= =?us-ascii?Q?OrpWmKBd/G8U5racB5et4XjEFGDQ3lKm1XTQNQq5fsxy9Bt1VwRwuJsH/1xS?= =?us-ascii?Q?7OkhlISIOvTzVWlFAqg5NthkKbnGzgq23URSQozvwthWtUfaYZ74QUbd4Tof?= =?us-ascii?Q?pn7kTcoH7sLvddgNf67uZjsIStI+mZSAiRlOk3cEZQPKRmGUpBZ6tJXHqj2P?= =?us-ascii?Q?xUbeRKEwF2PxFr3NdCS0UWv3UH/3e59lRymkWsUxjIDDEsS+y65hEp7uJ5rY?= =?us-ascii?Q?27bUze6vf+OvkT/ybMBV0/RUx72w+YVxDDd2irktIhGVRbiJCHGxtiTMdemZ?= =?us-ascii?Q?IiKoL/J5fJqnsloCY5shptZa60DbZI6shYp//ri/mjppxQSO2zdZi5En+afC?= =?us-ascii?Q?z7xigTFWPjErD+axzOgAJLDADzBw823iN3Di1wGle52GhMY06s3u4obAUBCX?= =?us-ascii?Q?gHw9JPYzGpQUQEaanP631djFdm2MjhD+ucBqJXOvPjy0438Q8N7bAnIGxEzy?= =?us-ascii?Q?Sy1SipdyeSXEPwVqpONVWs35oRG3uE/884Q16xPTD6qIsLsLyucBO7G/JNqL?= =?us-ascii?Q?zI3czOiKUmj4Q4CWbWhDyTKDBh0eLTQK8VIOPvUiue6QwXXsvG+YhNP9upio?= =?us-ascii?Q?TtTgS1WDO2Q3LUmt9JdloqzDxjyBF/SgRw3s7NonqLet17uAhKlf234yZlzS?= =?us-ascii?Q?h5KI7xzfalu4W01AAYeiCokEuckHi7f9WKkLr1rU/pKiAGDGiC0+qN4bh4TB?= =?us-ascii?Q?Lh3+UkNVESDYa7TQS8lTD7qAdcsedjXHEdJQpQAONvc8/7NJfTjQIdGfA5mY?= =?us-ascii?Q?YfBHl1WZNIMhyfoBdUwU1nRunGboq9BtGOQeeqtsWtRxtdkaWs7yy/XrmGCB?= =?us-ascii?Q?jcMIKUiowsIF3jlwRGu9Sr05Uz3tFz1zWzsXluFO/uB/S78ywOOGrJo0ryfS?= =?us-ascii?Q?Ngi5JeGdg0+EJIwMiVIXqvTE8wvg7W9cwrmN0COtCyvba/iVqaqQASDgh/Rz?= =?us-ascii?Q?9kPvLTk23I58oKqScY5FqPBS/agrTD9DNfcRhom1T/sT4NLpko7MQgpRgVLn?= =?us-ascii?Q?B4i/+5KApdWcJ7tRw72goQ0EzY5LmdTJFQd/JZ5c6tQM/0tupbuo1lrnC6r/?= =?us-ascii?Q?Av0WkN2ct2NpXH1hC0UxidpQ7fWgbyD8Lnkg/zwwwA68uS2oIKfRehvPdqg4?= =?us-ascii?Q?6AtaYNFIZS3piG2shBHfGIKQpGCac4ONyr1AWN7ptTcHfwLnUw+MnLH+rbZg?= =?us-ascii?Q?Bmzd6E3AQqx/4Zdp1QM=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46a4240f-0380-4628-d54f-08dbe009edcd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2023 03:22:25.1914 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5In43shRO135teFAq2AXy1jLlHa7OUVxCVUK0ZsFZPFXXX3TXi49LC/VhSoTOQ+7jLHVwnmYqhCm0/qrOcXYaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4038 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yHR9qYyEWG5tbMYJuAP6ZNXsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NPmUxsNt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Hi Nate and Liming, Please check this patch. The one under IpmiFeaturePkg is an old one, we sh= ould remove it to avoid the confusions. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Monday, October 30, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Nate DeSimone ; Liming Gao > ; Chasel Chiu ; Li-Xia > Huang ; Attar, AbdulLateef (Abdul Lateef) > ; Nickle Wang > Subject: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: > Remove IpmiCommandLib from IpmiFeaturePkg > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > From: Abner Chang > > Remove IpmiCommandLib from IpmiFeaturePkg as ManageabilityPkg > already had one and is newer. > > Signed-off-by: Abner Chang > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Chasel Chiu > Cc: Li-Xia Huang > Cc: Abdul Lateef Attar > Cc: Nickle Wang > --- > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 4 - > .../IpmiFeaturePkg/Include/IpmiFeature.dsc | 2 +- > .../Library/IpmiCommandLib/IpmiCommandLib.inf | 32 -- > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 335 ------------------ > .../IpmiCommandLibNetFnChassis.c | 144 -------- > .../IpmiCommandLibNetFnStorage.c | 274 -------------- > .../IpmiCommandLibNetFnTransport.c | 123 ------- > 7 files changed, 1 insertion(+), 913 deletions(-) > delete mode 100644 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > ndLib/IpmiCommandLib.inf > delete mode 100644 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > ndLib/IpmiCommandLibNetFnApp.c > delete mode 100644 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > ndLib/IpmiCommandLibNetFnChassis.c > delete mode 100644 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > ndLib/IpmiCommandLibNetFnStorage.c > delete mode 100644 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiComma > ndLib/IpmiCommandLibNetFnTransport.c > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cb..f26741e244 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -32,10 +32,6 @@ > OsWdt > > [LibraryClasses] > - ## @libraryclass Provides services to send IPMI commands. > - # > - IpmiCommandLib|Include/Library/IpmiCommandLib.inf > - > ## @libraryclass Provides an API for platform-specific IPMI hooks. > # > IpmiCommandLib|Include/Library/IpmiPlatformHookLib.h > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > ure.dsc > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > ure.dsc > index 0401974b82..063638ce56 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > ure.dsc > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat > ure.dsc > @@ -37,7 +37,7 @@ > [LibraryClasses] > IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf > > - > IpmiCommandLib|IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommand > Lib.inf > + > IpmiCommandLib|ManageabilityPkg/Library/IpmiCommandLib/IpmiComman > dLib.inf > > IpmiPlatformHookLib|IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/Ipmi > PlatformHookLibNull.inf > > [LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM] > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLib.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLib.inf > deleted file mode 100644 > index d5c14ff2a4..0000000000 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLib.inf > +++ /dev/null > @@ -1,32 +0,0 @@ > -### @file > -# Component description file for IPMI Command Library. > -# > -# Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> -# > -# SPDX-License-Identifier: BSD-2-Clause-Patent > -# > -### > - > -[Defines] > - INF_VERSION =3D 0x00010005 > - BASE_NAME =3D IpmiCommandLib > - FILE_GUID =3D E599C9C7-5913-40A0-8669-67282E2BEC5= 3 > - MODULE_TYPE =3D UEFI_DRIVER > - VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D IpmiCommandLib > - > -[sources] > - IpmiCommandLibNetFnApp.c > - IpmiCommandLibNetFnTransport.c > - IpmiCommandLibNetFnChassis.c > - IpmiCommandLibNetFnStorage.c > - > -[Packages] > - MdePkg/MdePkg.dec > - MdeModulePkg/MdeModulePkg.dec > - IpmiFeaturePkg/IpmiFeaturePkg.dec > - > -[LibraryClasses] > - BaseMemoryLib > - DebugLib > - IpmiBaseLib > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnApp.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnApp.c > deleted file mode 100644 > index 2e34909f3e..0000000000 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnApp.c > +++ /dev/null > @@ -1,335 +0,0 @@ > -/** @file > - IPMI Command - NetFnApp. > - > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > -#include > -#include > -#include > - > -#include > - > -EFI_STATUS > -EFIAPI > -IpmiGetDeviceId ( > - OUT IPMI_GET_DEVICE_ID_RESPONSE *DeviceId > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*DeviceId); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_DEVICE_ID, > - NULL, > - 0, > - (VOID *)DeviceId, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSelfTestResult ( > - OUT IPMI_SELF_TEST_RESULT_RESPONSE *SelfTestResult > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*SelfTestResult); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_SELFTEST_RESULTS, > - NULL, > - 0, > - (VOID *)SelfTestResult, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiResetWatchdogTimer ( > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_RESET_WATCHDOG_TIMER, > - NULL, > - 0, > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetWatchdogTimer ( > - IN IPMI_SET_WATCHDOG_TIMER_REQUEST *SetWatchdogTimer, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_SET_WATCHDOG_TIMER, > - (VOID *)SetWatchdogTimer, > - sizeof(*SetWatchdogTimer), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetWatchdogTimer ( > - OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetWatchdogTimer); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_WATCHDOG_TIMER, > - NULL, > - 0, > - (VOID *)GetWatchdogTimer, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetBmcGlobalEnables ( > - IN IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST *SetBmcGlobalEnables, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_SET_BMC_GLOBAL_ENABLES, > - (VOID *)SetBmcGlobalEnables, > - sizeof(*SetBmcGlobalEnables), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetBmcGlobalEnables ( > - OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE *GetBmcGlobalEnables > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetBmcGlobalEnables); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_BMC_GLOBAL_ENABLES, > - NULL, > - 0, > - (VOID *)GetBmcGlobalEnables, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiClearMessageFlags ( > - IN IPMI_CLEAR_MESSAGE_FLAGS_REQUEST *ClearMessageFlagsRequest, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_CLEAR_MESSAGE_FLAGS, > - (VOID *)ClearMessageFlagsRequest, > - sizeof(*ClearMessageFlagsRequest), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetMessageFlags ( > - OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE *GetMessageFlagsResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetMessageFlagsResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_MESSAGE_FLAGS, > - NULL, > - 0, > - (VOID *)GetMessageFlagsResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetMessage ( > - OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse, > - IN OUT UINT32 *GetMessageResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_MESSAGE, > - NULL, > - 0, > - (VOID *)GetMessageResponse, > - GetMessageResponseSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSendMessage ( > - IN IPMI_SEND_MESSAGE_REQUEST *SendMessageRequest, > - IN UINT32 SendMessageRequestSize, > - OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse, > - IN OUT UINT32 *SendMessageResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_SEND_MESSAGE, > - (VOID *)SendMessageRequest, > - SendMessageRequestSize, > - (VOID *)SendMessageResponse, > - SendMessageResponseSize > - ); > - return Status; > -} > - > -/** > - This function gets the system UUID. > - > - @param[out] SystemGuid The pointer to retrieve system UUID. > - > - @retval EFI_SUCCESS UUID is returned. > - @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > - @retval Others Other errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -IpmiGetSystemUuid ( > - OUT EFI_GUID *SystemGuid > - ) > -{ > - EFI_STATUS Status; > - UINT32 RequestSize; > - UINT32 ResponseSize; > - IPMI_GET_SYSTEM_UUID_RESPONSE GetSystemUuidResponse; > - > - if (SystemGuid =3D=3D NULL) { > - return EFI_INVALID_PARAMETER; > - } > - RequestSize =3D 0; > - ResponseSize =3D sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_SYSTEM_GUID, > - (VOID *)NULL, > - RequestSize, > - (VOID *)&GetSystemUuidResponse, > - &ResponseSize > - ); > - if (!EFI_ERROR (Status) && GetSystemUuidResponse.CompletionCode =3D=3D > IPMI_COMP_CODE_NORMAL) { > - CopyMem ( > - (VOID *)SystemGuid, > - (VOID *)&GetSystemUuidResponse.SystemUuid, > - sizeof (EFI_GUID) > - ); > - } > - return Status; > -} > - > -/** > - This function gets the channel information. > - > - @param[in] GetChannelInfoRequest The get channel information > request. > - @param[out] GetChannelInfoResponse The get channel information > response. > - @param[out] GetChannelInfoResponseSize When input, the expected si= ze > of response. > - When output, the exact size= of the returned > - response. > - > - @retval EFI_SUCCESS Get channel information successfully. > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > invalid. > - @retval Others Other errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -IpmiGetChannelInfo ( > - IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > - OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > - OUT UINT32 *GetChannelInfoResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - if (GetChannelInfoRequest =3D=3D NULL || > - GetChannelInfoResponse =3D=3D NULL || > - GetChannelInfoResponseSize =3D=3D NULL) { > - return EFI_INVALID_PARAMETER; > - } > - > - *GetChannelInfoResponseSize =3D sizeof > (IPMI_GET_CHANNEL_INFO_RESPONSE); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_APP, > - IPMI_APP_GET_CHANNEL_INFO, > - (UINT8 *)GetChannelInfoRequest, > - sizeof (IPMI_GET_CHANNEL_INFO_REQUEST), > - (UINT8 *)GetChannelInfoResponse, > - GetChannelInfoResponseSize > - ); > - return Status; > -} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnChassis.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnChassis.c > deleted file mode 100644 > index 9c19f52ce4..0000000000 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnChassis.c > +++ /dev/null > @@ -1,144 +0,0 @@ > -/** @file > - IPMI Command - NetFnChassis. > - > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > -#include > -#include > -#include > - > -#include > - > - > -EFI_STATUS > -EFIAPI > -IpmiGetChassisCapabilities ( > - OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE > *GetChassisCapabilitiesResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetChassisCapabilitiesResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_GET_CAPABILITIES, > - NULL, > - 0, > - (VOID *)GetChassisCapabilitiesResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetChassisStatus ( > - OUT IPMI_GET_CHASSIS_STATUS_RESPONSE *GetChassisStatusResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetChassisStatusResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_GET_STATUS, > - NULL, > - 0, > - (VOID *)GetChassisStatusResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiChassisControl ( > - IN IPMI_CHASSIS_CONTROL_REQUEST *ChassisControlRequest, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_CONTROL, > - (VOID *)ChassisControlRequest, > - sizeof(*ChassisControlRequest), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetPowerRestorePolicy ( > - IN IPMI_SET_POWER_RESTORE_POLICY_REQUEST *ChassisControlRequest, > - OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE > *ChassisControlResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*ChassisControlResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_SET_POWER_RESTORE_POLICY, > - (VOID *)ChassisControlRequest, > - sizeof(*ChassisControlRequest), > - (VOID *)ChassisControlResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetSystemBootOptions ( > - IN IPMI_SET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > - OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*BootOptionsResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, > - (VOID *)BootOptionsRequest, > - sizeof(*BootOptionsRequest), > - (VOID *)BootOptionsResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSystemBootOptions ( > - IN IPMI_GET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > - OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*BootOptionsResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_CHASSIS, > - IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, > - (VOID *)BootOptionsRequest, > - sizeof(*BootOptionsRequest), > - (VOID *)BootOptionsResponse, > - &DataSize > - ); > - return Status; > -} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnStorage.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnStorage.c > deleted file mode 100644 > index 2215028089..0000000000 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnStorage.c > +++ /dev/null > @@ -1,274 +0,0 @@ > -/** @file > - IPMI Command - NetFnStorage. > - > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > -#include > -#include > -#include > - > -#include > - > - > -EFI_STATUS > -EFIAPI > -IpmiGetFruInventoryAreaInfo ( > - IN IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST > *GetFruInventoryAreaInfoRequest, > - OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE > *GetFruInventoryAreaInfoResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetFruInventoryAreaInfoResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO, > - (VOID *)GetFruInventoryAreaInfoRequest, > - sizeof(*GetFruInventoryAreaInfoRequest), > - (VOID *)GetFruInventoryAreaInfoResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiReadFruData ( > - IN IPMI_READ_FRU_DATA_REQUEST *ReadFruDataRequest, > - OUT IPMI_READ_FRU_DATA_RESPONSE *ReadFruDataResponse, > - IN OUT UINT32 *ReadFruDataResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_READ_FRU_DATA, > - (VOID *)ReadFruDataRequest, > - sizeof(*ReadFruDataRequest), > - (VOID *)ReadFruDataResponse, > - ReadFruDataResponseSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiWriteFruData ( > - IN IPMI_WRITE_FRU_DATA_REQUEST *WriteFruDataRequest, > - IN UINT32 WriteFruDataRequestSize, > - OUT IPMI_WRITE_FRU_DATA_RESPONSE *WriteFruDataResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*WriteFruDataResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_WRITE_FRU_DATA, > - (VOID *)WriteFruDataRequest, > - WriteFruDataRequestSize, > - (VOID *)WriteFruDataResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSelInfo ( > - OUT IPMI_GET_SEL_INFO_RESPONSE *GetSelInfoResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetSelInfoResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_SEL_INFO, > - NULL, > - 0, > - (VOID *)GetSelInfoResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSelEntry ( > - IN IPMI_GET_SEL_ENTRY_REQUEST *GetSelEntryRequest, > - OUT IPMI_GET_SEL_ENTRY_RESPONSE *GetSelEntryResponse, > - IN OUT UINT32 *GetSelEntryResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_SEL_ENTRY, > - (VOID *)GetSelEntryRequest, > - sizeof(*GetSelEntryRequest), > - (VOID *)GetSelEntryResponse, > - GetSelEntryResponseSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiAddSelEntry ( > - IN IPMI_ADD_SEL_ENTRY_REQUEST *AddSelEntryRequest, > - OUT IPMI_ADD_SEL_ENTRY_RESPONSE *AddSelEntryResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*AddSelEntryResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_ADD_SEL_ENTRY, > - (VOID *)AddSelEntryRequest, > - sizeof(*AddSelEntryRequest), > - (VOID *)AddSelEntryResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiPartialAddSelEntry ( > - IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST *PartialAddSelEntryRequest, > - IN UINT32 PartialAddSelEntryRequestSize= , > - OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE > *PartialAddSelEntryResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*PartialAddSelEntryResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY, > - (VOID *)PartialAddSelEntryRequest, > - PartialAddSelEntryRequestSize, > - (VOID *)PartialAddSelEntryResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiClearSel ( > - IN IPMI_CLEAR_SEL_REQUEST *ClearSelRequest, > - OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*ClearSelResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_CLEAR_SEL, > - (VOID *)ClearSelRequest, > - sizeof(*ClearSelRequest), > - (VOID *)ClearSelResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSelTime ( > - OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetSelTimeResponse); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_SEL_TIME, > - NULL, > - 0, > - (VOID *)GetSelTimeResponse, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetSelTime ( > - IN IPMI_SET_SEL_TIME_REQUEST *SetSelTimeRequest, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_SET_SEL_TIME, > - (VOID *)SetSelTimeRequest, > - sizeof(*SetSelTimeRequest), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSdrRepositoryInfo ( > - OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE > *GetSdrRepositoryInfoResp > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*GetSdrRepositoryInfoResp); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_SDR_REPOSITORY_INFO, > - NULL, > - 0, > - (VOID *)GetSdrRepositoryInfoResp, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSdr ( > - IN IPMI_GET_SDR_REQUEST *GetSdrRequest, > - OUT IPMI_GET_SDR_RESPONSE *GetSdrResponse, > - IN OUT UINT32 *GetSdrResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_STORAGE, > - IPMI_STORAGE_GET_SDR, > - (VOID *)GetSdrRequest, > - sizeof(*GetSdrRequest), > - (VOID *)GetSdrResponse, > - GetSdrResponseSize > - ); > - return Status; > -} > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnTransport.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnTransport.c > deleted file mode 100644 > index 30ea84c04b..0000000000 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCom > mandLib/IpmiCommandLibNetFnTransport.c > +++ /dev/null > @@ -1,123 +0,0 @@ > -/** @file > - IPMI Command - NetFnTransport. > - > - Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > - > - SPDX-License-Identifier: BSD-2-Clause-Patent > -**/ > - > -#include > -#include > -#include > -#include > - > -#include > - > - > -EFI_STATUS > -EFIAPI > -IpmiSolActivating ( > - IN IPMI_SOL_ACTIVATING_REQUEST *SolActivatingRequest, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_TRANSPORT, > - IPMI_TRANSPORT_SOL_ACTIVATING, > - (VOID *)SolActivatingRequest, > - sizeof(*SolActivatingRequest), > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiSetSolConfigurationParameters ( > - IN IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST > *SetConfigurationParametersRequest, > - IN UINT32 SetConfigurationPar= ametersRequestSize, > - OUT UINT8 *CompletionCode > - ) > -{ > - EFI_STATUS Status; > - UINT32 DataSize; > - > - DataSize =3D sizeof(*CompletionCode); > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_TRANSPORT, > - IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM, > - (VOID *)SetConfigurationParametersRequest, > - SetConfigurationParametersRequestSize, > - (VOID *)CompletionCode, > - &DataSize > - ); > - return Status; > -} > - > -EFI_STATUS > -EFIAPI > -IpmiGetSolConfigurationParameters ( > - IN IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST > *GetConfigurationParametersRequest, > - OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE > *GetConfigurationParametersResponse, > - IN OUT UINT32 > *GetConfigurationParametersResponseSize > - ) > -{ > - EFI_STATUS Status; > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_TRANSPORT, > - IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM, > - (VOID *)GetConfigurationParametersRequest, > - sizeof(*GetConfigurationParametersRequest), > - (VOID *)GetConfigurationParametersResponse, > - GetConfigurationParametersResponseSize > - ); > - return Status; > -} > - > -/** > - This function gets the LAN configuration parameter. > - > - @param[in] GetLanConfigurationParametersRequest Request data > - @param[out] GetLanConfigurationParametersResponse Response data > - @param[in,out] GetLanConfigurationParametersSize When input, the > expected size of response data. > - When out, the ex= act size of response data. > - > - @retval EFI_SUCCESS Lan configuration parameter is returned= in the > response. > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > invalid. > - @retval Others Other errors. > - > -**/ > - > -EFI_STATUS > -EFIAPI > -IpmiGetLanConfigurationParameters ( > - IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > *GetLanConfigurationParametersRequest, > - OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > *GetLanConfigurationParametersResponse, > - IN OUT UINT32 *GetLanConfigura= tionParametersSize > - ) > -{ > - EFI_STATUS Status; > - > - if (GetLanConfigurationParametersRequest =3D=3D NULL || > - GetLanConfigurationParametersResponse =3D=3D NULL || > - GetLanConfigurationParametersSize =3D=3D NULL) { > - return EFI_INVALID_PARAMETER; > - } > - > - Status =3D IpmiSubmitCommand ( > - IPMI_NETFN_TRANSPORT, > - IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS, > - (UINT8 *)GetLanConfigurationParametersRequest, > - sizeof(*GetLanConfigurationParametersRequest), > - (UINT8 *)GetLanConfigurationParametersResponse, > - GetLanConfigurationParametersSize > - ); > - return Status; > -} > -- > 2.37.1.windows.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110887): https://edk2.groups.io/g/devel/message/110887 Mute This Topic: https://groups.io/mt/102270138/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-