From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.40019.1682739141216851650 for ; Fri, 28 Apr 2023 20:32:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=1Qs4/waz; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.40, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHI8+QRRMoCA5VE4u+MhkHyzQ/0pi77sCSjU2Bb/qVBQkaA9NJeOYH+8v9cDtsMXqrm5rf03ZeTNlDnTfaCrLeoV+EHv7QubDI0DSzYH7tJXFYGNFwtkGEgVy3Wn5/v6/FhD0FL9e9oy+NBat/nA2vZ5ILtyN1NSLppoG8+pwsmWs2wJiEfxJ/ATXYeORm1qPmzhZSvkJVA12CjI8wHiaLVhsZ3J7wJV3nh6tKhuLA9eul4oKPSFzhbB2zFy/Xe9vxB1mXcFOQR/DdEQxRPIRl1OjVs9Dl1PSB/0cyCwis5ei3EsXgUqX5XTB06kjLT4RNv/4PIEXM3x/Bd0wqf5CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7kDUbegiU5/ydMMJhsUedO8VOdoPM4MyykqK0r3cPDE=; b=Vep7nWIyEtzotOUI9qC6Dn7c1l2tNIsMjk+mJKp5Wrg3BNm/N533k9i0RoY8vlYjfckd90mG0cPRF3QaodN6uJRk0DxVKEICnnzfnZjEO/AJ/SK6YQ0D708hSjBTvK2+OInM9dtx9vJ+bl6zzcPPyl938uFk/vc9WaW49mUFTHbKrDYxbjp/47hp2KUvWmR/Ac5ou+3gFvTpKdJPeP+mTUB1k4ZHNTe5WPTGM9WCDVmsJdFidxdfwfj7oDl+lavITiBQHFJQCjJbt195HsYfMZxhS2MS5F6OzI7CdIs93uL1ilDaucu/gv5jxDyomky56KNTjMg6YH0Fn4IVtpaBUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7kDUbegiU5/ydMMJhsUedO8VOdoPM4MyykqK0r3cPDE=; b=1Qs4/wazWh3IoU5UaTBxTr3XAc1YFVvYBJrYtl8Dv+sfTKDEImmS8SaWTlhaHSfaVBwpJ5YT7TepqAM6gEHJW3prvsFwIY4zuC9IZ4I1ReNic15Xae9/uSi07E1h7kcd1apQgihPwOpgcu+zw7fH+IwcYjOGibqfpp1l/cTW86Y= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH8PR12MB7446.namprd12.prod.outlook.com (2603:10b6:510:216::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.25; Sat, 29 Apr 2023 03:32:18 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.022; Sat, 29 Apr 2023 03:32:18 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions Thread-Topic: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions Thread-Index: AQHZeYZX9UJOg5T970aV4thmqPRmgK9Bowbw Date: Sat, 29 Apr 2023 03:32:18 +0000 Message-ID: References: <20230428035940.1765700-1-tinhnguyen@os.amperecomputing.com> <20230428035940.1765700-3-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230428035940.1765700-3-tinhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-29T03:32:14Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=06214506-6669-4bba-b28f-907edede0ab6; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH8PR12MB7446:EE_ x-ms-office365-filtering-correlation-id: 103cd13f-f33f-43d3-981f-08db4862557d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0MczTOhKhI0RcQ5a8Z2euVNzEPFVYxZxhgb9CZKN7zxCx7vOzKJr3XWc66r+ZpZ6onvffEFmC9xSYMhbxtAxmRgeGdWgQSSUkbtfnHCxoQt16ubifxXBwKX4jhLaXQjKbVj9moN1/4tFy3sEfVEgT/l2Axc00aT5R9mXZOpb4LWyFZwaeWZPejEuRO5BEKTrwSRYR0PtVhlocjmdahzcXkTWt3g2MenpgAzOge2uif/4NMpXpypBAQyKZQeuhir0Cn0oNr3vrEFT2lN2h2mG+C2Qjzp3X3I3ht2lYE6kz7vtNU6Yn13yprhqcQRgh0egDIX+2xNube4Aw3PsMc4ZbXuCQrlkJ4dX9XWCWFAxIZBK/Gu8uVm3S62j9B/owUHtwCDhLOyqMvzx0P+kllzfE2LIFvWRMwWigUZ2F32W81Tf7vyw/KcKqfjW6dhCpiDT98CDBoLkc4CWpk84YkvaIGKSBk8KgVruJR7yen+LNQI5Z3DLOAVbJVru0FhzIAwGb4EUfDAsoqvjk77jVpKFkKOSDXTm/kkjAnGjmFHiXhOlal6JKEEHUFW6ViB8iWprWkC0DryGB3pZSOIhx7U4iURxP4XxyTxLMbtA9rCJRd4HVk/TgVvFiOJtmUhLgShD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(83380400001)(478600001)(7696005)(110136005)(71200400001)(6506007)(54906003)(26005)(9686003)(186003)(53546011)(52536014)(2906002)(33656002)(5660300002)(38100700002)(122000001)(64756008)(66446008)(66946007)(76116006)(66556008)(4326008)(41300700001)(66476007)(8936002)(8676002)(38070700005)(86362001)(55016003)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3yn6xTSqb1F2bFbm0HI2NSgSJ7AmRWHOAboJ0HgjwschKA8ZO8kfAFKteKk6?= =?us-ascii?Q?Grt1T897UHITRyRBUAWnYr0fDWMU91kHylRCP7mDoeWGQgbOWnTY6i6o4ZaH?= =?us-ascii?Q?QC8PG7OZwjjq7rYGcBjyb37ux9EMWoaScVwg88b60CVADTyLF5cOEe8IKzgX?= =?us-ascii?Q?Oan66v3xxdLuKmTPlZAqECopcGbt6D6IV4/wUQRXrzK4UJBpXdT9I7jRCAhv?= =?us-ascii?Q?3NqKVDLyRACeDHntLjmycyAE70UQoUDANpHVgcVF0QF7kkK6Mv1b2xgvloW8?= =?us-ascii?Q?7Z5Qhs/J2r8tbr3U5LJPVf2tdctEMIFs9dn4ceWkUk3ALzqCxCBi7/QkVhM6?= =?us-ascii?Q?H+tT5UEfrZbnwRYGiEGhhzd5M33EVkAmyacV/NBjF7h8KW+1n//pBw4TiZop?= =?us-ascii?Q?y6s3Vn3DjUGbS+gnHW2VGy5YIqOxJjTavECmiUzLZiTvmBieSE55dWNQVrGj?= =?us-ascii?Q?5KEwHgTvOak87BXngUrCYLf25Bz/2nOZf+M6rH4SN4KQqph9ap9VRHc41K/L?= =?us-ascii?Q?Eshl+LCv27xoi9Z1EMH12oZt1N+6HknJA6x7l5Fww1YbqFeT8plEgOfGzd9w?= =?us-ascii?Q?fW2UHQAv2GzyBbTtn0me8+gwOKvuXZ0cxwY9/5R6qWcZZrUlH2wuGnfESUxZ?= =?us-ascii?Q?A3FSGHNx7K837cGgpFh70rS4R0PHB+Lcsose6J8DxPNmEI4x9JmKofRzNmqE?= =?us-ascii?Q?4uyi56aXrYLkglHISXBb+4z5Q3NCBz3fvixnEsxom3Q/Bk5r0djBMVGYKe9y?= =?us-ascii?Q?nyRy3d5V6ZCN33bwGuJE8DFrdT79UFp4HLdhCf98LfIe73rTfmSqEmUZrwDK?= =?us-ascii?Q?7K4xIUo5KwIiOqLlVVrDakw0F9Z9K65m5HxR+ALwTDxnTYE/DcvmMbX0SeUt?= =?us-ascii?Q?e3aufNQajyfJSGbZ8tAMrdf9sdbiqg4xGKo0a9esdU5L/ST1/ISR5IC8ogPq?= =?us-ascii?Q?lldnL6ABPuPkqDYBPvJyOdyH0aV6ucaOW5nQV2v4rdMzjybX74paOKiavROo?= =?us-ascii?Q?PLJaNdEdyGGZWCSJlnkuk/PWgjlg9Ir1AashycHaOL3BawszsBokv9ewIZHO?= =?us-ascii?Q?JOVv5J4HO5cigjCbdPuZx8aLl1StHiONmjvuBCBs/nUBLOOuPFhOjeVKmoWo?= =?us-ascii?Q?w5at5JCb8GL1yvII2WCYqsb/pW3AuD0gPUSDzoaI2vTJAbIji3m/p6g6W1+T?= =?us-ascii?Q?bkviZmbssukqwqM+ZMnRFWt3kdfa639K1mGNBYMS1CXgWsh5vfoRbPfbb4Po?= =?us-ascii?Q?sM9XwPFM+rkmxTHpfJSbybFTl3NQRDeUgmUD18hyitaJmy697PxW2lEjdTUv?= =?us-ascii?Q?N+aouY9ZktJKCURv5KbvzQYXlq6R6syjIXb3V089neCHW/hG6IXDByplquca?= =?us-ascii?Q?E4Q8nsYF7eIwXHo/OmtrRHRkWc12unX5XYCM8gGi8S7GrFQP66IedfTu6n6K?= =?us-ascii?Q?nE3870gsrov+dPylE/bgkk3lA3p1GXIXiVget0GT0kZ3W17Jj2V+2tTnu9OQ?= =?us-ascii?Q?B+Sm7OTxdHOxBV2jeJbYadV3yr0mBWvGeiQ82tXbvTDRUnj+92LyqCFW8FXq?= =?us-ascii?Q?bvdFFaG1BSC6FBWNJnI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 103cd13f-f33f-43d3-981f-08db4862557d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2023 03:32:18.0807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qSSBjAgDRv17xfR42akN7DwrSxaicWrkXaeIJ7hZRW0n1BqC2Ml2Yz0EdZ5wTWTraFAn0a0C1DtojsY28e0r+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7446 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Tinh Nguyen > Sent: Friday, April 28, 2023 12:00 PM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > ; Tinh Nguyen > > Subject: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more > definitions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > This adds more definitions for the IPMI Get System Interface Capabilities > command. >=20 > Signed-off-by: Tinh Nguyen > --- > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31 > ++++++++++++++++++++ > 1 file changed, 31 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > index a5835ba08c00..933303b0fa2c 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h > @@ -13,6 +13,7 @@ >=20 > Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
> Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > @@ -1046,6 +1047,36 @@ typedef struct { > // Constants and Structure definitions for "Get System Interface > Capabilities" command to follow here // >=20 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF 0x0 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS 0x1 > +#define > IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC 0x2 > + > +typedef union { > + struct { > + UINT8 InterfaceType : 4; > + UINT8 Reserved : 4; > + } Bits; > + UINT8 Uint8; > +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST; > + > +typedef union { > + struct { > + UINT8 Version : 3; > + UINT8 PecSupport : 1; > + UINT8 Reserved : 2; > + UINT8 TransactionSupport : 2; > + } Bits; > + UINT8 Uint8; > +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES; > + > +typedef struct { > + UINT8 CompletionCode; > + UINT8 Reserved; > + IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES InterfaceCap; > + UINT8 InputMsgSize; > + UINT8 OutputMsgSize; > +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE; > + > // > // Definitions for Get System Interface Capabilities command SSIF > transaction support // > -- > 2.40.0