From: "Chang, Abner" <abner.chang@amd.com>
To: Ard Biesheuvel <ardb@kernel.org>, Wenyi Xie <xiewenyi2@huawei.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
"daniel.schaefer@hpe.com" <daniel.schaefer@hpe.com>,
"songdongkuang@huawei.com" <songdongkuang@huawei.com>
Subject: Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
Date: Tue, 6 Sep 2022 08:28:56 +0000 [thread overview]
Message-ID: <MN2PR12MB39665BF0002D6095FFD93E72EA7E9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXEz_QnAjxZB8vt+nMc8-yRowcy3RN1NrzgiuzBUGx42gA@mail.gmail.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
Hi Ard, please also update Daniel's email address to Daniel Schaefer <git@danielschaefer.me>
Thanks
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Monday, September 5, 2022 9:56 PM
> To: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com;
> ardb+tianocore@kernel.org; Chang, Abner <Abner.Chang@amd.com>;
> daniel.schaefer@hpe.com; songdongkuang@huawei.com
> Subject: Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix
> compile warning
>
> [CAUTION: External Email]
>
> On Wed, 3 Aug 2022 at 11:27, Wenyi Xie <xiewenyi2@huawei.com> wrote:
> >
> > The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this PCD
> > is UINT32. So change the declaratrion of gTimeOut to UINT32 to fix
> > compile warning.
> >
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> > EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2
> > +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > index d53a5fe47f18..d54e1cf7e094 100644
> > ---
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > +++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.
> > +++ c
> > @@ -17,7 +17,7 @@
> > #include <Protocol/DebugPort.h>
> >
> > EFI_DEBUGPORT_PROTOCOL *gDebugPort = NULL;
> > -UINTN gTimeOut = 0;
> > +UINT32 gTimeOut = 0;
> >
> > /**
> > The constructor function initializes the UART.
> > --
> > 2.20.1.windows.1
> >
>
> Merged as #3287
prev parent reply other threads:[~2022-09-06 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 9:27 [PATCH EDK2 v1 0/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning wenyi,xie
2022-08-03 9:27 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-09-05 13:56 ` Ard Biesheuvel
2022-09-06 8:28 ` Chang, Abner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB39665BF0002D6095FFD93E72EA7E9@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox