* [PATCH EDK2 v1 0/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
@ 2022-08-03 9:27 wenyi,xie
2022-08-03 9:27 ` [PATCH EDK2 v1 1/1] " wenyi,xie
0 siblings, 1 reply; 4+ messages in thread
From: wenyi,xie @ 2022-08-03 9:27 UTC (permalink / raw)
To: devel, quic_llindhol, ardb+tianocore, abner.chang,
daniel.schaefer
Cc: songdongkuang, xiewenyi2
Main Changes :
1.Change the type of gTimeOut to UINT32.
Wenyi Xie (1):
EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
2022-08-03 9:27 [PATCH EDK2 v1 0/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning wenyi,xie
@ 2022-08-03 9:27 ` wenyi,xie
2022-09-05 13:56 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: wenyi,xie @ 2022-08-03 9:27 UTC (permalink / raw)
To: devel, quic_llindhol, ardb+tianocore, abner.chang,
daniel.schaefer
Cc: songdongkuang, xiewenyi2
The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this
PCD is UINT32. So change the declaratrion of gTimeOut to UINT32
to fix compile warning.
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
index d53a5fe47f18..d54e1cf7e094 100644
--- a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
+++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
@@ -17,7 +17,7 @@
#include <Protocol/DebugPort.h>
EFI_DEBUGPORT_PROTOCOL *gDebugPort = NULL;
-UINTN gTimeOut = 0;
+UINT32 gTimeOut = 0;
/**
The constructor function initializes the UART.
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
2022-08-03 9:27 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2022-09-05 13:56 ` Ard Biesheuvel
2022-09-06 8:28 ` Chang, Abner
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2022-09-05 13:56 UTC (permalink / raw)
To: Wenyi Xie
Cc: devel, quic_llindhol, ardb+tianocore, abner.chang,
daniel.schaefer, songdongkuang
On Wed, 3 Aug 2022 at 11:27, Wenyi Xie <xiewenyi2@huawei.com> wrote:
>
> The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this
> PCD is UINT32. So change the declaratrion of gTimeOut to UINT32
> to fix compile warning.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> index d53a5fe47f18..d54e1cf7e094 100644
> --- a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> +++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> @@ -17,7 +17,7 @@
> #include <Protocol/DebugPort.h>
>
> EFI_DEBUGPORT_PROTOCOL *gDebugPort = NULL;
> -UINTN gTimeOut = 0;
> +UINT32 gTimeOut = 0;
>
> /**
> The constructor function initializes the UART.
> --
> 2.20.1.windows.1
>
Merged as #3287
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning
2022-09-05 13:56 ` Ard Biesheuvel
@ 2022-09-06 8:28 ` Chang, Abner
0 siblings, 0 replies; 4+ messages in thread
From: Chang, Abner @ 2022-09-06 8:28 UTC (permalink / raw)
To: Ard Biesheuvel, Wenyi Xie
Cc: devel@edk2.groups.io, quic_llindhol@quicinc.com,
ardb+tianocore@kernel.org, daniel.schaefer@hpe.com,
songdongkuang@huawei.com
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
Hi Ard, please also update Daniel's email address to Daniel Schaefer <git@danielschaefer.me>
Thanks
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Monday, September 5, 2022 9:56 PM
> To: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: devel@edk2.groups.io; quic_llindhol@quicinc.com;
> ardb+tianocore@kernel.org; Chang, Abner <Abner.Chang@amd.com>;
> daniel.schaefer@hpe.com; songdongkuang@huawei.com
> Subject: Re: [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix
> compile warning
>
> [CAUTION: External Email]
>
> On Wed, 3 Aug 2022 at 11:27, Wenyi Xie <xiewenyi2@huawei.com> wrote:
> >
> > The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this PCD
> > is UINT32. So change the declaratrion of gTimeOut to UINT32 to fix
> > compile warning.
> >
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> > EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2
> > +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > index d53a5fe47f18..d54e1cf7e094 100644
> > ---
> > a/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c
> > +++ b/EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.
> > +++ c
> > @@ -17,7 +17,7 @@
> > #include <Protocol/DebugPort.h>
> >
> > EFI_DEBUGPORT_PROTOCOL *gDebugPort = NULL;
> > -UINTN gTimeOut = 0;
> > +UINT32 gTimeOut = 0;
> >
> > /**
> > The constructor function initializes the UART.
> > --
> > 2.20.1.windows.1
> >
>
> Merged as #3287
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-06 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-03 9:27 [PATCH EDK2 v1 0/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning wenyi,xie
2022-08-03 9:27 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-09-05 13:56 ` Ard Biesheuvel
2022-09-06 8:28 ` Chang, Abner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox