From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.77]) by mx.groups.io with SMTP id smtpd.web10.21906.1671637452469991348 for ; Wed, 21 Dec 2022 07:44:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=hrTUA1QU; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.77, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPjDhbE/bQlc9PVh4hiCvfwD4D+iX8gnX843iXxj6wEpouF+oOXDEf8Tpe3ku0zxq++HfFLuhcJdX44+S1XNKvrVtA2Iqc3P1D8q5hFT4xq7j1aS9hVKxKQL8unTVHNK0FS5ExxA7A64LQZx+eo9E8Eltp7qnp+IgacaBjtGBLHzHksj27a+r/wyjI9CHaiyrQe5NAnvsIYcbzSe1DjIj7BkdLaZitZhaOVvpaSxtNA2grR/aOjLDMC9ISB1vMV/4Kuwv7IjcZtVivNxS8KAvLtDrEbqfBDwHXch/MK4eX0owUpU847RCv0hT1465k/0KRDTeTe9XKr96MguHALhgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r4lWx9Mw+XFizP8SJ8TncaN3JybYGFC26ZRJVxMCpQk=; b=l4n8JVmwO/xgXIaOoAjvD+hXcC4w39QQKiugxA5Uij6TOPezm57e/PGycN3293lTvbTxWr2MKR3HAoyceJW/qn95wTY1VjsHkTceDkq3lBBwVeTsdr1SQa1MZHDQh3QHKG90iOzl+FqGHPnsJvJYhfYeSylTLIZCFEdUddYSuRb60lDQfWNEy6NR31qFD4lcj1PZvYqSARy2WC5Clc5hvUxVSvkISmUSoA9yvyoaMaTfYp3AKYtv2BBez8Y2LgrkCNFvJcryZbKBcsupoLao8Ze5goQl7lW/zvwAkEPgo7UH084qBHS23gO2Vai8qiUMlOnkez9jfMSdF/vOcFlc1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r4lWx9Mw+XFizP8SJ8TncaN3JybYGFC26ZRJVxMCpQk=; b=hrTUA1QU+JPQcXN4dUQMSXf9YkBDHKMiaNSygxbLprR04gesK9SB41F7libDBRVidiAs2D8DAdQhhr+2rRSR8ldBo8JNN3jRu5WdzAeD6jX/RMpbSmCD5GPCMmbj2j6NEyNXpMNTC+e7Ni0HN2kIOFr0/n6ugCiBVn+nC8/4Eh8= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN2PR12MB4127.namprd12.prod.outlook.com (2603:10b6:208:1d1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 15:44:09 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 15:44:09 +0000 From: "Chang, Abner" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Lin, Kuei-Hung (Timothy)" , "Ni, Ray" , "Kirkendall, Garrett" Subject: Re: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Topic: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Index: AQHZDKlQxCFyQ4+KbkGYDV+p7csXRq5pmfSAgAyGdpCAAAWAAIACZdeg Date: Wed, 21 Dec 2022 15:44:09 +0000 Message-ID: References: <20221210150824.1231-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-21T15:43:53Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=78b41bd5-1d4e-478d-a057-6f1a6e3c282b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN2PR12MB4127:EE_ x-ms-office365-filtering-correlation-id: 51e748f5-7a3e-44f9-acdb-08dae36a3369 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: scY9SFgfEGSmkPjVuSafED7W0m2D81XIu5bvDxWvwbQKqo1bzvgjGWFCaSSfHQtCSJJOZCJZsn/oKv1PC28ypZBI2elH02D+i47tcaVm5QpRcjYxiPN790Vo1KsopnXr6sj0ThXJgn/c2aaQUZ6UFuCU4p8tkuQPeiFauOPfM1VjANrQdVN1TIg3LDB9QMKSmvMop0Sm1vKAZ0btw2XJYxuLtT+0YfdxkZns1eyz/OWk/SusbrnV/NyaD/ZsifuPv22Ya20F6VqI58hlpaCvzhJ7UIuIcLrSpPYABnEtX7/j2F3+zucY4Abdw2OdRuRgzaBI6O2PaHKApJ/gCYEwd8MeslQw6PIG3bMkMyFxF6KDbrZvgODIFJYrciWLy56i8KRIbZn7Zule/0UcFT2FS9eHTBeYIplTePLz1DHJXmmAoGnGchyHp3Qj0C0i+VC9wwgtmR+hq7lwBpauopkMTs7t5pZDHrZKyGbXbYWWJk73ZdF/eSVYl0zY3Uwy9niA17Jb9fAs2NzmbNDyrJP/H6QY4Yn0WPFmezV0oss35qwwh9EzXjS1uBJGGUM59yRQVEoZTStTFrooSSd5vx4WDnMN7CankUD2XXKNTjeQZv0lSDDDjWXRalFZvAcbTTsuvt7wEkt8WX6AMgIvVOuA3yJ1AagK7m3CjftPu3WAdY3tJorNwNRoPRzUljH/VHDDQOE20YrA7YJ5ad5KPChyj3byahj/LEw0pU8xHe0/KRIObv+F5hZnSb0M6D0fHpwq2spZzgUQ+V2UjrJmaL59vy8QgqaSP/wmg7o4IEY+MBA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(366004)(396003)(346002)(136003)(39860400002)(451199015)(966005)(53546011)(9686003)(26005)(186003)(7696005)(71200400001)(6506007)(41300700001)(83380400001)(38100700002)(5660300002)(55016003)(86362001)(76116006)(66946007)(8676002)(66556008)(66446008)(99936003)(122000001)(45080400002)(64756008)(19627235002)(54906003)(478600001)(66476007)(110136005)(52536014)(8936002)(4326008)(38070700005)(33656002)(2906002)(316002)(64893003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o4fqyCN2Bh5dI7neAzyT3aYEu2L8wMwSH3tI0ygT3knYYVjO/0pOz6Z/Icew?= =?us-ascii?Q?A2g91Pgm2g8cvi2EbFo2tyoUJWwTKxTnKqHotAE22Ow827NdCVROX3s56FNE?= =?us-ascii?Q?tyj2T900sMlfX6t66DXEjlOdOT1L0WJOtdKt1YIhmikaHt1f1f+NjOCMMUGx?= =?us-ascii?Q?UW/laIb35GGVcKB+hwbq4a8hinefTdU9Rc4u1t2UK+q3keA73JfpXHydzyLi?= =?us-ascii?Q?LapDpNRjAzsns49kF/WvI6IyjbIlxf1F2BeN+93dpWLeJubhyH6V9zdBqizN?= =?us-ascii?Q?2wY7S9PZ6E/EB1Fd/4bNS4fRQJ0rmFsW6bRuEYhC65/j2aaa8SU6gLoQXDOT?= =?us-ascii?Q?tegnE+dnyzZoIJZoDNf32HbOvPqGc459ex2ICfb5mvkSsSACp5yuqoAJVVH9?= =?us-ascii?Q?00CgenM4ad44M0m140fc9EA8X3Qir3P4e2bNrUfgddiLbaQu1PwA7z+Hiwh5?= =?us-ascii?Q?TxksTj0iYUOE03PVT71T5U7GF2sJSR+YKp/1+GSLBlFVNYxAoquFH2awG0bJ?= =?us-ascii?Q?Eu7SF78OIHSRkPYq+4wKbSJuEMIlUrXgbNfGDnER8rkBPHOVKONVuRR38kbj?= =?us-ascii?Q?Gws9ML0J/Q/pEKCR7t6EzVwpnnEdcnqcA4DSOINHgU6qXb3UXG3Lh7VDyJAh?= =?us-ascii?Q?CKuoKrhe+42S5KTErg1ED6SlFgCYwaz5jF3jNKaeCsbwyH0qizQVAu32PbOQ?= =?us-ascii?Q?8hvG3jMcff27Zi95sdomS0lpm56RfUnpDtbLb2AXbJThZpuKuOmW241gszVO?= =?us-ascii?Q?kWtH7TUyVQGtifDVAMvkACh+smn1Xz7RMvmC4XAp30eFjlXZNP/ZWHxITep8?= =?us-ascii?Q?RKJkatSoXaoWXiH8LJ1WVZVoqIcP5SRIzdjN9U4eDtz1GHgpTq4n+TTLu/N4?= =?us-ascii?Q?nAw7wnkTuwQUeUWPwOeBOcapqrTlhCqbiSv4RM2zyvjaEElvBu8tV4pxJyHC?= =?us-ascii?Q?dwHAtT/7UFPeguyH+cMpHIZSWM7MGauuKKv6dSFX4GsYBhJcw4vWa3KIhw/4?= =?us-ascii?Q?Fv4LZEBLmNNnC8yjD01kPUIXXgaAG7iMsETOZ+uMo5ndg3mZjFKWGQKEPGxC?= =?us-ascii?Q?S5hmNK/srmUnXMXybL3fxybzfgvOJc9a7IqWlY+j1kGjUWsUthPZQ/9OwuLW?= =?us-ascii?Q?AvdteLpJm9gFZFEiZl+DFFbSGwioG8Wo2+zcypCFtAJwIddhmNw880C+NiSY?= =?us-ascii?Q?VCDC8epL7HJ8rt7WKQZo0QbHXN4MSo0jAU1nMMM+lTAWZ4hrbawcRc2JAmrS?= =?us-ascii?Q?GDgV7T0jEID2dM/zblkeHv7XdFnUSMHiVMp1WMRaH8XveThvE4PTE2MgOIll?= =?us-ascii?Q?1p0P/5U2M+vjls5W6Vm7+4HG2807/4NBfq+fQH61FaFlGZaT0tryh38WWFDg?= =?us-ascii?Q?7CYMukS4JpgSCL0amTQFe23Y4t2/NyjnGoGnrfY+3RHq0JrpEb5QoWgO/dE/?= =?us-ascii?Q?qDSpms5pSPlzMC8wD5JCJV4yeO3/wRA1ydJIwXZ/GC6dBNDAoH3RH03/G2XB?= =?us-ascii?Q?UrASUGsSbDavi1hLT3amSWGi5EO8e6D8rUfihC79TzCHzEuhHgW60yMo+yWw?= =?us-ascii?Q?ila5ElnESOtAv+sb/BA=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51e748f5-7a3e-44f9-acdb-08dae36a3369 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 15:44:09.4792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J37eollXrFNV6CMUHvcJotv6IvZWDRSCo+vc3SV0dSPxIf1P3B7QPrCY5wI6/KnWxcoP6J9wkqzFYiVPkAVnew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4127 X-Groupsio-MsgNum: 97691 Content-Language: en-US Content-Type: multipart/mixed; boundary="_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_" --_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Hao, I just sent out three patches and below is PR which passed the CI. https://github.com/tianocore/edk2/pull/3794 Thanks Abner > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, December 20, 2022 11:03 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > ; Kirkendall, Garrett > Subject: RE: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Contex= t > value >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > Thanks, >=20 > For this patch "MdeModulePkg/XhciPei: Unlinked XhciPei memory block", my > take is that there will also be an updated version, right? > If this is the case, could you help to send out a single 3-patch series f= or them > instead of sending 3 separated patches? Thanks in advance. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Chang, Abner > > Sent: Tuesday, December 20, 2022 10:45 AM > > To: Wu, Hao A ; devel@edk2.groups.io > > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > > ; Kirkendall, Garrett > > Subject: RE: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's > > Context value > > > > [AMD Official Use Only - General] > > > > Hi Hao, > > That is the uncrustify check error. I already fixed it at "[PATCH V3] > > MdeModulePkg/Usb: Read a large number of blocks." > > > > Also, these three patches are passed the CI test. > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= h > > > ub.com%2Ftianocore%2Fedk2%2Fpull%2F3794&data=3D05%7C01%7CAbner.Chan > g%40a > > > md.com%7C187600a1cd0942afb7b708dae236cbf5%7C3dd8961fe4884e608e11 > a82d99 > > > 4e183d%7C0%7C0%7C638071022231599779%7CUnknown%7CTWFpbGZsb3d8e > yJWIjoiMC > > > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > %7C% > > > 7C&sdata=3DAqFmywwFq9wJmix13UNfBDdT84wtFK%2BH8THRa7iYcm4%3D&rese > rved=3D0 > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Wu, Hao A > > > Sent: Monday, December 12, 2022 11:27 AM > > > To: Chang, Abner ; devel@edk2.groups.io > > > Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray > > > ; Kirkendall, Garrett > > > Subject: RE: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's > > > Context value > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > For the 3 patches: > > > [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block > > [PATCH > > > V2] MdeModulePkg/Usb: Read a large number of blocks [PATCH V3] > > > MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value > > > > > > I found that they will cause CI failures: > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= h > > > > > ub.com%2Ftianocore%2Fedk2%2Fpull%2F3749&data=3D05%7C01%7Cabn > > > > > er.chang%40amd.com%7Cfe921dc0e08b4cdf30a208dadbf0cb8c%7C3dd8961 > > f > > > > > e4884e608e11a82d994e183d%7C0%7C0%7C638064124508360013%7CUnkno > > w > > > > > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > > > WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D0iQKJ3X3IJv1CSqe > > > mjTWyT1hlYvqGZsYPAdwXEi%2B%2FZ4%3D&reserved=3D0 > > > Could you help to update them and help to ensure they can pass the CI= test? > > > Thanks in advance. > > > > > > Best Regards, > > > Hao Wu > > > > > > > -----Original Message----- > > > > From: abner.chang@amd.com > > > > Sent: Saturday, December 10, 2022 11:08 PM > > > > To: devel@edk2.groups.io > > > > Cc: Kuei-Hung.Lin@amd.com; Wu, Hao A ; Ni, Ray > > > > ; Garrett Kirkendall > > > > ; Abner Chang > > > > Subject: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's > > > > Context value > > > > > > > > From: Abner Chang > > > > > > > > In V3: Add AMD copyright. > > > > In V2: Remove the signed-off-by: Abner Chang. > > > > > > > > Initialize XHCI DCI slot's context entries value. > > > > > > > > Signed-off-by: Kuei-Hung Lin > > > > Cc: Hao A Wu > > > > Cc: Ray Ni > > > > Cc: Garrett Kirkendall > > > > Cc: Abner Chang > > > > --- > > > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++ > > > > MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++ > > > > 2 files changed, 14 insertions(+) > > > > > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > > > index 13b0400e83d..f08722905f3 100644 > > > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > > > @@ -4,6 +4,7 @@ > > > > > > > > Copyright (c) 2011 - 2020, Intel Corporation. All rights > > > > reserved.
Copyright (c) Microsoft Corporation.
> > > > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > > > > +reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > **/ > > > > @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext ( > > > > MaxDci =3D 0; > > > > > > > > NumEp =3D IfDesc->NumEndpoints; > > > > + if (NumEp =3D=3D 0) { > > > > + MaxDci =3D 1; > > > > + } > > > > > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -3006,6 > > > > +3010,9 @@ XhcInitializeEndpointContext64 ( > > > > MaxDci =3D 0; > > > > > > > > NumEp =3D IfDesc->NumEndpoints; > > > > + if (NumEp =3D=3D 0) { > > > > + MaxDci =3D 1; > > > > + } > > > > > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { diff --git > > > > a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > > > b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > > > index cc597a43717..8400c90f7ad 100644 > > > > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > > > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > > > > @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid > > based > > > on > > > > gPeiUsbControllerPpiGuid which is used to enable recovery > > > > function from USB Drivers. > > > > > > > > Copyright (c) 2014 - 2017, Intel Corporation. All rights > > > > reserved.
> > > > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > > > > +reserved.
> > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd ( > > > > } > > > > > > > > NumEp =3D IfDesc->NumEndpoints; > > > > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > > > > + MaxDci =3D 1; > > > > + } > > > > > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -1974,6 > > > > +1978,9 @@ XhcPeiSetConfigCmd64 ( > > > > } > > > > > > > > NumEp =3D IfDesc->NumEndpoints; > > > > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > > > > + MaxDci =3D 1; > > > > + } > > > > > > > > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > > > > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > > > > -- > > > > 2.37.1.windows.1 --_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Wed, 21 Dec 2022 15:43:56 GMT"; modification-date="Wed, 21 Dec 2022 15:44:00 GMT" Received: from PH7PR12MB6834.namprd12.prod.outlook.com (2603:10b6:510:1b4::18) by MN2PR12MB3966.namprd12.prod.outlook.com with HTTPS; Wed, 21 Dec 2022 15:42:52 +0000 Received: from BL1PR13CA0021.namprd13.prod.outlook.com (2603:10b6:208:256::26) by PH7PR12MB6834.namprd12.prod.outlook.com (2603:10b6:510:1b4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 15:42:50 +0000 Received: from BL02EPF0000C406.namprd05.prod.outlook.com (2603:10b6:208:256:cafe::8c) by BL1PR13CA0021.outlook.office365.com (2603:10b6:208:256::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.10 via Frontend Transport; Wed, 21 Dec 2022 15:42:50 +0000 Received: from mail02.groups.io (66.175.222.108) by BL02EPF0000C406.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 15:42:49 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" CC: Hao A Wu , Ray Ni , "Kirkendall, Garrett" , "Chang, Abner" , "Lin, Kuei-Hung (Timothy)" Subject: [edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block Thread-Topic: [edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block Thread-Index: AQHZFVLj9/VYoqyNWUa7mfCFoaLCEg== Sender: "devel@edk2.groups.io" Date: Wed, 21 Dec 2022 15:42:17 +0000 Message-ID: <1732D953FCEE4284.12545@groups.io> List-Help: List-Subscribe: List-Unsubscribe: Reply-To: "devel@edk2.groups.io" , "Chang, Abner" Content-Language: zh-CN X-MS-Exchange-Organization-AuthSource: BL02EPF0000C406.namprd05.prod.outlook.com X-MS-Has-Attach: X-Auto-Response-Suppress: All X-MS-Exchange-Organization-Network-Message-Id: fc19cbc9-4334-4c1b-4ba4-08dae36a0427 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 received-spf: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C x-ms-exchange-organization-originalclientipaddress: 66.175.222.108 x-ms-exchange-organization-originalserveripaddress: 10.167.241.8 x-ms-publictraffictype: Email x-originating-ip: [10.180.168.240] authentication-results: spf=pass (sender IP is 66.175.222.108) smtp.mailfrom=groups.io; dkim=pass (signature was verified) header.d=groups.io;dmarc=bestguesspass action=none header.from=groups.io;compauth=pass reason=109 delivered-to: mailing list devel@edk2.groups.io mailing-list: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io list-id: dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1671637369; bh=CuvMgjhIHP33x0psYOtLFIl1ycS2sBxvMhgmjUQllUo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=k1D3HcqYZ7TvonAy2QDLVax3h7nWfZ8ENQYorSALpx0jER2nnMjj42FXRwWJPX3+0dQ ndo2o41zM1LUPcsnvppJQ6MRX3e/GTfN1nDus9UYugCLdUA4agHviy1l0XBWzPQfyCuqL 4hWfwp7l6pK7naBQawB1iQG77UsAXGvTG7c= x-ms-office365-filtering-correlation-id: fc19cbc9-4334-4c1b-4ba4-08dae36a0427 x-ms-traffictypediagnostic: DS1PEPF0000E630:EE_|DM6PR12MB4403:EE_|BL02EPF0000C406:EE_|PH7PR12MB6834:EE_ x-forefront-antispam-report: CIP:66.175.222.108;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail02.groups.io;PTR:mail02.groups.io;CAT:NONE;SFS:(13230022)(4636009)(451199015)(33656002)(36756003)(336012)(7636003)(34756004)(7596003)(2616005)(6862004)(956004)(5660300002)(4326008)(8676002)(6486002)(1096003)(7846003)(83380400001)(36736006)(76796012)(966005)(7696005)(54906003)(6666004)(19810500001)(9316004)(19627235002)(26005)(356005)(118246002)(66899015);DIR:INB; x-microsoft-antispam: BCL:0; x-ms-exchange-crosstenant-network-message-id: fc19cbc9-4334-4c1b-4ba4-08dae36a0427 x-ms-exchange-crosstenant-originalarrivaltime: 21 Dec 2022 15:42:49.9725 (UTC) x-ms-exchange-crosstenant-fromentityheader: Internet x-ms-exchange-crosstenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d x-ms-exchange-transport-crosstenantheadersstamped: PH7PR12MB6834 x-ms-exchange-transport-endtoendlatency: 00:00:02.9338266 x-ms-exchange-processed-by-bccfoldering: 15.20.5924.016 x-eopattributedmessage: 1 x-ms-exchange-crosstenant-authas: Anonymous x-ms-exchange-crosstenant-authsource: BL02EPF0000C406.namprd05.prod.outlook.com x-received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 21 Dec 2022 09:42:41 -0600 arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hM/7/1Vb5WDep4hAhsJuLngEn9nUcQYfMXitOlx+LM5kKxQ8JpIq7pNui6Jgqg0uZZV+8N5LXi/Nzs4Qf3+MjmN0OvVLxHa8EQ/Jj1M0orZzMYzKCEEfim7fjdUJ0xxceB+Ro9atqZc6Mnhg8IbTihcTW/1YpUKLjDSe1pn8xy1yhptlb0YinwZ9HG72q2vBTs4y2f2rpd/n6itxzbcfEG0JkwACTgDo8vsX529AAUPP2l5lHLrWgcmtRL6LapjzHvhEjbERX3VPVCXIjTMr4yPXLUr5vS6kjYAdLVWYAlXyr+vvZjvWX/pCN9jIFJYfsOXXjauln4Jj0eBgB3FFVA== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TxS3SVMCdwR0tKO5INXrjseBFPdb46K10J2vdmsIRXY=; b=MPYMKOPLRnhBjs+J0ETtPg35KpRCKFnOAan+oqiV+L87fI5X1cTt5llsNCBdl2/J3g1L4Cs9pSvff1zpbjWEiWspgpkTfFxX4i8M1GApLAqj4i1McaMQb1wVqlZGDbwf0sUTxhGgLcxkP4QB3IKqp1yLm1LEC6SEiB9N88vQV40yc8lnNP+bdDzUue9gKth2NOKrlcTftnCo8l0famap+47pPX15ghOWrgDVcNO/hEA5SH4XT4Q+1Ph2fETjMwX3yJydDDaWid/Z0cCakRbx1S+MO0LqehctJ29WtaxoP/+lg0E+43qC6ilUOdZQ5MhQej7dg2WQUO6VD19OCROWsg== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info-original: Ol9pAHpKBCPohfZDzPDkDlQ+SueIf0wNtO2cVT6XwcZg0ypXWqkKFcDr1WU3ytgFqdh7fSEgmRi6BwfCaYx21aMDiV5QkXpCsMhySYO2cztCWVXP4HesomhtWkggwxJNJFrY668hkGUNy2AjFAFBnH4b1HjwX87oXVeJJgD7SGy9pSRJGJUdUOgNtQs5PSsvr0SEPoIP8d22l6kRcOtzYhw8PwKPd61NtS+PcX085s0CIV5QfCs9dTvR+nk2StPMmIH4Nqsb+QLn97cXnwJKnGJL91g44KFgvDS6Piv86U1lQLqwZ8QXyMqD9aaqljRm09jKSv2pg3MDKxrXs2jH9urP9s44uXks0dm3xKI9NFIw28OYm/Gpgs1AfQROSQa60bHZfPMyltUMgzpT2IdklZSe3MRILsqfSE/BlUWOEX9tp1JEsCqIT+/1o+1fUj6M+uObMvtVBCoXq68tsXt1xMrHtaOm3HtMTX8Kq3sIHDwsYXZvKXq0zn/muOuf+Z/d6mysuyL07d7Nyp3Cq9Kl0XdzYJAwUXHu4Pyv8t5hFEqw0WKSfAM8Fj5j/tTv2IxtG+fbQjDd1UQRSGQNBpGvRrCr82tdSPyHoo5t2wJYp2yVBerHTFJ6bJXCkdCst7vSNQ9K5TGLYmq60f9ZD/rtnk24Q+sk6T/nIT+f/WsNEQMa+xiN+mlLJn13shkobAxcIzDj495Qki3UYYxw5FZ3zOlANxmMYKGrcM6s3s9/UEU= x-ms-exchange-transport-crosstenantheadersstripped: BL02EPF0000C406.namprd05.prod.outlook.com x-ms-office365-filtering-correlation-id-prvs: 13ac8105-ca6e-421e-a7a0-08dae36a00c2 x-ms-exchange-antispam-relay: 0 x-gm-message-state: EZnWM6zrE5S6cfbKEvpHn1J9x7039027AA= x-clientproxiedby: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) x-ms-exchange-atpmessageproperties: SA|SL X-Microsoft-Antispam-Mailbox-Delivery: ucf:0;jmr:0;auth:0;dest:I;ENG:(910001)(944506478)(944626604)(920097)(930097); X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7ooFO/8l7CQ5xxri9hJyILXmN5ewHtr7q9cI4t2KSQbdXEoCkC12wVifEIoT?= =?us-ascii?Q?3Mg1XPL2cA3pdtllnu/PyB2A6ZfxC8rcyEIALKm4wq2PcRxXKUmsYwRK5mjx?= =?us-ascii?Q?tlvNvh0wqCUEMzWAw1YgBiAcM55pJEp5aVu7ksyqX7UqysEpThm7/4ttIsfa?= =?us-ascii?Q?oL4i0ejqFELCvvDDTUuZKDT6WqfL91e7RJxSxsbCqPxcv15GKDIJcd3rzRnx?= =?us-ascii?Q?WFEFlv3oNhXXg1QMJ4CpJDbNo47k3hdnWXk7LUmyhSYgJshsjs0/9BjsuU+g?= =?us-ascii?Q?UDthadsoH6byINWZocXp+pOlJ8g7VOBidUH1L6tH35QSKn3n6vfyh1g22DNp?= =?us-ascii?Q?1OK/OVO0d4K5WGwUWquJxjzA5czTs5LtroB/vP31UTJ27w3ElI9oG+E81NXW?= =?us-ascii?Q?GNtHAwL+OOdTLLstZbFc74rL8Be9BRZ5JTOi+VUhwnEp3gUC+B3sZsnZtsTJ?= =?us-ascii?Q?qVI0VBAhB2yn20fJRkQPkbSSmA3ums9Sea8UNY+8awf6tBM4/orbDrf+GZfS?= =?us-ascii?Q?0P/z35EY1RHKQiujZ22jbGR0zipAfvKqqfIB7GxZC2HXwd1whA5WABB2Juk7?= =?us-ascii?Q?r1eZOkWPHLNuGzYDX4yCY/f4IngAqPqOUgZ8Hm19+qywf5Ur/ORY923S3hcB?= =?us-ascii?Q?3QYxUS+sbmcU7AkY3gPcqAjzVpE7yruA82WL8W13m/tieEn2MZFLdYHFJseT?= =?us-ascii?Q?yMNfWzOpwKLQr/ZoF5vGnNXkFDMSdYbyvkpQrD0/msJhEt5LmGc4n4HgRvwc?= =?us-ascii?Q?z3pfH3+iaR7bIJU1xd7WwLTbmX2FGdxR3zXQNhSy/PksuAq+JKXaLGOz862h?= =?us-ascii?Q?uXKehunY+DYjw3l0Qj95MjO7RTHBlwpE0zchWXdtdUS9M3mrYc2tJTOtNe0w?= =?us-ascii?Q?uQ253WtMFw0yCvcB73XJ/+hzqfs8ggWi1fEiR+Mhubos/O7/HeEHLbFuWobO?= =?us-ascii?Q?lWtScj/PNZTVxybGGfCtn+2LcRiFHuKntYaGSq+TaV7i0xeqVOLrBKVGz3OY?= =?us-ascii?Q?EGIScrPkeA1p0Fkgb47CYP1rHtEK04IvP0cUdBLZL//PG83rIRdMzX+Y774p?= =?us-ascii?Q?H/03rSE2EWTiWbTy1xwI2sMShIH9s+LbVSx7prdFzxwEBTikkofeZfgdLOqH?= =?us-ascii?Q?v4otarBVL69PGXqK0Hw3vN1kLJQX3Aza/fY1R1xRYN6k9TpuRuibydZ75c39?= =?us-ascii?Q?XYMQo0y4rP6GuL+DbCVDTkoOMNvH0bRONxgCkwV6iH4rLmHQOuJDLFjeSQRo?= =?us-ascii?Q?97ZoMNbvjn9T+AoIWGJJ5cWydJyKC+apM9tkN+bxwVnxyL2PozeeNlNxdDQr?= =?us-ascii?Q?x1SoBF4Sh3pjEPsQplgBdPyJ3qcSiAuIDaxmau6duoswPPGMMdFeeVrybYJ6?= =?us-ascii?Q?MPNoZ7bRbO6gOkqSS6IkEh1LcTO/LU2Wih3u+JsIqPW+MoiMG33e9fLXD7GZ?= =?us-ascii?Q?uHZnAMUS60AOvujVQFmJcIUh0bzZQCUQMLOY09sTe73CaW85bUqPwh8g/qMA?= =?us-ascii?Q?aBESy0whIcfkWnsmHH1NJOu0TvdD5b4spW/3GY+oBB4YoE1UgK+6G/KOYcqy?= =?us-ascii?Q?HAxUhTTTfHp5l/uiD80ftk+CSey1vq5R9NlviWl+A8pLJCd5C/1fJOMQt2zo?= =?us-ascii?Q?DS+2qXwDBrSkIKt7x1pJ7ymfBN/uEDV0XXdcQlf3QZ5vWxRdS/3HcccV/S0q?= =?us-ascii?Q?266lGjte5nxFJN2mcRpAhudVhvwXuIjJN8tCW56IPOxDM/uaHihp7UbDKtfC?= =?us-ascii?Q?1/rqE14fbIU0O9ZYykI/rFuKve31NVT/OmhQ7DeQuMtZjjyjX7Sg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. From: Abner Chang Unlink the XhciPei memory block when it has been freed. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 29 ++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c b/MdeModulePkg/Bus/Pci= /XhciPei/UsbHcMem.c index c64b38fcfc8..7dc014e465d 100644 --- a/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c +++ b/MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based on gPei= UsbControllerPpiGuid which is used to enable recovery function from USB Drivers. Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.
+Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -365,6 +366,32 @@ UsbHcInitMemPool ( return Pool; } +/** + Unlink the memory block from the pool's list. + + @param Head The block list head of the memory's pool. + @param BlockToUnlink The memory block to unlink. + +**/ +VOID +UsbHcUnlinkMemBlock ( + IN USBHC_MEM_BLOCK *Head, + IN USBHC_MEM_BLOCK *BlockToUnlink + ) +{ + USBHC_MEM_BLOCK *Block; + + ASSERT ((Head !=3D NULL) && (BlockToUnlink !=3D NULL)); + + for (Block =3D Head; Block !=3D NULL; Block =3D Block->Next) { + if (Block->Next =3D=3D BlockToUnlink) { + Block->Next =3D BlockToUnlink->Next; + BlockToUnlink->Next =3D NULL; + break; + } + } +} + /** Release the memory management pool. @@ -386,7 +413,7 @@ UsbHcFreeMemPool ( // first block. // for (Block =3D Pool->Head->Next; Block !=3D NULL; Block =3D Pool->Head->= Next) { - // UsbHcUnlinkMemBlock (Pool->Head, Block); + UsbHcUnlinkMemBlock (Pool->Head, Block); UsbHcFreeMemBlock (Pool, Block); } -- 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97690): https://nam11.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F97690&data=3D05= %7C01%7Cabner.chang%40amd.com%7Cfc19cbc943344c1b4ba408dae36a0427%7C3dd8961f= e4884e608e11a82d994e183d%7C0%7C0%7C638072341730469421%7CUnknown%7CTWFpbGZsb= 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300= 0%7C%7C%7C&sdata=3DoddTHEzsrA3M%2BDWgm6H3DH3f8NDkfNKhsklRp9TUsx0%3D&reserve= d=3D0 Mute This Topic: https://nam11.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F95808360%2F7039027&data=3D05%7C01%7Cabner.chang%= 40amd.com%7Cfc19cbc943344c1b4ba408dae36a0427%7C3dd8961fe4884e608e11a82d994e= 183d%7C0%7C0%7C638072341730469421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM= DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DN= 24EzofHEBkr50g2VoMPaITH5s702887E2c331mYSoY%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D05%7C01%7Cabner.chang%40amd= .com%7Cfc19cbc943344c1b4ba408dae36a0427%7C3dd8961fe4884e608e11a82d994e183d%= 7C0%7C0%7C638072341730469421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DnpI1cV= SbpKZreSExI%2FrguTqKuYkwLeHmroAQ2JN905k%3D&reserved=3D0 [abner.chang@amd.co= m] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Wed, 21 Dec 2022 15:44:01 GMT"; modification-date="Wed, 21 Dec 2022 15:44:04 GMT" Received: from CH2PR12MB4149.namprd12.prod.outlook.com (2603:10b6:610:7c::13) by MN2PR12MB3966.namprd12.prod.outlook.com with HTTPS; Wed, 21 Dec 2022 15:42:20 +0000 Received: from BN9PR03CA0782.namprd03.prod.outlook.com (2603:10b6:408:13f::7) by CH2PR12MB4149.namprd12.prod.outlook.com (2603:10b6:610:7c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 15:42:18 +0000 Received: from BL02EPF00010207.namprd05.prod.outlook.com (2603:10b6:408:13f:cafe::47) by BN9PR03CA0782.outlook.office365.com (2603:10b6:408:13f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 15:42:18 +0000 Received: from mail02.groups.io (66.175.222.108) by BL02EPF00010207.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 15:42:17 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" CC: Hao A Wu , Ray Ni , "Kirkendall, Garrett" , "Chang, Abner" , "Lin, Kuei-Hung (Timothy)" Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg/Usb: Read a large number of blocks Thread-Topic: [edk2-devel] [PATCH 2/3] MdeModulePkg/Usb: Read a large number of blocks Thread-Index: AQHZFVLQFg2rBCN6M0SysvI3sEtldw== Sender: "devel@edk2.groups.io" Date: Wed, 21 Dec 2022 15:41:44 +0000 Message-ID: <1732D94C3D119999.12545@groups.io> List-Help: List-Subscribe: List-Unsubscribe: Reply-To: "devel@edk2.groups.io" , "Chang, Abner" Content-Language: zh-CN X-MS-Exchange-Organization-AuthSource: BL02EPF00010207.namprd05.prod.outlook.com X-MS-Has-Attach: X-Auto-Response-Suppress: All X-MS-Exchange-Organization-Network-Message-Id: 73bf3032-2ab7-43bf-065c-08dae369f0f7 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 received-spf: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C x-ms-exchange-organization-originalclientipaddress: 66.175.222.108 x-ms-exchange-organization-originalserveripaddress: 10.167.241.197 x-ms-publictraffictype: Email x-originating-ip: [10.180.168.240] authentication-results: spf=pass (sender IP is 66.175.222.108) smtp.mailfrom=groups.io; dkim=pass (signature was verified) header.d=groups.io;dmarc=bestguesspass action=none header.from=groups.io;compauth=pass reason=109 delivered-to: mailing list devel@edk2.groups.io mailing-list: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io list-id: dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1671637337; bh=rWEhnLJPQ4dofX9QqWc9w3DcNbiaUw0AtgzNMV44qDE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=QZmCdZhEQxkhqhb/Uh/Biwi1MHVvOb6DwrFFPf15QZLyevtwzBGIyrcKef/SNxh21ym YPXYaEQGDNLQ8Ki8eNMhredbiOPcqeT9oLFyTc5e2GXiEMnrcF4jdeVKZflAiNVkuIuQz 86whctCPw+s6WSK348LWCqtBwWjyGDy7IzM= x-ms-office365-filtering-correlation-id: 73bf3032-2ab7-43bf-065c-08dae369f0f7 x-ms-traffictypediagnostic: CO1NAM11FT068:EE_|CY5PR12MB6348:EE_|BL02EPF00010207:EE_|CH2PR12MB4149:EE_ x-forefront-antispam-report: CIP:66.175.222.108;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail02.groups.io;PTR:mail02.groups.io;CAT:NONE;SFS:(13230022)(4636009)(451199015)(36756003)(356005)(336012)(34756004)(33656002)(956004)(4326008)(2616005)(8676002)(83380400001)(6486002)(5660300002)(1096003)(76796012)(6862004)(19810500001)(7696005)(966005)(7846003)(54906003)(36736006)(6666004)(26005)(7596003)(7636003)(9316004)(118246002)(66899015);DIR:INB; x-microsoft-antispam: BCL:0; x-ms-exchange-crosstenant-network-message-id: 73bf3032-2ab7-43bf-065c-08dae369f0f7 x-ms-exchange-crosstenant-originalarrivaltime: 21 Dec 2022 15:42:17.6232 (UTC) x-ms-exchange-crosstenant-fromentityheader: Internet x-ms-exchange-crosstenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d x-ms-exchange-transport-crosstenantheadersstamped: CH2PR12MB4149 x-ms-exchange-transport-endtoendlatency: 00:00:03.1446924 x-ms-exchange-processed-by-bccfoldering: 15.20.5924.016 x-eopattributedmessage: 1 x-ms-exchange-crosstenant-authas: Anonymous x-ms-exchange-crosstenant-authsource: BL02EPF00010207.namprd05.prod.outlook.com x-received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 21 Dec 2022 09:42:07 -0600 arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NtzVTnUN6sTQLGcP3GYn/11pO7ihoNDt/dvEjuJ/SQYLmfnNy5w6AXum/06XOu8FQeq43Tf9tqdEIRJ0cezrxAyNCY3eDJBhvH5d+AAnz0gpsKw6sHqo9rY64lAyenuSJf41uhYlzE21LXmiB4toxc96F2c40m1KaLPeT1nPrxRP55FcODK4wNMELTmeUPoHFKzsSCw23cnbksFRfLWxzK3MZsJ6xW7nfkUqiiHXgCw3DeHIGMJzoUXyLXQFVvyK9IZoURv52IVRWqFMa95TallWfsRAwcr/gveyW9ztPyNY7fe+nb6ASmDuQGfFnwCCx58P6cyGnpdZcyY+WxdIzw== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tb4+RI3css/1WwpGGJXO4kioar6lwzp8dkOJpDdGUGs=; b=XOkf0kWDzXOKb8IjsM+4bMKF1LSFOODGOdbhX80uMB9rOz8HIHZWRhWMn6ICfEhug0OfO1zcFdTJXuceHBgAHKcXtPYzMyLJYDTMaTU9ElTRKCUDc+VtsGE2AaKFlLklGWSoyI1qtP07eNDDB1aD/kzMdTNm+JHk8Z7BM8x2wNaoZeECRIZ5j1ggI6qBHSXDF1EVJwAfl1ZIqIsAhaqRr7ivm1hPuXngGwLk1cBg9swQsg/b6oKQmG3b/Sp0PhdiE/vz9xuNADf5jZx5rUw6bHdLNNFUbO1Kyci7k9TUKWqZupVsSUA6OS30BzpL9wOye5zD0SGjRG/Kk1ld13Yi+w== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info-original: TuynHC3H11HEf6Qaz/kFn74Atm9PR0/VrWx+EDt3BpZREzvJh2maO3/jHbARUSW88Jv7Hb3MhIy6ne1+Cip0HB1OB4b2n9IVgpnV7GhBREdu7XJYsnGQPT8cxRmONhAEYiNeYNkBaJY9a2sxmOaGMnh80M1XBcxjCiiyHWB1oNAvJd0vdbqMS+cAt8N/DuBh9osb9j1AwPAE2tvTGA+nJZdQRQDwPSVOmwTNUBWkBxYipp0S5GuJtW0j8TcVS8R78Hmlkxnc3dsXbqbdLYi72Nfcl9uOVu5eaMH0dVIw4IZPhfVhAd4t8ssD0OM+cvAW1RASxFrX7bQkE8TDugtIOTNUXEM7g+t6fxRKqh8JkpsvMnDXVl4KKPu530zbuCfY1AXaO117WAaDidXbICcGW5k2OPu4ZahuL8GfdVfi2gXbCjVOxAactdYcA2RFRPi2Dhpd7PPJpY6gGT2zlR3Je8aEe/vwea6753UUAoVlPoSMTHlLeWE69w+0RujCHOR0919XPPjSa99HqyYtmBV/37XLqz7WHHZCxO+ObdFz8ehrY7cCDENyUKZ/xQv6+1kNv+ci24xZTuFvCnZj8VHYm/+oAuvrPDzih82OCuKHG+OTMsvjJq5sJ7J8HnIssypb2akY9BrnCTsLRUYnImDJDM3Jmvxc3I2T+MEcbFRNhtt5lJXe9PF89+wPCBfnPhVX7XXd96GgABX4Tv6pI0MxfXOkYJmdIBZKSkNBxlI6slU= x-ms-exchange-transport-crosstenantheadersstripped: BL02EPF00010207.namprd05.prod.outlook.com x-ms-office365-filtering-correlation-id-prvs: 1c8f2468-80e9-49c6-32c7-08dae369ecc6 x-ms-exchange-antispam-relay: 0 x-gm-message-state: 04AHFrrwMqsxPsEEu4fj0n2Xx7039027AA= x-clientproxiedby: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) x-ms-exchange-atpmessageproperties: SA|SL X-Microsoft-Antispam-Mailbox-Delivery: ucf:0;jmr:0;auth:0;dest:I;ENG:(910001)(944506478)(944626604)(920097)(930097); X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S/66xjhDOiovjS7dj+ZviJ/gzqptmA7jIO0SnUuljtBU6lsU6KPOdEvy8gBh?= =?us-ascii?Q?4paz+0mdoBAgZWlxuMQNF3jsnyhWdVv+1Y2QpkG6TllX99KkI2RYoZxyIcE3?= =?us-ascii?Q?ZKF+8njHTXeS6KGG/kmAAqzcNfSGn+dgZkYu5LalfYU7J1kg2tYja2wBEm61?= =?us-ascii?Q?LCSY0am+y7vuMr1IJEtJtj1t2HrHPWu80Pli7DeXVUBbzkWv90u8NTv+JNpx?= =?us-ascii?Q?bXtjLqMhcGJVrX4lU4WasBZUmeY2eKv95qkVeloiUiGkV74VOm0KQhdxsutM?= =?us-ascii?Q?7nDuwtzWEayLVLY1tYbkuvZuK5F3D3YKVGfQ22FABv5oVVjaHRsF5sia9BbC?= =?us-ascii?Q?PeODM9d9tpHTzdQvCArPa7r47+2T2zefh4413ppooVCRumZi1RuCg9J7gujj?= =?us-ascii?Q?EVLv0pzOGBYPGo/OLnE5cJH8r74+xDNrPstwXWVbebdjblxqGGAqlKFRHR8t?= =?us-ascii?Q?R1F0PWEQepS4DrZbQnxivAzfegJO7HVO1hxp0DslKXTLe/gDc8pXoMO8A5PE?= =?us-ascii?Q?fYzFueQ1PW+vmKFMwUOjieRFtQ+VXv+5bLP6hP54zJKMD56UjXL5ObCT9Tj9?= =?us-ascii?Q?QYiDvjMSe+jdbnYRTJ1rSMqhpRoQKPGKXiM/j2pTmnJx0cz55vh7y3+aOQXW?= =?us-ascii?Q?XYMRtB1T5FI9PD9YLEpVFVwPprH2MTW9BlwztYaf7MeoT4ZkmzFedDEEWbgK?= =?us-ascii?Q?r7YxvwSBt6lZWVM7sl69myZ7a1mcCVuJP3Kx9zC1sK1pNkiAZDvVz9+UP+Lq?= =?us-ascii?Q?kS+fU0kucQeJhbyeJHcTYwIwgEc7WP75wYr8YPMx1aDRlNmLef/j53urNz1n?= =?us-ascii?Q?qR0c0KCqfpLb/NuLtoeo2KteU1svANfixyPC3rgGaTLjZIXZGYBnsPJUEBvs?= =?us-ascii?Q?M8Dtsym78EZmlgFZIjgXOs961MDswVDn5c4ZCw6kGiBuD4eurUmL0p1lbBy3?= =?us-ascii?Q?kw9e9p9IPYMXjIsI4ZJ4Gr2uDWv4eAJljkf1XGkxe0X1rEkeiuhUNfuiQS4A?= =?us-ascii?Q?pJVsv6ts/4b25qAfo/UIAS2TFwin8HlXVyyk2F7nANS8HoDO22NQTVWXQWeC?= =?us-ascii?Q?6Q6j+L6yLBiUpu65ZmpjqpiSMnsmTkPoSkqOzfbcNjALdbKGhhBvWJeVx3c3?= =?us-ascii?Q?mXlNzHnV9OtdEbOAhrQajFzc5DH10QIIHWTipjXH7mH01qkwupAL8RA8c1Q8?= =?us-ascii?Q?jt8kf4KDSXplbBKFWhsBaQUfFwZd0Bgj7C0tpeojEcWxYqRf6tlAAfmdFd8W?= =?us-ascii?Q?YOT5FL3WNJh6DPOStgmfZKSv4CAZEPqfALGDYjy0/mIFCGXgPq3SBh1Is9RT?= =?us-ascii?Q?uN+Kdj5oHfK0EDMi80a8EIfCD2lylBtksL4ZckydUrEFIEDjg0CXAzBE0Zp7?= =?us-ascii?Q?8bim5Fr1MR9iG1tOiAg15UL9/NJ3nnCijpU3xdZlUrx13CoSIeKqhjL9YJux?= =?us-ascii?Q?6lB2dGv2o2d8lprgzn2OtJGMCt+RyB32IuBb9c4kPlMgayvNlRKE/y6Wje1N?= =?us-ascii?Q?PFHfBYGKud1RsWaMIvRHEW7OAoQCUCtL9A5hnw3JdMDsj+OmOUDrjYB9IpS8?= =?us-ascii?Q?oJnRLa3ly0Do8vTPMbFfzCxzAiZ7zh7huuLlG2iEXcf649MZo4kymL/AgWNV?= =?us-ascii?Q?BHInpX0WITxqcSe8xomG+gKVF4/8MgOgV7hEkmsI+1MvRcBg7dcdlSUb/Kiw?= =?us-ascii?Q?Yzwt63Ov6FNtt4o7taLdVvrhAhm07/88Dj0izy6qIZsvdLgKwxEVqSnn06nh?= =?us-ascii?Q?gWTEEQzSQ1kgWZ6c7LpHvcQQTxMupVuq2nzt9gjkcJrOmwyCLS1L?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. From: Abner Chang Changes to allow reading blocks that greater than 65535 sectors. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 25 +++++++++++------------ 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c b/MdeModulePkg/Bus/U= sb/UsbBotPei/PeiAtapi.c index 422ac5fec99..5111e4579e2 100644 --- a/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c +++ b/MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c @@ -2,6 +2,7 @@ Pei USB ATAPI command implementations. Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.
+Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -382,14 +383,14 @@ PeiUsbRead10 ( ATAPI_PACKET_COMMAND Packet; ATAPI_READ10_CMD *Read10Packet; UINT16 MaxBlock; - UINT16 BlocksRemaining; - UINT16 SectorCount; + UINT32 BlocksRemaining; + UINT32 SectorCount; UINT32 Lba32; UINT32 BlockSize; UINT32 ByteCount; VOID *PtrBuffer; EFI_STATUS Status; - UINT16 TimeOut; + UINT32 TimeOut; // // prepare command packet for the Inquiry Packet Command. @@ -401,16 +402,13 @@ PeiUsbRead10 ( BlockSize =3D (UINT32)PeiBotDevice->Media.BlockSize; - MaxBlock =3D (UINT16)(65535 / BlockSize); - BlocksRemaining =3D (UINT16)NumberOfBlocks; + MaxBlock =3D (UINT16)(MAX_UINT16 / BlockSize); + ASSERT (NumberOfBlocks < MAX_UINT32); + BlocksRemaining =3D (UINT32)NumberOfBlocks; Status =3D EFI_SUCCESS; while (BlocksRemaining > 0) { - if (BlocksRemaining <=3D MaxBlock) { - SectorCount =3D BlocksRemaining; - } else { - SectorCount =3D MaxBlock; - } + SectorCount =3D MIN (BlocksRemaining, MaxBlock); // // fill the Packet data structure @@ -435,7 +433,7 @@ PeiUsbRead10 ( ByteCount =3D SectorCount * BlockSize; - TimeOut =3D (UINT16)(SectorCount * 2000); + TimeOut =3D SectorCount * 2000; // // send command packet @@ -448,16 +446,17 @@ PeiUsbRead10 ( (VOID *)PtrBuffer, ByteCount, EfiUsbDataIn, - TimeOut + (UINT16)MIN (TimeOut, MAX_UINT16) ); if (Status !=3D EFI_SUCCESS) { return Status; } + ASSERT (Lba32 <=3D (MAX_UINT32-SectorCount)); Lba32 +=3D SectorCount; PtrBuffer =3D (UINT8 *)PtrBuffer + SectorCount * BlockSize; - BlocksRemaining =3D (UINT16)(BlocksRemaining - SectorCount); + BlocksRemaining =3D BlocksRemaining - SectorCount; } return Status; -- 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97689): https://nam11.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F97689&data=3D05= %7C01%7Cabner.chang%40amd.com%7C73bf30322ab743bf065c08dae369f0f7%7C3dd8961f= e4884e608e11a82d994e183d%7C0%7C0%7C638072341408928871%7CUnknown%7CTWFpbGZsb= 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300= 0%7C%7C%7C&sdata=3DxX2U2xR%2Bp%2F6AYiyQqdObppuUzPBQkJAyHn4bSOE1d6Q%3D&reser= ved=3D0 Mute This Topic: https://nam11.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F95808341%2F7039027&data=3D05%7C01%7Cabner.chang%= 40amd.com%7C73bf30322ab743bf065c08dae369f0f7%7C3dd8961fe4884e608e11a82d994e= 183d%7C0%7C0%7C638072341408928871%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM= DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dd= 4VTNFZ8mJgTD4nvdLJoGAJa5oWVzpWpGmrZAHmCQqE%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D05%7C01%7Cabner.chang%40amd= .com%7C73bf30322ab743bf065c08dae369f0f7%7C3dd8961fe4884e608e11a82d994e183d%= 7C0%7C0%7C638072341408928871%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dy1Vk68= SVot9lz2PJWT22P7BRibzHKVYcFkPz8WzSeVk%3D&reserved=3D0 [abner.chang@amd.com] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Wed, 21 Dec 2022 15:44:05 GMT"; modification-date="Wed, 21 Dec 2022 15:44:08 GMT" Received: from DM8PR12MB5478.namprd12.prod.outlook.com (2603:10b6:8:29::12) by MN2PR12MB3966.namprd12.prod.outlook.com with HTTPS; Wed, 21 Dec 2022 15:41:51 +0000 Received: from BN1PR10CA0006.namprd10.prod.outlook.com (2603:10b6:408:e0::11) by DM8PR12MB5478.namprd12.prod.outlook.com (2603:10b6:8:29::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 15:41:50 +0000 Received: from BL02EPF00010208.namprd05.prod.outlook.com (2603:10b6:408:e0:cafe::fe) by BN1PR10CA0006.outlook.office365.com (2603:10b6:408:e0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend Transport; Wed, 21 Dec 2022 15:41:50 +0000 Received: from mail02.groups.io (66.175.222.108) by BL02EPF00010208.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.8 via Frontend Transport; Wed, 21 Dec 2022 15:41:49 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" CC: Hao A Wu , Ray Ni , "Kirkendall, Garrett" , "Chang, Abner" , "Lin, Kuei-Hung (Timothy)" Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Topic: [edk2-devel] [PATCH 1/3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Index: AQHZFVK+0G3aCYyYXE2vSRbZj+PvvQ== Sender: "devel@edk2.groups.io" Date: Wed, 21 Dec 2022 15:41:11 +0000 Message-ID: <1732D944B7F00903.12545@groups.io> List-Help: List-Subscribe: List-Unsubscribe: Reply-To: "devel@edk2.groups.io" , "Chang, Abner" Content-Language: zh-CN X-MS-Exchange-Organization-AuthSource: BL02EPF00010208.namprd05.prod.outlook.com X-MS-Has-Attach: X-Auto-Response-Suppress: All X-MS-Exchange-Organization-Network-Message-Id: 93d24d98-bbf3-4d41-b39f-08dae369e047 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 received-spf: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C x-ms-exchange-organization-originalclientipaddress: 66.175.222.108 x-ms-exchange-organization-originalserveripaddress: 10.167.241.199 x-ms-publictraffictype: Email x-originating-ip: [10.180.168.240] authentication-results: spf=pass (sender IP is 66.175.222.108) smtp.mailfrom=groups.io; dkim=pass (signature was verified) header.d=groups.io;dmarc=bestguesspass action=none header.from=groups.io;compauth=pass reason=109 delivered-to: mailing list devel@edk2.groups.io mailing-list: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io list-id: dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1671637309; bh=+4YMlIjCKFS3SoKGtQKCAO8OwmyZadIeS3j5h5giSNA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ced7s6T3sVvTJqzX5lonbcXaE5YlERzD0N5gw2/Kn8R95foqWOXJjc2MJuMc6QMtn3b yrg0CeevHrNFlFkAV5ubTwmRq+Neuqd3NMTTXlCpm8lpz9wrJKK5v4Po2OTG5dq552fYO ephYZF9qg8zMpPPOZWoif4zNLCp+TkngGdk= x-ms-office365-filtering-correlation-id: 93d24d98-bbf3-4d41-b39f-08dae369e047 x-ms-traffictypediagnostic: CO1NAM11FT049:EE_|CH3PR12MB8076:EE_|BL02EPF00010208:EE_|DM8PR12MB5478:EE_ x-forefront-antispam-report: CIP:66.175.222.108;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail02.groups.io;PTR:mail02.groups.io;CAT:NONE;SFS:(13230022)(4636009)(451199015)(66899015)(36756003)(1096003)(19627235002)(356005)(4326008)(33656002)(8676002)(966005)(5660300002)(7596003)(83380400001)(7636003)(956004)(7846003)(76796012)(336012)(19810500001)(2616005)(6486002)(36736006)(118246002)(26005)(34756004)(9316004)(6862004)(54906003)(6666004)(7696005)(64893003);DIR:INB; x-microsoft-antispam: BCL:0; x-ms-exchange-crosstenant-network-message-id: 93d24d98-bbf3-4d41-b39f-08dae369e047 x-ms-exchange-crosstenant-originalarrivaltime: 21 Dec 2022 15:41:49.8025 (UTC) x-ms-exchange-crosstenant-fromentityheader: Internet x-ms-exchange-crosstenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d x-ms-exchange-transport-crosstenantheadersstamped: DM8PR12MB5478 x-ms-exchange-transport-endtoendlatency: 00:00:01.8111258 x-ms-exchange-processed-by-bccfoldering: 15.20.5924.016 x-eopattributedmessage: 1 x-ms-exchange-crosstenant-authas: Anonymous x-ms-exchange-crosstenant-authsource: BL02EPF00010208.namprd05.prod.outlook.com x-received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 21 Dec 2022 09:41:34 -0600 arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6chrYON6N26l9Xjgd/v4sVj/N2M+jaxhr4f9r2fqh3ur+oLWYFWSkz2xjfYwXq63SO9pG3y9nwaL1vs9QQd6XRvGEb+ywe0sZLeRZtA4wGUzwyJ9bUEyalu3RI+KybtJw0BjGw8svZj3CiVqvIx/o7VWVLSMm5ciJtQX+JwyNU6afpO9dyWfVi3205wDeacwaU8NxQ653iM5k5zNOrTq5J2tYkBfUNFO3Dytm81Vk+QxXe/RBoiAv5N4bmY8FL4bWz/AI/B5bsRlB7y6t+2QeQXqcucYfcb0LSUmzGiTRra8+fA9tUUj6J6xmM/d8IEQrhdPTZw+APZsHrXyZ/ahQ== arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nLu1I9ERRicLUIjdbkJamxFODKQ95BBINfz3uShK5Po=; b=DB7sJg23cAOPvit2Y26tx/H5rd5ly29tZSbVBz0FvKFaEZjW8tf/hmi9fmqckJej91LYhM2OMQM3lUTTjEhJHJgId+3vfRy0DE90CsQgT+BESBB/g6A5UEZirOTO8MG9i4UySWOpfewKYzMWGfh1KXQgNSoVyc8W6++I9msWsiuAzmnlYyJ8diws8mo2wZ92t86imJuz92GivuvfNTWOB1efDZ+R/lzf4MdbwvFHdVSQw4q5RlSsiTbYxP0q8gmoKJPf9mTQSU3cDq9aqN/T0m74GGVzdw7PqnHeR5U248CNtAm/RQcDdZZr2IKtnnWDBEF7/QeT4n5UzTXpwia/vA== arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info-original: b9S58BgdCCDuTBawJQJl69pNa3ZynBPACQ6AG+5/2ctXughXIgJVjaJLiw1HOXDvCjcLaK5oC9HcI4pse3xLVPJ1MuZhu+UkamUOW+GZ3U8+5ED150CWh9gwFoMxPyGy7CB0Z7FWSjszXsj3DhxGKQtjILVDSTJsTFKuB+yvsQkGEAdAjlbjhcSuUQ6eZc5nsT9l4ct7JhUuBSmaN3qSfiMYHdrdSToilVvBDASejcoLOzCHmEVJwsCspg8KFTlhfAbc+ExYqX3w2wZj4OjQnoPncEwgbpE+Rh6x6nY8rIfzX58oADhR7DhfwnOqIZ4PnBLClyA/LGJ3klYpxK4dFSVysGr18AXLQhlthFFXrHVEjE1LsmFUEiRziqh0wffyB3eawXWWVUdm2JHG+whz4gtzg46s8Tma7K5guE3yPrU5kQ2Ooyli/hJPvs+31W/ZCAAiZtf+LffamPP9M4AV8JIlByF0Bskx10SIHXAzwNXHySDlxZF3y1Z/ptO1jPrwU0sPahs5IvzHmlHRE4ao7HzhOGU2zC20NfVl9VzCOXgOeP6p0oDR9YT1lhKSlMO80wMRGjcZ96Xf746kZxHinGcgdUXg1QEtA3bH5pT8h9h87hqWhopKsqM6Prqk2duBN62wN6EGxhuHHTiNMHgQZKjWWO9uP+Whc6Jn3/2Uyno0RC1SwqLpH+DAwf6Zc+4wqD7GO1N1StCW3HS4vOwlrvzvFCB4xR+ba3XknCbdIlpTxckS90l/1OmRXy/3fyWfYt2lbDx8ttm3/1+9/T/Tnw== x-ms-exchange-transport-crosstenantheadersstripped: BL02EPF00010208.namprd05.prod.outlook.com x-ms-office365-filtering-correlation-id-prvs: 51c48595-9444-4314-ca2a-08dae369d940 x-ms-exchange-antispam-relay: 0 x-gm-message-state: o8AEmB7uAIlOG6eeIxQgzxnIx7039027AA= x-clientproxiedby: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) x-ms-exchange-atpmessageproperties: SA|SL X-Microsoft-Antispam-Mailbox-Delivery: ucf:0;jmr:0;auth:0;dest:I;ENG:(910001)(944506478)(944626604)(920097)(930097); X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nkH7nH+Zuf/DPHhrDfAbfIy762DtrXiVB+EvfpOPqWFeGk1hItK1jAeUyx2a?= =?us-ascii?Q?NmGjb1CgGAtAPYX9pSvAWlnvUhcczmCTRgBpoFI4i5wdCtfMeH+/kdH85cMH?= =?us-ascii?Q?ayjrFYUvyEC+A9I710kvG9aWMa/uIAgUbDhPgphyhCFoduSfEKPV4Mc4flYs?= =?us-ascii?Q?OLEfqu+E5ZIxpHBTpcqO0LUp3UShISgrQOgcZ+WuF/btwaV7gTMzPyB2lOk9?= =?us-ascii?Q?5fQtYSiO5P6i8I41Tc2h3w0KkTGp68AVhV5x/L60MbSYAC9ixEEJY19E3iHa?= =?us-ascii?Q?fKLfVOgM8cLL0mh4dg7xcaMOhEw59+EPQ22thKO+x/Gq3Bo8GrBmV6tL6jPV?= =?us-ascii?Q?Fj/QwcTx65y79s8RgexztQyE8cIfMrhiNUrmPwZrqtkbb/M6vxhnP0hF0aQ3?= =?us-ascii?Q?AMVYveDiSOPDoZR6OTL+DFqu0cVyz6lzKoNh8nRYVTLT6QpP0nCe1ykPS0wV?= =?us-ascii?Q?PVarX/jp3H6sYh+C8zFLuTzc2wCr1dzsINqoEt4ulqQNJ2BsPAbVA208dk3y?= =?us-ascii?Q?rnP59f6wZuS2Eav1SEGIgMeJR/1RpbmIziOzYeRl3MzQsbumW2EAbICIDHjf?= =?us-ascii?Q?qHBRaqIugM6CoxeZ+8NMmYB43UXjINHyK23RCOzvVkvBbP1qJwpPik9vOgog?= =?us-ascii?Q?uFDNb0UPv+/05tJJ/JWEiY4884F4tqK+aJcxelcbSaZLfyDmf9JZJrghSADz?= =?us-ascii?Q?Csr402KLuzDsHdFL34yvqhvCnMQT0XXlSJPkvnSrn1KjHcMaV1GwT8pZxpAJ?= =?us-ascii?Q?be3CnBhpyNdjquqdrhXYWq35iwOy5uH6dDmJ9iwyAsXiOBexIgmFpb2Xpefq?= =?us-ascii?Q?0ltXHs/oA9oh2IdZ1ep7Sa+S3GiNM+xSk3ehE8pNVLDL8/qIgikJiN/wc65u?= =?us-ascii?Q?Rkpi9tY3uc2RJNvnP9L6WnCCqhd2ngRC30Do7uLLnAK8BD7SJ0NHnztWpoxy?= =?us-ascii?Q?jSUdWk81v01v8OniJgq/Rgxg5KeejY84EzqbDHBru0frN6M1vkOtzoWo7sUG?= =?us-ascii?Q?jv5xXiCO3QAMs9d9gnPUw+XJMv5vm/7hoz93PXlvMijo0/XVlBRjKcqcxQF3?= =?us-ascii?Q?C2wJ0W/wlZitcsc82/h9h07xVUG0I6Jbq4ewBpumQUYybHXZTR1JaD9vM7fT?= =?us-ascii?Q?FMwx5KPh02AhHS6F7Qqh5p3jPtdmWcgwTkXye8rEAOd03kno35HcnbmsDPdK?= =?us-ascii?Q?cyWsuSHR5yC1SDDcoZCLD/LNIGcCFCwGPPSnqzSCKIuDSuR+R2Vq1LCaX1lo?= =?us-ascii?Q?eO0QX+OFNsYTXnr7efNryt86x3dE1670n3VpBFGfyUT/XK21wRD/1PNtLiJL?= =?us-ascii?Q?w5LCYkVq81R4RMp9Qc186tH8BSHwb9ErS2wReU6wTNjn2Q/FwnBS65jTUXbY?= =?us-ascii?Q?Oz+anOhjYQqwCC+g6M3ZkieUDhI5CElZDqATt0m/e3XQXQ1z8e1to431T4Yk?= =?us-ascii?Q?T5n67dMI1zEMJSkw1gAvEfS5s/brVDS2vX+4BU95+vQ0hOUJCpCeehvpqc0O?= =?us-ascii?Q?l3JQOrv7lq3aDFNSnmuiLOQmpoNmfvQQzphvjCd1DrrBdZQ4qNra5athE+1B?= =?us-ascii?Q?D1ypDNj33kThMAQcfUCQRmivK2kRittZhUn6SuJxZRHHspoTypHVKsPbyE7T?= =?us-ascii?Q?q4CsSm4a8KNIUSqRnKP4QfNd/7csg+SXPqk2C+8xSSzPv7vhbhGxgHX7ohdL?= =?us-ascii?Q?ML/a9Itca7HpKIWlkfjPa5O69L+bjAXZefCSmywr4dYhQCYNmR/9PznpWwfw?= =?us-ascii?Q?hsWfTB2DBNxNGCRYBBSM8cSyRfuONYvlsMGZWPao0/71JTITJxxz7lpDbT84?= =?us-ascii?Q?RhSIegYE9Sl5dxnudeODdcqdP9SViLmy8nKHHlN3qN/bvmphkNPQKfwL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. From: Abner Chang Initialize XHCI DCI slot's context entries value. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++ MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c index 13247f7b0df..4b7462704a8 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -4,6 +4,7 @@ Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.
Copyright (c) Microsoft Corporation.
+Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext ( MaxDci =3D 0; NumEp =3D IfDesc->NumEndpoints; + if (NumEp =3D=3D 0) { + MaxDci =3D 1; + } EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -3006,6 +3010,9 @@ XhcInitializeEndpointContext64 ( MaxDci =3D 0; NumEp =3D IfDesc->NumEndpoints; + if (NumEp =3D=3D 0) { + MaxDci =3D 1; + } EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciPei/XhciSched.c index cc597a43717..8400c90f7ad 100644 --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based on gPei= UsbControllerPpiGuid which is used to enable recovery function from USB Drivers. Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.
+Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd ( } NumEp =3D IfDesc->NumEndpoints; + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { + MaxDci =3D 1; + } EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { @@ -1974,6 +1978,9 @@ XhcPeiSetConfigCmd64 ( } NumEp =3D IfDesc->NumEndpoints; + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { + MaxDci =3D 1; + } EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { -- 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97688): https://nam11.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F97688&data=3D05= %7C01%7Cabner.chang%40amd.com%7C93d24d98bbf34d41b39f08dae369e047%7C3dd8961f= e4884e608e11a82d994e183d%7C0%7C0%7C638072341117542409%7CUnknown%7CTWFpbGZsb= 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300= 0%7C%7C%7C&sdata=3DQ9npM2Zn6uKw%2Fi%2FQtHNllUeh8iARA0U6zBZ4T%2BaHhzw%3D&res= erved=3D0 Mute This Topic: https://nam11.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F95808331%2F7039027&data=3D05%7C01%7Cabner.chang%= 40amd.com%7C93d24d98bbf34d41b39f08dae369e047%7C3dd8961fe4884e608e11a82d994e= 183d%7C0%7C0%7C638072341117542409%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM= DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dl= 2mO2VIZCQE8UhZ%2BWrjPblTwb4GqaoT2197MO9azbvM%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D05%7C01%7Cabner.chang%40amd= .com%7C93d24d98bbf34d41b39f08dae369e047%7C3dd8961fe4884e608e11a82d994e183d%= 7C0%7C0%7C638072341117542409%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D2bEyXD= JVZxQV%2FeeQMmX0HeTicEtpYrC4iS7dERVg%2FrU%3D&reserved=3D0 [abner.chang@amd.= com] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_004_MN2PR12MB39665DFB7F589463F00FE3B2EAEB9MN2PR12MB3966namp_--