Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Hi Isaac,
I am not quite understand, this patch set should be independent of edk2. What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is good now? 

Abner

> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Friday, January 6, 2023 1:42 AM
> To: devel@edk2.groups.io; Oram, Isaac W <isaac.w.oram@intel.com>; Chang,
> Abner <Abner.Chang@amd.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13..
> f5da8af6befbfc655fd3e4cb899eda158dd9ede5
> 
> My apologies, I was sloppy and didn't ensure the edk2 changes were pushed
> first, so IpmiFeaturePkg build is currently broken pending
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=05%7C01%7Ca
> bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tBhHMIQhVL8AI3bof
> YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=0 being pushed.
> 
> Regards,
> Isaac
> 
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac
> Oram
> Sent: Thursday, January 5, 2023 9:05 AM
> To: abner.chang@amd.com; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for
> Redfish
> 
> Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
> 
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Thursday, January 5, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Nickle Wang <nicklew@nvidia.com>;
> Igor Kulchytskyy <igork@ami.com>
> Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> In V2: Addressed the comments from Isaac.
> 
> BZ# 4214
> This patch adds IPMI functions for building up SMBIOS 42 record for the USB
> NIC host interface exposed by BMC.
> The corresponding updates on edk2 is in the separate pacth.
> 
> This is the part I of upstream, the follow up patche sets are:
> - RedfishPlatformCredentialLib contributed by NVidia.
> - Relocate IpmiCommandLib.h from edk2-platforms
>   to edk2/MdePkg. A NULL instance of IpmiCommandLib is created
>   and located under MdePkg. With above, RedfishPkg doesn't have the
>   dependence with edk2-platforms. The implementation of IpmiCommandLib
>   stays in edk2-platforms without relocation, which can be pulled in
>   to platform DSC as needed.
> - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging
>   temporarily because some requirements are necessray to be spec out
>   in the Redfish section in UEFI spec.
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> 
> Abner Chang (3):
>   Features/IpmiFeaturePkg: Add IPMI functions
>   IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions
>   IpmiFeaturePkg: Add reference of IpmiBaseLib
> 
>  .../IpmiFeaturePkg/IpmiFeaturePkg.dec         |  5 ++
>  .../Include/Library/IpmiCommandLib.h          | 62 +++++++++++++
>  .../IpmiCommandLib/IpmiCommandLibNetFnApp.c   | 88
> +++++++++++++++++++
>  .../IpmiCommandLibNetFnTransport.c            | 43 +++++++++
>  4 files changed, 198 insertions(+)
> 
> --
> 2.37.1.windows.1
> 
> 
> 
> 
>