From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.50]) by mx.groups.io with SMTP id smtpd.web10.4611.1672972047931034947 for ; Thu, 05 Jan 2023 18:27:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=BQZaC+DT; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.50, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEGm0rnwDveFGWRqOSHrBX3x8KhDTVheJUsmAS5Imb2ifayQPSGH7x/xkwiY/oPxeakkUWxZphmuVEQ+OkAmeZfXHndbczyUqlQE8d9j66JpZCjZlXTldsbSUqLu9puMup2ijjKnWH0MUmL9aQx4OAJ6hyU+FpURwL0XfKAg1kk5PXkQvbufDNKF+54z1SjMD0u4jej5OOf6DlVjwCd+G02bn7pZ7bswIC2nVMqqvsZBwZHMM1Xn+BEToYhfHcnINbhaqEI9geSiUpmnNuhs4uQu/TurVAIrko3pExTlZkwl2kEU5SUe3XOR2TJLF+11Vqhlc/wpWStX2rDXSw/Jug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8Gh/xzxwCYAb73yrjg664EGEsZk/R9eJ6FyyqpiyAM=; b=UNbbTrsJgFFZ2LMPgtvR3H7yaAYjV8mnYkR6Ujhb0y0bj8UHBaATTNT7UAq4BHKb8f//AwI6+TaH1ep/FQvpoQjjpw48xul0+8+cV+6BhXL4Z+0G75miqRZhxQM9neM2Y2TzvHNvDjL1oJeeqTGuIDuZDP/sHVMXbAFIY473xWFmYvh8+m9Syhrpq7g7dTFRrvqbmP00z2daTrEOEE4k1ioUbYH3ZhA57HIzQ89Am4SDeq4nYwFUQVW0bS+o9jRklvpIgsl4LtM182PvZETyQgXM1W2bnIPxZiaGpriZfXAG+F8hqDNSvY/Lyhvxg33oEW71CCcrBjhHBYjfkKdZ2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8Gh/xzxwCYAb73yrjg664EGEsZk/R9eJ6FyyqpiyAM=; b=BQZaC+DTy0dx7fGJ7yd33TivZ2qGuHhDPagXq8PMs2DoAORG6tFeRB0eLse+XwgHjc+NhdcgCmBPl6J7yUaGzoAHFpppT0rs/fyj6oDd8cIMUXUUu7JJuX0EdaV1jZlNFnTlphMulDDYextUxJ4xSIlZl2HxqO+gfXHCYUfA2QE= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH3PR12MB8185.namprd12.prod.outlook.com (2603:10b6:610:123::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 02:27:25 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 02:27:25 +0000 From: "Chang, Abner" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Index: AQHZIR8LWofAPDAH8EaQaIRDPPizoK6QC/DAgAAJh+CAAJR7sA== Date: Fri, 6 Jan 2023 02:27:25 +0000 Message-ID: References: <20230105160100.772-1-abner.chang@amd.com> <17377895696F6651.2132@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-06T02:27:23Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c30d0ee5-a699-4b3c-9099-cd112f954d1f; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH3PR12MB8185:EE_ x-ms-office365-filtering-correlation-id: c457f475-4e64-4592-48de-08daef8d8c93 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kz74JaMNM1Va2FXdR4Vm0S4uXNPSrV406wcvTylT9kRDJx9Qu7DcElmAg05Cwl/6CTe1dsai4BLrxNLrPL3vU67+EAisS3Yg6E8Ts9HYww2cpmc37/ATIaQiShQYdY6w8dgcJy1Hvq1s715M5Om4biY++8xshAxUUCTxQ/vInnTiemlckfSl2SEq5YIAoBh3I9nydRQeKA7mTJHw5OuvI5l5/TlFRumCDUmap2Otr9mwe5TiuKFvcuklsvDluJ0HYBw3LhJERW+H0egZFxeZwYTg70gyMXsNgZR8YGZKCUEb3N37zZtY8eVSQVfqjWT3OJ8c7A8OGgC/R3tb+SXdBTXUjFu3UXbwXv3iXUoIcNy3KaYAEal5b7JbVxr5hFndBirjEqsf6E+rK+korOYxAtvdyvyKWeqPArFJ9pr04kvgtHWkjRcnmU7LZ27pfFuiyxTN/jdi7iOINZfT7zYdtoTIGS0Ev01NSvLsMxjOY4dPx+90KpoIWQTl20mARWCCjIJI5Nz7DxyIOx4HUDKxeb6PvrNpTu5J8JRp0nXnLAoLc5DDf2THKZho8f+TBpSKA5NXUmU4awaB3yiOoynQzaMUfSTcTDn4MJWdLOsn7CZyTbwAXG9n4GDuYUloRTS4N5Lq3zXzSEdTZhvk7WOyFjJ44P1zJoJjsKnjdHFBzORUUpBTKjVV8x5sJ4eBtW7CKWMkhAfYKL4I1F3bSrQ0VT1V7M5cLSYJS5rDjZzaiF/zdQPSyFqPvl1FE5dt+XJQECpv1NerkgETLqT6UNsn1w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199015)(66899015)(83380400001)(52536014)(8936002)(41300700001)(66476007)(66446008)(8676002)(64756008)(76116006)(4326008)(66556008)(66946007)(2906002)(38100700002)(122000001)(966005)(33656002)(478600001)(38070700005)(71200400001)(9686003)(186003)(55016003)(316002)(54906003)(53546011)(5660300002)(26005)(86362001)(7696005)(6506007)(110136005)(45080400002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eQnRzk/YjFuwX3d7P5kEH8KxdguP6hPdulLT3PxnUQ/RQhVesYxAsGLOBerD?= =?us-ascii?Q?giiWZuevSK9i1V/Fsk2mx7VJdQLEDgSgIEQm7ZRJNX1FASbTNTi/7Y0a9Yu9?= =?us-ascii?Q?H1x2U5mQpV5PNekflpd39Ih//A4IKGkq8MJaEOJmc7x2HCspRsN7AFqq67c9?= =?us-ascii?Q?AP3+WU9lkueiAXJNTyQdMr+7EouAk7qlbc/Qda/xFz8nlrMlpToo2PNb5z+P?= =?us-ascii?Q?lxoE1rQP8vy8QfpOqKfjhJoBF2kstwdYCHPLPlEG+zhA4BSHQzk9qnhLlPw4?= =?us-ascii?Q?SWPLTCdILjjkBsBIclxpI6hX+e/nf5DjyItwcAeVE8t3J1CEjoh25s9yZsfT?= =?us-ascii?Q?jYKuKKx4VRks+IKKkNx/YuvWVS0UvO9nttpUk5W0WFMvg/wtxEsG/XGSVaOo?= =?us-ascii?Q?S3QGH9aiOiotqLPqMcEAWNNiy9HL73ZO6CZfV4SF1ORYRy0yCnehAtumXrzS?= =?us-ascii?Q?MtcQK2Jn2SHPHW+Y6ULmMyK+GnijqbBNMY8t2FUF5en3oHWIRyapQuTzMB3J?= =?us-ascii?Q?urVoEWxb/dA1hlBUqQi+BhudTlynBiyq7TMBHfwZXdvCLc4qfP8a5/oxh/Y6?= =?us-ascii?Q?wzkb7NuoRNFz8mbxCNqzlFuFNviFQ3hzxB2n6JhO/3D+y/l9qAxm1elWJAHs?= =?us-ascii?Q?fQjis56TqIrzmdZgGcjOaq8KIeLTUin2ddFfphJmZISfytv3spgybJmYTJ48?= =?us-ascii?Q?26eZ3nLIOvR+tM7CLZudnh70uPhHZqmZCktNdsmla5V+s0k7uuMotgvu1XjN?= =?us-ascii?Q?Rh0mpOQvtDvTYlTjnkt3TcN3r4oNkGvZfY6g2wmKRKWKyfml+UeLhhKJCM68?= =?us-ascii?Q?3hco1F8zY/ix1rhW6rTAeGVDFJocUkI/p732NcpU1DyYzXweV2RD5OBu7LRS?= =?us-ascii?Q?5576NPUwH5AdnjcsFOKBQznfkdeUgZe/KEiKw4KaXjmNETLykTVlRXR7pK8l?= =?us-ascii?Q?KziTE27Bilujbs/VI5mvJAG9urfl3GAmE2UMSchWNcdTI+0YiZFccLxdf15O?= =?us-ascii?Q?tDJWvL2M7vCn1nnEu4IQ2Qtc2j6TvllVWJ71jExNNFYcY11yaiD5jKMspPGu?= =?us-ascii?Q?NoBsr/XelvLTEESWyTOawxepwq0PaN1ZIOgFBWCAIrHjBh9ryTTuBaWR7z6m?= =?us-ascii?Q?lkfapj8/HJtkMQz46QPRz/KVKRFLaI1qVxO6xBzKrRcKoAeFSSC6xMM6eWrD?= =?us-ascii?Q?zQv0VDBSSvOQu6TYbY3nhA9cQiyZt600Qe8wixfR8Si7U18qxeVTPZUuTb+g?= =?us-ascii?Q?wN6GN/CGSTPt13uhgnU+UscyLdygKL4IVR9Gd7QkUXUc+TNk+P5whW9hfUMy?= =?us-ascii?Q?xBVwwuz1BV3rF3D7DYe7c4wLl0Gkj3JmKkCOe+vYB7MSKK8RrmmmE2Yq2bRg?= =?us-ascii?Q?sYzvALyafGcbU68cv8TFSd7E4T75zb0spB5GiQQElnJhylLdMnPmoul3OkXZ?= =?us-ascii?Q?2lhEzzsQclikDA1q3EesMtAqSM4ahkbc0CwdwO5PbQA4IaacjFl8OrpHUWdk?= =?us-ascii?Q?43UHJUTI6ATVyIiWgJxWzXXa+mse9fPkLECmLjWwynB51tAiQZM9GB5W7Rh7?= =?us-ascii?Q?yRl0hcYVGa8d8KJN1CN+2hZmvu3fvPeQ9XgTPeHy?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c457f475-4e64-4592-48de-08daef8d8c93 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 02:27:25.4080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tNRlxoHzPDioTOeTz8VoNB7bCSZoCctAdUEmp3CdQ50yabdb72oQ8k9QgbNaW+Ez1IWpLlLQDsV6q/y1LY/8kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8185 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Isaac, I am not quite understand, this patch set should be independent of edk2. Wh= at do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg is goo= d now?=20 Abner > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 1:42 AM > To: devel@edk2.groups.io; Oram, Isaac W ; Chang, > Abner > Cc: Desimone, Nathaniel L ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. > f5da8af6befbfc655fd3e4cb899eda158dd9ede5 >=20 > My apologies, I was sloppy and didn't ensure the edk2 changes were pushed > first, so IpmiFeaturePkg build is currently broken pending > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=3D05%7C01%7Ca > bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896 > 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DtBhHMIQhVL8AI3bof > YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=3D0 being pushed. >=20 > Regards, > Isaac >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Isaac > Oram > Sent: Thursday, January 5, 2023 9:05 AM > To: abner.chang@amd.com; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish >=20 > Series Reviewed-by: Isaac Oram >=20 > -----Original Message----- > From: abner.chang@amd.com > Sent: Thursday, January 5, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang ; Nickle Wang ; > Igor Kulchytskyy > Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish >=20 > From: Abner Chang >=20 > In V2: Addressed the comments from Isaac. >=20 > BZ# 4214 > This patch adds IPMI functions for building up SMBIOS 42 record for the U= SB > NIC host interface exposed by BMC. > The corresponding updates on edk2 is in the separate pacth. >=20 > This is the part I of upstream, the follow up patche sets are: > - RedfishPlatformCredentialLib contributed by NVidia. > - Relocate IpmiCommandLib.h from edk2-platforms > to edk2/MdePkg. A NULL instance of IpmiCommandLib is created > and located under MdePkg. With above, RedfishPkg doesn't have the > dependence with edk2-platforms. The implementation of IpmiCommandLib > stays in edk2-platforms without relocation, which can be pulled in > to platform DSC as needed. > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging > temporarily because some requirements are necessray to be spec out > in the Redfish section in UEFI spec. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Nickle Wang > Cc: Igor Kulchytskyy >=20 > Abner Chang (3): > Features/IpmiFeaturePkg: Add IPMI functions > IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions > IpmiFeaturePkg: Add reference of IpmiBaseLib >=20 > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ > .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 > +++++++++++++++++++ > .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ > 4 files changed, 198 insertions(+) >=20 > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20