From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.65]) by mx.groups.io with SMTP id smtpd.web11.1092.1660177975783972755 for ; Wed, 10 Aug 2022 17:32:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=5rI4ON9+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.65, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=erv0jVX9fGDd93ZExHjNLAKkFxstYs/af210hnYWq+CfcrIMX9EzFWd6ULZLpqxC6t0tqvnUkCDXaf5wnI/7yaLVrtZtisQ/qmxKp5BExtmEsjNXYE1E9j6dISYby26tTa3awy7eHSDFk1Ns3W59D6vCn3OM3VwLodH/hD3DnfIPVgH2ePxedS3l5vRPwoXKFP+Mnh1Lu96tufOV9CduBg+2/9DFR6g15m9qlNR6iAp0+bfjg6b6h1NPfZNkpXTSEeLHKl1GxpQ0RdYrOBr3I85iEHcN0bHL6BYmodZUrJkSBLhOCMCapNyqRQ+WKgFBCUn/bJPo0PvHEQeoysw0rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2eVgAgVaMJQxIzhmgsWIa0nGJnEnak+EogxkDJVextc=; b=NZCI7hviioAzoLlA9VhH5+gukOTY6qyjl9HwIkUjFTIX237qjsclx/RNWWPoHCWmItXIaz9FR3816T9iL4Y1/0MZPpmiAYb4MXxkGzJN5hxPxuVd56LLkvtbXwtqxp4Bdg3DVTrcTO7ZU4eESwc+NQBbad0tM7lzV/LdSdvMZEHyjj8bWVeZOUbwqUJHgQ8XRGjq7WRJjM0PbjaCGhwSbG6iHGsuc0Fmslwt26JlLCJ0jgJmzFNV8TNbwpws7ct1C8KB6AToiSVH14Ku3EZqX5WmZlLQXzfIlSmpE3C7fX0DsXSITEBHClJXMRiHqEkqg6t4z2puCw3qnIXRl1/WKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2eVgAgVaMJQxIzhmgsWIa0nGJnEnak+EogxkDJVextc=; b=5rI4ON9+H9QdtkFbudeTEE5+Q4mYjDcBev+7QniHelpSiLP0vgbHSAobHRKgle9AeVT9GEBcFqyYq60Pfe+NQh35ugDSNK6qgrJXanh8347Srzs/Uo2L3V0MMqhwPfxPXxc9AdxoOJ8zOw9fjh+9zvvEHI3XiXukF1pGCeJIlyQ= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB5669.namprd12.prod.outlook.com (2603:10b6:806:237::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Thu, 11 Aug 2022 00:32:53 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f%4]) with mapi id 15.20.5504.020; Thu, 11 Aug 2022 00:32:53 +0000 From: "Chang, Abner" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqljLKVm7X4buzUSN71MsFikpzK2mL5pggAC4fKCAAFu9eYABmY9A Date: Thu, 11 Aug 2022 00:32:52 +0000 Message-ID: References: <1659875125-9504-1-git-send-email-igork@ami.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-11T00:32:48Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=816bbdc3-1f7c-4c19-b57d-48f3d5371476; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7888e665-adf2-41e1-0b9a-08da7b310729 x-ms-traffictypediagnostic: SA1PR12MB5669:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b4iavY7Xumzvh+TKgS3/kuSR8nCw1K7uCRDPqCOCemUkrDH4L7MbvzTHiPWaVtVwip1Nbs6gZufYOii8dQ0WpDskP4136mY9HHvxdmP8qij/UCLkQhV8ZTlvDGa7WqsiwFGcVhMo7T4O8YaQz4fNodstHZgj4tQukqCWTF4Wl0HclYOgK2wkoLnT5Zd/FRqzYxs+rK12k9sukI47hQ1tttePvdr9IBJHQ7V6sHEzf38xGEiswlniZciqx6z+DxsB5nsL7aRX7pVTu1cDOivj8bJDqexfzYL/G6s+oILxhZ9AfhHu6nKe6xjhuZtKYcFLm04aP5H402FknHYYeGM/SbtTqJsmxOoLtTrU616d2NN4HxAhJv3H9ELs/EZCo6lu71Nq/KbCQcXnn43hZ2Y5Y9hgbm/LebL99TsDIHNGj4KEJDj+jpxsiNasIFtNGuzY7zVEc3NtIzgzJdvzd0ILpZ/f/3m3tZxgOUETiEemQ+tEQWB7Kj7f3k26rCxTFJVV4rRhtjl06BCDyRAl6smZBQvCTCX7M+Ds5XDLvif92Q+ZPjnVzELIOFp4LMSqFFA2+4YdanYdEt2KcQnwYm8qcQllXqiViHtaBg0Ygg3MNVizOWmyIlWZzTkidmJcs5ifvmtnBdzV/PjRjtAy/IfX+HFfwgedFEZcylpSqmYvNfZOVeyDJND5ov3pQynYtnNv+o/pRlng+T3JocJzV3r47KIgMhgnsRBfXUyLmd9AP5jiIG4mC5dNzFrj+/IwToKZ+9uuQx4Ju25sARxyICXgEotVetQ713fRVYipPK9z/hm/GZc2lfVBl55uIXhM74+zX2qGwKukFh3B8rVGQWqKng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(71200400001)(478600001)(41300700001)(55016003)(2906002)(33656002)(40140700001)(316002)(110136005)(45080400002)(6506007)(86362001)(7696005)(38100700002)(9686003)(38070700005)(53546011)(186003)(83380400001)(122000001)(52536014)(8936002)(8676002)(76116006)(66476007)(66946007)(66556008)(64756008)(66446008)(5660300002)(4326008)(166002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IdoY23BttW8FKeJll1bnmYeWNEcYtYm6D878mRBjuGcNosAKFJwKbxCQwNTb?= =?us-ascii?Q?a2iu3sbdK9L0z5T3Mm0PSLKXmC+mQZBWweezR9Cdd4oim5WCz5e+bWIUbPrB?= =?us-ascii?Q?9AnEmhc1IY4LB1qRC6Z5/CpfE87jIpaQpbtf5MuluJrvH2Ups60icZq5e1dM?= =?us-ascii?Q?RENI1/paLR0M62pd/0Wmwcl0t6i5VI2gyQ51zGDfm19lcenf9Piih2JQxff1?= =?us-ascii?Q?bu1AG8/gl3uO+IPaFFsVRrCwO24tjnfOqBZ0LNIsmv+ykpzHxH05K8Iam9V/?= =?us-ascii?Q?37QztaPZuHSIFqUd2IfRaWUFUalLS2xp39CE17/ekyhaBQU60w4Y8uynnMbd?= =?us-ascii?Q?T3PNk0dZd0rVYLa3tfBbbNNoO1Nccyj6Il1Zanuz9JxdyujkFWgZyysxY8J5?= =?us-ascii?Q?3xs8Ask9WE+kq8Mcq3uU7MqnX7mWpbN7NhykDZBw8upaGaRdTsClOpTPjV3U?= =?us-ascii?Q?GSJMzDACjq/FzxUv4ckus9FXAZ3BLdxBqcEw5UxzNUb+ACCrecb0ISx3aZm5?= =?us-ascii?Q?e2S9dK6N86NNgAk85ChRmHY6Hn5F3Wu6UgnyDkoKAUfufu/IYOEysRAoYQn6?= =?us-ascii?Q?4AkHey9Wug8StQtJIM+Uya9ctvY9qCf9aPirKwzC2T8S3FUSWBpi2PlKTUTb?= =?us-ascii?Q?aBJoQKGWjU/DUhqsyKdAJ6SXzBEjmf60xbQpuoK1OTZHSWqupUEk3N3hC/Ne?= =?us-ascii?Q?xRdD8NDyBR6E6TfZ6hfnJbROyhyh9kjnKfUbAFfFFFkNc8bxKZhUw48D+hQ7?= =?us-ascii?Q?wqSIFy4c6wG9lbp7Pcmvszy1N2aGTYKtWjSLQ+3IXdJssbRRZ6jx61JE7jGI?= =?us-ascii?Q?Wy3/LT7Vnd41Zrses5+Nnji8vnqY53Jf5LP6vr4y9MrjaNddYyqdn8UbxfL0?= =?us-ascii?Q?PUBe4sHiz8wTed5FuTqIrthjnLTfvVaMkn2fHz2QvjqMxuWOikrxN0rqmGYi?= =?us-ascii?Q?ozMQGV+n/ZJY+uxB31h7vUznlmO5TXXWBGvAle89v3cLT75raBvdoL8Ih85Y?= =?us-ascii?Q?/Npf4neBNac9TlS6DPJA9Ch/fkLWz7LiZQCyEWTjdwN/LEyA6kH+NchwYKHB?= =?us-ascii?Q?b/TJUmyh1dlCWgT+Fdd4cEdPQPrxTlpnPm5KRjYquNqYYMTzWZTBwnG2HJjV?= =?us-ascii?Q?ur1G2OrBfxPg0fL73zYRrzLrrlaSxYvZcK0Bz/MXBPy2m2+ya0KmACzdU8f+?= =?us-ascii?Q?1vZJKEX2hWsle5X5RPO7B/RtcNZm09NwTw0fXyQJwK9QRfg2u1OhwAnebL6A?= =?us-ascii?Q?A5SrkvDNYpmKtKgYGEXvv2X0tLSebeBufF6ndzsjsPukx26Uc2h0RL8lIMBE?= =?us-ascii?Q?18K+FMWRObxElAAxx3HyH2dENwVnZpIYLwYcaMeITOHKTUAmgmaqyt5EeKgO?= =?us-ascii?Q?yd4MmZATUD93kwBvcbzvaDxGdfaflj68LW35HSIqD4SxkLZXYBDsUDjB+Jk4?= =?us-ascii?Q?tcKXCGOhg9VvGMa3o6uIKTrmCyy+yCqFbpOr/BScEDJX9MKyw2Z2RLjH7Twb?= =?us-ascii?Q?vZ2SHxFDAUJIfQAnrB4Qv0/fRV3PUPaWobhMUaGy3uQasjDJ3EsKoVtPXF5O?= =?us-ascii?Q?RHzxWYSU0AuOgDljCLpLMI8zsrqqh3VOL22kVl2zN3TPv4ZTyS87sroliFYU?= =?us-ascii?Q?flmRapJGTow/53zN0NUKfNZiR+c9sgTVC7MrZY9rGvOF?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7888e665-adf2-41e1-0b9a-08da7b310729 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 00:32:52.9778 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e8Lik/mqI8WMKBTh3eN1ySVgcxDY6M69cBkypmaWdsRyaMvdQyrhi8znYUGjubIjpB9y0L97Y12Ju5lWZz3BRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5669 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB39665E9E162418D97F42E759EA649MN2PR12MB3966namp_" --_000_MN2PR12MB39665E9E162418D97F42E759EA649MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Igor, you sent two patches or three? Seems I only got two patches. If you missed the third one, then please resend it with the prefix [PATCH = V2 RESEND]. And please also have the numbered patch such as 1/3, 2/3 and 3= /3, you can have the numbered patch using git format-patch *without* --no-n= umbered assigned. That's fine if you will send the 3rd one separately, I will review these tw= o first. Thanks Abner From: Chang, Abner Sent: Wednesday, August 10, 2022 8:05 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.wang@hpe.com Subject: Re: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported Yes, please create the new patch set with the prefix [PATCH V2]. Also, use = git move to move Redfish.h to Include\ to keep the commit history, this one= could be the patch 3. Thank you, Abner Get Outlook for Android ________________________________ From: Igor Kulchytskyy > Sent: Wednesday, August 10, 2022 3:21:46 AM To: Chang, Abner >; devel@e= dk2.groups.io > Cc: nickle.wang@hpe.com > Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported [CAUTION: External Email] Hi Abner, Thank you for your feedback. I agree with you. What should I do to change it? Should I create a new patch? Thank you, Igor -----Original Message----- From: Chang, Abner > Sent: Tuesday, August 09, 2022 3:35 AM To: Igor Kulchytskyy >; devel@edk2.grou= ps.io Cc: nickle.wang@hpe.com Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Hi Igor, my feedback is inline. > -----Original Message----- > From: Igor Kulchytskyy > > Sent: Sunday, August 7, 2022 8:26 PM > To: devel@edk2.groups.io > Cc: Chang, Abner >; nickl= e.wang@hpe.com; Igor > Kulchytskyy > > Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported > > [CAUTION: External Email] > > Host Interface details are discribed by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > That function only supports PCI-E interface. > > > Cc: Abner Chang > > Cc: Nickle Wang > > Signed-off-by: Igor Kulchytskyy > > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++-- > - > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git > a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..a3b977f 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; > > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is s= upported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } > + if (*RecordTmp =3D=3D > + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ [Chang, Abner] We can do if-else here because we only support two types of network device = now. Abner > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_MN2PR12MB39665E9E162418D97F42E759EA649MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Hi Igor, you sent two patches or three? Seems I only= got two patches.

If you missed the third one, then please resend it w= ith the prefix  [PATCH V2 RESEND].  And please also have the numb= ered patch such as 1/3, 2/3 and 3/3, you can have the numbered patch using = git format-patch *without* --no-numbered assigned.

That’s fine if you will send the 3rd one separately, I will review these two first.

 

Thanks

Abner

 

 

 

From: Chang, Abner <Abner.Chang@amd.com>= ;
Sent: Wednesday, August 10, 2022 8:05 AM
To: Igor Kulchytskyy <igork@ami.com>; devel@edk2.groups.io
Cc: nickle.wang@hpe.com
Subject: Re: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported

 

Yes, please create the new patch set with the prefix [PATCH V2]. Also,= use git move to move Redfish.h to Include\ to keep the commit history, thi= s one could be the patch 3.

 

Thank you,
Abner

From: Igor Kulchytskyy <igork@ami.com>
Sent: Wednesday, August 10, 2022 3:21:46 AM
To: Chang, Abner <Abner.Ch= ang@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: nickle.wang@hpe.com &= lt;nickle.wang@hpe.com>
Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported

 

[CAUTION: External Email]

Hi Abner,
Thank you for your feedback.
I agree with you.
What should I do to change it?
Should I create a new patch?
Thank you,
Igor

-----Original Message-----
From: Chang, Abner <Abner.Chang@a= md.com>
Sent: Tuesday, August 09, 2022 3:35 AM
To: Igor Kulchytskyy <igork@ami.com= >; devel@edk2.groups.io
Cc: nickle.wang@hpe.com
Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported


**CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.**
[AMD Official Use Only - General]

Hi Igor, my feedback is inline.

> -----Original Message-----
> From: Igor Kulchytskyy <igork@ami.= com>
> Sent: Sunday, August 7, 2022 8:26 PM
> To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chan= g@amd.com>; nickle.wang@hpe.com; Igor
> Kulchytskyy <igork@ami.com>=
> Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host
> interface is not supported
>
> [CAUTION: External Email]
>
> Host Interface details are discribed by the SMBIOS Type 42 table.
> The table is published by the RedfishHostInterfaceDxe driver.
> That driver supports PCI-E and USB host interface types.
> The table is consumed by the RedfishGetHostInterfaceProtocolData
> function in the RedfishDiscoverDxe driver.
> That function only supports PCI-E interface.
>
>
> Cc: Abner Chang <Abner.Chang= @amd.com>
> Cc: Nickle Wang <nickle.wang= @hpe.com>
> Signed-off-by: Igor Kulchytskyy <i= gork@ami.com>
> ---
>  RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11<= br> > ++++++++--
> -
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git
> a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> index d79750b..a3b977f 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData (
>          RecordTmp &= nbsp;     =3D (UINT8 *)Record + Offset;
>
>          //
> -        // Check Device Type, only= PCI/PCIe Network Interface v2 is supported
> now.
> +        // Check Device Type, PCI/= PCIe and USB Network Interface v2 is supported.
>          //
> -        if (*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) {
> -          ASSERT (Specif= icDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +        if ((*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D<= br> > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) {
> +          if (*RecordTmp= =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){
> +           &nb= sp;  ASSERT (SpecificDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +          }
> +          if (*RecordTmp= =3D=3D
> + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){
[Chang, Abner]
We can do if-else here because we only support two types of network device = now.
Abner

> +           &nb= sp;  ASSERT (SpecificDataLen > sizeof
> (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1);
> +          }
>            *Dev= iceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp;
>            Offs= et            =3D Of= fset + SpecificDataLen;
>            Reco= rdTmp         =3D (UINT8 *)Record += Offset;
> --
> 2.6.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and= then delete or destroy all copies of the transmission.
-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission.

--_000_MN2PR12MB39665E9E162418D97F42E759EA649MN2PR12MB3966namp_--