From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.71]) by mx.groups.io with SMTP id smtpd.web11.19292.1688640866181106709 for ; Thu, 06 Jul 2023 03:54:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=YDNDvuFU; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.71, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LUKwWI4ag/Q7wbCBR9i0cu0oJqTxS2Od0wkihtx0lzi/wAg/Df4dOEgezWHC+abAmcMtGQ47xf9OSN/w1+TY82W2UBQfrJsrWi1ilbP0OTi4dCwQGN0DoZhml6c5NfYWMtBCjb73xlaIRcLzHggWi1cIbgybuGBSQ4UnutUhWEMSTSsneBAIVTXS4Nx6/KZNvyR+qwgCNBnsIA1JmmmRLPOIhCDZeTIGxPNkBXdbo0yrIJGjRprpXhpSnwIR8AlSM7TqdlrqpVtBT47/BMDSdRxbcz2hhEOaiH7l8aCpQAgeRR7ZcEZoIQDmeLrehmcsoQ/rWS/jXAicUUxUVduuGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=liQG7GgxvNBxxhndsOcy6ZSRXhOTBj/vApk+9Y1UrNM=; b=ZUv4VvUvRH+uIVNHoiONHD6myCe8wFbddUgCjHMZyZH7kU8IY751K4QzblhAaWkvhWfJ+9w8HoVz2+MpURuMEoAZg08ZsUrNAh6VSC+VI1GXW3Ja8twQ0g/MgNjj5gJgInOA2v/LUh9g8TgTlegSmeTpeWIoFduuwht0bWeRObtpoTMX9F5FqL+jZj5xFJ2LRobn/xFh9UNqX0sYqzPUMnouTC4TRkuB8rPbrUBw9FxyB+dPtOT+KIBV9U/2tjeno9MB6Yf1N1Pa/1FhddL09c0fzFOTRsSR2ecPLgWQJcJkRrm86Iw3cIwFq941I6RfFfu9mXUeOCsdKbcLdNoE0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=liQG7GgxvNBxxhndsOcy6ZSRXhOTBj/vApk+9Y1UrNM=; b=YDNDvuFUwoBWx1lyYXynNwcR49tlY+AgXWeV0HpJOkdgGaYWjG3ru6sRVvYguqZ1R7ERbDSkm85k7YPsPXcs34u0WZHpMVVYcEvcmtPrrIG4Y6ZyWtdDhuCOdANyGWMbD5JBzlql5VbLLgNGQzvgw+CwZjDU9lMaA5yGC1tiwXE= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA1PR12MB8517.namprd12.prod.outlook.com (2603:10b6:208:449::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Thu, 6 Jul 2023 10:54:18 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6565.016; Thu, 6 Jul 2023 10:54:18 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH v2 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message Thread-Topic: [PATCH v2 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message Thread-Index: AQHZrw3iXGykYtwKp0y5P+p3yosEmK+skkBw Date: Thu, 6 Jul 2023 10:54:18 +0000 Message-ID: References: <20230705065637.1430-1-nicklew@nvidia.com> In-Reply-To: <20230705065637.1430-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=bccc7e31-ed6f-418f-b2ab-d65a253a1b2d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-06T10:54:04Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA1PR12MB8517:EE_ x-ms-office365-filtering-correlation-id: 25c575ac-a7a4-4675-d060-08db7e0f5905 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 688Q2uyol4r7+lFj9JEvo8GFPduDkjDHZ3y2YMqUHWEw4YnUCnqtbB3wASFM44k/alVtf6dOjEPzKlf5WI9KbQADcyO4pbhsWswjRlJaPUkuzh+8mftsr6gxlVQuI0LmVZ14BRN6Q1hksr2/RXZUlOrOKG3W7SfPvGiNK4UcaIY74rybg7KbKXDKKmMFGdwV+ynvKKnIGmLubHLpabepI0G7WRXZwpwZhiWhrNKZjpmgmPe3XpxTALUXRkLnwAlKGe4PKmNDjAJc2aJOBtt0meWXrQTtPZSn7YQl0loU0w0HEMBpI1dHToBCYvzynulrMZMLyoOUGhrRfAZFrOZuLS5uuDKgx8FLKbRvH3bV3BN1JyBnsAsH31h5k/iQZgE7kuT76HFvoHoi5xREEjCF1XNPDFZBNWOuXaHXSjz7ZwExC2WfHcf5pE/akeD7Wd64ig/GFOXrvtzjQWqpaQHUhjFMACEH9mRIyIePqLiK0sI2Bfwy8/RDzfUB2TNB8xlDitsbeLYSf8e+RK7zSu+tqSYB11A8FaqZWZuW0uBmlJrpRGTWDhMPrU6OtxH2m8DrugcRajIIjy0ctW82SQsclxJwb24NhYWmmnEpjmyI0ME= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199021)(71200400001)(7696005)(478600001)(110136005)(54906003)(76116006)(83380400001)(86362001)(33656002)(38070700005)(55016003)(15650500001)(2906002)(66946007)(6506007)(26005)(53546011)(186003)(9686003)(38100700002)(122000001)(4326008)(66476007)(66556008)(64756008)(66446008)(41300700001)(316002)(8936002)(8676002)(5660300002)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FBF5VEG3yF390kBwiNhpBCZMdZCb2C6oJlbfxPIOTfZIdf2LDdG9566CWdaU?= =?us-ascii?Q?Qovz28qcqegZyw1oftRPeWV0MXeDrllLlC64BqekYg1mpixcS1kijzxjfGBX?= =?us-ascii?Q?Mxe3/78/JuJUOM+HhibBHq9nDaw6z7BVXz70EaASiJWl7cO1GjLEkDrOZxcd?= =?us-ascii?Q?NW29tHC+k1id63dmFxUvPRiM/NuuPfEE4NLrVO2eU2VSuxFBzz+kEepJu1Il?= =?us-ascii?Q?beewY/BPr9WWgY62XRd2j6UBq+LN80yNmcqnKChPmaLntU66TKfMDen6+91b?= =?us-ascii?Q?bfDVZtRSjrdYWjCQ/T3AULmlJlvUHx7GtEPng9aG/vbt/hDxWi2IIc9Fxh4R?= =?us-ascii?Q?o5PS/hkN5kK9Ko9dT1kUrsna9Wr1aLNpF7WiXWFwzy/zs673tpMMkKhIY9jn?= =?us-ascii?Q?cHs8TRzmJ7sior8C0mFI4e3Wbe79qeFaWZ5KYYvH0cs1EZHHRCivz4qIbW+o?= =?us-ascii?Q?U8sBwQoNcgMWaYP29P4kjfYHXqVbp7UDvsB63qBJ0iJrQEFKwGqIJ6rQQrHB?= =?us-ascii?Q?g3zVMIG6KCKK2DKCnNbhJyUyFYXLOWRRjENhWfk98IDy0GA2qmjtTq9HdP6V?= =?us-ascii?Q?LvsDFR8ibAGGhkj8GIdmpV7J883p53KRFhLBoUuawHL4CdKEw5Ovyk3riBI7?= =?us-ascii?Q?SuRKPHQ/TDz+jqhE+CU12WT9ILsCGzVPLpOfJYyCGlFMbTuTrAI1QlcK3krQ?= =?us-ascii?Q?AE/ecHcl4IqWVW7vUmiltmCYhokPJQpcKMuUPsg/b0OgF5qnIX/1pWQn2HGZ?= =?us-ascii?Q?X5ql3A6Z4uZICgwTCrupI4dGIr98N4CRqmdAeo6smeAJ8+DOwx9yzEsU8BzQ?= =?us-ascii?Q?sMttdgd6AzKZD3cU0keysLyVkCybP9852LYnfcVAra880x0zlDNeHthz70Lr?= =?us-ascii?Q?Jmm/NJLnblZlMick95jK513WbvSADzIMcM9gNO1FvM/DdZ/mT/k5qD6KVwUK?= =?us-ascii?Q?wB6zHKKMP67M3O3deDiLmV2gH21nM5Vy+8QRRNkoxxK78qumygMXgBuxAwHC?= =?us-ascii?Q?5XRyfF3yntGeU9E6nm6TS4aEw0sHAl6Y5NOsO6Fxe4iqmIKqLY7wldniePzl?= =?us-ascii?Q?vThemhbBZfyIGRsdyJipDmSZTGpUUnA6ywElJ45/WXkCYTpIblAnQw2vPuZi?= =?us-ascii?Q?q9SyCaIXzwdD+IDJ1JtgEqAcfZrbPx9vmH/h1jvVBG09waSc+cSrzuSkwC61?= =?us-ascii?Q?dPevu9Mux6ym6i7XYzTUUqwf5oJvh6zMImHX+dWqUFkS2zKjQ5fAtmP9SUzv?= =?us-ascii?Q?D1hH6C2pGnNaNuGpDpM88EGKa+PSWWYWOXgO/qpB9vkGma+hZc8+Ol4CCC30?= =?us-ascii?Q?UWatLrGXzdRJlQAKWMMSQzutTuLYiycVC7Y1d2TvvuDf06YKBggaW5NKhHbT?= =?us-ascii?Q?9/zJGLmGBmqgdr1iU32sRGRg3LiCG84MSvA82aoAvikeqEspHBdLS8GrSwd2?= =?us-ascii?Q?d7UYUwQ/lr4lKPz5iUZp3rQEs6hQTp90IDPN1dJNvAmL1PsNvH41BHsW1+8j?= =?us-ascii?Q?yd8KdygmTKkjUa2HWoB218dHaX1jHTlz6Z+7SODls/8/OkKE4nF2HsQcAMds?= =?us-ascii?Q?4tBE3moc1qenaIC9C7U=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25c575ac-a7a4-4675-d060-08db7e0f5905 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2023 10:54:18.6045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uivy34On3eQXy72sg7uAJ15SWtDiYppIDjom50jIqFWC+QRYCpVb365HILC80CoE16r2kSKu0ssV3F257KnwHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8517 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, July 5, 2023 2:57 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug > message > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Change debug message level of showing ordered list op-code > to REDFISH_PLATFORM_CONFIG_DEBUG. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishPlatformConfigDxe.h | 2 +- > .../RedfishPlatformConfigDxe.c | 24 +++++++++---------- > 2 files changed, 13 insertions(+), 13 deletions(-) > > diff --git > a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > index c86bc6e9ce2d..38adea04c5bf 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.h > @@ -75,7 +75,7 @@ typedef struct { > #define REGULAR_EXPRESSION_INCLUDE_ALL L".*" > #define CONFIGURE_LANGUAGE_PREFIX "x-uefi-redfish-" > #define REDFISH_PLATFORM_CONFIG_VERSION 0x00010000 > -#define REDFISH_PLATFORM_CONFIG_DEBUG DEBUG_VERBOSE > +#define REDFISH_PLATFORM_CONFIG_DEBUG DEBUG_MANAGEABILITY > #define REDFISH_MENU_PATH_SIZE 8 > > /** > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index 462f269f6a3f..f2a8e77d9b00 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -955,12 +955,12 @@ DumpOrderedListValue ( > return; > } > > - DEBUG ((DEBUG_ERROR, "Value.Type=3D 0x%x\n", OrderedListStatement- > >Value.Type)); > - DEBUG ((DEBUG_ERROR, "Value.BufferValueType=3D 0x%x\n", > OrderedListStatement->Value.BufferValueType)); > - DEBUG ((DEBUG_ERROR, "Value.BufferLen=3D 0x%x\n", > OrderedListStatement->Value.BufferLen)); > - DEBUG ((DEBUG_ERROR, "Value.Buffer=3D 0x%x\n", OrderedListStatement- > >Value.Buffer)); > - DEBUG ((DEBUG_ERROR, "Value.MaxContainers=3D 0x%x\n", > OrderedListStatement->ExtraData.OrderListData.MaxContainers)); > - DEBUG ((DEBUG_ERROR, "StorageWidth=3D 0x%x\n", OrderedListStatement- > >StorageWidth)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Type=3D 0x%x\n", > OrderedListStatement->Value.Type)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferValueType=3D > 0x%x\n", OrderedListStatement->Value.BufferValueType)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferLen=3D > 0x%x\n", OrderedListStatement->Value.BufferLen)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Buffer=3D 0x%x\n", > OrderedListStatement->Value.Buffer)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.MaxContainers=3D > 0x%x\n", OrderedListStatement->ExtraData.OrderListData.MaxContainers)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "StorageWidth=3D 0x%x\n", > OrderedListStatement->StorageWidth)); > > if (OrderedListStatement->Value.Buffer =3D=3D NULL) { > return; > @@ -977,7 +977,7 @@ DumpOrderedListValue ( > Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value8[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); > } > > break; > @@ -985,7 +985,7 @@ DumpOrderedListValue ( > Value16 =3D (UINT16 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT16); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value16[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value16[Index])); > } > > break; > @@ -993,7 +993,7 @@ DumpOrderedListValue ( > Value32 =3D (UINT32 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT32); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value32[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value32[Index])); > } > > break; > @@ -1001,7 +1001,7 @@ DumpOrderedListValue ( > Value64 =3D (UINT64 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT64); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value64[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value64[Index])); > } > > break; > @@ -1009,13 +1009,13 @@ DumpOrderedListValue ( > Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value8[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); > } > > break; > } > > - DEBUG ((DEBUG_ERROR, "\n")); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n")); > } > > /** > -- > 2.17.1