From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.84]) by mx.groups.io with SMTP id smtpd.web09.7560.1660282124924351791 for ; Thu, 11 Aug 2022 22:28:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Inp29BBr; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.84, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9XVGNYkWiKtMdEwPS4VF+LJVPBJhpJy/UqytQLGkSzr1Oz29w4MVXOri/i8PS9zHX0HQhaPl4XcmSC2GlFVf398lga8JPcCw0/41S6opwK/t9n9XxQ6VG2Kd5ehVVg6bx6me+PSvtQ5TSZp5Q8jy8GEGgBBroURH84Arq3I9qtUtBhteNrlN7+Y4eXm3oaFQsnPKGwRXnBMkzRzPQWYKhq6OHtqO8WHmEaoRp04njVE60C9OQg7vw19PRqB3YQQZ4l3qKfl8nLTzuKjbNIkZPNyKelbRHSKPhyFF1Dkn/Rwp+JVgJSAGAYh24ZcsJjKI2luV3DqTl1LOX9RyhQUKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+qK8lyhqODBJDFvV4I9DPpWGDB+WaYF1jcxjkvPlPg=; b=b3tWzjLrjV1bwCfKTlz2/+iVkpeswONEtbSzGmCIPQ26Yg5gzQabaKWaLdAMMuN6wQ+JmlWbL+sQ8TSsya3K7PFO7DQNHBIwJHtdBOAVnFznOJYJBuZFn5Iuc/GPoyz86oTeEtgFA7t6ZjXLAWlPpDY9sp3fkPBu7RqD0ZMquw0S//TMYAorGKXe6y74syNCvDpSyt9txfI1I/K5rvHXEwRnKSIfAxOONL2axyclwBqj2p1dRlbpE/Koq9mASpGIutQaXRmW+vG3xiMpJOEvZjSdWNS1vEKpuNa+xCmB5LW1mo4I2mSwMpmol6UxYWadrkeaASiUC4G1+4lRTwQubg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+qK8lyhqODBJDFvV4I9DPpWGDB+WaYF1jcxjkvPlPg=; b=Inp29BBr34GBXWVvjXpfcngufliXP/OHj22p28ujo76mkUUdyZw5nKSkCsT07WHMXA3vWeQfU7HQrNp9vh8U/MMCnxyoJfgIfDfEKykZcwYgP5VtSRNcAAss0zqbpH9luBo2qokxhX8UY3+dVgVcyHLEb3XwKg2Lgw1KeL59L0o= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB3065.namprd12.prod.outlook.com (2603:10b6:5:3c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Fri, 12 Aug 2022 05:28:42 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f%4]) with mapi id 15.20.5504.020; Fri, 12 Aug 2022 05:28:42 +0000 From: "Chang, Abner" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYrPVSkYqCIEsaE0CVehSJl7+jQK2qvb4g Date: Fri, 12 Aug 2022 05:28:42 +0000 Message-ID: References: <1660162257-21424-1-git-send-email-igork@ami.com> In-Reply-To: <1660162257-21424-1-git-send-email-igork@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-12T05:28:40Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=885ae939-c9a6-4c22-ba99-343696c681f3; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08befc92-5586-4de2-0172-08da7c2384ec x-ms-traffictypediagnostic: DM6PR12MB3065:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TC9NDmBzlwidZ0WwsjUvnxMW1tlccR5MSCAABAeHYcONqFSIVRj1jOVF6Je2zcUFTvDzOFW2U45qZaYEqkBR1DCTj7kDt6AEak158dMayLFwi+7/C5o/vN7BDZtfvQv4EagWm3Nz6nNm65DR5QejDPOWmIVu5WRmsUMEbGGTpkqzXFs2oueAw8F4b2HKn6USjwugkqlh0KsXvJB7hMn/OtCIkRRdSsftYpTcO+DFxbIDufqa3SQ/V4iZSGKzYLPuUozvNymilkuSphNmrznbzUqOS24TorKIUq3nOYSJBv1Rui0VinE+04FjoSSnJdN5lWOI/24BcURO1edOd+ZbbSJ9ljh09y7nYhsUjTPQASR/aBmpMndpmR5vMhRk31nJSVtcOJXEbYGv5sOXo/cHx4AWPgGoc5Ozu8CATjKzy5bRfVOWtFdsVJToIB2V7DaYrcxYmGgwESSyPTL4gdceMAwmr+kVJt19FWJ2VrHb4l61p//l600jbl2Ie+NgkmJTg5iq81bcq6IlMRuA3Xnv+nOesNNQTF7dg7ZWUmLYM3vL5TBWSpO1GVUYFSjtUwAyeJ1W0H+giopgoSsPgodErK8Cw+bK6PfhH0dqUT915ehA+dyXgzPJyN0P4RVvYT96vGrPiWW0jA6JYT48o7aEwYbVoeGnw6S/0BUgn77LVDB71iv9sjVPHJipTEjZ56uuGtajAYJll72B+85TagETGKmJrYRCGAQ596LAF0hfH0fVzqs1tUlzm5k9rcUKmWOHMuGyELL9REiVyUUWUDUiRDiUZnSlkTDcOc+o5W0/yWcVGgKavy0oldtQnln01Dyp x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(366004)(346002)(136003)(186003)(53546011)(52536014)(41300700001)(26005)(6506007)(7696005)(9686003)(5660300002)(40140700001)(8936002)(478600001)(33656002)(110136005)(71200400001)(122000001)(38070700005)(38100700002)(86362001)(55016003)(83380400001)(64756008)(2906002)(4326008)(8676002)(66476007)(66446008)(316002)(76116006)(66556008)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?op8XEGlQG6egt4Py0aBOfrixA+oNEnyg8Hq9ZxsIzNaeGkrnSdpmoUgBqnij?= =?us-ascii?Q?YDC7llK/UYncyjib3B5xUSD7TatsONKp6eyyGGRAizn0rmbj/JTjlSQh7kgq?= =?us-ascii?Q?GgMeuWstzk7wsuQAZF7hy52ckqozIMJNQVNrQWCTkOJhmmZ+i5X8Nj0nK7Dd?= =?us-ascii?Q?PMlqcZw6q81TdDU7s79HZ4ObtbZmxAg/3Dgy0SCNCev6U+ARuS7kN+bLilD6?= =?us-ascii?Q?c7wULi+N0kWgSGcBb7dzRFTzyzMZjmnBHQIbYZMsPTxkqTpjPx1fc9+uE2Do?= =?us-ascii?Q?f/6dyDjr+tLYot5byPUGASdeN+lwS4ekB+p7GU5QZ9R2+XSkCgvMwxS5zU8A?= =?us-ascii?Q?EG4WgFQsvduyuNz3zpXK+nDAHQzRYJ6aCgdyFOs0mZOtU7nk9G+0w84O4Quh?= =?us-ascii?Q?pxTFLlj9mZ+8h+HXe0J+3Kv7MBL1Ki2JIlu/VQvnl9ADfnswK33+NGgbEf5p?= =?us-ascii?Q?Rmv0iYzCJQYzh3STtePvl7bEyZzWFJxslv+SRwtA177IlHyGEO04hKk33SE8?= =?us-ascii?Q?EZrk/SJFfFQuHoJ3RVsWCWhkq0ZAhZ9HzGzzTkd6T+N36MoMjQ/lqESmP4tA?= =?us-ascii?Q?cUOO6D7svSKP1I4N+DdrP41/USBfZfIqhl1mYcdVfX22sWvIYvwTIRgqWGjm?= =?us-ascii?Q?7AufrvL8JbIsgHlBpPFskBR3brE4gkPE5a89Ig81ibpBECXKU7Vgvqz/FuRL?= =?us-ascii?Q?j4vkT7thyo9Ts1oEDXUg3J5jVjyon1SuhawCyX+v2HSPhB/nYwSu1gLjCJ04?= =?us-ascii?Q?1MdRwRX6vRieJXnf76EsOBneOBciPZ9moLodShycmOJjwFK1fMlZ6rlYDt9y?= =?us-ascii?Q?SO1mxAMffhLPvHBRrBZ98U3SdV5Xtnm5EhDFXuAghHKOXJvLK2p4GNGvW03p?= =?us-ascii?Q?h/Js3yzXFOE865/Vs8getiow71v0UIEYL7qe9daQQXMzyYgc3n3SyUnDsH2m?= =?us-ascii?Q?uVheFuo9pUVnYqFSPJ1jfeIXjFjlGvPyzbb8Q2BFj11r23NJ47pRw7+L5SWB?= =?us-ascii?Q?QB1wz4Q+V1N56ciBCAvcEZM3Pmo4ZkXyAcDE8fPTqLQ+Rkwx5a1019JWnKlf?= =?us-ascii?Q?0ntVnh2oXnwwddU1ryFKoDYYoNbYYzNOaN0s1fNFRyQdodNyBNLB8BvWRZHa?= =?us-ascii?Q?zQn+imMuURQ+ja1CH7pxxYkmDxOQ9ShogRcKD3ZEQsb/wZHRgMLkyLDPmI/p?= =?us-ascii?Q?ZM0foqgjhjxYcbAP96opWPQY3cDlWum6URsC74Ut2On7HY7oeiv1J34rgDtD?= =?us-ascii?Q?z9uFDyXCoXvgotmkOFJVSC6vs++7PCAUYjF58rhkeidoTG8XHYkL01Eqey02?= =?us-ascii?Q?+TRHftStvs/8obiwtQwkWuq5rM+Pz6BTDF0bJPN0orRtjvO+l9uYLKO+toXb?= =?us-ascii?Q?ishBYXHFEp/4fYEJvezyL2/vKxigbpH6gDZSZzgkuGd3o5g7sw5vvIonyudH?= =?us-ascii?Q?LuNeydT/2Y7J1GA4JfIER5hJfnIALGAyZI2OTRWrxYNvYR9N3WVZoeuxS4/B?= =?us-ascii?Q?hJ4XT9xqF29vOy9QfWQw06uPdRaNszBnY4p7BMYw+YSrJHFhHIRLF0v3X447?= =?us-ascii?Q?zWVx0wY710in9eyQwnI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08befc92-5586-4de2-0172-08da7c2384ec X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2022 05:28:42.1949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M8uLx0gXE6bQoXP4grSVaCXMaHqxWlxt1FOTA8UR0tizFzBCoUoCfoZmnp8SayE7jex2cmQljICVf825CmCgqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3065 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Three comments inline to coding standard. > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, August 11, 2022 4:11 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.wang@hpe.com; Igor > Kulchytskyy ; Chang, Abner > Subject: [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported >=20 > [CAUTION: External Email] >=20 > Host Interface details are described by the SMBIOS Type 43 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is comsumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > The function only supports PCI-E interface. >=20 > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Igor Kulchytskyy > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..636a1ac 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; >=20 > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is > supported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ Space between ')'. and '{'. > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } Please have 'else' share the same line with '}' > + else{ Please have space between 'else' and '{'. Thanks Abner > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.