From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4AD42D80233 for ; Tue, 14 Nov 2023 14:29:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y2EjRp48sEgIWS4xQOIjRs75jXA56/bVwrRqJoLSfY8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699972148; v=1; b=UONtW58ofY4Cylgf4FwuzqJhgYtXKnel5uUvQKmNncYhHNCImN69gcrejDDVT1kex+rBpFjh h/V9IG4a6qLcGPRErXR/2A+7abaasFX02iDEMa4pvG0TV6OQG4/6x4FO+HrDn+agTf/dk4ZVBjI m9q60YNtMNfYqT6+r+qY64iA= X-Received: by 127.0.0.2 with SMTP id Q05oYY7687511xWr7ltuBBQ1; Tue, 14 Nov 2023 06:29:08 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.69]) by mx.groups.io with SMTP id smtpd.web11.13816.1699972148168125615 for ; Tue, 14 Nov 2023 06:29:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lWM1MQP0owy+dOkn3WjULBV+25xrogdY490jaeQA38WJUYmY1aMLmHqTuegSx3rBHm2OESpjFJKNX1szL8wqNh+s29m8I1UztcU+QCxRyLLxM65sFqV56bAEJJxyp/dQ5RuwnacTX3G7D4Qg+jvbQq6lEAYRLilTN/ca6/35vIB8SNxBMyRX367oPI4SAaq4+iJnO8mCkk45YX/iC4m00iFvHHcvBJ/zMgaO0pTdAkZsCMWT9/mIVkoitbxNy3/zf3q1mCK0CTcIUa2DtCY2rK0TK9dyW/m1468lWBFfvYtRKxQ7nYMEtM0h341SAmW5v1YQxV/ckI40U0uDGriKSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oRp1lk2PdeJofCy3txHVkUkfzlz7ibPM1swuZqMw5dw=; b=GPRgbehiURwby3/PqJ2rYfANUho0PsswvsPChmQpc9CM1iG+l0qDCyoIYKcN2z/qa+0++wIySRtUofEue6b2p+oOrWmhrrh4G3q8tpkNr0jE1xqr9UlToOom31tAnCCSlsObK4zcdCflKyOGWY8ShElLBrRvAQEyXQFo/Oi9yybCXGq/lhzCCD6f95VLvPCEgM3bvywxi117cRA9p1p0fslo88LDlc3roc8pporAclKwYLtlDWV1Qu630v8QuRWJdX8lTeBVofL0EcVKLdAmG+MhCpB9foShXN6aNviJR3fBp/C6fraefySHVUW3heZngURU7HtZXHOENpAGbAOivQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH0PR12MB7094.namprd12.prod.outlook.com (2603:10b6:510:21d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Tue, 14 Nov 2023 14:29:05 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%4]) with mapi id 15.20.6977.029; Tue, 14 Nov 2023 14:29:05 +0000 From: "Chang, Abner via groups.io" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [edk2-devel] [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Topic: [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Index: AQHaFwbJ9rsBiebOqUyrd2XIVDds3LB537tw Date: Tue, 14 Nov 2023 14:29:05 +0000 Message-ID: References: <20231114142805.90-1-igork@ami.com> In-Reply-To: <20231114142805.90-1-igork@ami.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f49c645d-b661-4978-9ae6-429b6ab1a4e4;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-14T14:28:53Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH0PR12MB7094:EE_ x-ms-office365-filtering-correlation-id: f6f1724a-59f1-4510-8571-08dbe51e0e1b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wertSRfnNpKzyxL+mpHwstLVo4kgwHWZLeD7mUpiHhZq2tmUHuyNRs9fOhreU4fVZn5Y3zzdl9h4B2Tc7SOluj3kbsr9BNfzXqTerDTToCRSP68hfZMoUJWDrftUhBJ2K3SQOcGv+sRosLZ4G1NUszHohVdF40JGqv7kz+V75fMQf2oqCvLtKxcCOaB0vT5/qdmsEp2A9/lpC9Iqqqy/ciQWxZeuwSy3MrmJgfnP5Yh4H49hJgSbyzH4mxmUR5D8xQ5rgRpzdeY/aV9bdF8TGTHPj0mTOsBYde5nxAt3IJHjpK7JgvJcgklmPBUZ4LKBnoFCaitlGfL4bMcKf6hfGyYTozn0dR3/Cr9bqnvttLoEImtnQP7BFzrNFHAOyJctAtobxH/9C6u3H9w16nNVhgRocoq1meO0rSptz3v3uESBV5gW/T0Ffmc6T0PKkI+y9jMA7HfikdbHaND+ZUYz8ymNN9qYzo9kzP0KYbOe3snjKNfIFMfyaP8XeRKi6odNXvOTHlPORgPoC2J6r4P47qYz1tUgHZmfp9yxEc7L2wlxaa6M2oT2qHpnuWPYPS1FlFyKOdNm921zTkp7CIagQ7WbRI8vBD4z7i+PjOBWj4Sx2+TL5yHIP5709+p0WFTwCBCnIV2gwWB7gsKYSyosJkfbAVztSPcI2WlS/ybfSA8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vi4QgpjxeWP3L+BJZnrDcogeyykdONwHBKGOe4BUasoxWtzYiNjlSqySgkAZ?= =?us-ascii?Q?RbE3TBF107bc3vwsvlzmOtRfg62ZOslDO+vyIqr+g6UevrCINbGFtkDiY87Y?= =?us-ascii?Q?tXneFkxHB9QnsqpHvJ6HLQ624F/DLkpGXEqdB661aCqWXe9+DkbUuaIUGsii?= =?us-ascii?Q?YBRxKZbJw8hb+SNel7dbr+ki/nhr4CJRPhSMnC4dYyRJoLtD+Nm8Go4QRbWB?= =?us-ascii?Q?nT4J+F+UeBUTDR/nLaJ6DkwRqBeJnphSNfA9IWcCMp8OvFe4eEADAfral85G?= =?us-ascii?Q?2o0gR3+71sCrud6scw1bgYS5hYbGWfVzjWLVEkRTYgCW5JASS9nDmWwVOZ6q?= =?us-ascii?Q?t/N/i67B++54g1rHOWK3D5k5r1dj7vc2de7IHSuML647vSAht7rHaBYZ0Cr5?= =?us-ascii?Q?0bzxJaAt3M50WYXXQWrCq/98ikH7MiCFIjGzXSxySzJnqSJRloKYU2GsSS3R?= =?us-ascii?Q?SpMzPTuhsM8X+vsZoT7tenIUOwgWXG4TzpKa+DeLAlmGvow2ln7dtKtJuc9H?= =?us-ascii?Q?oRfqYx4dc4RVH2PPyi6ISOIE9bM+xrCXK1TrUKe2BCrjHPgXFe9KDqvnGyTk?= =?us-ascii?Q?AEX6jzyH+Fldo0JIL4fFmUqHbfuLuD7zWjmN39VQ8yFKUqX+AmuemGLIDNJi?= =?us-ascii?Q?EhkiIV0EHyQy+a/lTHwdby81VNDaWZmtPPkyGspizj0t8Kvz7rMqIw91f4Z2?= =?us-ascii?Q?9whMkDRWT5CU7doQqJrlYkXgcyjbne/zlfiGLOy1EdXdxMVlIrL4kiRJz/20?= =?us-ascii?Q?JBXPHaKEkK6i/o2LPWuPtpyRPz9nhSNnj+wvQaHGheSvsJRXZVtGgTpk35zI?= =?us-ascii?Q?fAdND03PoBCHgAMEJVDrGvNc7ottj/KqLff+yesdFuHyWeXIEH7qyAQiCvUx?= =?us-ascii?Q?uL4v+QZ0UqSI0jciczQHfxgk2k+246+6rls8Yy2FTfwfPYPaNNcm1Suo9Kbl?= =?us-ascii?Q?F3rTuJ+BBRYw4i/qcuvutXQU8AulByR/mzteodYeeqa52IlJshEOx3mq8AAF?= =?us-ascii?Q?Ey5rIBaX9japzIG/TZkdeLliEIIHXdNZrrExrNQWXtW6nEdFN+8r/iwsUbc4?= =?us-ascii?Q?YTOX6k/WBanjx5cFF+YHXe85ufdKAWlUU/x/rxv8EuPsQqMSHT7/EZjYOrPV?= =?us-ascii?Q?S2zsRYQlcRPaEr7GaJo+ChsaFreH33bsTaxu0x3grmH4JTOY1jJJaveGhIUM?= =?us-ascii?Q?KdE3XJructOUVdBelAe9G3qtwvUcwVFxVH4v3OPXNpSk0BRPvV/39iiV+j4K?= =?us-ascii?Q?4yZ3AgZ4N4CcLeYZI/2XDlN+8oNeGIOAvfak6hH+tffIbXLVq9PoRgsmxSsq?= =?us-ascii?Q?J7jfGyCmIFDadKHVolP4xJwRF3+Rg7FbarJH7CZykaPCn70Yfr3d3o3e09jP?= =?us-ascii?Q?2grOEGoOWv9emoVqCPByKFrKKN4MyR0h/QbgHdnMX0CVGKPNJVDDlJbgu+3+?= =?us-ascii?Q?P/AVstb+kM0qQzPBvu9fxpFiopCLdWFr7AF+fiGLAJLo/DKB7JI3UR/XAeZ/?= =?us-ascii?Q?XvwDwkX5uYxC3p9s6047lcn8takz3WW5Bk8xJ1sQ8yCpNzvTLd6YKSNhThu8?= =?us-ascii?Q?Ra23lexYQUHKUuNlLUg=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6f1724a-59f1-4510-8571-08dbe51e0e1b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2023 14:29:05.1040 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VtxInyiW42Uo1OiUOhhwou9/Gl7ATZmJjXeBFQ26hUB3luW/SzpLYYZEx0Ty2OJ8/n9EgqvP1egSpMAjsEe2fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7094 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WMX7dZOZxtws944UQyldxG1yx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UONtW58o; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Igor Kulchytskyy > Sent: Tuesday, November 14, 2023 10:28 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > > Subject: [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Supported function of the driver changed to wait for all network > interface to be installed. > > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Igor Kulchytskyy > --- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++++++++++------ > ---- > 1 file changed, 16 insertions(+), 15 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 23da3b968f..0f622e05a9 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -1547,25 +1547,26 @@ TestForRequiredProtocols ( > ControllerHandle, > EFI_OPEN_PROTOCOL_TEST_PROTOCOL > ); > + if (EFI_ERROR (Status)) { > + return EFI_UNSUPPORTED; > + } > + > + Status =3D gBS->OpenProtocol ( > + ControllerHandle, > + gRequiredProtocol[Index].DiscoveredProtocolGuid, > + (VOID **)&Id, > + This->DriverBindingHandle, > + ControllerHandle, > + EFI_OPEN_PROTOCOL_GET_PROTOCOL > + ); > if (!EFI_ERROR (Status)) { > - Status =3D gBS->OpenProtocol ( > - ControllerHandle, > - gRequiredProtocol[Index].DiscoveredProtocolGuid, > - (VOID **)&Id, > - This->DriverBindingHandle, > - ControllerHandle, > - EFI_OPEN_PROTOCOL_GET_PROTOCOL > - ); > - if (EFI_ERROR (Status)) { > - if (Index =3D=3D ListCount - 1) { > - DEBUG ((DEBUG_INFO, "%a: all required protocols are found on t= his > controller handle: %p.\n", __func__, ControllerHandle)); > - return EFI_SUCCESS; > - } > - } > + // Already installed > + return EFI_UNSUPPORTED; > } > } > > - return EFI_UNSUPPORTED; > + DEBUG ((DEBUG_MANAGEABILITY, "%a: all required protocols are found on > this controller handle: %p.\n", __func__, ControllerHandle)); > + return EFI_SUCCESS; > } > > /** > -- > 2.37.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telep= hone > at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111198): https://edk2.groups.io/g/devel/message/111198 Mute This Topic: https://groups.io/mt/102584128/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-